Re: [Mesa-dev] [PATCH 3/5] glsl: Convert ir_call to be a statement rather than an rvalue.

2011-09-21 Thread Paul Berry
On 21 September 2011 18:44, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > On 09/20/2011 06:28 PM, Kenneth Graunke wrote: > | This begins the process of cleaning up and un-muddling our IR. > | > | Aside from ir_call, our IR is cleanly split into two classes: - > | Sta

[Mesa-dev] [Bug 41023] [PATCH] d3d1x: error when building -> src/dxgi_native.cpp:1165:40: error: uninitialized const ‘black’

2011-09-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41023 Lucas Stach changed: What|Removed |Added CC||e0425...@student.tuwien.ac.

Re: [Mesa-dev] [PATCH 3/5] glsl: Convert ir_call to be a statement rather than an rvalue.

2011-09-21 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/20/2011 06:28 PM, Kenneth Graunke wrote: | This begins the process of cleaning up and un-muddling our IR. | | Aside from ir_call, our IR is cleanly split into two classes: - | Statements (typeless; used for side effects, control flow) - Values |

Re: [Mesa-dev] [PATCH 1/5] glsl: Move get_error_instruction() from ir_call to ir_constant.

2011-09-21 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/20/2011 06:28 PM, Kenneth Graunke wrote: | All this does is generate a bogus value with error type; the fact | that it was in ir_call was rather arbitrary to begin with. | ir_constant is an equally arbitrary place. The rationale is that a | futu

Re: [Mesa-dev] [PATCH 2/2] glsl: Implement a lowering pass for gl_ClipDistance.

2011-09-21 Thread Kenneth Graunke
On 09/15/2011 04:40 PM, Paul Berry wrote: > In i965 GEN6+ (and I suspect most other hardware), gl_ClipDistance > needs to be laid out as a pair of vec4's (the first containing clip > distances 0-3, and the second containing clip distances 4-7). > However, it is declared in GLSL as an array of 8 flo

[Mesa-dev] [PATCH 3/3] mesa: remove support for GL_APPLE_client_storage extension

2011-09-21 Thread Brian Paul
From: Brian Paul AFAIK, there are few users of this extension and I can see a couple reasons why this is probably broken in Mesa anyway. --- docs/relnotes-7.12.html |1 + src/mesa/drivers/dri/intel/intel_extensions.c |1 - src/mesa/main/attrib.c

[Mesa-dev] [PATCH 2/3] mesa: move gl_texture_image::Width/Height/DepthScale fields to swrast

2011-09-21 Thread Brian Paul
From: Brian Paul These fields were only used for swrast so move them into swrast_texture_image. --- src/mesa/main/mtypes.h|3 --- src/mesa/main/teximage.c | 13 - src/mesa/swrast/s_context.h |2 +- src/mesa/swrast/s_fragprog.c |6 -- src/mesa/swrast/

[Mesa-dev] [PATCH 1/3] mesa: move gl_texture_image::_IsPowerOfTwo into swrast

2011-09-21 Thread Brian Paul
From: Brian Paul It's only used by swrast. --- src/mesa/main/mtypes.h|1 - src/mesa/main/teximage.c |7 --- src/mesa/swrast/s_context.h |3 ++- src/mesa/swrast/s_texfilter.c | 27 ++- src/mesa/swrast/s_texture.c |8 src/mesa

[Mesa-dev] [Bug 41023] [PATCH] d3d1x: error when building -> src/dxgi_native.cpp:1165:40: error: uninitialized const ‘black’

2011-09-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41023 Alexandre Demers changed: What|Removed |Added Summary|[bisected] d3d1x: error |[PATCH] d3d1x: error when

Re: [Mesa-dev] [PATCH 3/5] glsl: Convert ir_call to be a statement rather than an rvalue.

2011-09-21 Thread Kenneth Graunke
On 09/21/2011 01:47 PM, Paul Berry wrote: > On 20 September 2011 18:28, Kenneth Graunke wrote: [...] > diff --git a/src/glsl/ir_constant_expression.cpp > b/src/glsl/ir_constant_expression.cpp > index 4264847..bc0b589 100644 > --- a/src/glsl/ir_constant_expression.cpp > +++ b/src

Re: [Mesa-dev] RFC: Remove GL_APPLE_client_storage

2011-09-21 Thread Henri Verbeet
On 22 September 2011 01:10, Eric Anholt wrote: > wined3d is the only potential consumer I've ecountered.  I don't think I Yeah, although I'm not entirely convinced of the usefulness of wined3d using the extension either. Apple seems to have their fair share of APPLE_client_storage related bugs as

Re: [Mesa-dev] RFC: Remove GL_APPLE_client_storage

2011-09-21 Thread Eric Anholt
On Wed, 21 Sep 2011 15:32:52 -0600, Brian Paul wrote: > > I don't know if many apps use this extension but I doubt that it works > properly in Mesa. We have no piglit or mesa tests for it. wined3d is the only potential consumer I've ecountered. I don't think I have any interest in the extensi

[Mesa-dev] [Bug 40920] [openvg] defective pixels using mesa with openvg

2011-09-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40920 --- Comment #5 from Andreas Betz 2011-09-21 15:10:38 PDT --- Created an attachment (id=51474) --> (https://bugs.freedesktop.org/attachment.cgi?id=51474) PART II of A win32 studio project showing the defective pixels. This file contains a win32

[Mesa-dev] [Bug 40920] [openvg] defective pixels using mesa with openvg

2011-09-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40920 --- Comment #4 from Andreas Betz 2011-09-21 15:09:33 PDT --- Created an attachment (id=51473) --> (https://bugs.freedesktop.org/attachment.cgi?id=51473) A win32 studio project showing the defective pixels. This file contains a win32 visual stu

[Mesa-dev] [Bug 40920] [openvg] defective pixels using mesa with openvg

2011-09-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40920 --- Comment #3 from Andreas Betz 2011-09-21 14:59:51 PDT --- Created an attachment (id=51472) --> (https://bugs.freedesktop.org/attachment.cgi?id=51472) Picture showing the defective pixels -- Configure bugmail: https://bugs.freedesktop.org/u

Re: [Mesa-dev] [PATCH 6/7] intel: Drop gratuitous flush in PBO blit upload.

2011-09-21 Thread Kenneth Graunke
On 09/21/2011 02:20 PM, Eric Anholt wrote: > On Wed, 21 Sep 2011 11:22:25 -0700, Kenneth Graunke > wrote: >> On 09/21/2011 10:15 AM, Eric Anholt wrote: >>> Since the blit gets sequenced after other batchbuffer rendering like >>> normal, there's no need to push things out early. >>> --- >>> src/m

[Mesa-dev] RFC: Remove GL_APPLE_client_storage

2011-09-21 Thread Brian Paul
I don't know if many apps use this extension but I doubt that it works properly in Mesa. We have no piglit or mesa tests for it. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 6/7] intel: Drop gratuitous flush in PBO blit upload.

2011-09-21 Thread Eric Anholt
On Wed, 21 Sep 2011 11:22:25 -0700, Kenneth Graunke wrote: > On 09/21/2011 10:15 AM, Eric Anholt wrote: > > Since the blit gets sequenced after other batchbuffer rendering like > > normal, there's no need to push things out early. > > --- > > src/mesa/drivers/dri/intel/intel_tex_image.c |3 -

Re: [Mesa-dev] [PATCH 0/5] Compiler IR cleanups

2011-09-21 Thread Paul Berry
On 20 September 2011 18:28, Kenneth Graunke wrote: > Here's a few cleanups to our compiler's IR that I've been wanting to do > for a very long time. With this series, expression trees are finally > guaranteed to be pure; you can no longer put calls with side effects in > them. ir_call is now a

Re: [Mesa-dev] [PATCH 1/5] glsl: Move get_error_instruction() from ir_call to ir_constant.

2011-09-21 Thread Kenneth Graunke
On 09/21/2011 11:48 AM, Paul Berry wrote: > On 20 September 2011 18:28, Kenneth Graunke wrote: > @@ -1446,16 +1455,6 @@ ir_function::has_user_signature() >return false; > } > > - > -ir_call * > -ir_call::get_error_instruction(void *ctx) > -{ > - ir_call *call

Re: [Mesa-dev] [PATCH 1/5] glsl: Move get_error_instruction() from ir_call to ir_constant.

2011-09-21 Thread Paul Berry
On 21 September 2011 10:21, Eric Anholt wrote: > On Tue, 20 Sep 2011 18:28:15 -0700, Kenneth Graunke > wrote: > > All this does is generate a bogus value with error type; the fact that > > it was in ir_call was rather arbitrary to begin with. ir_constant is an > > equally arbitrary place. The ra

Re: [Mesa-dev] [PATCH 1/5] glsl: Move get_error_instruction() from ir_call to ir_constant.

2011-09-21 Thread Kenneth Graunke
On 09/21/2011 10:21 AM, Eric Anholt wrote: > On Tue, 20 Sep 2011 18:28:15 -0700, Kenneth Graunke > wrote: >> All this does is generate a bogus value with error type; the fact that >> it was in ir_call was rather arbitrary to begin with. ir_constant is an >> equally arbitrary place. The rationale

Re: [Mesa-dev] [PATCH 1/5] glsl: Move get_error_instruction() from ir_call to ir_constant.

2011-09-21 Thread Paul Berry
On 20 September 2011 18:28, Kenneth Graunke wrote: > diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp > index d6594cd..70d0ae2 100644 > --- a/src/glsl/ir.cpp > +++ b/src/glsl/ir.cpp > @@ -725,6 +725,15 @@ ir_constant::zero(void *mem_ctx, const glsl_type > *type) >return c; > } > > +ir_constant

Re: [Mesa-dev] intel PBO upload cleanup

2011-09-21 Thread Kenneth Graunke
On 09/21/2011 10:15 AM, Eric Anholt wrote: > This came up in a chat with Chad a while back. I was in the area > because I'm planning out how to use the MapTextureImage changes to gut > even more of our texture code. For the series, except for patches 2 and 6: Reviewed-by: Kenneth Graunke I don'

Re: [Mesa-dev] [PATCH 6/7] intel: Drop gratuitous flush in PBO blit upload.

2011-09-21 Thread Kenneth Graunke
On 09/21/2011 10:15 AM, Eric Anholt wrote: > Since the blit gets sequenced after other batchbuffer rendering like > normal, there's no need to push things out early. > --- > src/mesa/drivers/dri/intel/intel_tex_image.c |3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 2/2] glsl: Implement a lowering pass for gl_ClipDistance.

2011-09-21 Thread Eric Anholt
On Mon, 19 Sep 2011 13:40:47 -0700, Paul Berry wrote: Non-text part: multipart/alternative > On 19 September 2011 11:10, Ian Romanick wrote: > > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > On 09/15/2011 04:40 PM, Paul Berry wrote: > > > In i965 GEN6+ (and I suspect most other har

Re: [Mesa-dev] [PATCH 3/5] glsl: Convert ir_call to be a statement rather than an rvalue.

2011-09-21 Thread Eric Anholt
On Tue, 20 Sep 2011 18:28:17 -0700, Kenneth Graunke wrote: > This begins the process of cleaning up and un-muddling our IR. > > Aside from ir_call, our IR is cleanly split into two classes: > - Statements (typeless; used for side effects, control flow) > - Values (deeply nestable, pure, typed ex

Re: [Mesa-dev] [PATCH 2/7] intel: Remove the pbo zero-copy code.

2011-09-21 Thread Keith Whitwell
I'm suprised that fragile code lasted as long as it did... Looks good to me. Keith On Wed, 2011-09-21 at 10:15 -0700, Eric Anholt wrote: > There were notes about the possibility of slowdowns due to zcopy from > a PBO due to thrashing around of the region. Slowdowns are even more > likely now th

Re: [Mesa-dev] [PATCH 1/5] glsl: Move get_error_instruction() from ir_call to ir_constant.

2011-09-21 Thread Eric Anholt
On Tue, 20 Sep 2011 18:28:15 -0700, Kenneth Graunke wrote: > All this does is generate a bogus value with error type; the fact that > it was in ir_call was rather arbitrary to begin with. ir_constant is an > equally arbitrary place. The rationale is that a future commit will > change ir_calls fro

[Mesa-dev] [PATCH 5/7] intel: Clean up check_pbo_format to ignore internalFormat.

2011-09-21 Thread Eric Anholt
All that matters here is the format of the texture, not the internalformat (which might mean various different pixel formats). In one case, the pbo upload for MESA_FORMAT_YCBCR would have swapped the channels for MESA_FORMAT_YCBCR_REV. --- src/mesa/drivers/dri/intel/intel_tex_image.c | 38 +

[Mesa-dev] [PATCH 7/7] intel: Unindent the blit call in PBO blit uploads.

2011-09-21 Thread Eric Anholt
--- src/mesa/drivers/dri/intel/intel_tex_image.c | 30 +++-- 1 files changed, 13 insertions(+), 17 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_tex_image.c b/src/mesa/drivers/dri/intel/intel_tex_image.c index ac3489b..5cfd3a7 100644 --- a/src/mesa/drivers/dri/

[Mesa-dev] [PATCH 6/7] intel: Drop gratuitous flush in PBO blit upload.

2011-09-21 Thread Eric Anholt
Since the blit gets sequenced after other batchbuffer rendering like normal, there's no need to push things out early. --- src/mesa/drivers/dri/intel/intel_tex_image.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_tex_image.c b/src/mes

[Mesa-dev] [PATCH 2/7] intel: Remove the pbo zero-copy code.

2011-09-21 Thread Eric Anholt
There were notes about the possibility of slowdowns due to zcopy from a PBO due to thrashing around of the region. Slowdowns are even more likely now that textures are generally tiled, which a zcopy wouldn't get. Additionally, there were no checks on the buffer size to ensure that the hardware-re

[Mesa-dev] [PATCH 1/7] intel: Remove extra FreeTextureImageBuffer() from glTexImage*.

2011-09-21 Thread Eric Anholt
The core code does this before calling in to us. --- src/mesa/drivers/dri/intel/intel_tex_image.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_tex_image.c b/src/mesa/drivers/dri/intel/intel_tex_image.c index fd719e4..16a0a24 100644 ---

[Mesa-dev] [PATCH 4/7] intel: Move more of the PBO blit upload logic into that function.

2011-09-21 Thread Eric Anholt
This also improves the debugging output in the failure paths so you get more than just "failed", and don't get spammed with "failed" when you didn't even have a PBO to try. --- src/mesa/drivers/dri/intel/intel_tex_image.c | 54 +++--- 1 files changed, 31 insertions(+), 23 del

[Mesa-dev] intel PBO upload cleanup

2011-09-21 Thread Eric Anholt
This came up in a chat with Chad a while back. I was in the area because I'm planning out how to use the MapTextureImage changes to gut even more of our texture code. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/

[Mesa-dev] [PATCH 3/7] intel: Remove stale comment about non-intel gl_buffer_objects.

2011-09-21 Thread Eric Anholt
This hasn't been true since dd26899ca39111e0866afed9df94bfb1618dd363 in 2009. --- src/mesa/drivers/dri/intel/intel_buffer_objects.h |9 + 1 files changed, 1 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_buffer_objects.h b/src/mesa/drivers/dri/intel/intel

Re: [Mesa-dev] [PATCH] mesa: Fix save/restore of ActiveProgram in meta-ops

2011-09-21 Thread Eric Anholt
On Tue, 20 Sep 2011 12:01:56 -0700, Chad Versace wrote: > The mismatch below caused ActiveProgram to be incorrectly saved/restored: > > _meas_meta_begin: > line 465) ActiveShader := gl_shader_state::CurrentFragmentProgram > _mesa_meta_end: > line 741) gl_shader_state::Acti

Re: [Mesa-dev] [PATCH] st/mesa: Finalize texture on render-to-texture.

2011-09-21 Thread Brian Paul
On 09/21/2011 03:36 AM, Michel Dänzer wrote: On Die, 2011-09-20 at 12:55 -0600, Brian Paul wrote: On 09/20/2011 10:40 AM, Michel Dänzer wrote: On Don, 2011-09-15 at 13:01 -0600, Brian Paul wrote: On 09/15/2011 10:08 AM, Michel Dänzer wrote: On Don, 2011-09-15 at 09:01 -0600, Brian Paul wrote:

Re: [Mesa-dev] R: Re: Building with -fno-builtin-memcmp for improved performance

2011-09-21 Thread Roland Scheidegger
Am 21.09.2011 14:24, schrieb Fabio: > > >> Messaggio originale >> Da: kei...@vmware.com >> Data: 20/09/2011 16.45 >> A: "Roland Scheidegger" >> Cc: "Fabio", >> Ogg: Re: [Mesa-dev] Building with -fno-builtin-memcmp for improved > performance >> >> On Tue, 2011-09-20 at 16:35 +0200, Rolan

[Mesa-dev] R: Re: Building with -fno-builtin-memcmp for improved performance

2011-09-21 Thread Fabio
>Messaggio originale >Da: kei...@vmware.com >Data: 20/09/2011 16.45 >A: "Roland Scheidegger" >Cc: "Fabio", >Ogg: Re: [Mesa-dev] Building with -fno-builtin-memcmp for improved performance > >On Tue, 2011-09-20 at 16:35 +0200, Roland Scheidegger wrote: >> Am 20.09.2011 16:15, schrieb Keit

[Mesa-dev] [Bug 41065] Fix build with LLVM-3.0svn

2011-09-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41065 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Mesa-dev] [Bug 41074] Build broken - CHAN_TYPE undeclared

2011-09-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41074 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Mesa-dev] [Bug 41074] Build broken - CHAN_TYPE undeclared

2011-09-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41074 Knut Petersen changed: What|Removed |Added CC||knut_peter...@t-online.de -- Configure

Re: [Mesa-dev] [PATCH] st/mesa: Finalize texture on render-to-texture.

2011-09-21 Thread Michel Dänzer
On Die, 2011-09-20 at 12:55 -0600, Brian Paul wrote: > On 09/20/2011 10:40 AM, Michel Dänzer wrote: > > On Don, 2011-09-15 at 13:01 -0600, Brian Paul wrote: > >> On 09/15/2011 10:08 AM, Michel Dänzer wrote: > >>> On Don, 2011-09-15 at 09:01 -0600, Brian Paul wrote: > On 09/15/2011 04:55 AM, M

[Mesa-dev] [Bug 41074] New: Build broken - CHAN_TYPE undeclared

2011-09-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41074 Summary: Build broken - CHAN_TYPE undeclared Product: Mesa Version: git Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: blocker Priority: medium

Re: [Mesa-dev] Fixup: Use C++ style constant member functions for is_one and is_zero.

2011-09-21 Thread Tolga Dalman
On Tue, 20 Sep 2011 08:20:27 -0700 Paul Berry wrote: > On 20 September 2011 01:05, Tolga Dalman wrote: > Tolga, your uneasiness is certainly justified in terms of conventional > wisdom. As someone who used to write numerical analysis software, I cringe > whenever I see floats compared using ==,

[Mesa-dev] [Bug 40920] [openvg] defective pixels using mesa with openvg

2011-09-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40920 --- Comment #2 from Andreas Betz 2011-09-21 00:29:40 PDT --- Hi, sry that i forgot to mention it ... im using the llvmpipe (because ... it is simply faster ...). Using the soft-pipe it look good ... but it is very slow ... The point is ... i