Re: [Mesa-dev] [PATCH] r300/compiler: Implement ROUND

2011-08-23 Thread Lauri Kasanen
On Tue, 23 Aug 2011 14:41:45 -0700 Tom Stellard wrote: > MLAA should work on r300g (r500 only) with this patch. I've tested > with the kasanen-post-process-v2 branch and it looks OK to me, but it > would be nice to have a second opinion. Hi Tom Thanks for implementing this for r300g. Could you

Re: [Mesa-dev] [PATCH 1/4] r600g: share the source list

2011-08-23 Thread Marek Olšák
I took a quick look and the patches look good to me. Reviewed-by: Marek Olšák On Wed, Aug 24, 2011 at 5:08 AM, Chia-I Wu wrote: > Factor out C_SOURCES from Makefile to Makefile.sources, and let > Makefile and SConscript share it. > --- >  src/gallium/drivers/r600/Makefile         |   17 ++-

Re: [Mesa-dev] [PATCH 1/2] i965: Factor source lists into Makefile.sources

2011-08-23 Thread Chia-I Wu
On Wed, Aug 24, 2011 at 8:04 AM, Chad Versace wrote: > In preparation for porting i965 to Android, factor its source lists into > a shared makefile. This prevents duplication of source lists, and hence > prevents the Android from breaking as often. I did not test, but the series looks good to me

[Mesa-dev] [PATCH 3/3] android: add support for egl_dri2

2011-08-23 Thread Chia-I Wu
Add rules to build egl_dri2 and make it a built-in EGL driver of libGLES_mesa. --- Android.mk | 11 +++- src/egl/drivers/dri2/Android.mk | 50 +++ src/egl/main/Android.mk |3 ++ 3 files changed, 63 insertions(+), 1 deleti

[Mesa-dev] [PATCH 2/3] egl_dri2: add support for Android

2011-08-23 Thread Chia-I Wu
Add platform_android.c that supports _EGL_PLAFORM_ANDROID. It works with drm_gralloc, where back buffers of windows are backed by GEM objects. In Android a native window has a queue of back buffers allocated by the server, through drm_gralloc. For each frame, EGL needs to dequeue the next bac

[Mesa-dev] [PATCH 1/3] egl_dri2: allow RGBA masks to be specified for matching

2011-08-23 Thread Chia-I Wu
Add rgba_masks to dri2_add_config. When it is non-NULL, the DRI config is accepted only when the offsets and sizes of the its channels match rgba_mask. --- src/egl/drivers/dri2/egl_dri2.c | 23 ++- src/egl/drivers/dri2/egl_dri2.h |3 ++- src/egl/drivers/d

[Mesa-dev] [PATCH 4/4] android: add support for r600g

2011-08-23 Thread Chia-I Wu
Tested with a Radeon HD 6250. SurfaceFlinger (the display server and compositor) works. 2D apps with RGB or RGBA visuals work. As for 3D apps, some work but some don't (with serious rendering defects). --- Android.mk| 10 +- src/gallium/Android.mk

[Mesa-dev] [PATCH 3/4] winsys/radeon: share the source list

2011-08-23 Thread Chia-I Wu
Factor out C_SOURCES from Makefile to Makefile.sources, and let Makefile and SConscript share it. --- src/gallium/winsys/radeon/drm/Makefile |6 ++ src/gallium/winsys/radeon/drm/Makefile.sources |4 src/gallium/winsys/radeon/drm/SConscript |6 +- 3 files chan

[Mesa-dev] [PATCH 2/4] winsys/r600: share the source list

2011-08-23 Thread Chia-I Wu
Factor out C_SOURCES from Makefile to Makefile.sources, and let Makefile and SConscript share it. --- src/gallium/winsys/r600/drm/Makefile |8 ++-- src/gallium/winsys/r600/drm/Makefile.sources |7 +++ src/gallium/winsys/r600/drm/SConscript |8 +--- 3 files cha

[Mesa-dev] [PATCH 1/4] r600g: share the source list

2011-08-23 Thread Chia-I Wu
Factor out C_SOURCES from Makefile to Makefile.sources, and let Makefile and SConscript share it. --- src/gallium/drivers/r600/Makefile | 17 ++--- src/gallium/drivers/r600/Makefile.sources | 15 +++ src/gallium/drivers/r600/SConscript | 18 ++---

[Mesa-dev] [PATCH 09/10] i965/vs: Pack live uniform vectors together in the push constant upload.

2011-08-23 Thread Eric Anholt
At some point we need to also move uniform accesses out to pull constants when there are just too many in use, but we lack tests for that at the moment. Fixes glsl-vs-large-uniform-array. --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 89 src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 05/10] i965: Make the old VS backend record pull constant references in pull_params[].

2011-08-23 Thread Eric Anholt
We'll be using that to track things for the new VS backend, and this will avoid cluttering brw_vs_surface_state.c for it. --- src/mesa/drivers/dri/i965/brw_context.h |1 + src/mesa/drivers/dri/i965/brw_vs_emit.c | 14 ++ src/mesa/drivers/dri/i965/brw_vs_surface_

[Mesa-dev] [PATCH 10/10] i965/vs: Fix GL_FIXED setup when a writemask is present.

2011-08-23 Thread Eric Anholt
By emitting code before generate_code(), we ended up in align1 mode where writemasks don't exist, so we rescaled gl_Vertex.w and things went badly. By moving GL_FIXED support to the visitor, we end up with normal codegen, and as a bonus the GL_FIXED setup ends up getting printed appropriately in d

[Mesa-dev] [PATCH 07/10] i965/vs: Don't lower uniform array indexing.

2011-08-23 Thread Eric Anholt
This avoids the massive conditional move array access, and brings code generation quality for the new VS backend into the realm of efficiency of the old backend (roughly 20% more instructions generated than before across shader-db, instead of assertion failing for generating over 10,000 instruction

[Mesa-dev] [PATCH 06/10] i965/vs: Add support for pull constant loads for uniform arrays.

2011-08-23 Thread Eric Anholt
--- src/mesa/drivers/dri/i965/brw_defines.h|1 + src/mesa/drivers/dri/i965/brw_vec4.h | 11 ++ src/mesa/drivers/dri/i965/brw_vec4_emit.cpp| 51 +- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 133 +++- 4 files changed, 192 insertions(+

[Mesa-dev] [PATCH 08/10] i965/vs: Track uniforms as separate vectors once we've done array access.

2011-08-23 Thread Eric Anholt
This will make it easier to figure out which elements are totally unused and not upload them. --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 30 src/mesa/drivers/dri/i965/brw_vec4.h |1 + src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp |7 + 3

[Mesa-dev] [PATCH 04/10] mesa: Fix glGetUniform() type conversions.

2011-08-23 Thread Eric Anholt
We were primarily failing to convert in the NativeIntegers case, which this fixes. However, the GL 3.2 core specification is unclear on what should happen when asked to convert a floating point uniform to integer. I assume the result should be like glGetInteger's conversion of floating point valu

[Mesa-dev] [PATCH 02/10] i965: Use native integer uniforms when the new VS backend is in use.

2011-08-23 Thread Eric Anholt
Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_context.c|6 + src/mesa/drivers/dri/i965/brw_context.h|2 - src/mesa/drivers/dri/i965/brw_curbe.c |3 +- src/mesa/drivers/dri/i965/brw_vec4_emit.cpp|1 - src/mesa/drivers/dri/i965/brw_v

[Mesa-dev] [PATCH 03/10] mesa: Make the gl_constant_value's bool occupy the same space as float/int.

2011-08-23 Thread Eric Anholt
At least for Intel, all our uniform components are of uint32_t size, either float or signed or unsigned int. For uploading uniform data in the driver, it's much easier to upload a full dword per uniform element instead of trying to pick out the bool byte and then fill in the top 3 bytes of pad wit

[Mesa-dev] [PATCH 01/10] i965/vs: Move the flag for whether to use the new backend to the context.

2011-08-23 Thread Eric Anholt
Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_context.c |2 ++ src/mesa/drivers/dri/i965/brw_context.h |1 + src/mesa/drivers/dri/i965/brw_vs.c |6 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/sr

[Mesa-dev] glGetUniform rework v2 and VS backend uniform array support

2011-08-23 Thread Eric Anholt
This finishes off the remaining piglit regressions in the new VS backend, so that now it overall fixes 2 tests (vs-temp-array-mat4-index-col-row-rd, vs-temp-array-mat4-index-row-rd). After Ken's note about type conversion for non-GL_FLOAT returntype, I noticed a one-character typo in the testcase

[Mesa-dev] [Bug 40328] request for account on freedesktop - eugeni dodonov

2011-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40328 Eric Anholt changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: [Mesa-dev] [PATCH 1/2] i965: Factor source lists into Makefile.sources

2011-08-23 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The first two lines of the diff, + MESA_TOP := $(TOP) + ignore them. They slipped in by accident. - -- Chad Versace c...@chad-versace.us On 08/23/2011 05:04 PM, Chad Versace wrote: > In preparation for porting i965 to Android, factor its sou

[Mesa-dev] [PATCH 2/2] i915: Factor source lists into Makefile.sources

2011-08-23 Thread Chad Versace
In preparation for porting i915 to Android, factor its source lists into a shared makefile. This prevents duplication of source lists, and hence prevents the Android from breaking as often. Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i915/Makefile | 49 +---

[Mesa-dev] [PATCH 1/2] i965: Factor source lists into Makefile.sources

2011-08-23 Thread Chad Versace
In preparation for porting i965 to Android, factor its source lists into a shared makefile. This prevents duplication of source lists, and hence prevents the Android from breaking as often. Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/Makefile | 132 ++--

[Mesa-dev] [Bug 40328] request for account on freedesktop - eugeni dodonov

2011-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40328 --- Comment #1 from Eugeni Dodonov 2011-08-23 15:51:30 PDT --- Created an attachment (id=50511) --> (https://bugs.freedesktop.org/attachment.cgi?id=50511) ssh public key -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=ema

[Mesa-dev] [Bug 40328] request for account on freedesktop - eugeni dodonov

2011-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40328 Eugeni Dodonov changed: What|Removed |Added Attachment #50510|application/pgp-signature |text/plain mime type|

[Mesa-dev] [Bug 40328] New: request for account on freedesktop - eugeni dodonov

2011-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40328 Summary: request for account on freedesktop - eugeni dodonov Product: Mesa Version: unspecified Platform: Other OS/Version: All Status: NEW Severity: normal Priorit

Re: [Mesa-dev] [PATCH 1/3] auxiliary/os: add wrappers for mmap/munmap

2011-08-23 Thread Chia-I Wu
On Sun, Aug 21, 2011 at 8:41 PM, Chia-I Wu wrote: > From: Chia-I Wu > > The use of mmap() in winsys requires large file support.  Not all OSes > have LFS so a wrapper should be used.  In particular, os_mmap() should > call __mmap2() on Android. If there is no objection, I plan to commit this seri

[Mesa-dev] Version 7.11 is missing on freedesktop bugzilla

2011-08-23 Thread Eugeni Dodonov
Hi, The 7.11 version of Mesa is missing on freedesktop bugzilla, could someone add it please? -- Eugeni Dodonov http://eugeni.dodonov.net/ ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] r300/compiler: Implement ROUND

2011-08-23 Thread Corbin Simpson
Have not tested this, but it looks good. I'll apply after testing if Marek doesn't get there first. Thanks! Sending from a mobile, pardon my terseness. ~ C. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/lis

Re: [Mesa-dev] [PATCH] r300/compiler: Implement ROUND

2011-08-23 Thread Corbin Simpson
Sending from a mobile, pardon my terseness. ~ C. On Aug 23, 2011 2:42 PM, "Tom Stellard" wrote: > According to the GLSL spec, the implementor can decide which way to round > when the fraction is .5. The r300 compiler will round down, so we can use > CND and save an instruction. > --- > > MLAA shou

[Mesa-dev] [PATCH] r300/compiler: Implement ROUND

2011-08-23 Thread Tom Stellard
According to the GLSL spec, the implementor can decide which way to round when the fraction is .5. The r300 compiler will round down, so we can use CND and save an instruction. --- MLAA should work on r300g (r500 only) with this patch. I've tested with the kasanen-post-process-v2 branch and it l

[Mesa-dev] [Bug 12092] [OGL] Get incorrect texture image if texture's internalformat is COMPRESSED_RGB_FXT1_3DFX

2011-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=12092 Eugeni Dodonov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: [Mesa-dev] [PATCH 5/6] i965/fs: Implement textureSize (TXS) on Gen5+.

2011-08-23 Thread Kenneth Graunke
On 08/23/2011 11:18 AM, Eric Anholt wrote: > On Mon, 22 Aug 2011 16:26:23 -0700, Kenneth Graunke > wrote: >> Signed-off-by: Kenneth Graunke >> --- >> src/mesa/drivers/dri/i965/brw_defines.h |2 + >> src/mesa/drivers/dri/i965/brw_fs.cpp |1 + >> src/mesa/drivers/dri/i965/brw

Re: [Mesa-dev] [PATCH 13/12] i965: Only map the necessary buffer range in brw_prepare_indices

2011-08-23 Thread Eric Anholt
On Mon, 22 Aug 2011 10:54:45 -0700, "Ian Romanick" wrote: > From: Ian Romanick Reviewed-by: Eric Anholt pgpcbpJ1nJEmt.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listin

Re: [Mesa-dev] [PATCH 1/2] Change return type of try_emit_* methods to bool.

2011-08-23 Thread Kenneth Graunke
On 08/23/2011 01:48 AM, Kai Wasserbäch wrote: > > Ian Romanick explained (Message-Id: <4e528973.6080...@freedesktop.org>), > that the return type of non-API methods shouldn't use GLboolean but a > standard C++ bool. > > CC: Ian Romanick > CC: Bryan Cain > Signed-off-by: Kai Wasserbäch Reviewe

Re: [Mesa-dev] [PATCH 5/6] i965/fs: Implement textureSize (TXS) on Gen5+.

2011-08-23 Thread Eric Anholt
On Mon, 22 Aug 2011 16:26:23 -0700, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_defines.h |2 + > src/mesa/drivers/dri/i965/brw_fs.cpp |1 + > src/mesa/drivers/dri/i965/brw_fs.h |3 +- > src/mesa/drivers/dri/i9

Re: [Mesa-dev] [PATCH] st/xorg: Advertise support for XvMC

2011-08-23 Thread Michel Dänzer
On Fre, 2011-07-29 at 19:37 +0200, Maarten Lankhorst wrote: > Formats were based on a patch sent to xf86-video-nouveau by Bryan Cain > > Signed-off-by: Maarten Lankhorst Pushed, thanks. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast

[Mesa-dev] [PATCH 0/4] Various st/xorg related changes

2011-08-23 Thread Michel Dänzer
Patch 1 is an unrelated fix I stumbled across recently, patches 2-4 are to get the xorg state tracker working with r600g. Patch 2 works around r600g's fences still being incorrectly context-dependent (otherwise causing a crash on X server shutdown), but I think it's the better default anyway, as d

[Mesa-dev] [PATCH 2/4] st/xorg: Disable dirty throttling by default.

2011-08-23 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/gallium/state_trackers/xorg/xorg_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gallium/state_trackers/xorg/xorg_driver.c b/src/gallium/state_trackers/xorg/xorg_driver.c index 063ae92..0ade319 1006

[Mesa-dev] [PATCH 3/4] r600g: Handle PIPE_TRANSFER_MAP_DIRECTLY.

2011-08-23 Thread Michel Dänzer
From: Michel Dänzer If the state tracker tries to map the resource directly but we can't or don't want to do that, fail to create a transfer. Signed-off-by: Michel Dänzer --- src/gallium/drivers/r600/r600_texture.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH 1/4] st/xorg: Only damage non-front source in DRI2 CopyRegion hook.

2011-08-23 Thread Michel Dänzer
From: Michel Dänzer Based on a vmwgfx xa/saa fix. Signed-off-by: Michel Dänzer --- src/gallium/state_trackers/xorg/xorg_dri2.c | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/src/gallium/state_trackers/xorg/xorg_dri2.c b/src/gallium/state_trackers/xorg/

[Mesa-dev] [PATCH] st/xorg: Better handling of EXA copies.

2011-08-23 Thread Michel Dänzer
From: Michel Dänzer Always use the resource_copy_region hook. If a source and destination rectangle overlap, copy to/from a temporary pixmap. --- This gets accelerated tiled fills (such as for the X root weave; EXA expects each Copy driver hook call to pick up the results of the previous one for

[Mesa-dev] [PATCH 4/4] r600g: Hook up xorg state tracker.

2011-08-23 Thread Michel Dänzer
From: Michel Dänzer Mostly copied from r300g. Signed-off-by: Michel Dänzer --- configure.ac |2 +- src/gallium/targets/xorg-r600/Makefile | 25 ++ src/gallium/targets/xorg-r600/target.c | 26 ++ src/gallium/targets/xorg-r600/xorg.c | 148 +++

[Mesa-dev] [PATCH 1/2] Change return type of try_emit_* methods to bool.

2011-08-23 Thread Kai Wasserbäch
Ian Romanick explained (Message-Id: <4e528973.6080...@freedesktop.org>), that the return type of non-API methods shouldn't use GLboolean but a standard C++ bool. CC: Ian Romanick CC: Bryan Cain Signed-off-by: Kai Wasserbäch --- src/mesa/program/ir_to_mesa.cpp|8 src/m

[Mesa-dev] [PATCH 2/2] Document the return type coding style.

2011-08-23 Thread Kai Wasserbäch
As per discussion at [0] methods shouldn't use OpenGL return types, if they're not part of the GL API. [0] CC: Ian Romanick Signed-off-by: Kai Wasserbäch --- docs/devinfo.html |7 +++ 1 files changed, 7 insertions(+), 0 deletions(

[Mesa-dev] Move try_emit_* methods to bool return type

2011-08-23 Thread Kai Wasserbäch
[Please CC me on all replies, I'm not subscribed to mesa-dev.] Dear Ian, dear Bryan, the following two patches incorporate the wishes of Ian ([0]) wrt moving the try_emit_* methods to bool from GLboolean. The second patch adds the documentation requested in [0], though I'm not sure, whether that

Re: [Mesa-dev] [PATCH 3/6] glsl/builtins: Uncomment textureSize prototypes.

2011-08-23 Thread Dave Airlie
On Tue, Aug 23, 2011 at 12:26 AM, Kenneth Graunke wrote: > --- >  src/glsl/builtins/profiles/130.frag |    2 -- >  src/glsl/builtins/profiles/130.vert |    2 -- >  2 files changed, 0 insertions(+), 4 deletions(-) Reviewed-by: Dave Airlie ___ mesa-dev m

Re: [Mesa-dev] [PATCH 1/6] glsl: Add a new ir_txs (textureSize) opcode to ir_texture.

2011-08-23 Thread Dave Airlie
On Tue, Aug 23, 2011 at 12:26 AM, Kenneth Graunke wrote: > One unique aspect of TXS is that it doesn't have a coordinate. Looks more complete than my attempt. Reviewed-by: Dave Airlie > --- >  src/glsl/ir.cpp                              |   16 +++ >  src/glsl/ir.h