Re: [Mesa-dev] [PATCH 1/4] i965/gen7: Remove gratuitous dirty flags from WM and PS state.

On Fri, 8 Jul 2011 20:17:50 -0700, Kenneth Graunke wrote: > Commit b46dc45ceef3deb17ba2b0b4300eeb93e9cf7833 claimed that > NEW_POLYGONSTIPPLE is gratuitous, but somehow just changed comments > and whitespace instead of actually removing the flag. > > While we're at it, 3DSTATE_PS doesn't appear

[Mesa-dev] [PATCH 4/4] i965/gen7: Add support for gl_PointCoord.

This is exactly analogous to Eric's Gen6 change in commit 6861a701772eac3a6a7d3136d03efa7ac7e5c026. His explanation: "This is just like PointSprite overrides, but it's always on for that attribute." Fixes glsl-fs-pointcoord and gtf/point_sprites. Signed-off-by: Eric Anholt Signed-off-by: Kenn

[Mesa-dev] [PATCH 3/4] i965/gen7: Fix point sprite texture coordinate overrides.

This is exactly analogous to Eric's Gen6 change in commit f304bb8a5d040d99db47a65813d216d11c66fb47. His explanation: "We were assuming that the input attribute n to the FS was FRAG_ATTRIB_TEXn, which happened to be true often enough for our testcases." Signed-off-by: Eric Anholt Signed-off-by

[Mesa-dev] [PATCH 2/4] i965/gen7: Refactor SF setup a bit to handle overrides in one place.

This is exactly analogous to Eric's Gen6 change in commit e7280b16d634e1f434bebbce83996b3d30d0419c. Signed-off-by: Eric Anholt Signed-off-by: Kenneth Graunke NOTE: This is a candidate for the 7.11 branch. --- src/mesa/drivers/dri/i965/gen7_sf_state.c | 43 - 1 fil

[Mesa-dev] [PATCH 1/4] i965/gen7: Remove gratuitous dirty flags from WM and PS state.

Commit b46dc45ceef3deb17ba2b0b4300eeb93e9cf7833 claimed that NEW_POLYGONSTIPPLE is gratuitous, but somehow just changed comments and whitespace instead of actually removing the flag. While we're at it, 3DSTATE_PS doesn't appear to need NEW_LINE or NEW_POLYGON either (those are in 3DSTATE_WM). Als

Re: [Mesa-dev] Mesa 7.11 release candidate 1

Are the tarball corrupt? in the tar.bz2 file much files and dirs are missing, MesaLib-7.11-rc1.tar looks to small (3.7MB) and the md5sums not matching...? Stephan Am 09.07.2011 04:06, schrieb Ian Romanick: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mesa 7.11-rc1 has been released. This

Re: [Mesa-dev] intel state dump debugging series

On 07/08/2011 03:43 PM, Eric Anholt wrote: > Here's what I've been working on for better driver debugging (without > the simulator). The main goal is to make almost all our state get > dumped with INTEL_DEBUG=batch, instead of just the last set of state > used in the batchbuffer. > > I think it a

[Mesa-dev] Mesa 7.11 release candidate 1

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mesa 7.11-rc1 has been released. This is a release candidate for the 7.11 development release. The tag in the GIT repository for Mesa 7.11-rc1 is 'mesa-7.11-rc1'. Mesa 7.11-rc1 is available for download at ftp://freedesktop.org/pub/mesa/7.11/ md5su

Re: [Mesa-dev] [PATCH] i965/gen4: Fix GPU hangs since the program streaming change.

On 07/08/2011 03:48 PM, Eric Anholt wrote: > This was tricky. We were doing a use-before-initialize of > grf_reg_count, but the value usually got overwritten anyway -- when we > didn't have to do a relocation (typical), or on gen5 when we didn't > have relocations at all. > > Bugzilla: https://bu

[Mesa-dev] [PATCH] i965/gen4: Fix GPU hangs since the program streaming change.

This was tricky. We were doing a use-before-initialize of grf_reg_count, but the value usually got overwritten anyway -- when we didn't have to do a relocation (typical), or on gen5 when we didn't have relocations at all. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38771 --- src/mesa/

[Mesa-dev] [PATCH 15/15] i965/gen4: Add a stub dumper for CC unit state, which is different from gen6.

--- src/mesa/drivers/dri/i965/brw_state_dump.c | 23 --- 1 files changed, 20 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_state_dump.c b/src/mesa/drivers/dri/i965/brw_state_dump.c index cc2c36c..b9e5cc1 100644 --- a/src/mesa/drivers/dri/i965/brw_

[Mesa-dev] [PATCH 06/15] i965: Move the new gen6 state structs to using state_batch_list[].

--- src/mesa/drivers/dri/i965/brw_state_dump.c | 46 ++- 1 files changed, 24 insertions(+), 22 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_state_dump.c b/src/mesa/drivers/dri/i965/brw_state_dump.c index 2736ad5..6dd1314 100644 --- a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 09/15] i965: Dump the surface, sampler, and sdc state using state_batch_list[].

Now, for example, INTEL_DEBUG=batch tex-border-1 shows all the texturing state involved. --- src/mesa/drivers/dri/i965/brw_state_dump.c | 269 +++- 1 files changed, 105 insertions(+), 164 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_state_dump.c b/src/mesa/dri

[Mesa-dev] [PATCH 13/15] i965/gen6: Add state dumping for the VS constants.

This is quite a bit of spam, but I think it's useful to have in a full INTEL_DEBUG=batch dump. And a lot of this spam on glxgears is just because we're awful at handling our constants :/ --- src/mesa/drivers/dri/i965/brw_context.h|1 + src/mesa/drivers/dri/i965/brw_state_dump.c | 20 +++

[Mesa-dev] [PATCH 14/15] i965/gen4: Add state dumping for unit state using state_batch_list[].

This is just barely more pretty-printing than we previously had, but at least it doesn't leave out unit states in the log. --- src/mesa/drivers/dri/i965/brw_state_dump.c | 169 ++-- 1 files changed, 112 insertions(+), 57 deletions(-) diff --git a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 10/15] i965: Dump the binding table using state_batch_list[].

--- src/mesa/drivers/dri/i965/brw_state_dump.c | 24 +++- 1 files changed, 19 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_state_dump.c b/src/mesa/drivers/dri/i965/brw_state_dump.c index a7ead64..3750ec6 100644 --- a/src/mesa/drivers/dri/i965/brw

[Mesa-dev] [PATCH 12/15] i965/gen6: Add state dumping for the scissor packet.

--- src/mesa/drivers/dri/i965/brw_state_dump.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_state_dump.c b/src/mesa/drivers/dri/i965/brw_state_dump.c index 391f73d..e78e48f 100644 --- a/src/mesa/drivers/dri/i965/brw_state_d

[Mesa-dev] [PATCH 08/15] i965: Dump brw_state_batch data in an easier format for cross-referencing.

Now that we're using state base addresses for most things, we're less interested in the absolute address of the state, and more in its offset from the state base address (start of batchbuffer). Also, reorder the printout so it looks more like the batchbuffer dump. --- src/mesa/drivers/dri/i965/br

[Mesa-dev] [PATCH 11/15] i965: When dumping programs, dump the whole cache. But don't by default.

The previous brw_state_dump output was rather useless -- last used program per batch, and just the hex. Now we dump all programs (since we don't know which were used), and disassemble them. But that's a ton of spam, and usually when looking into program contents we use INTEL_DEBUG={vs,wm,misc,oth

[Mesa-dev] [PATCH 07/15] i965: Map the batch once for dumping all our state batch structs.

--- src/mesa/drivers/dri/i965/brw_state_dump.c | 27 ++- 1 files changed, 2 insertions(+), 25 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_state_dump.c b/src/mesa/drivers/dri/i965/brw_state_dump.c index 6dd1314..2356490 100644 --- a/src/mesa/drivers/dri/i965/

[Mesa-dev] [PATCH 05/15] i965: Move the SF VP state dump to using the state_batch_list[]

--- src/mesa/drivers/dri/i965/brw_state_dump.c | 30 +-- 1 files changed, 19 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_state_dump.c b/src/mesa/drivers/dri/i965/brw_state_dump.c index 1b76a30..2736ad5 100644 --- a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 02/15] i965: Add a type argument to brw_state_batch().

I want to make brw_state_dump.c handle more than just the last statechange, so I want to keep track of what's in the batch state. By using AUB file numbering for most of these packets, this may be reusable for aub dumping. --- src/mesa/drivers/dri/i965/brw_cc.c|6 +++- src/mes

[Mesa-dev] [PATCH 04/15] i965: Move CLIP VP state dump to using the state_batch_list[].

--- src/mesa/drivers/dri/i965/brw_state_dump.c | 26 +- 1 files changed, 21 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_state_dump.c b/src/mesa/drivers/dri/i965/brw_state_dump.c index 7a3a88f..1b76a30 100644 --- a/src/mesa/drivers/dri/i965/b

Re: [Mesa-dev] [PATCH 06/11] glsl: Refactor logic for determining whether to lower return statements.

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/07/2011 01:16 AM, Kenneth Graunke wrote: > On 07/05/2011 03:07 PM, Paul Berry wrote: >> Previously, do_lower_jumps.cpp determined whether to lower return >> statements in ir_lower_jumps_visitor::should_lower_jumps(). Moved >> this logic to ir_lo

[Mesa-dev] [PATCH 03/15] i965: Track the brw_state_batch() data while under INTEL_DEBUG=batch.

--- src/mesa/drivers/dri/i965/brw_context.h |8 src/mesa/drivers/dri/i965/brw_state_batch.c | 26 ++ src/mesa/drivers/dri/i965/brw_vtbl.c|2 ++ 3 files changed, 36 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_conte

[Mesa-dev] [PATCH 01/15] intel: Make our context structure be a ralloc context.

This will let me hang cached compiler structs off of the context without having to worry about cleaning them up at destroy time. --- src/mesa/drivers/dri/i915/i830_context.c |3 ++- src/mesa/drivers/dri/i915/i915_context.c |4 ++-- src/mesa/drivers/dri/i965/brw_context.c|3 ++-

[Mesa-dev] intel state dump debugging series

Here's what I've been working on for better driver debugging (without the simulator). The main goal is to make almost all our state get dumped with INTEL_DEBUG=batch, instead of just the last set of state used in the batchbuffer. I think it adds back in a lot of the info we're going to want for m

[Mesa-dev] [PATCH 3/4] glsl: Create a standalone executable for testing optimization passes.

This patch adds a new build artifact, glsl_test, which can be used for testing optimization passes in isolation. I'm hoping that we will be able to add other useful standalone tests to this executable in the future. Accordingly, it is built in a modular fashion: the main() function uses its first

[Mesa-dev] [PATCH 2/4] glsl: Move initialize_context() to glsl_parser_extras.cpp so it can be re-used.

This function is used by main.cpp to initialize a context to a default configuration for use in compiling builtins. Moved the bulk of it to glsl_parser_extras.cpp so that it can be re-used in testing. --- src/glsl/glsl_parser_extras.cpp | 33 + src/glsl/glsl_pars

[Mesa-dev] [PATCH 1/4] mesa: Add an ifndef guard around the definition of the INLINE macro

Several headers redundantly define the INLINE macro. Adding this guard prevents the compiler from complaining about macro redefinition. --- src/mesa/main/compiler.h | 42 ++ 1 files changed, 22 insertions(+), 20 deletions(-) diff --git a/src/mesa/main/co

[Mesa-dev] glsl: revised unit tests for lower_jumps.cpp

The following patch series is a rework of the contentious unit tests in my patch series from Tuesday ("glsl: improvements to lower_jumps.cpp"). Based on concerns about the maintainability and readability of the tests in Python form, I've re-worked them into simple bash scripts that invoke glsl_tes

Re: [Mesa-dev] Building internal glsl_compiler with builtin_function.o instead of builtin-stubs.o?

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/07/2011 10:39 PM, Kenneth Graunke wrote: > On 07/07/2011 06:13 PM, Dan McCabe wrote: >> Is there a good reason not to build the internal glsl_compiler (in >> mesa/src/glsl) and link it with builtin_function.o? It is currently >> being built with

Re: [Mesa-dev] [PATCH 1/2] i965: Fix fp-lit-src-equals-dst.

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/07/2011 05:14 PM, Eric Anholt wrote: For the series, Reviewed-by: Ian Romanick The Mesa patches should also get cherry-picked to 7.11 and 7.10. > We were stomping over the source for the body of the LIT instruction > when doing the MOV of 1.

Re: [Mesa-dev] [PATCH 06/11] glsl: Refactor logic for determining whether to lower return statements.

On 7 July 2011 10:53, Kenneth Graunke wrote: > On 07/07/2011 09:56 AM, Paul Berry wrote: >> On 7 July 2011 01:16, Kenneth Graunke wrote: >>> What exactly is the difference between lowering returns in "main" and >>> lowering them in other subroutines?  void vs. non-void is definitely >>> different

[Mesa-dev] [Bug 38842] Various valid GLX attributes are rejected by MESA glxChooseFBConfig

https://bugs.freedesktop.org/show_bug.cgi?id=38842 --- Comment #8 from Brian Paul 2011-07-08 08:51:13 PDT --- (In reply to comment #7) > The attributes are valid for glxChooseFBConfig, the attributes and their > values > are just ignore by it. > > Returning NULL in choose_visual causes glxConfi

[Mesa-dev] [Bug 38842] Various valid GLX attributes are rejected by MESA glxChooseFBConfig

https://bugs.freedesktop.org/show_bug.cgi?id=38842 --- Comment #7 from Jonathan Kirkham 2011-07-08 08:07:47 PDT --- The attributes are valid for glxChooseFBConfig, the attributes and their values are just ignore by it. Returning NULL in choose_visual causes glxConfigFBConfig to also return NULL

Re: [Mesa-dev] [PATCH] gallivm: Fix build with llvm-3.0

On 07/06/2011 03:12 PM, Gustaw Smolarczyk wrote: LLVM 3.0svn changes pretty rapidly. The change in Target->createMCInstPrinter() signature which inspired commits 40ae214067673edbda79371969d1730b6194d83e and 92e29dc5b0474c073b0f05d60629fc6c3decfca4 has been reverted. Signed-off-by: Gustaw Smolarc

Re: [Mesa-dev] [PATCH] gallivm: Remove TargetMachine from createMCInstPrinter when using llvm-3.0

On 07/07/2011 09:45 PM, Tobias Droste wrote: llvm-3.0svn revision 134525 removed the TargetMachine parameter from createMCInstPrinter Signed-off-by: Tobias Droste --- src/gallium/auxiliary/gallivm/lp_bld_debug.cpp |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/sr

[Mesa-dev] [Bug 38842] Various valid GLX attributes are rejected by MESA glxChooseFBConfig

https://bugs.freedesktop.org/show_bug.cgi?id=38842 Brian Paul changed: What|Removed |Added Attachment #48839|0 |1 is obsolete|

[Mesa-dev] [Bug 38842] Various valid GLX attributes are rejected by MESA glxChooseFBConfig

https://bugs.freedesktop.org/show_bug.cgi?id=38842 --- Comment #5 from Jonathan Kirkham 2011-07-08 01:04:12 PDT --- Having just re-read the EGL spec: "If EGL MAX PBUFFER WIDTH, EGL MAX PBUFFER HEIGHT, EGL MAX PBUFFER PIXELS, or EGL NATIVE VISUAL ID are specified in attrib list, then they are ig