Re: [Mesa-dev] glsl: Improvements to lower_jumps.cpp

2011-07-06 Thread Jamey Sharp
On Wed, Jul 06, 2011 at 12:18:18PM -0700, Ian Romanick wrote: > This is an area that I've been thinking about lately. I noticed that > XCB uses a framework called check (http://check.sourceforge.net/), and > I've been wanting to talk to Jamey and Josh about their experience with > it, but I never

Re: [Mesa-dev] [PATCH 00/13] Floating-point depth buffers

2011-07-06 Thread Marek Olšák
On Wed, Jul 6, 2011 at 5:49 PM, Brian Paul wrote: > On 06/30/2011 06:29 PM, Marek Olšák wrote: >> >> Hi, >> >> this patch series implements ARB_depth_buffer_float in Mesa and Gallium. >> There is complete r600g/r600-r700 support in my private branch, which passes >> the same tests that pass for Z2

[Mesa-dev] [PATCH 2/2] r600g: introduce r600_bc_src_toggle_neg helper and fix SUB & LRP

2011-07-06 Thread Vadim Girlin
SUB & LRP instructions should toggle NEG bit instead of setting it, otherwise e.g. "SUB a,b,-1" is translated as "ADD a,b,-1" Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/r600_shader.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/gallium/driver

[Mesa-dev] [PATCH 1/2] r600g: introduce r600_bc_src_set_abs helper and fix LOG

2011-07-06 Thread Vadim Girlin
LOG instruction should use absolute values of source operand. Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/r600_shader.c | 28 +++- 1 files changed, 19 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/

[Mesa-dev] [PATCH 0/2] [RESEND] r600g: cleanup ABS/NEG bits modification and fix LOG, SUB, LRP

2011-07-06 Thread Vadim Girlin
These patches introduce inline helpers to cleanup ABS/NEG modification. #1 fixes LOG implementation, which should use ABS bit for operand too. #2 fixes SUB and LRP, which should toggle NEG bit instead of setting it. r600g: introduce r600_bc_src_set_abs helper and fix LOG r600g: introduce r60

Re: [Mesa-dev] [PATCH 0/2] r600g: cleanup ABS/NEG bits modification and fix LOG, SUB, LRP

2011-07-06 Thread Vadim Girlin
On Thu, 2011-07-07 at 07:45 +0400, Vadim Girlin wrote: > These patches introduce inline helpers to cleanup ABS/NEG modification. > > #1 fixes LOG implementation, which should use ABS bit for operand too. > #2 fixes SUB and LRP, which should toggle NEG bit instead of setting it. > > r600g: intr

[Mesa-dev] [PATCH 2/2] r600g: introduce r600_bc_src_toggle_neg helper and fix SUB & LRP

2011-07-06 Thread Vadim Girlin
SUB & LRP instructions should toggle NEG bit instead of setting it, otherwise e.g. "SUB a,b,-1" is translated as "ADD a,b,-1" Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/r600_shader.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/drive

[Mesa-dev] [PATCH 1/2] r600g: introduce r600_bc_src_set_abs helper and fix LOG

2011-07-06 Thread Vadim Girlin
LOG instruction should use absolute values of source operand. Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/r600_shader.c | 28 +++- 1 files changed, 19 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/

[Mesa-dev] [PATCH 0/2] r600g: cleanup ABS/NEG bits modification and fix LOG, SUB, LRP

2011-07-06 Thread Vadim Girlin
These patches introduce inline helpers to cleanup ABS/NEG modification. #1 fixes LOG implementation, which should use ABS bit for operand too. #2 fixes SUB and LRP, which should toggle NEG bit instead of setting it. r600g: introduce r600_bc_src_set_abs helper and fix LOG r600g: introduce r60

Re: [Mesa-dev] glsl: Improvements to lower_jumps.cpp

2011-07-06 Thread Tom Stellard
On Wed, Jul 06, 2011 at 12:18:18PM -0700, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 07/05/2011 03:07 PM, Paul Berry wrote: > > The following patch series fixes bug #36669 (EmitNoMainReturn set > > to 1 doesn't make the GLSL compiler lower all the RET opcodes) as

[Mesa-dev] [Bug 39017] New: [bisected] Segfault in Gallium drivers in Mupen64Plus

2011-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=39017 Summary: [bisected] Segfault in Gallium drivers in Mupen64Plus Product: Mesa Version: git Platform: Other OS/Version: All Status: NEW Severity: normal Priority: med

Re: [Mesa-dev] [PATCH 11/11] glsl: Lower break instructions when necessary at the end of a loop.

2011-07-06 Thread Paul Berry
On 6 July 2011 12:18, Ian Romanick wrote: >> +   /** >> +    * If the block ends in a conditional or unconditional break, lower >> +    * it, even though should_lower_jump() says it needn't be lowered. >> +    */ >> +   void lower_final_breaks(exec_list *block) >> +   { >> +      ir_instruction *i

Re: [Mesa-dev] [PATCH 04/11] glsl: Add a unit test for lower_jumps.cpp

2011-07-06 Thread Paul Berry
On 6 July 2011 12:18, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 07/05/2011 03:07 PM, Paul Berry wrote: >> This test invokes do_lower_jumps() in isolation (using the glsl_test >> executable) and verifies that it transforms the IR in the expected >> way. >> >> The

[Mesa-dev] [Bug 38842] Various valid GLX attributes are rejected by MESA glxChooseFBConfig

2011-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38842 --- Comment #1 from Brian Paul 2011-07-06 16:20:14 PDT --- Created an attachment (id=48839) View: https://bugs.freedesktop.org/attachment.cgi?id=48839 Review: https://bugs.freedesktop.org/review?bug=38842&attachment=48839 add switch cases for

[Mesa-dev] [Bug 38705] call glDrawElements (GL_LINES, 2, GL_UNSIGNED_BYTE, indices); will be exhaust memory

2011-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38705 --- Comment #1 from Brian Paul 2011-07-06 16:08:00 PDT --- Which driver are you using? What does glxinfo report? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- Yo

Re: [Mesa-dev] [PATCH 1/5] intel: Allow intel_region_reference() with *dst != NULL.

2011-07-06 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/29/2011 03:26 PM, Eric Anholt wrote: > This should help us avoid leaking regions in region reference code by > making the API more predictable. > --- > src/mesa/drivers/dri/intel/intel_regions.c | 10 ++ > 1 files changed, 6 insertions

Re: [Mesa-dev] [PATCH 03/11] glsl: Create a standalone executable for testing optimization passes.

2011-07-06 Thread Paul Berry
On 6 July 2011 12:18, Ian Romanick wrote: > > I'm a little uncomfortable with this part.  We now have this code in two > places outside the usual Mesa tree (the other is in src/glsl/main.cpp). >  We've had a hard enough time keeping one external set of values up to > date, so adding another just s

Re: [Mesa-dev] glsl: Improvements to lower_jumps.cpp

2011-07-06 Thread Paul Berry
On 6 July 2011 12:18, Ian Romanick wrote: > > The only other unit tests in Mesa are for the old matrix math routines > (fixed function).  See src/mesa/math/m_debug*.c. > > This is an area that I've been thinking about lately.  I noticed that > XCB uses a framework called check (http://check.source

Re: [Mesa-dev] [PATCH 3/5] intel: Remove now trivial intel_renderbuffer_set_{hiz_, }region().

2011-07-06 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/29/2011 03:26 PM, Eric Anholt wrote: > Note that as a result of this cleanup a bug in > intel_process_dri2_buffer_no_separate_stencil() beomes quite apparent. --- > src/mesa/drivers/dri/intel/intel_context.c | 40 > --

Re: [Mesa-dev] [PATCH 4/5] mesa: Fix a couple of TexEnv unit limits.

2011-07-06 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/06/2011 01:33 PM, Henri Verbeet wrote: > On 6 July 2011 22:03, Ian Romanick wrote: >>> @@ -419,7 +419,7 @@ _mesa_TexEnvfv( GLenum target, GLenum pname, const >>> GLfloat *param ) >>> ASSERT_OUTSIDE_BEGIN_END(ctx); >>> >>> maxUnit = (tar

[Mesa-dev] [PATCH] gallivm: Fix build with llvm-3.0

2011-07-06 Thread Gustaw Smolarczyk
LLVM 3.0svn changes pretty rapidly. The change in Target->createMCInstPrinter() signature which inspired commits 40ae214067673edbda79371969d1730b6194d83e and 92e29dc5b0474c073b0f05d60629fc6c3decfca4 has been reverted. Signed-off-by: Gustaw Smolarczyk --- src/gallium/auxiliary/gallivm/lp_bld_debu

Re: [Mesa-dev] [PATCH 4/5] mesa: Fix a couple of TexEnv unit limits.

2011-07-06 Thread Henri Verbeet
On 6 July 2011 22:03, Ian Romanick wrote: >> @@ -419,7 +419,7 @@ _mesa_TexEnvfv( GLenum target, GLenum pname, const >> GLfloat *param ) >>     ASSERT_OUTSIDE_BEGIN_END(ctx); >> >>     maxUnit = (target == GL_POINT_SPRITE_NV && pname == GL_COORD_REPLACE_NV) >> -      ? ctx->Const.MaxTextureCoordUn

Re: [Mesa-dev] [PATCH 1/5] mesa: Check the texture against all units in unbind_texobj_from_texunits().

2011-07-06 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/03/2011 04:00 PM, Henri Verbeet wrote: > --- > src/mesa/main/texobj.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c > index 565a3a2..0e84b87 100644 > --- a/src/mes

Re: [Mesa-dev] [PATCH 4/5] mesa: Fix a couple of TexEnv unit limits.

2011-07-06 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/03/2011 04:00 PM, Henri Verbeet wrote: > --- > src/mesa/main/texenv.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/main/texenv.c b/src/mesa/main/texenv.c > index 9228e35..c0d0f37 100644 > --- a/src

Re: [Mesa-dev] [PATCH 2/2] st/mesa: handle float formats in st_format_datatype

2011-07-06 Thread Brian Paul
On 06/30/2011 04:10 PM, Marek Olšák wrote: NOTE: This is a candidate for the 7.11 branch. --- src/mesa/state_tracker/st_format.c | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) Reviewed-by: Brian Paul ___ mesa-dev mailin

Re: [Mesa-dev] [PATCH 1/2] st/mesa: use the first non-VOID channel in st_format_datatype

2011-07-06 Thread Brian Paul
On 06/30/2011 04:10 PM, Marek Olšák wrote: Otherwise PIPE_FORMAT_X8B8G8R8_UNORM and friends would fail. NOTE: This is a candidate for the 7.10 and 7.11 branches. Reviewed-by: Brian Paul ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http:

Re: [Mesa-dev] [PATCH 11/11] glsl: Lower break instructions when necessary at the end of a loop.

2011-07-06 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/05/2011 03:07 PM, Paul Berry wrote: > Normally lower_jumps.cpp doesn't need to lower a break instruction > that occurs at the end of a loop, because all back-ends can produce > proper GPU instructions for a break instruction in this "canonical" >

Re: [Mesa-dev] [PATCH 04/11] glsl: Add a unit test for lower_jumps.cpp

2011-07-06 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/05/2011 03:07 PM, Paul Berry wrote: > This test invokes do_lower_jumps() in isolation (using the glsl_test > executable) and verifies that it transforms the IR in the expected > way. > > The unit test may be run from the top level directory usin

Re: [Mesa-dev] [PATCH 08/11] glsl: lower unconditional returns and continues in loops.

2011-07-06 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/05/2011 03:07 PM, Paul Berry wrote: > Previously, lower_jumps.cpp would only lower return and continue > statements that appeared inside conditionals. This patch makes it > lower unconditional returns and continue statements that occur inside >

Re: [Mesa-dev] [PATCH 03/11] glsl: Create a standalone executable for testing optimization passes.

2011-07-06 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/05/2011 03:07 PM, Paul Berry wrote: > This patch adds a new build artifact, glsl_test, which can be used for > testing optimization passes in isolation. > > I'm hoping that we will be able to add other useful standalone tests > to this executabl

Re: [Mesa-dev] glsl: Improvements to lower_jumps.cpp

2011-07-06 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/05/2011 03:07 PM, Paul Berry wrote: > The following patch series fixes bug #36669 (EmitNoMainReturn set > to 1 doesn't make the GLSL compiler lower all the RET opcodes) as > well as several other bugs I found in the course of reviewing > lower_ju

Re: [Mesa-dev] [PATCH 00/13] Floating-point depth buffers

2011-07-06 Thread Brian Paul
On 06/30/2011 06:29 PM, Marek Olšák wrote: Hi, this patch series implements ARB_depth_buffer_float in Mesa and Gallium. There is complete r600g/r600-r700 support in my private branch, which passes the same tests that pass for Z24S8. Softpipe has only sampler support. This has turned out to be

Re: [Mesa-dev] [PATCH 1/5] mesa: Check the texture against all units in unbind_texobj_from_texunits().

2011-07-06 Thread Brian Paul
On 07/03/2011 05:00 PM, Henri Verbeet wrote: --- src/mesa/main/texobj.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 565a3a2..0e84b87 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj.c @@ -899,7 +8

Re: [Mesa-dev] [PATCH 2/2] r600g: RSQ: clear NEG for operand

2011-07-06 Thread Jose Fonseca
Good find. On this sort of issues it's a good idea to search the code for similar cases: - it looks like this is done differently above: case TGSI_OPCODE_ABS: alu.src[0].abs = 1; if (alu.src[0].neg) alu.src