[Mesa-dev] r600g on rv635 and broken mipmaps

2011-04-29 Thread Mathias Fröhlich
Hi, Since the lazy gpu flush changes for r600g about two weeks ago, I get broken mipmaps on my notebooks rv635. I am not sure if my analysis is right, but it appears to me that flushing the destination caches like it is done in r600_context_flush_dest_caches is not sufficient for my rv635. Sin

[Mesa-dev] [PATCH] r600g: Take care of bo placement domains.

2011-04-29 Thread Mathias Fröhlich
Hi, Attached is at patch described as follows: For creating and reusing already existing buffer objects, take care of the placement domains. Have a little more finegrained usage to placement mapping. This change does not account for the real location of the buffer object for buffer objects retu

[Mesa-dev] [Bug 36702] git master 41b38bd won't build on amd64

2011-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36702 atswa...@gmail.com changed: What|Removed |Added CC||atswa...@gmail.com -- Configure bug

[Mesa-dev] [Bug 36702] New: git master 41b38bd won't build on amd64

2011-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36702 Summary: git master 41b38bd won't build on amd64 Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority:

[Mesa-dev] [PATCH 12/12] i965: Update cached stencil region pointer when updating draw buffers

2011-04-29 Thread chad
From: Chad Versace That is, update brw_context.state.stencil_region and set the dirty bit BRW_NEW_STENCIL_BUFFER. Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/brw_vtbl.c |8 +++- src/mesa/drivers/dri/intel/intel_buffers.c | 13 + 2 files changed, 16 ins

[Mesa-dev] [PATCH 11/12] intel: Change signature of intel_context.vtbl.set_draw_region

2011-04-29 Thread chad
From: Chad Versace Add additional parameter 'struct intel_region *stencil_region'. A subsequent patch uses the new parameter to update brw_context.state.stencil_region. Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i915/i915_vtbl.c |3 +++ src/mesa/drivers/dri/i965/brw_vtbl.c

[Mesa-dev] [PATCH 10/12] i965: Define tracked state for separate stencil buffer

2011-04-29 Thread chad
From: Chad Versace - Add field brw_context.state.stencil_region. - Define dirty bit BRW_NEW_STENCIL_BUFFER, which signals that brw_context.state.stencil_region has changed. - Define 'struct brw_tracked_state brw_stencil_buffer' and add it to gen4_atoms. Signed-off-by: Chad Versace --- src/

[Mesa-dev] [PATCH 09/12] i965: Emit 3D_STATE_HIER_DEPTH_BUFFER

2011-04-29 Thread chad
From: Chad Versace ... when a HiZ region is present. Also change the hiz bits and depth format in 3D_STATE_DEPTH_BUFFER. Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/brw_misc_state.c | 47 +--- 1 files changed, 42 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH 08/12] i965: Refactor prepare_depthbuffer() and emit_depthbuffer()

2011-04-29 Thread chad
From: Chad Versace Rename variable 'region' to 'depth_region'. This removes naming ambiguity introduced by the next commit, which introduces the variable 'hiz_region'. Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/brw_misc_state.c | 26 +- 1 files changed,

[Mesa-dev] [PATCH 07/12] i965: Change FBO completeness criteria when HiZ is enabled

2011-04-29 Thread chad
From: Chad Versace When HiZ is enabled, hardware allows rendering to a separate stencil region and does not allow rendering to a combined depth/stencil region. So we need to: 1. Set an FBO's status to GL_FRAMEBUFFER_UNSUPPORTED when HiZ is enabled and its depth and stencil attachments are ide

[Mesa-dev] [PATCH 06/12] intel: Change allocation of user-created renderbuffers for HiZ

2011-04-29 Thread chad
From: Chad Versace Hardware does not allow rendering to depth/stencil formats when HiZ is enabled. Also, a GEM region must be allocated for HiZ. Signed-off-by: Chad Versace --- src/mesa/drivers/dri/intel/intel_fbo.c | 36 +++- 1 files changed, 35 insertions(+), 1

[Mesa-dev] [PATCH 05/12] intel: Add HiZ region to intel_renderbuffer

2011-04-29 Thread chad
From: Chad Versace When rendering to a depth buffer when HiZ is enabled, a GEM region must be allocated just for HiZ. There are two potential ways to do this: 1. Allocate a separate HiZ region. 2. Allocate a larger depth region, and let the tail be the HiZ region. Method 1 is chosen because,

[Mesa-dev] [PATCH 04/12] mesa/main: Add MESA_FORMAT_X8_Z24 to _mesa_choose_tex_format

2011-04-29 Thread chad
From: Chad Versace Prefer MESA_FORMAT_X8_Z24 over MESA_FORMAT_S8_Z24 for textures with internal format GL_DEPTH_COMPONENT*. i965 needs MESA_FORMAT_X8_Z24 for HiZ. Signed-off-by: Chad Versace --- src/mesa/main/texformat.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

[Mesa-dev] [PATCH 03/12] intel: Change supported texture formats

2011-04-29 Thread chad
From: Chad Versace Combined depth/stencil formats cannot be used when HiZ is enabled, so change intel_context.ctx.TextureFormatSupported accordingly. Signed-off-by: Chad Versace --- src/mesa/drivers/dri/intel/intel_context.c|7 ++- src/mesa/drivers/dri/intel/intel_tex_format.c |

[Mesa-dev] [PATCH 02/12] intel: Override intel_context.use_hiz with env var INTEL_USE_HIZ

2011-04-29 Thread chad
From: Chad Versace Valid values for INTEL_USE_HIZ are "0" or "1". Overriding HiZ is useful for performance profiling and testing. Signed-off-by: Chad Versace --- src/mesa/drivers/dri/intel/intel_context.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff

[Mesa-dev] [PATCH 01/12] intel: Add flag intel_context.use_hiz

2011-04-29 Thread chad
From: Chad Versace Currently, it is always set it to false. Once the HiZ implementation is complete, it needs to be enabled on Gen >= 5. Even though support for hiz is present only on gen >= 5, the field belongs in intel_context, not brw_context, because the functions that interact with DRI2 and

[Mesa-dev] [PATCH 00/12] i965: Begin implementing HiZ

2011-04-29 Thread chad
From: Chad Versace Begin implementing HiZ for Gen >= 5. Since it's incomplete, the patch series leaves HiZ disabled default. But you can force enable it with env INTEL_USE_HIZ=1. I did a full Piglit run on Gen 5 and found no regressions. These patches live on my personal hiz branch. What does

Re: [Mesa-dev] [PATCH] i965/gen6: Align interleaved URB writes for overflow outputs as well.

2011-04-29 Thread Kenneth Graunke
On 04/29/2011 04:13 PM, Eric Anholt wrote: Fixes glsl-max-varyings. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=35614 --- src/mesa/drivers/dri/i965/brw_vs_emit.c | 35 +++--- 1 files changed, 27 insertions(+), 8 deletions(-) Nice catch. Reviewed-by: Kenn

[Mesa-dev] [PATCH] i965/gen6: Align interleaved URB writes for overflow outputs as well.

2011-04-29 Thread Eric Anholt
Fixes glsl-max-varyings. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=35614 --- src/mesa/drivers/dri/i965/brw_vs_emit.c | 35 +++--- 1 files changed, 27 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vs_emit.c b/src/mesa/drivers/dri/i

Re: [Mesa-dev] [PATCH 2/2] st/mesa: expose ARB_ES2_compatibility if GL_FIXED vertex format is supported

2011-04-29 Thread Brian Paul
Reviewed-by: Brian Paul On 04/29/2011 10:13 AM, Marek Olšák wrote: Tested with softpipe and llvmpipe. --- src/mesa/state_tracker/st_extensions.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_e

Re: [Mesa-dev] [PATCH 1/2] mesa: accept GL_FIXED in glVertexAttribPointer (ARB_ES2_compatibility)

2011-04-29 Thread Brian Paul
Reviewed-by: Brian Paul On 04/29/2011 10:13 AM, Marek Olšák wrote: GL_FIXED should not be accepted in the other gl*Pointer calls in OpenGL. There is a new piglit for this: arb_es2_compatibility-fixed-type. --- src/mesa/main/varray.c | 23 +-- 1 files changed, 13 insert

[Mesa-dev] [Bug 36687] [regression] git/master now requires LLVM to build

2011-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36687 --- Comment #3 from Marek Olšák 2011-04-29 11:18:26 PDT --- Use: --disable-gallium-r300 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the

[Mesa-dev] [Bug 36687] [regression] git/master now requires LLVM to build

2011-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36687 --- Comment #2 from David Ronis 2011-04-29 11:10:25 PDT --- Thanks for the quick reply. So mesa requires a new compiler suite just for one module? Amazing! I've got an R200 here, can I simply disable the R300 module? -- Configure bugmail:

[Mesa-dev] [Bug 36687] [regression] git/master now requires LLVM to build

2011-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36687 Alex Deucher changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Mesa-dev] [Bug 36687] New: [regression] git/master now requires LLVM to build

2011-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36687 Summary: [regression] git/master now requires LLVM to build Product: Mesa Version: git Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: critical P

[Mesa-dev] [PATCH 2/2] st/mesa: expose ARB_ES2_compatibility if GL_FIXED vertex format is supported

2011-04-29 Thread Marek Olšák
Tested with softpipe and llvmpipe. --- src/mesa/state_tracker/st_extensions.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index a5324df..030bbc7 100644 --- a/src/mesa/state_tracker/st

[Mesa-dev] [PATCH 1/2] mesa: accept GL_FIXED in glVertexAttribPointer (ARB_ES2_compatibility)

2011-04-29 Thread Marek Olšák
GL_FIXED should not be accepted in the other gl*Pointer calls in OpenGL. There is a new piglit for this: arb_es2_compatibility-fixed-type. --- src/mesa/main/varray.c | 23 +-- 1 files changed, 13 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/varray.c b/src/mesa/

Re: [Mesa-dev] [PATCH 2/2] configure.ac: refuse to build r300g without LLVM

2011-04-29 Thread Marek Olšák
Looks good. Reviewed-by: Marek Olšák On Fri, Apr 29, 2011 at 1:55 PM, Jon TURNEY wrote: > On 28/04/2011 11:50, Marek Olšák wrote: >> Would the attached patch be ok with you? Or do you have a better idea? > > I'm wondering if it makes any sense to build the various gallium hardware > drivers whe

Re: [Mesa-dev] [PATCH 2/2] configure.ac: refuse to build r300g without LLVM

2011-04-29 Thread Jon TURNEY
On 28/04/2011 11:50, Marek Olšák wrote: > Would the attached patch be ok with you? Or do you have a better idea? I'm wondering if it makes any sense to build the various gallium hardware drivers when not ./configured --with-driver=dri? (at the moment svga i915 i965 r300 are all automatically enabl

Re: [Mesa-dev] [PATCH] st/mesa: fix WPOS adjustment, with more comments

2011-04-29 Thread Marek Olšák
Tested-by: Marek Olšák On Wed, Apr 27, 2011 at 8:53 PM, Christoph Bumiller wrote: > Again, with a more detailed explanation added as comments. > > On 20.04.2011 17:33, Christoph Bumiller wrote: > > On 04/19/2011 04:00 AM, Christoph Bumiller wrote: > > On 16.04.2011 18:50, Christoph Bumiller wr

Re: [Mesa-dev] [PATCH] Add git_sha1.h to .gitignore

2011-04-29 Thread Marek Olšák
Reviewed-by: Marek Olšák On Tue, Apr 26, 2011 at 2:17 PM, Jon TURNEY wrote: > Since commit de579a1 "Include GIT SHA1 in GL version string" > > $ git status >  On branch master >  Your branch is ahead of 'origin/master' by 2 commits. > >  Untracked files: >   (use "git add ..." to include in what