[Mesa-dev] [PATCH] st/mesa: fix computing the lowest address for interleaved attribs

2011-02-22 Thread Marek Olšák
From: Wiktor Janas Ptr can be very well NULL, so when there are two arrays, with one having offset 0 (and thus NULL Ptr), and the other having a non-zero offset, the non-zero value is taken as minimum (because of !low_addr ? start ...). On 32-bit systems, this somehow works. On 64-bit systems, it

Re: [Mesa-dev] [PATCH 3/4] dri2: Don't call the dri2 flush hook for swapbuffers unless we have a context.

2011-02-22 Thread Eric Anholt
On Tue, 22 Feb 2011 15:04:07 -0800, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 02/22/2011 01:55 PM, Eric Anholt wrote: > > Could the glFlush() skipping affect real applications? I'm not sure if > > ARB_sync or OQ users do glFlush()es after OQs they know they're

Re: [Mesa-dev] [PATCH 3/4] dri2: Don't call the dri2 flush hook for swapbuffers unless we have a context.

2011-02-22 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/22/2011 12:07 PM, Kristian Høgsberg wrote: > It looks like there could be a problem if the drawable isn't current > for any context, and Erics patch looks like it just skips it if > there's no current context which probably fixes some crashes. I

Re: [Mesa-dev] [PATCH 3/4] dri2: Don't call the dri2 flush hook for swapbuffers unless we have a context.

2011-02-22 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/22/2011 01:55 PM, Eric Anholt wrote: > On Tue, 22 Feb 2011 15:07:45 -0500, Kristian Høgsberg > wrote: >> On Tue, Feb 22, 2011 at 2:07 PM, Ian Romanick wrote: >>> -BEGIN PGP SIGNED MESSAGE- >>> Hash: SHA1 >>> >>> On 02/21/2011 02:41 PM,

Re: [Mesa-dev] [PATCH 3/4] dri2: Don't call the dri2 flush hook for swapbuffers unless we have a context.

2011-02-22 Thread Eric Anholt
On Tue, 22 Feb 2011 15:07:45 -0500, Kristian Høgsberg wrote: > On Tue, Feb 22, 2011 at 2:07 PM, Ian Romanick wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > On 02/21/2011 02:41 PM, Eric Anholt wrote: > >> The driver only has one reasonable place to look for its context to >

Re: [Mesa-dev] [cairo] [PATCH 1/4] mesa: Add new MESA_multithread_makecurrent extension.

2011-02-22 Thread Alexandros Frantzis
On Mon, Feb 21, 2011 at 02:41:06PM -0800, Eric Anholt wrote: > This extension allows a client to bind one context in multiple threads > simultaneously. It is then up to the client to manage synchronization of > access to the GL, just as normal multithreaded GL from multiple contexts > requires syn

Re: [Mesa-dev] [PATCH 1/4] mesa: Add new MESA_multithread_makecurrent extension.

2011-02-22 Thread Eric Anholt
On Tue, 22 Feb 2011 11:57:38 -0800, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 02/21/2011 02:41 PM, Eric Anholt wrote: > > This extension allows a client to bind one context in multiple threads > > simultaneously. It is then up to the client to manage synchroniz

Re: [Mesa-dev] [PATCH 3/4] dri2: Don't call the dri2 flush hook for swapbuffers unless we have a context.

2011-02-22 Thread Kristian Høgsberg
On Tue, Feb 22, 2011 at 2:07 PM, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 02/21/2011 02:41 PM, Eric Anholt wrote: >> The driver only has one reasonable place to look for its context to >> flush anything, which is the current context.  Don't bother it with >> hav

Re: [Mesa-dev] [PATCH 1/4] mesa: Add new MESA_multithread_makecurrent extension.

2011-02-22 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/21/2011 02:41 PM, Eric Anholt wrote: > This extension allows a client to bind one context in multiple threads > simultaneously. It is then up to the client to manage synchronization of > access to the GL, just as normal multithreaded GL from mul

Re: [Mesa-dev] [PATCH 3/4] dri2: Don't call the dri2 flush hook for swapbuffers unless we have a context.

2011-02-22 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/21/2011 02:41 PM, Eric Anholt wrote: > The driver only has one reasonable place to look for its context to > flush anything, which is the current context. Don't bother it with > having to check. There are some odd interactions here, but I don't

Re: [Mesa-dev] Mesa 7.9.2 and 7.10.1 releases

2011-02-22 Thread Kenneth Graunke
On Monday, February 21, 2011 02:01:45 PM Ian Romanick wrote: > I'm planning to cherry pick a handful more patches back to the stable > branches this week. I just pushed a bunch of Sandybridge fixes that I'd like to see in the next 7.10 release. They're all marked. > I'd like to make stable rele

Re: [Mesa-dev] DRM EGL swapbuffers?

2011-02-22 Thread Chia-I Wu
On Tue, Feb 22, 2011 at 1:56 AM, Thomas Hellstrom wrote: > Hi, Chia-I, > > Looking at the EGL DRM implementation of swapbuffers, it looks like we're > sort of ad-hoc attaching the backbuffer as a new scanout surface, using > drmModeSetCrtc. > > I don't think this works very well on all hardware. I

Re: [Mesa-dev] [cairo] [PATCH 1/4] mesa: Add new MESA_multithread_makecurrent extension.

2011-02-22 Thread Eric Anholt
On Tue, 22 Feb 2011 12:09:44 +0200, Alexandros Frantzis wrote: > On Mon, Feb 21, 2011 at 02:41:06PM -0800, Eric Anholt wrote: > > This extension allows a client to bind one context in multiple threads > > simultaneously. It is then up to the client to manage synchronization of > > access to the

[Mesa-dev] [Bug 33078] Sauerbraten refuses to start

2011-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33078 Marek Olšák changed: What|Removed |Added Component|Drivers/Gallium/r300|GLX AssignedTo|dri-devel@lists.fre

Re: [Mesa-dev] [PATCH] Define GLX_USE_TLS when the user asks for TLS.

2011-02-22 Thread Dan Nicholson
On Mon, Feb 21, 2011 at 9:11 PM, Chia-I Wu wrote: > On Mon, Feb 21, 2011 at 8:12 PM, Tom Fogal wrote: >> From: Tom Fogal >> >> Without this, we do not actually respect the request for TLS. > What is your setup?  The macro should be defined as part of $(CFLAGS). >  It may not be a good practice a

[Mesa-dev] [Bug 32946] piglit glx-make-current gives X error BadMatch

2011-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=32946 Marek Olšák changed: What|Removed |Added Component|Drivers/Gallium/r300|GLX AssignedTo|dri-devel@lists.fre

Re: [Mesa-dev] [PATCH] Define GLX_USE_TLS when the user asks for TLS.

2011-02-22 Thread Chia-I Wu
On Mon, Feb 21, 2011 at 10:39 PM, tom fogal wrote: > Chia-I Wu writes: >> On Mon, Feb 21, 2011 at 8:12 PM, Tom Fogal wrote: >> > From: Tom Fogal >> > >> > Without this, we do not actually respect the request for TLS. >> >> What is your setup? > >    ./configure                           \ >    

Re: [Mesa-dev] [PATCH] st/mesa: fix crash when DrawBuffer->_ColorDrawBuffers[0] is NULL

2011-02-22 Thread Brian Paul
On 02/22/2011 03:52 AM, Marek Olšák wrote: Brian, I realized that this clear color translation is wrong because it won't work for multiple render targets. It's possible to have mixed format attachments like one with GL_LUMINANCE8_ALPHA8 and another one with GL_RGBA8 in slots 0 and 1 respectively

Re: [Mesa-dev] Mesa 7.9.2 and 7.10.1 releases

2011-02-22 Thread Brian Paul
Hmmm, I'm not seeing that here. I normally build with 'make linux-llvmpipe' but I just tried './configure --enable-gallium-llvm --enable-gallium-swrast' and it worked fine. -Brian On 02/22/2011 12:29 AM, Marek Olšák wrote: FYI, Mesa 7.9 doesn't build with --enable-gallium-llvm --enable-gall

Re: [Mesa-dev] [PATCH] st/mesa: fix crash when using both user and vbo buffers with the same stride

2011-02-22 Thread Keith Whitwell
Looks good to me. Keith On Sun, 2011-02-20 at 18:14 +0100, Marek Olšák wrote: > If two buffers had the same stride where one buffer is a user one and > the other is a vbo, it was considered to be one interleaved buffer, > resulting in incorrect rendering and crashes. > > This patch makes sure th

Re: [Mesa-dev] [PATCH] st/mesa: fix crash when DrawBuffer->_ColorDrawBuffers[0] is NULL

2011-02-22 Thread Keith Whitwell
Looks good Marek. Keith On Sun, 2011-02-20 at 16:52 +0100, Marek Olšák wrote: > This fixes the game Tiny and Big. > --- > src/mesa/state_tracker/st_cb_clear.c | 16 ++-- > 1 files changed, 10 insertions(+), 6 deletions(-) > > diff --git a/src/mesa/state_tracker/st_cb_clear.c > b/

Re: [Mesa-dev] [PATCH] st/mesa: fix crash when DrawBuffer->_ColorDrawBuffers[0] is NULL

2011-02-22 Thread Marek Olšák
Brian, I realized that this clear color translation is wrong because it won't work for multiple render targets. It's possible to have mixed format attachments like one with GL_LUMINANCE8_ALPHA8 and another one with GL_RGBA8 in slots 0 and 1 respectively, the ARB_fbo spec allows it. I think we shou

[Mesa-dev] FreeGLUT performance - pointless X server roundtrip

2011-02-22 Thread Keith Whitwell
I've always wondered why freeGLUT gives such poor numbers for gears and similar high-framerate demos relative to the original. It looks like one reason is the code added for Spaceball handling which tries to initialize the Spaceball device every frame, even if it previously failed. The trouble be

[Mesa-dev] DRM EGL swapbuffers?

2011-02-22 Thread Thomas Hellstrom
Hi, Chia-I, Looking at the EGL DRM implementation of swapbuffers, it looks like we're sort of ad-hoc attaching the backbuffer as a new scanout surface, using drmModeSetCrtc. I don't think this works very well on all hardware. In particular, I think drmModeSetCrtc may return before the swap a

Re: [Mesa-dev] [PATCH v3] mesa: Optionally build a dricore support library (v3)

2011-02-22 Thread Sedat Dilek
On Mon, Feb 21, 2011 at 6:06 PM, Dan Nicholson wrote: > On Sun, Feb 20, 2011 at 3:04 PM, Sedat Dilek > wrote: >> >> # LIBGL_DEBUG=verbose glxinfo 2>/dev/null | grep -i opengl >> OpenGL vendor string: Mesa Project >> OpenGL renderer string: Software Rasterizer >> OpenGL version string: 2.1 Mesa 7

[Mesa-dev] [PATCH] st/mesa: fix crash when using both user and vbo buffers with the same stride

2011-02-22 Thread Marek Olšák
If two buffers had the same stride where one buffer is a user one and the other is a vbo, it was considered to be one interleaved buffer, resulting in incorrect rendering and crashes. This patch makes sure that the interleaved buffer is either user or vbo, not both. --- src/mesa/state_tracker/st_