https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/121820
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/121819
>From 9f952de3cb3e973f17121c057089a28bf4c6e5e0 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 6 Jan 2025 11:15:35 -0800
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UTF-8
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/121819
>From 9f952de3cb3e973f17121c057089a28bf4c6e5e0 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 6 Jan 2025 11:15:35 -0800
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UTF-8
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/121820
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/121820
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/121820
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/121820
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
ilovepi wrote:
@petrhosek I assume we'r good to reland this now that the RTSan and libunwind
build fixes are in?
https://github.com/llvm/llvm-project/pull/121820
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llv
@@ -0,0 +1,95 @@
+// Tests that we assign appropriate identifiers to indirect calls and targets
ilovepi wrote:
can we get more descriptive file names than `call-graph-section-1`
`call-graph-section-2`? For instance, its nice if you can tell which properties
are
@@ -2214,9 +2214,8 @@ CGObjCCommonMac::EmitMessageSend(CodeGen::CodeGenFunction
&CGF,
llvm::CallBase *CallSite;
CGCallee Callee = CGCallee::forDirect(BitcastFn);
- RValue rvalue = CGF.EmitCall(MSI.CallInfo, Callee, Return, ActualArgs,
- &Cal
@@ -6172,7 +6172,6 @@ RValue CodeGenFunction::EmitCall(QualType CalleeType,
}
if (CallOrInvoke)
*CallOrInvoke = LocalCallOrInvoke;
-
ilovepi wrote:
nit: unrelated
https://github.com/llvm/llvm-project/pull/117036
___
ilovepi wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/132103?utm_source=stack-comment-downstack-mergeability-warning";
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/132103
>From 4fba6cff9cc3dc5b2a8eeedb8de0fded9178fcb3 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 19 Mar 2025 21:07:22 +
Subject: [PATCH] [clang-doc] Correct improper file paths in HTML output
In index.js
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/132101
>From df32792335aa51d040a536a7132bf7e9fadff558 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 19 Mar 2025 20:58:15 +
Subject: [PATCH] [clang-doc][NFC] Remove unnecessary directory cleanup
The tests al
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/132101
>From df32792335aa51d040a536a7132bf7e9fadff558 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 19 Mar 2025 20:58:15 +
Subject: [PATCH] [clang-doc][NFC] Remove unnecessary directory cleanup
The tests al
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/132103
>From 9293b4ce688b5e420e31e6b442be2f41233d2e1d Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 19 Mar 2025 21:07:22 +
Subject: [PATCH] [clang-doc] Correct improper file paths in HTML output
In index.js
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/132103
>From 9293b4ce688b5e420e31e6b442be2f41233d2e1d Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 19 Mar 2025 21:07:22 +
Subject: [PATCH] [clang-doc] Correct improper file paths in HTML output
In index.js
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/132103
>From 4fba6cff9cc3dc5b2a8eeedb8de0fded9178fcb3 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 19 Mar 2025 21:07:22 +
Subject: [PATCH] [clang-doc] Correct improper file paths in HTML output
In index.js
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/132103
>From f50f1a7bac5c0a91fb8280d4ee90139691f07f95 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 19 Mar 2025 21:07:22 +
Subject: [PATCH] [clang-doc] Correct improper file paths in HTML output
In index.js
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/132103
>From f50f1a7bac5c0a91fb8280d4ee90139691f07f95 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 19 Mar 2025 21:07:22 +
Subject: [PATCH] [clang-doc] Correct improper file paths in HTML output
In index.js
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/132101
>From c857982fa9162b37e34099bf20332cc0b22286ed Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 19 Mar 2025 20:58:15 +
Subject: [PATCH] [clang-doc][NFC] Remove unnecessary directory cleanup
The tests al
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/132101
>From c857982fa9162b37e34099bf20332cc0b22286ed Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 19 Mar 2025 20:58:15 +
Subject: [PATCH] [clang-doc][NFC] Remove unnecessary directory cleanup
The tests al
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/131939
>From ea338585014151fcc5806a1c39ad39e9cb35999a Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 18 Mar 2025 23:38:09 +
Subject: [PATCH] [clang-doc] Avoid deref of invalid std::optional
Since our existin
ilovepi wrote:
### Merge activity
* **Mar 20, 5:02 PM EDT**: A user started a stack merge that includes this pull
request via
[Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/132103).
https://github.com/llvm/llvm-project/pull/132103
ilovepi wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/132101?utm_source=stack-comment-downstack-mergeability-warning";
@@ -0,0 +1,93 @@
+# Test MIR printer and parser for type id field in callSites. It is used
+# for propogating call site type identifiers to emit in the call graph section.
+
+# RUN: llc --call-graph-section %s -run-pass=none -o - | FileCheck %s
+# CHECK: name: main
+# CHECK: callS
@@ -496,6 +496,9 @@ class LLVM_ABI MachineFunction {
struct CallSiteInfo {
/// Vector of call argument and its forwarding register.
SmallVector ArgRegPairs;
+
+/// Callee type id.
+ConstantInt *TypeId = nullptr;
ilovepi wrote:
```suggestion
https://github.com/ilovepi commented:
LGTM on the RISC-V additions, but do follow through on @arsenm's comments
before landing.
https://github.com/llvm/llvm-project/pull/87575
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
htt
@@ -576,6 +576,9 @@ void
MIRPrinter::convertCallSiteObjects(yaml::MachineFunction &YMF,
printRegMIR(ArgReg.Reg, YmlArgReg.Reg, TRI);
YmlCS.ArgForwardingRegs.emplace_back(YmlArgReg);
}
+// Get type id.
+if (CSInfo.second.TypeId)
+ YmlCS.TypeId = CSI
ilovepi wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/131939?utm_source=stack-comment-downstack-mergeability-warning";
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/132103
In index.js the logic of the ternary operator was backwards, preventing
us from generating the correct file paths, or relative paths in the HTML
output.
>From 6182de900b039f86b564ecf8b74fce8f07317d28 Mon Sep 17
ilovepi wrote:
### Merge activity
* **Mar 20, 5:02 PM EDT**: A user started a stack merge that includes this pull
request via
[Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/132101).
https://github.com/llvm/llvm-project/pull/132101
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/132101
>From 3f09b51ea96344fe03a6ffd453d4fba48e700526 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 19 Mar 2025 20:58:15 +
Subject: [PATCH] [clang-doc][NFC] Remove unnecessary directory cleanup
The tests al
ilovepi wrote:
Is there documentation anywhere on the format being output via
`--call-graph-section`? I get you're checking the MD5, but I'm also interested
in if we're checking the output sufficiently.
https://discourse.llvm.org/t/rfc-computing-storing-and-restoring-conservative-call-graphs-w
ilovepi wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/135457?utm_source=stack-comment-downstack-mergeability-warning";
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/135457
clang-doc didn't visit VarDecl, and hence never collected info
from class statics members and functions.
Fixes #59813.
>From 4b02fd4b9043237a997f01b3fa814c6f172d98d8 Mon Sep 17 00:00:00 2001
From: Paul Kirth
D
https://github.com/ilovepi ready_for_review
https://github.com/llvm/llvm-project/pull/135457
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ilovepi approved this pull request.
I think this makes sense to backport.
https://github.com/llvm/llvm-project/pull/134711
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/135706
Since the backend may emit calls to these functions, they should be
treated like other libcalls. If we don't, then it is possible to
have their definitions removed during LTO because they are dead, only to
have a
https://github.com/ilovepi ready_for_review
https://github.com/llvm/llvm-project/pull/135706
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -1642,6 +1642,101 @@ void AsmPrinter::emitStackUsage(const MachineFunction
&MF) {
*StackUsageStream << "static\n";
}
+/// Extracts a generalized numeric type identifier of a Function's type from
+/// type metadata. Returns null if metadata cannot be found.
+static Cons
@@ -1642,6 +1642,101 @@ void AsmPrinter::emitStackUsage(const MachineFunction
&MF) {
*StackUsageStream << "static\n";
}
+/// Extracts a generalized numeric type identifier of a Function's type from
+/// type metadata. Returns null if metadata cannot be found.
+static Cons
@@ -1948,6 +2047,26 @@ void AsmPrinter::emitFunctionBody() {
break;
}
+ // FIXME: Some indirect calls can get lowered to jump instructions,
+ // resulting in emitting labels for them. The extra information can
+ // be neglected while disassembling
@@ -1948,6 +2045,28 @@ void AsmPrinter::emitFunctionBody() {
break;
}
+ // FIXME: Some indirect calls can get lowered to jump instructions,
+ // resulting in emitting labels for them. The extra information can
+ // be neglected while disassembling
@@ -0,0 +1,50 @@
+;; Tests that we store the type identifiers in .callgraph section of the
binary.
+
+; RUN: llc --call-graph-section -filetype=obj -o - < %s | \
+; RUN: llvm-readelf -x .callgraph - | FileCheck %s
+
+declare void @foo()
+
+declare noundef i32 @bar(i8 signext)
+
+
@@ -1642,6 +1642,101 @@ void AsmPrinter::emitStackUsage(const MachineFunction
&MF) {
*StackUsageStream << "static\n";
}
+/// Extracts a generalized numeric type identifier of a Function's type from
+/// type metadata. Returns null if metadata cannot be found.
+static Cons
@@ -0,0 +1,50 @@
+;; Tests that we store the type identifiers in .callgraph section of the
binary.
+
+; RUN: llc --call-graph-section -filetype=obj -o - < %s | \
+; RUN: llvm-readelf -x .callgraph - | FileCheck %s
+
+declare void @foo()
+
+declare noundef i32 @bar(i8 signext)
+
+
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/87576
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -0,0 +1,50 @@
+;; Tests that we store the type identifiers in .callgraph section of the
binary.
+
+; RUN: llc --call-graph-section -filetype=obj -o - < %s | \
+; RUN: llvm-readelf -x .callgraph - | FileCheck %s
+
+declare void @foo()
+
+declare noundef i32 @bar(i8 signext)
+
+
@@ -1642,6 +1642,101 @@ void AsmPrinter::emitStackUsage(const MachineFunction
&MF) {
*StackUsageStream << "static\n";
}
+/// Extracts a generalized numeric type identifier of a Function's type from
+/// type metadata. Returns null if metadata cannot be found.
+static Cons
@@ -2873,14 +2890,33 @@ void
CodeGenModule::CreateFunctionTypeMetadataForIcall(const FunctionDecl *FD,
llvm::Metadata *MD = CreateMetadataIdentifierForType(FD->getType());
F->addTypeMetadata(0, MD);
- F->addTypeMetadata(0, CreateMetadataIdentifierGeneralized(FD->getType(
@@ -2860,9 +2861,25 @@ static void setLinkageForGV(llvm::GlobalValue *GV, const
NamedDecl *ND) {
GV->setLinkage(llvm::GlobalValue::ExternalWeakLinkage);
}
+static bool HasExistingGeneralizedTypeMD(llvm::Function *F) {
+ llvm::MDNode *MD = F->getMetadata(llvm::LLVMContext
@@ -2860,9 +2861,25 @@ static void setLinkageForGV(llvm::GlobalValue *GV, const
NamedDecl *ND) {
GV->setLinkage(llvm::GlobalValue::ExternalWeakLinkage);
}
+static bool HasExistingGeneralizedTypeMD(llvm::Function *F) {
ilovepi wrote:
```suggestion
static
@@ -2873,14 +2890,33 @@ void
CodeGenModule::CreateFunctionTypeMetadataForIcall(const FunctionDecl *FD,
llvm::Metadata *MD = CreateMetadataIdentifierForType(FD->getType());
F->addTypeMetadata(0, MD);
- F->addTypeMetadata(0, CreateMetadataIdentifierGeneralized(FD->getType(
@@ -0,0 +1,83 @@
+// Tests that we assign appropriate identifiers to indirect calls and targets.
+
ilovepi wrote:
```suggestion
REQUIRES: x86-registered-target
```
I think you need a requires line here, if you're gong to set the triple. Or
this could be under `C
@@ -0,0 +1,83 @@
+// Tests that we assign appropriate identifiers to indirect calls and targets.
+
+// RUN: %clang_cc1 -triple x86_64-unknown-linux -fcall-graph-section \
ilovepi wrote:
Should this run w/ `-disable-llvm-passes`?
https://github.com/llvm/llvm-proj
@@ -1622,6 +1622,9 @@ class CodeGenModule : public CodeGenTypeCache {
void CreateFunctionTypeMetadataForIcall(const FunctionDecl *FD,
llvm::Function *F);
+ /// Create and attach type metadata to the given call.
+ void CreateCalleeT
@@ -1642,6 +1642,94 @@ void AsmPrinter::emitStackUsage(const MachineFunction
&MF) {
*StackUsageStream << "static\n";
}
+/// Extracts a generalized numeric type identifier of a Function's type from
+/// type metadata. Returns null if metadata cannot be found.
+static Const
@@ -68,6 +68,9 @@ class MCObjectFileInfo {
/// Language Specific Data Area information is emitted to.
MCSection *LSDASection = nullptr;
+ /// Section containing metadata on call graph.
ilovepi wrote:
```suggestion
/// Section containing call graph meta
@@ -0,0 +1,50 @@
+;; Tests that we store the type identifiers in .callgraph section of the
binary.
+
+; RUN: llc --call-graph-section -filetype=obj -o - < %s | \
+; RUN: llvm-readelf -x .callgraph - | FileCheck %s
ilovepi wrote:
I don't see any tests under `test
@@ -1619,9 +1619,12 @@ class CodeGenModule : public CodeGenTypeCache {
llvm::Metadata *CreateMetadataIdentifierGeneralized(QualType T);
/// Create and attach type metadata to the given function.
- void CreateFunctionTypeMetadataForIcall(const FunctionDecl *FD,
+ void cre
@@ -2860,9 +2861,25 @@ static void setLinkageForGV(llvm::GlobalValue *GV, const
NamedDecl *ND) {
GV->setLinkage(llvm::GlobalValue::ExternalWeakLinkage);
}
+static bool HasExistingGeneralizedTypeMD(llvm::Function *F) {
+ llvm::MDNode *MD = F->getMetadata(llvm::LLVMContext
ilovepi wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/138059?utm_source=stack-comment-downstack-mergeability-warning";
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/135457
>From 1e5adae44b8e8ebbb0438d1c5972f3937711954a Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 7 Apr 2025 08:37:40 -0700
Subject: [PATCH 1/4] [clang-doc] Handle static members and functions
clang-doc didn'
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/135457
>From 1e4d789c7b45fbc17910d48602f314860e731350 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 7 Apr 2025 08:37:40 -0700
Subject: [PATCH 1/5] [clang-doc] Handle static members and functions
clang-doc didn'
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/135457
>From 1e4d789c7b45fbc17910d48602f314860e731350 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 7 Apr 2025 08:37:40 -0700
Subject: [PATCH 1/5] [clang-doc] Handle static members and functions
clang-doc didn'
@@ -687,6 +687,62 @@ emitInfo(const RecordDecl *D, const FullComment *FC, int
LineNumber,
PopulateTemplateParameters(I->Template, D);
+ // Full and partial specializations.
+ if (auto *CTSD = dyn_cast(D)) {
+if (!I->Template)
+ I->Template.emplace();
+I->Tem
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/135457
>From 1e5adae44b8e8ebbb0438d1c5972f3937711954a Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 7 Apr 2025 08:37:40 -0700
Subject: [PATCH 1/5] [clang-doc] Handle static members and functions
clang-doc didn'
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/135457
>From 1e5adae44b8e8ebbb0438d1c5972f3937711954a Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 7 Apr 2025 08:37:40 -0700
Subject: [PATCH 1/3] [clang-doc] Handle static members and functions
clang-doc didn'
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/135457
>From 1e5adae44b8e8ebbb0438d1c5972f3937711954a Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 7 Apr 2025 08:37:40 -0700
Subject: [PATCH 1/2] [clang-doc] Handle static members and functions
clang-doc didn'
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/135457
>From 1e5adae44b8e8ebbb0438d1c5972f3937711954a Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 7 Apr 2025 08:37:40 -0700
Subject: [PATCH 1/2] [clang-doc] Handle static members and functions
clang-doc didn'
ilovepi wrote:
First, thanks for the context. I don't see anything like this written down, so
I plan to find some place in our docs to put those details. I'll be sure to CC
you and other folks I think will have thoughts on the precise verbiage. The
compiler's contract with libc is, from what I
ilovepi wrote:
hmm, that's an interesting direction. We were discussing this internally, and
we were outlining some ideas along these lines, but I think you've articulated
this quite a bit better than we have so far. I really like this idea of a
"no-builtins" world, and transitioning the IR. I
ilovepi wrote:
@efriedma-quic We've been discussing the topic of LTOing libc quite a bit
internally, and are currently sketching out how this could work.
Unsurprisingly, there's quite a lot to think about in both the compiler and
linker, and how the two combine in our different versions of LTO
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/138062
This patch adds or fills in some helper functions related to template
setup when initializing the mustache backend. It was split from #133161.
Co-authored-by: Peter Chou
>From 77bb241f4c6d69e934296a54040e233f9
ilovepi wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/138060?utm_source=stack-comment-downstack-mergeability-warning";
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/138065
This patch updates Serialize.cpp to serialize more data about C++
templates, which are supported by the new mustache HTML template.
Split from #133161.
Co-authored-by: Peter Chou
Rate l
ilovepi wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/138061?utm_source=stack-comment-downstack-mergeability-warning";
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/138066
This patch adds a command line option and enables the Mustache template
HTML backend. This allows users to use the new, more flexible templates
over the old and cumbersome HTML output. Split from #133161.
Co-aut
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/138059
This patch adds the various assets used with the HTML Mustache backend.
This includes templates for a variety of different language constructs,
as well as the CSS. Split from #133161.
Co-authored-by: Peter Chou
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/138063
Split from #133161. This patch provides the implementation of a number
of extractValue overloads used with the different types of Info.
The new helper functions extract the relevant information from the
differen
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/138064
This patch implements the business logic for setupTemplateValue, which
was split from #133161. The implementation configures the relative path
relationships between the various HTML components, and prepares them
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/138060
Split from #133161. This patch adds HTMLMustacheGenerator.cpp, and
the most basic class defintion for the generator. Future patches will
add functionality.
Co-authored-by: Peter Chou
>From 397d5dc9657733afa951
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/138061
Split from #133161. This patch fills in the implementation for a number
of the MustacheHTMLGenerator methods. Many of these APIs are just
stubbed out, and will have their implementation filled in by later
patches
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/138067
Originally part of #133161. This patch adds preliminary tracking
for of TypeInfo, by tracking if the type is a builtin or template.
The new functionality is not yet exercised.
Co-authored-by: Peter Chou
ilovepi wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/138066?utm_source=stack-comment-downstack-mergeability-warning";
ilovepi wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/138064?utm_source=stack-comment-downstack-mergeability-warning";
ilovepi wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/138065?utm_source=stack-comment-downstack-mergeability-warning";
https://github.com/ilovepi ready_for_review
https://github.com/llvm/llvm-project/pull/138059
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
ilovepi wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/138067?utm_source=stack-comment-downstack-mergeability-warning";
ilovepi wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/138063?utm_source=stack-comment-downstack-mergeability-warning";
ilovepi wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/138062?utm_source=stack-comment-downstack-mergeability-warning";
https://github.com/ilovepi ready_for_review
https://github.com/llvm/llvm-project/pull/138062
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ilovepi ready_for_review
https://github.com/llvm/llvm-project/pull/138060
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ilovepi ready_for_review
https://github.com/llvm/llvm-project/pull/138061
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
ilovepi wrote:
@PeterChou1 can you provide some context about how you originally expected
these fields to be used/consumed? Here we bake them into the representation and
serialize them, but I don't see any handling of them in the original patch. How
should they be used by the different backend
ilovepi wrote:
I appreciate this is a lot of CSS and templates. I have this here in the stack,
so that hopefully I can leverage these to bootstrap unittests for the
HTMLMustacheGenerator in subsequent patches.
https://github.com/llvm/llvm-project/pull/138059
___
ilovepi wrote:
Testing in this patch will have to be limited to unit tests, if we can
bootstrap anything at all.
https://github.com/llvm/llvm-project/pull/138060
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llv
ilovepi wrote:
I'm wondering if this should be earlier in the stack to facilitate better
testing.
https://github.com/llvm/llvm-project/pull/138066
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/ilovepi approved this pull request.
LGTM once all the dependent patches are landed.
https://github.com/llvm/llvm-project/pull/117037
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-
401 - 500 of 769 matches
Mail list logo
