[llvm-branch-commits] [clang] [TySan] A Type Sanitizer (Clang) (PR #76260)

https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/76260 >From ab8d005600b99fb62d991bc63c58136576429385 Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Thu, 18 Apr 2024 23:01:03 +0100 Subject: [PATCH 1/3] [TySan] A Type Sanitizer (Clang) --- clang/include/clang/Basic/

[llvm-branch-commits] [clang] [TySan] A Type Sanitizer (Clang) (PR #76260)

fhahn wrote: > The clang changes are ok, but this needs some level of documentation/release > notes, which I don't see in the clang release. As this is a part of a larger > feature, do we intend to push that later? > > Also, the clang-format suggestion makes sense. Sorry for the long delay! A

[llvm-branch-commits] [compiler-rt] [TySan] Fix struct access with different bases (PR #108385)

fhahn wrote: Thanks for putting up the patch! I just rebased the patches, hopefully we can get them in soon so it is easier to submit bug-fixes iteratively. I noticed that with this patch, I am seeing segfaults when running `llvm-min-tblgen` when built with `-fsanitize=type`, but I wasn't ab

[llvm-branch-commits] [clang] [TySan] A Type Sanitizer (Clang) (PR #76260)

https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/76260 >From ab8d005600b99fb62d991bc63c58136576429385 Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Thu, 18 Apr 2024 23:01:03 +0100 Subject: [PATCH 1/2] [TySan] A Type Sanitizer (Clang) --- clang/include/clang/Basic/

[llvm-branch-commits] [llvm] release/19.x: [Matrix] Skip already fused instructions before trying to fuse multiply. (PR #118020)

https://github.com/fhahn closed https://github.com/llvm/llvm-project/pull/118020 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] llvm-reduce: Change function return types if function is not called (PR #134035)

https://github.com/fhahn edited https://github.com/llvm/llvm-project/pull/134035 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] llvm-reduce: Change function return types if function is not called (PR #134035)

@@ -55,8 +57,10 @@ static void rewriteFuncWithReturnType(Function &OldF, Value *NewRetValue) { BasicBlock::iterator NewValIt = NewRetI ? NewRetI->getIterator() : EntryBB.end(); + Type *OldRetTy = OldFuncTy->getReturnType(); + // Hack up any return values in other

[llvm-branch-commits] [llvm] SeparateConstOffsetFromGEP: Avoid looking at constant uses (PR #134685)

https://github.com/fhahn approved this pull request. LGTM ,thanks! https://github.com/llvm/llvm-project/pull/134685 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-comm

[llvm-branch-commits] [llvm] llvm-reduce: Change function return types if function is not called (PR #134035)

https://github.com/fhahn approved this pull request. LGTM, thanks https://github.com/llvm/llvm-project/pull/134035 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi

[llvm-branch-commits] [llvm] SCEVExpander: Don't look at uses of constants (PR #134691)

https://github.com/fhahn approved this pull request. LGTM, thanks https://github.com/llvm/llvm-project/pull/134691 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi

[llvm-branch-commits] [llvm] [ConstraintElim] Add `noundef` to several testcases (NFC) (PR #135799)

https://github.com/fhahn commented: Just checking why this was closed? https://github.com/llvm/llvm-project/pull/135799 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-

[llvm-branch-commits] [llvm] release/20.x: [GlobalOpt] Do not promote malloc if there are atomic loads/stores (#137158) (PR #137179)

https://github.com/fhahn approved this pull request. LGTM, thanks https://github.com/llvm/llvm-project/pull/137179 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi

[llvm-branch-commits] [llvm] release/20.x: [LV] Fix crash when building partial reductions using types that aren't known scale factors (#136680) (PR #136863)

https://github.com/fhahn commented: Should be good to include, assuming the test failures are just missed test updates https://github.com/llvm/llvm-project/pull/136863 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lis

[llvm-branch-commits] [llvm] [ObjC] Support objc_claimAutoreleasedReturnValue (PR #138696)

@@ -9545,7 +9545,9 @@ AArch64TargetLowering::LowerCall(CallLoweringInfo &CLI, // Do what the frontend tells us: if the rvmarker module flag is present, // emit the marker. Always emit the call regardless. // Tell the pseudo expansion using an additional boolean op.

[llvm-branch-commits] [llvm] [ObjC] Support objc_claimAutoreleasedReturnValue (PR #138696)

@@ -9545,7 +9545,9 @@ AArch64TargetLowering::LowerCall(CallLoweringInfo &CLI, // Do what the frontend tells us: if the rvmarker module flag is present, // emit the marker. Always emit the call regardless. // Tell the pseudo expansion using an additional boolean op.

[llvm-branch-commits] [llvm] [ObjC] Support objc_claimAutoreleasedReturnValue (PR #138696)

@@ -160,10 +160,7 @@ static bool lowerObjCCall(Function &F, const char *NewFn, auto *CB = cast(U.getUser()); if (CB->getCalledFunction() != &F) { - objcarc::ARCInstKind Kind = objcarc::getAttachedARCFunctionKind(CB); - (void)Kind; - assert((Kind == objca

[llvm-branch-commits] [llvm] [LV] An attempt to cherry-pick the fix PR #132691 (cherry-pick from the main branch to the release/20.x branch) (PR #135231)

fhahn wrote: I'm not sure if it is feasible to strip the fix down, as it depends quite a few refactoring patches. For 20.x, it might be best just not enable epilogue vectorization for FindLastIV: https://github.com/llvm/llvm-project/pull/135666 https://github.com/llvm/llvm-project/pull/135231

[llvm-branch-commits] [llvm] [LV] Disable epilogue vectorization for FindLastIV if start is poison. (PR #135666)

https://github.com/fhahn created https://github.com/llvm/llvm-project/pull/135666 Back-porting properly freezing of the start value during epilogue vectorization (https://github.com/llvm/llvm-project/commit/2bdc1a1337692a5743658ba6b680e5d914e684a4) is non-trivial. For the 20.x release, just di

[llvm-branch-commits] [llvm] [LV] Disable epilogue vectorization for FindLastIV if start is poison. (PR #135666)

https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/135666 >From e21b3211d2129e3e0110bcaa75ab0b451397ef42 Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Mon, 14 Apr 2025 17:16:08 +0100 Subject: [PATCH 1/2] [LV] Add tests with FindLastIV and epilogue vectorization. Te

[llvm-branch-commits] [llvm] [LoopVectorizer] Bundle partial reductions inside VPMulAccumulateReductionRecipe (PR #136173)

@@ -2432,12 +2437,40 @@ static void tryToCreateAbstractReductionRecipe(VPReductionRecipe *Red, Red->replaceAllUsesWith(AbstractR); } +/// This function tries to create an abstract recipe from a partial reduction to +/// hide its mul and extends from cost estimation. +stati

[llvm-branch-commits] [llvm] release/20.x: [BasicAA] Gracefully handle large LocationSize (#138528) (PR #138681)

https://github.com/fhahn approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/138681 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-comm

[llvm-branch-commits] [clang] release/20.x: [TBAA] Don't emit pointer-tbaa for void pointers. (#122116) (PR #125206)

fhahn wrote: Without the pointer-tbaa changes (which is new on by default in Clang 20), we would always generate `any pointer`. Without this fix, we will generate different tags for different `void` pointer depths. With this fix, we will generate `any pointer` again for `void` pointers. I th

[llvm-branch-commits] [llvm] release/20.x: [LAA] Consider accessed addrspace when mapping underlying obj to access. (#129087) (PR #129317)

https://github.com/fhahn edited https://github.com/llvm/llvm-project/pull/129317 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/20.x: [LAA] Consider accessed addrspace when mapping underlying obj to access. (#129087) (PR #129317)

https://github.com/fhahn created https://github.com/llvm/llvm-project/pull/129317 Backport 275baedfde9dcd344bc4f11f552b046a69a4bf3f In some cases, it is possible for the same underlying object to be accessed via pointers to different address spaces. This could lead to pointers from different

[llvm-branch-commits] [llvm] release/20.x: [LAA] Consider accessed addrspace when mapping underlying obj to access. (#129087) (PR #129317)

https://github.com/fhahn milestoned https://github.com/llvm/llvm-project/pull/129317 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/20.x: [LV][VPlan] Prevent calculate cost for skiped instructions in precomputeCosts(). (#127966) (PR #128879)

https://github.com/fhahn milestoned https://github.com/llvm/llvm-project/pull/128879 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/20.x: [LV][VPlan] Prevent calculate cost for skiped instructions in precomputeCosts(). (#127966) (PR #128694)

https://github.com/fhahn approved this pull request. This fixes a potential crash with assertions enabled, would be good to pick to avoid assertions. https://github.com/llvm/llvm-project/pull/128694 ___ llvm-branch-commits mailing list llvm-branch-com

[llvm-branch-commits] [llvm] release/20.x: [LV][VPlan] Prevent calculate cost for skiped instructions in precomputeCosts(). (#127966) (PR #128879)

https://github.com/fhahn created https://github.com/llvm/llvm-project/pull/128879 Backport https://github.com/llvm/llvm-project/commit/8009c1fd81ad0b6ac65724d2b134a92db48f8fbf >From 508d5e45a57affceeb87e69a99ebb65efde88478 Mon Sep 17 00:00:00 2001 From: Elvis Wang Date: Tue, 25 Feb 2025 11:0

[llvm-branch-commits] [llvm] release/20.x: [LV][VPlan] Prevent calculate cost for skiped instructions in precomputeCosts(). (#127966) (PR #128694)

fhahn wrote: I created https://github.com/llvm/llvm-project/pull/128879 with a test update https://github.com/llvm/llvm-project/pull/128694 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[llvm-branch-commits] [llvm] release/20.x: [LV][VPlan] Prevent calculate cost for skiped instructions in precomputeCosts(). (#127966) (PR #128879)

https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/128879 >From 508d5e45a57affceeb87e69a99ebb65efde88478 Mon Sep 17 00:00:00 2001 From: Elvis Wang Date: Tue, 25 Feb 2025 11:09:09 +0800 Subject: [PATCH 1/2] [LV][VPlan] Prevent calculate cost for skiped instructions in pr

[llvm-branch-commits] [llvm] llvm-reduce: Filter function based on uses before removing arguments (PR #133412)

https://github.com/fhahn approved this pull request. LGTM, thanks https://github.com/llvm/llvm-project/pull/133412 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi

[llvm-branch-commits] [llvm] llvm-reduce: Fix losing fast math flags when removing arguments (PR #133408)

https://github.com/fhahn approved this pull request. LGTM, thanks https://github.com/llvm/llvm-project/pull/133408 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi

[llvm-branch-commits] [llvm] [ConstraintElim] Simplify `usub_with_overflow` when A uge B (PR #135785)

https://github.com/fhahn commented: Could you add an Alive2 proof showing this transform is valid given the precondition for completeness? https://github.com/llvm/llvm-project/pull/135785 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.

[llvm-branch-commits] [llvm] RuntimeLibcalls: Cleanup darwin bzero configuration (PR #145639)

https://github.com/fhahn approved this pull request. LGTM, thanks https://github.com/llvm/llvm-project/pull/145639 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi

[llvm-branch-commits] [llvm] RuntimeLibcalls: Cleanup darwin exp10 case (PR #145638)

https://github.com/fhahn approved this pull request. LGTM, thanks https://github.com/llvm/llvm-project/pull/145638 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi

[llvm-branch-commits] [llvm] [LV] Use VPReductionRecipe for partial reductions (PR #146073)

@@ -2744,6 +2702,12 @@ class VPSingleDefBundleRecipe : public VPSingleDefRecipe { /// vector operands, performing a reduction.add on the result, and adding /// the scalar result to a chain. MulAccumulateReduction, +/// Represent an inloop multiply-accumulate re

[llvm-branch-commits] [llvm] [LV] Use VPReductionRecipe for partial reductions (PR #147513)

https://github.com/fhahn commented: does the latest version of this depend on https://github.com/llvm/llvm-project/pull/147026? https://github.com/llvm/llvm-project/pull/147513 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org ht

[llvm-branch-commits] [llvm] [LV] Bundle partial reductions inside VPExpressionRecipe (PR #147302)

@@ -2532,7 +2533,10 @@ class VPPartialReductionRecipe : public VPReductionRecipe { Opcode(Opcode), VFScaleFactor(ScaleFactor) { [[maybe_unused]] auto *AccumulatorRecipe = getChainOp()->getDefiningRecipe(); -assert((isa(AccumulatorRecipe) || +// When

[llvm-branch-commits] [llvm] [LV] Bundle partial reductions inside VPExpressionRecipe (PR #147302)

@@ -2857,15 +2857,26 @@ tryToMatchAndCreateExtendedReduction(VPReductionRecipe *Red, VPCostContext &Ctx, VPValue *VecOp = Red->getVecOp(); // Clamp the range if using extended-reduction is profitable. - auto IsExtendedRedValidAndClampRange = [&](unsigned Opcode, bool isZ

[llvm-branch-commits] [llvm] [LV] Bundle partial reductions inside VPExpressionRecipe (PR #147302)

@@ -2955,12 +2966,14 @@ tryToMatchAndCreateMulAccumulateReduction(VPReductionRecipe *Red, // Match reduce.add(mul(ext, ext)). if (RecipeA && RecipeB && -(RecipeA->getOpcode() == RecipeB->getOpcode() || A == B) && +(RecipeA->getOpcode() == RecipeB->getO

[llvm-branch-commits] [llvm] [LV] Bundle partial reductions inside VPExpressionRecipe (PR #147302)

@@ -2678,6 +2684,23 @@ InstructionCost VPExpressionRecipe::computeCost(ElementCount VF, case ExpressionTypes::ExtNegatedMulAccReduction: case ExpressionTypes::ExtMulAccReduction: { bool Negated = ExpressionType == ExpressionTypes::ExtNegatedMulAccReduction; +if (i

[llvm-branch-commits] [llvm] [LV] Bundle partial reductions inside VPExpressionRecipe (PR #147302)

@@ -2470,7 +2470,8 @@ class VPReductionRecipe : public VPRecipeWithIRFlags { static inline bool classof(const VPRecipeBase *R) { return R->getVPDefID() == VPRecipeBase::VPReductionSC || - R->getVPDefID() == VPRecipeBase::VPReductionEVLSC; + R->getVPDe

<    1   2   3   4