https://github.com/fabianmcg commented:
Overall LGTM, see the only comment.
https://github.com/llvm/llvm-project/pull/71165
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bra
https://github.com/fabianmcg edited
https://github.com/llvm/llvm-project/pull/71165
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -39,32 +39,32 @@ ModuleToObject::ModuleToObject(Operation &module, StringRef
triple,
: module(module), triple(triple), chip(chip), features(features),
optLevel(optLevel) {}
+ModuleToObject::~ModuleToObject() = default;
+
Operation &ModuleToObject::getOperation()
https://github.com/fabianmcg approved this pull request.
https://github.com/llvm/llvm-project/pull/71165
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/fabianmcg created
https://github.com/llvm/llvm-project/pull/156355
Implements translation from ptr dialect to LLVM IR for core pointer operations:
- `ptr.ptr_add` -> `getelementptr`
- `ptr.load` -> `load` with atomic ordering, volatility, and metadata support
- `ptr.store` ->
https://github.com/fabianmcg created
https://github.com/llvm/llvm-project/pull/156374
This patch extends `ptr_add` to work with shaped types with value semantics,
both for the offsets and base.
Concretely this patch makes the following changes:
- Supports scalar-to-scalar, scalar-to-shaped, sh
@@ -17,6 +17,46 @@ include "mlir/Interfaces/SideEffectInterfaces.td"
include "mlir/Interfaces/ViewLikeInterface.td"
include "mlir/IR/OpAsmInterface.td"
+//===--===//
+// Common props
+//===
https://github.com/fabianmcg updated
https://github.com/llvm/llvm-project/pull/157354
>From 5e4b9843521939d926c7fcc4007d38a8f4c320a6 Mon Sep 17 00:00:00 2001
From: Fabian Mora <[email protected]>
Date: Sun, 7 Sep 2025 17:33:04 +
Subject: [PATCH] [mlir][ptr] Add `ptr.
https://github.com/fabianmcg edited
https://github.com/llvm/llvm-project/pull/157354
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/fabianmcg created
https://github.com/llvm/llvm-project/pull/157354
Thi patch introduces the `ptr.ptr_diff` operation for computing pointer
differences. The semantics of the operation are given by:
```
The `ptr_diff` operation computes the difference between two pointers,
retu
https://github.com/fabianmcg updated
https://github.com/llvm/llvm-project/pull/157354
>From 4015e6f30fb89b5c0a4bb60ffdc8b3db51b2edc1 Mon Sep 17 00:00:00 2001
From: Fabian Mora <[email protected]>
Date: Sun, 7 Sep 2025 17:33:04 +
Subject: [PATCH 1/2] [mlir][ptr] Add `
https://github.com/fabianmcg created
https://github.com/llvm/llvm-project/pull/158484
This patch adds the following description to the pointer dialect:
```
The pointer dialect provides types and operations for representing and
interacting with pointer values in MLIR, such as loading and
https://github.com/fabianmcg updated
https://github.com/llvm/llvm-project/pull/156355
>From d4befc04b5565fd13cc53694031bf8296fd22312 Mon Sep 17 00:00:00 2001
From: Fabian Mora <[email protected]>
Date: Mon, 1 Sep 2025 16:32:01 +
Subject: [PATCH 1/2] add translations
https://github.com/fabianmcg created
https://github.com/llvm/llvm-project/pull/156368
This patch adds the `gather`, `masked_load`, `masked_store`, and `scatter`
operations to the `ptr` dialect. It also implements translation from these
operations to LLVM intrinsics:
- ptr.gather -> llvm.masked
https://github.com/fabianmcg updated
https://github.com/llvm/llvm-project/pull/156368
>From 1898a4301ca6f9ecd2d125217e28cce2abd20e52 Mon Sep 17 00:00:00 2001
From: Fabian Mora <[email protected]>
Date: Sun, 31 Aug 2025 12:01:19 +
Subject: [PATCH 1/2] Add load, store
@@ -56,6 +96,58 @@ def Ptr_FromPtrOp : Pointer_Op<"from_ptr", [
let hasVerifier = 1;
}
+//===--===//
+// GatherOp
+//===--===//
+
+def Ptr_
@@ -56,6 +96,58 @@ def Ptr_FromPtrOp : Pointer_Op<"from_ptr", [
let hasVerifier = 1;
}
+//===--===//
+// GatherOp
+//===--===//
+
+def Ptr_
@@ -23,6 +24,41 @@ class LLVM_Attrhttps://github.com/llvm/llvm-project/pull/156374
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/fabianmcg updated
https://github.com/llvm/llvm-project/pull/156374
>From af522ed2b48cee2fe81901f2396025d58341997b Mon Sep 17 00:00:00 2001
From: Fabian Mora <[email protected]>
Date: Mon, 1 Sep 2025 21:05:55 +
Subject: [PATCH] extend ptr_add op
--
fabianmcg wrote:
The only issue I can raise is,this is untested (I'm not familiar with back port
requirements on tests, so it'd be great if someone can comment on that). In the
other PR, the issue was indirectly tested by the ptr op.
https://github.com/llvm/llvm-project/pull/165768
___
https://github.com/fabianmcg approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/165768
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
21 matches
Mail list logo
