[llvm-branch-commits] [llvm] [utils][TableGen] Handle versions on clause/directive spellings (PR #141766)

2025-05-29 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah approved this pull request. Thanks for the update https://github.com/llvm/llvm-project/pull/141766 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bra

[llvm-branch-commits] [llvm] [mlir] [utils][TableGen] Implement clause aliases as alternative spellings (PR #141765)

2025-05-29 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah approved this pull request. LGTM but wait for another review https://github.com/llvm/llvm-project/pull/141765 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[llvm-branch-commits] [llvm] [utils][TableGen] Handle versions on clause/directive spellings (PR #141766)

2025-05-29 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/141766 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [utils][TableGen] Handle versions on clause/directive spellings (PR #141766)

2025-05-29 Thread Tom Eccles via llvm-branch-commits
@@ -77,6 +77,19 @@ static std::string getIdentifierName(const Record *Rec, StringRef Prefix) { return Prefix.str() + BaseRecord(Rec).getFormattedName(); } +using RecordWithSpelling = std::pair; + +static std::vector +getSpellings(ArrayRef Records) { tblah w

[llvm-branch-commits] [llvm] [utils][TableGen] Handle versions on clause/directive spellings (PR #141766)

2025-05-29 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah approved this pull request. LGTM with one nit, but wait for a second review https://github.com/llvm/llvm-project/pull/141766 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[llvm-branch-commits] [llvm] [utils][TableGen] Treat clause aliases equally with names (PR #141763)

2025-05-29 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/141763 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-comm

[llvm-branch-commits] [flang] [mlir] [flang][OpenMP][NFC] remove globals with mlir::StateStack (PR #144898)

2025-06-19 Thread Tom Eccles via llvm-branch-commits
tblah wrote: 1. https://github.com/llvm/llvm-project/pull/144897 2. https://github.com/llvm/llvm-project/pull/144898 https://github.com/llvm/llvm-project/pull/144898 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.

[llvm-branch-commits] [flang] [mlir] [flang][OpenMP][NFC] remove globals with mlir::StateStack (PR #144898)

2025-06-19 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah created https://github.com/llvm/llvm-project/pull/144898 Idea suggested by @skatrak >From 280e55d4355f100b7d3066fce3c0515b369fecce Mon Sep 17 00:00:00 2001 From: Tom Eccles Date: Wed, 18 Jun 2025 21:01:13 + Subject: [PATCH] [flang][OpenMP][NFC] remove globals with

[llvm-branch-commits] [flang] [mlir] [flang][OpenMP][NFC] remove globals with mlir::StateStack (PR #144898)

2025-06-20 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah updated https://github.com/llvm/llvm-project/pull/144898 >From 392514e4d56491575ec47a1eb5607fd52f5b1ff9 Mon Sep 17 00:00:00 2001 From: Tom Eccles Date: Wed, 18 Jun 2025 21:01:13 + Subject: [PATCH 1/2] [flang][OpenMP][NFC] remove globals with mlir::StateStack Idea s

[llvm-branch-commits] [flang] [flang][OpenMP] Add symbol table scopes for `teams` and `parallel` (PR #144015)

2025-06-13 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah approved this pull request. LGTM. Thanks for the fix https://github.com/llvm/llvm-project/pull/144015 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-

[llvm-branch-commits] [flang] [flang][OpenMP][NFC] Refactor to avoid global variable (PR #144087)

2025-06-13 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah created https://github.com/llvm/llvm-project/pull/144087 Based on top of #144013 I was really hoping this would also work for `hostEvalInfo` but unfortunately that needed to be shared to a greater degree. The same technique should work for that but it would need that

[llvm-branch-commits] [flang] [flang] Enable delayed localization by default for `do concurrent` (PR #142567)

2025-06-04 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah approved this pull request. https://github.com/llvm/llvm-project/pull/142567 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP] Map basic `local` specifiers to `private` clauses (PR #142735)

2025-06-04 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah approved this pull request. Looks great! https://github.com/llvm/llvm-project/pull/142735 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi

[llvm-branch-commits] [flang] [flang][OpenMP] Extend locality spec to OMP claues (`init` and `dealloc` regions) (PR #142795)

2025-06-04 Thread Tom Eccles via llvm-branch-commits
@@ -0,0 +1,51 @@ +// Tests mapping `local` locality specifier to `private` clauses for non-empty +// `init` and `dealloc` regions. + +// RUN: fir-opt --omp-do-concurrent-conversion="map-to=host" %s | FileCheck %s + +func.func @my_allocator() { + return +} + +func.func @my_dealloc

[llvm-branch-commits] [llvm] [OpenMP] Add directive spellings introduced in spec v6.0 (PR #141772)

2025-06-04 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah approved this pull request. https://github.com/llvm/llvm-project/pull/141772 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][do concurrent] Extned `getAllocaBlock()` and emit yields correctly (PR #146853)

2025-07-03 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah approved this pull request. LGTM, thanks https://github.com/llvm/llvm-project/pull/146853 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi

[llvm-branch-commits] [flang] [flang][fir] Small clean-up in `fir_DoConcurrentLoopOp`'s defintion (PR #146028)

2025-06-27 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah approved this pull request. https://github.com/llvm/llvm-project/pull/146028 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP] Basic mapping of `do concurrent ... reduce` to OpenMP (PR #146033)

2025-06-27 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah approved this pull request. LGTM but please could you add a test that covers every region. https://github.com/llvm/llvm-project/pull/146033 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.l

[llvm-branch-commits] [flang] [NFC][flang] Move `ReductionProcessor` to `Lower/Support`. (PR #146025)

2025-06-27 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah approved this pull request. https://github.com/llvm/llvm-project/pull/146025 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [mlir] [Flang][MLIR] Add `!$omp unroll` and `omp.unroll_heuristic` (PR #144785)

2025-07-09 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/144785 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [mlir] [Flang][MLIR] Add `!$omp unroll` and `omp.unroll_heuristic` (PR #144785)

2025-07-09 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah approved this pull request. Looks great to me with one nit. Please wait for another approval. https://github.com/llvm/llvm-project/pull/144785 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://list

[llvm-branch-commits] [flang] [mlir] [Flang][MLIR] Add `!$omp unroll` and `omp.unroll_heuristic` (PR #144785)

2025-07-09 Thread Tom Eccles via llvm-branch-commits
@@ -2154,6 +2176,163 @@ genLoopOp(lower::AbstractConverter &converter, lower::SymMap &symTable, return loopOp; } +static mlir::omp::CanonicalLoopOp +genCanonicalLoopOp(lower::AbstractConverter &converter, lower::SymMap &symTable, + semantics::SemanticsCon

[llvm-branch-commits] [mlir] [MLIR][OpenMP] Add canonical loop LLVM-IR lowering (PR #147069)

2025-07-09 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah approved this pull request. LGTM. Thanks for splitting the PR. Please wait for another approval before merging. https://github.com/llvm/llvm-project/pull/147069 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.ll

[llvm-branch-commits] [flang] [llvm] [flang][OpenMP] Sema checks, lowering with new format of MAP modifiers (PR #149137)

2025-07-21 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/149137 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [llvm] [flang][OpenMP] Sema checks, lowering with new format of MAP modifiers (PR #149137)

2025-07-21 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah commented: Please could you add a lit tests for lowering: one showing OpenMP 5 style modifiers being converted to the new ones, and one showing the new ones working in OpenMP 6.0. https://github.com/llvm/llvm-project/pull/149137

[llvm-branch-commits] [flang] [llvm] [flang][OpenMP] Sema checks, lowering with new format of MAP modifiers (PR #149137)

2025-07-21 Thread Tom Eccles via llvm-branch-commits
@@ -1003,12 +1003,13 @@ Map make(const parser::OmpClause::Map &inp, CLAUSET_ENUM_CONVERT( // convert1, parser::OmpMapType::Value, Map::MapType, tblah wrote: Not new in this patch, but I don't really like the `convert1` `convert2` `convert3` naming. I

[llvm-branch-commits] [flang] [llvm] [flang][OpenMP] Sema checks, lowering with new format of MAP modifiers (PR #149137)

2025-07-21 Thread Tom Eccles via llvm-branch-commits
@@ -402,6 +402,11 @@ class CanonicalizationOfOmp { // if the specified OpenMP version is less than 6.0, rewrite the affected // modifiers back into the pre-6.0 forms. void CanonicalizeMapModifiers(parser::OmpMapClause &map) { +unsigned version{context_.langOptions().O

[llvm-branch-commits] [flang] [flang] Implement `tanpi` (PR #149527)

2025-07-21 Thread Tom Eccles via llvm-branch-commits
@@ -8157,6 +8158,21 @@ mlir::Value IntrinsicLibrary::genTand(mlir::Type resultType, return getRuntimeCallGenerator("tan", ftype)(builder, loc, {arg}); } +// TANPI +mlir::Value IntrinsicLibrary::genTanpi(mlir::Type resultType, + llvm::Ar

<    1   2   3   4