https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138064
>From 603c1b69a3897e74b72c2f763448024ac69830d9 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 30 Apr 2025 08:13:46 -0700
Subject: [PATCH] [clang-doc] Implement setupTemplateValue for
HTMLMustacheGenerator
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138064
>From 603c1b69a3897e74b72c2f763448024ac69830d9 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 30 Apr 2025 08:13:46 -0700
Subject: [PATCH] [clang-doc] Implement setupTemplateValue for
HTMLMustacheGenerator
@@ -162,15 +162,264 @@ Error MustacheHTMLGenerator::generateDocs(
return Error::success();
}
+static json::Value
+extractValue(const Location &L,
+ std::optional RepositoryUrl = std::nullopt) {
+ Object Obj = Object();
+ // Should there be Start/End line number
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138067
>From b6c17fee39c013db4fa8b32650ed7afa14f0bd91 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 30 Apr 2025 14:20:40 -0700
Subject: [PATCH] [clang-doc] Track if a type is a template or builtin
Originally pa
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138066
>From bfd1d03da32ddda7bfab7c5122bc8a55e88b1353 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 29 Apr 2025 18:08:03 -0700
Subject: [PATCH] [clang-doc] Update clang-doc tool to enable mustache
templates
Th
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138067
>From b6c17fee39c013db4fa8b32650ed7afa14f0bd91 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 30 Apr 2025 14:20:40 -0700
Subject: [PATCH] [clang-doc] Track if a type is a template or builtin
Originally pa
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138066
>From dc1b8f6c518e964c59bdcc170d5daca06c3a0fd4 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 29 Apr 2025 18:08:03 -0700
Subject: [PATCH] [clang-doc] Update clang-doc tool to enable mustache
templates
Th
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138067
>From f8eff8a3edac66574902c693aacce42d6ac7b295 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 30 Apr 2025 14:20:40 -0700
Subject: [PATCH] [clang-doc] Track if a type is a template or builtin
Originally pa
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138067
>From f8eff8a3edac66574902c693aacce42d6ac7b295 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 30 Apr 2025 14:20:40 -0700
Subject: [PATCH] [clang-doc] Track if a type is a template or builtin
Originally pa
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138066
>From bfd1d03da32ddda7bfab7c5122bc8a55e88b1353 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 29 Apr 2025 18:08:03 -0700
Subject: [PATCH] [clang-doc] Update clang-doc tool to enable mustache
templates
Th
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138066
>From dc1b8f6c518e964c59bdcc170d5daca06c3a0fd4 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 29 Apr 2025 18:08:03 -0700
Subject: [PATCH] [clang-doc] Update clang-doc tool to enable mustache
templates
Th
ilovepi wrote:
I thought we switched away from cloning to avoid redundancy. I'll take a look
through previous patches though.
https://github.com/llvm/llvm-project/pull/13
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
http
ilovepi wrote:
nuts, I forgot about https://github.com/llvm/llvm-project/pull/72180, I guess
I'll need to think about this some more.
https://github.com/llvm/llvm-project/pull/13
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.
ilovepi wrote:
oh https://github.com/llvm/llvm-project/pull/139223 may avoid the issue w/
BlockAddress
https://github.com/llvm/llvm-project/pull/13
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-
@@ -2869,9 +2870,23 @@ static void setLinkageForGV(llvm::GlobalValue *GV, const
NamedDecl *ND) {
GV->setLinkage(llvm::GlobalValue::ExternalWeakLinkage);
}
+static bool hasExistingGeneralizedTypeMD(llvm::Function *F) {
+ llvm::MDNode *MD = F->getMetadata(llvm::LLVMContext
@@ -2869,9 +2870,23 @@ static void setLinkageForGV(llvm::GlobalValue *GV, const
NamedDecl *ND) {
GV->setLinkage(llvm::GlobalValue::ExternalWeakLinkage);
}
+static bool hasExistingGeneralizedTypeMD(llvm::Function *F) {
+ llvm::MDNode *MD = F->getMetadata(llvm::LLVMContext
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138065
>From 2d48537e7a270c0a1c6f463ef1118a65c40a6f27 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 29 Apr 2025 18:31:54 -0700
Subject: [PATCH] [clang-doc] Update serializer for improved template handling
This
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138067
>From 46795349a75a0815041e7ac3038be9c00ce8ad2b Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 30 Apr 2025 14:20:40 -0700
Subject: [PATCH] [clang-doc] Track if a type is a template or builtin
Originally pa
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138064
>From 5e56a521547f6e5b309fcfd65f5ad459a03f9abc Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 30 Apr 2025 08:13:46 -0700
Subject: [PATCH] [clang-doc] Implement setupTemplateValue for
HTMLMustacheGenerator
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138066
>From e94b231dbca9073da99f616516e21350d1136168 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 29 Apr 2025 18:08:03 -0700
Subject: [PATCH] [clang-doc] Update clang-doc tool to enable mustache
templates
Th
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138063
>From 6880c2fcb571c53ad4e21804b805e82a93077bc1 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 30 Apr 2025 08:11:39 -0700
Subject: [PATCH] [clang-doc] Extract Info into JSON values
Split from #133161. This
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138064
>From 5e56a521547f6e5b309fcfd65f5ad459a03f9abc Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 30 Apr 2025 08:13:46 -0700
Subject: [PATCH] [clang-doc] Implement setupTemplateValue for
HTMLMustacheGenerator
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138065
>From 2d48537e7a270c0a1c6f463ef1118a65c40a6f27 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 29 Apr 2025 18:31:54 -0700
Subject: [PATCH] [clang-doc] Update serializer for improved template handling
This
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138063
>From 6880c2fcb571c53ad4e21804b805e82a93077bc1 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 30 Apr 2025 08:11:39 -0700
Subject: [PATCH] [clang-doc] Extract Info into JSON values
Split from #133161. This
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138066
>From e94b231dbca9073da99f616516e21350d1136168 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 29 Apr 2025 18:08:03 -0700
Subject: [PATCH] [clang-doc] Update clang-doc tool to enable mustache
templates
Th
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138067
>From 46795349a75a0815041e7ac3038be9c00ce8ad2b Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 30 Apr 2025 14:20:40 -0700
Subject: [PATCH] [clang-doc] Track if a type is a template or builtin
Originally pa
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138067
>From 73cdd50ae91dbb751d2d3d56c388bcca6227b137 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 30 Apr 2025 14:20:40 -0700
Subject: [PATCH] [clang-doc] Track if a type is a template or builtin
Originally pa
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138066
>From 3d478e150a4bb22b1561852dcddbaed1e24b Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 29 Apr 2025 18:08:03 -0700
Subject: [PATCH] [clang-doc] Update clang-doc tool to enable mustache
templates
Th
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138065
>From 7deaf5aea3a20dc34f7eab13244e161da74a3148 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 29 Apr 2025 18:31:54 -0700
Subject: [PATCH] [clang-doc] Update serializer for improved template handling
This
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138067
>From fae895bbea79cc8a7adbf7266f366ecbc205ed91 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 30 Apr 2025 14:20:40 -0700
Subject: [PATCH] [clang-doc] Track if a type is a template or builtin
Originally pa
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138064
>From 011f2973a836c21b3ccc869fa96d64385c5b5b75 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 30 Apr 2025 08:13:46 -0700
Subject: [PATCH] [clang-doc] Implement setupTemplateValue for
HTMLMustacheGenerator
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138067
>From fae895bbea79cc8a7adbf7266f366ecbc205ed91 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 30 Apr 2025 14:20:40 -0700
Subject: [PATCH] [clang-doc] Track if a type is a template or builtin
Originally pa
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138066
>From 5dd55e81bd0d4f18b880c450e21e9faefcd38327 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 29 Apr 2025 18:08:03 -0700
Subject: [PATCH] [clang-doc] Update clang-doc tool to enable mustache
templates
Th
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138066
>From 5dd55e81bd0d4f18b880c450e21e9faefcd38327 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 29 Apr 2025 18:08:03 -0700
Subject: [PATCH] [clang-doc] Update clang-doc tool to enable mustache
templates
Th
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138065
>From 7deaf5aea3a20dc34f7eab13244e161da74a3148 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 29 Apr 2025 18:31:54 -0700
Subject: [PATCH] [clang-doc] Update serializer for improved template handling
This
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/138064
>From 011f2973a836c21b3ccc869fa96d64385c5b5b75 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 30 Apr 2025 08:13:46 -0700
Subject: [PATCH] [clang-doc] Implement setupTemplateValue for
HTMLMustacheGenerator
ilovepi wrote:
### Merge activity
* **May 23, 10:52 PM UTC**: A user started a stack merge that includes this
pull request via
[Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/138064).
https://github.com/llvm/llvm-project/pull/138064
___
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/13
>From 5205f4abb2379b11b2a2be075c262dea8d79c889 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 14 May 2025 20:47:26 -0700
Subject: [PATCH] [llvm][EmbedBitcodePass] Prevent modifying the module with
ThinLTO
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/13
>From 7373f7c53b287c9fcc2339bfe055d0eb60b974f4 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 14 May 2025 20:47:26 -0700
Subject: [PATCH] [llvm][EmbedBitcodePass] Prevent modifying the module with
ThinLTO
ilovepi wrote:
### Merge activity
* **May 29, 5:24 PM UTC**: A user started a stack merge that includes this pull
request via
[Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/13).
https://github.com/llvm/llvm-project/pull/13
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/13
>From 5205f4abb2379b11b2a2be075c262dea8d79c889 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 14 May 2025 20:47:26 -0700
Subject: [PATCH] [llvm][EmbedBitcodePass] Prevent modifying the module with
ThinLTO
ilovepi wrote:
> Linux CI shows failing but looks like all tests passed despite that.
>
> Added compound constraint support which just goes through the nested
> expressions until it reaches the constraint.
I've just been clicking re-run on those when i see it. you may want to file
abug abou
https://github.com/ilovepi approved this pull request.
LGTM. overall really good improvement. most of my comments are me noticing bad
existing code we should fix.
I also left a few nit comments to address, but they're rather minor.
https://github.com/llvm/llvm-project/pull/144430
_
@@ -662,6 +709,14 @@ void addTemplateSpecialization(TemplateInfo *I,
I->Specialization.emplace(std::move(TSI));
}
+template static void addConstraint(T I, ConstraintInfo &&C) {
+ llvm::errs() << "invalid container for constraint info";
+ exit(1);
+}
ilove
@@ -248,6 +257,27 @@ static void serializeCommonChildren(const ScopeChildren
&Children,
}
}
+template
+static void serializeArray(const std::vector &Records, Object &Obj,
+ const std::string &Key,
+ SerializationFunc seri
@@ -817,6 +872,20 @@ llvm::Error ClangDocBitcodeReader::readSubBlock(unsigned
ID, T I) {
addChild(I, std::move(TI));
return llvm::Error::success();
}
+ case BI_CONSTRAINT_BLOCK_ID: {
+ConstraintInfo CI;
+if (auto Err = readBlock(ID, &CI))
+ return Err;
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/144430
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -584,6 +613,18 @@ template <> llvm::Error addReference(RecordInfo *I,
Reference &&R, FieldId F) {
}
}
+template <>
+llvm::Error addReference(ConstraintInfo *I, Reference &&R, FieldId F) {
+ switch (F) {
+ case FieldId::F_concept:
+I->ConceptRef = std::move(R);
+
@@ -649,6 +693,9 @@ template <> void addTemplate(RecordInfo *I, TemplateInfo
&&P) {
template <> void addTemplate(FunctionInfo *I, TemplateInfo &&P) {
I->Template.emplace(std::move(P));
}
+template <> void addTemplate(ConceptInfo *I, TemplateInfo &&P) {
+ I->Template = std::
https://github.com/ilovepi approved this pull request.
https://github.com/llvm/llvm-project/pull/145069
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -211,6 +214,15 @@ struct TemplateSpecializationInfo {
std::vector Params;
};
+struct ConstraintInfo {
+ ConstraintInfo() = default;
+ ConstraintInfo(SymbolID USR, StringRef Name)
+ : ConceptRef(USR, Name, InfoType::IT_concept) {}
+ Reference ConceptRef;
+
+ Small
https://github.com/ilovepi approved this pull request.
LGTM, w/ one Q about the test expr. I could go either way on that, so its up to
you.
https://github.com/llvm/llvm-project/pull/145070
___
llvm-branch-commits mailing list
llvm-branch-commits@lists
@@ -25,7 +24,7 @@ typedef int MyTypedef;
// CHECK-NEXT: {
// CHECK-NEXT:"Location": {
// CHECK-NEXT: "Filename": "{{.*}}namespace.cpp",
-// CHECK-NEXT: "LineNumber": 15
+// CHECK-NEXT: "LineNumber": 14
ilovepi wrote:
Sho
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/145070
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -171,5 +171,78 @@ TEST(JSONGeneratorTest, emitRecordJSON) {
})raw";
EXPECT_EQ(Expected, Actual.str());
}
+
+TEST(JSONGeneratorTest, emitNamespaceJSON) {
+ NamespaceInfo I;
+ I.Name = "Namespace";
+ I.Path = "path/to/A";
+ I.Namespace.emplace_back(EmptySID, "A", InfoTyp
https://github.com/ilovepi approved this pull request.
LGTM. This seems like its in order, assuming CI is happy.
https://github.com/llvm/llvm-project/pull/143209
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm
@@ -171,5 +171,78 @@ TEST(JSONGeneratorTest, emitRecordJSON) {
})raw";
EXPECT_EQ(Expected, Actual.str());
}
+
+TEST(JSONGeneratorTest, emitNamespaceJSON) {
+ NamespaceInfo I;
+ I.Name = "Namespace";
+ I.Path = "path/to/A";
+ I.Namespace.emplace_back(EmptySID, "A", InfoTyp
@@ -171,5 +171,78 @@ TEST(JSONGeneratorTest, emitRecordJSON) {
})raw";
EXPECT_EQ(Expected, Actual.str());
}
+
+TEST(JSONGeneratorTest, emitNamespaceJSON) {
+ NamespaceInfo I;
+ I.Name = "Namespace";
+ I.Path = "path/to/A";
+ I.Namespace.emplace_back(EmptySID, "A", InfoTyp
https://github.com/ilovepi approved this pull request.
LGTM. I left some comments inline, but I'm fine if we plan to address them
later.
https://github.com/llvm/llvm-project/pull/143209
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.ll
@@ -0,0 +1,25 @@
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: clang-doc --output=%t --format=json --executor=standalone %s
+// RUN: FileCheck %s < %t/GlobalNamespace/index.json
+
+static void myFunction() {}
+
+void noExceptFunction() noexcept {}
+
+inline void inlineFunction() {}
+
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/143209
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -0,0 +1,108 @@
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: clang-doc --output=%t --format=json --executor=standalone %s
+// RUN: FileCheck %s < %t/GlobalNamespace/index.json
+
+class MyClass {};
+
+void myFunction(int Param);
+
+namespace NestedNamespace {
+} // namespace Nested
@@ -0,0 +1,25 @@
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: clang-doc --output=%t --format=json --executor=standalone %s
+// RUN: FileCheck %s < %t/GlobalNamespace/index.json
+
+static void myFunction() {}
+
+void noExceptFunction() noexcept {}
+
+inline void inlineFunction() {}
+
@@ -0,0 +1,108 @@
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: clang-doc --output=%t --format=json --executor=standalone %s
+// RUN: FileCheck %s < %t/GlobalNamespace/index.json
+
+class MyClass {};
+
+void myFunction(int Param);
+
+namespace NestedNamespace {
+} // namespace Nested
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/143209
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -947,6 +952,53 @@ emitInfo(const NamespaceDecl *D, const FullComment *FC,
Location Loc,
return {std::move(NSI), makeAndInsertIntoParent(*NSI)};
}
+static void parseFriends(RecordInfo &RI, const CXXRecordDecl *D) {
+ if (D->hasDefinition() && D->hasFriends())
---
https://github.com/ilovepi approved this pull request.
https://github.com/llvm/llvm-project/pull/146164
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/146165
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ilovepi approved this pull request.
LGTM, modulo formatting and 1 small suggestion.
https://github.com/llvm/llvm-project/pull/146165
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
@@ -60,6 +60,17 @@ HTML-SHAPE:
HTML-SHAPE:
HTML-SHAPE:
HTML-SHAPE: class Shape
+HTML-SHAPE:
+HTML-SHAPE:
+HTML-SHAPE: Abstr
https://github.com/ilovepi approved this pull request.
LGTM, except the Q on formatting. Obviously doesn't need to be solved in this
patch, though.
https://github.com/llvm/llvm-project/pull/149565
___
llvm-branch-commits mailing list
llvm-branch-commi
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/149565
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -210,12 +229,17 @@ serializeCommonAttributes(const Info &I, json::Object
&Obj,
}
if (!I.Description.empty()) {
-json::Value DescArray = json::Array();
-auto &DescArrayRef = *DescArray.getAsArray();
-DescArrayRef.reserve(I.Description.size());
-for (cons
https://github.com/ilovepi commented:
This seems mostly fine. I'll probably LGTM once I go through the whole stack.
https://github.com/llvm/llvm-project/pull/149564
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.l
@@ -210,12 +229,17 @@ serializeCommonAttributes(const Info &I, json::Object
&Obj,
}
if (!I.Description.empty()) {
-json::Value DescArray = json::Array();
-auto &DescArrayRef = *DescArray.getAsArray();
-DescArrayRef.reserve(I.Description.size());
-for (cons
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/149564
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -60,6 +60,17 @@ HTML-SHAPE:
HTML-SHAPE:
HTML-SHAPE:
HTML-SHAPE: class Shape
+HTML-SHAPE:
+HTML-SHAPE:
+HTML-SHAPE: Abstr
ilovepi wrote:
I think this is mostly in good shape, but some of the tests could be reduced
slightly using the method I gave in an another one of your PRs. After that its
probably LGTM from my perspective.
https://github.com/llvm/llvm-project/pull/87575
___
701 - 778 of 778 matches
Mail list logo
