[llvm-branch-commits] [libcxx] [libc++][format][4/7] Improves std::format_to performance. (PR #101823)

2024-08-20 Thread Louis Dionne via llvm-branch-commits
@@ -722,6 +724,95 @@ class _LIBCPP_TEMPLATE_VIS __allocating_buffer : public __output_buffer<_CharT> } }; +// A buffer that directly writes to the underlying buffer. +template ldionne wrote: ```suggestion template ``` That way, you don't need to `__unwr

[llvm-branch-commits] [libcxx] [libc++][format][4/7] Improves std::format_to performance. (PR #101823)

2024-08-20 Thread Louis Dionne via llvm-branch-commits
@@ -722,6 +724,95 @@ class _LIBCPP_TEMPLATE_VIS __allocating_buffer : public __output_buffer<_CharT> } }; +// A buffer that directly writes to the underlying buffer. +template +class _LIBCPP_TEMPLATE_VIS __direct_iterator_buffer : public __output_buffer<_CharT> { +public:

[llvm-branch-commits] [libcxx] [libc++][format][4/7] Improves std::format_to performance. (PR #101823)

2024-08-20 Thread Louis Dionne via llvm-branch-commits
@@ -722,6 +724,95 @@ class _LIBCPP_TEMPLATE_VIS __allocating_buffer : public __output_buffer<_CharT> } }; +// A buffer that directly writes to the underlying buffer. +template +class _LIBCPP_TEMPLATE_VIS __direct_iterator_buffer : public __output_buffer<_CharT> { +public:

[llvm-branch-commits] [libcxx] [libc++][format][3/7] Improves std::format performance. (PR #101817)

2024-08-20 Thread Louis Dionne via llvm-branch-commits
@@ -499,11 +652,78 @@ struct _LIBCPP_TEMPLATE_VIS __format_to_n_buffer final _LIBCPP_HIDE_FROM_ABI auto __make_output_iterator() { return this->__output_.__make_output_iterator(); } _LIBCPP_HIDE_FROM_ABI format_to_n_result<_OutIt> __result() && { -this->__output_.__fl

[llvm-branch-commits] [libcxx] PR for llvm/llvm-project#80168 (PR #80702)

2024-02-05 Thread Louis Dionne via llvm-branch-commits
ldionne wrote: > @ldionne What do you think about merging this PR to the release branch? Approved! https://github.com/llvm/llvm-project/pull/80702 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[llvm-branch-commits] [libcxx] release/18.x: [libc++][print] Moves is_terminal to the dylib. (#80464) (PR #81410)

2024-02-12 Thread Louis Dionne via llvm-branch-commits
ldionne wrote: Approved. https://github.com/llvm/llvm-project/pull/81410 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/18.x: [libc++][modules] Re-add build dir CMakeLists.txt. (#81370) (PR #81651)

2024-02-15 Thread Louis Dionne via llvm-branch-commits
ldionne wrote: Approved after talking with Mark. This is important for early adopters of modules. https://github.com/llvm/llvm-project/pull/81651 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

2024-02-27 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/82113 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

2024-02-27 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,53 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

2024-02-27 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne requested changes to this pull request. https://github.com/llvm/llvm-project/pull/82113 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

2024-02-27 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,53 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

2024-02-27 Thread Louis Dionne via llvm-branch-commits
@@ -35,5 +35,8 @@ int main(int, const char**) { assert(std::ranges::is_sorted(db.links)); assert(std::ranges::adjacent_find(db.links) == db.links.end()); // is unique? + assert(!db.leap_seconds.empty()); ldionne wrote: We seem to be missing a test that t

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

2024-02-27 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,56 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

2024-02-27 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,112 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

2024-02-27 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,51 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

2024-02-27 Thread Louis Dionne via llvm-branch-commits
@@ -612,6 +643,16 @@ void __init_tzdb(tzdb& __tzdb, __tz::__rules_storage_type& __rules) { std::ranges::sort(__tzdb.zones); std::ranges::sort(__tzdb.links); std::ranges::sort(__rules, {}, [](const auto& p) { return p.first; }); + + // There are two files with the leap s

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

2024-02-27 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,48 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

2024-02-27 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,53 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

2024-02-27 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,112 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

2024-02-27 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,102 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm-branch-commits] [libcxx] [libc++] Implements filebuf unbuffered. (PR #76629)

2024-02-27 Thread Louis Dionne via llvm-branch-commits
@@ -294,7 +318,10 @@ private: return nullptr; __om_ = __mode; + __try_set_unbuffered_mode(); ldionne wrote: Strange indentation. https://github.com/llvm/llvm-project/pull/76629 ___ llvm-branch-commi

[llvm-branch-commits] [libcxx] [libc++] Implements filebuf unbuffered. (PR #76629)

2024-02-27 Thread Louis Dionne via llvm-branch-commits
@@ -276,6 +276,30 @@ private: state_type __st_; state_type __st_last_; ios_base::openmode __om_; + // Used to track the currently used mode and track whether the output should + // be unbuffered. + // [filebuf.virtuals]/12 + // If setbuf(0, 0) is called on a stream

[llvm-branch-commits] [libcxx] release/18.x: [libc++][modules] Fixes naming inconsistency. (#83036) (PR #83156)

2024-02-27 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/83156 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][chrono] Completes the tzdb class. (PR #82157)

2024-03-05 Thread Louis Dionne via llvm-branch-commits
@@ -43,6 +44,40 @@ struct tzdb { vector links; vector leap_seconds; + + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI const time_zone* __locate_zone(string_view __name) const { +if (const time_zone* __result = __find_in_zone(__name); __result) + return __result; + +if

[llvm-branch-commits] [libcxx] [libc++][chrono] Completes the tzdb class. (PR #82157)

2024-03-05 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/82157 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][chrono] Completes the tzdb class. (PR #82157)

2024-03-05 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/82157 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][chrono] Completes the tzdb class. (PR #82157)

2024-03-05 Thread Louis Dionne via llvm-branch-commits
@@ -43,6 +44,40 @@ struct tzdb { vector links; vector leap_seconds; + + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI const time_zone* __locate_zone(string_view __name) const { +if (const time_zone* __result = __find_in_zone(__name); __result) + return __result; + +if

[llvm-branch-commits] [libcxx] [libc++][chrono] Completes the tzdb class. (PR #82157)

2024-03-05 Thread Louis Dionne via llvm-branch-commits
@@ -655,6 +655,57 @@ void __init_tzdb(tzdb& __tzdb, __tz::__rules_storage_type& __rules) { std::ranges::sort(__tzdb.leap_seconds); } +#ifdef _WIN32 +[[nodiscard]] static const time_zone* __current_zone_windows(const tzdb& tzdb) { + // TODO TZDB Implement this on Windows.

[llvm-branch-commits] [libcxx] [libc++][chrono] Completes the tzdb class. (PR #82157)

2024-03-05 Thread Louis Dionne via llvm-branch-commits
@@ -655,6 +655,57 @@ void __init_tzdb(tzdb& __tzdb, __tz::__rules_storage_type& __rules) { std::ranges::sort(__tzdb.leap_seconds); } +#ifdef _WIN32 +[[nodiscard]] static const time_zone* __current_zone_windows(const tzdb& tzdb) { + // TODO TZDB Implement this on Windows.

[llvm-branch-commits] [libcxx] [libc++][chrono] Completes the tzdb class. (PR #82157)

2024-03-05 Thread Louis Dionne via llvm-branch-commits
@@ -655,6 +655,57 @@ void __init_tzdb(tzdb& __tzdb, __tz::__rules_storage_type& __rules) { std::ranges::sort(__tzdb.leap_seconds); } +#ifdef _WIN32 +[[nodiscard]] static const time_zone* __current_zone_windows(const tzdb& tzdb) { + // TODO TZDB Implement this on Windows.

[llvm-branch-commits] [libcxx] [libc++][chrono] Completes the tzdb class. (PR #82157)

2024-03-05 Thread Louis Dionne via llvm-branch-commits
@@ -655,6 +655,57 @@ void __init_tzdb(tzdb& __tzdb, __tz::__rules_storage_type& __rules) { std::ranges::sort(__tzdb.leap_seconds); } +#ifdef _WIN32 +[[nodiscard]] static const time_zone* __current_zone_windows(const tzdb& tzdb) { + // TODO TZDB Implement this on Windows.

[llvm-branch-commits] [libcxx] [libc++][chrono] Completes the tzdb class. (PR #82157)

2024-03-05 Thread Louis Dionne via llvm-branch-commits
@@ -655,6 +655,57 @@ void __init_tzdb(tzdb& __tzdb, __tz::__rules_storage_type& __rules) { std::ranges::sort(__tzdb.leap_seconds); } +#ifdef _WIN32 +[[nodiscard]] static const time_zone* __current_zone_windows(const tzdb& tzdb) { + // TODO TZDB Implement this on Windows.

[llvm-branch-commits] [libcxx] release/18.x: [libc++] Enable availability based on the compiler instead of __has_extension (#84065) (PR #84374)

2024-03-07 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/84374 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/18.x: [libc++] Enable availability based on the compiler instead of __has_extension (#84065) (PR #84374)

2024-03-11 Thread Louis Dionne via llvm-branch-commits
ldionne wrote: No, it's not legitimate. Our CI is rather unstable at the moment but this looks as good as it'll get. https://github.com/llvm/llvm-project/pull/84374 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.

[llvm-branch-commits] [libcxx] [libcxxabi] [libunwind] release/18.x: [runtimes] Prefer -fvisibility-global-new-delete=force-hidden (#84917) (PR #85126)

2024-03-13 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/85126 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libcxxabi] [libunwind] release/18.x: [runtimes] Prefer -fvisibility-global-new-delete=force-hidden (#84917) (PR #85126)

2024-03-14 Thread Louis Dionne via llvm-branch-commits
ldionne wrote: @tstellar Yes. I think I'll disable these tests which keep failing in the LLVM 18 release branch so we can remove some of the noise here. https://github.com/llvm/llvm-project/pull/85126 ___ llvm-branch-commits mailing list llvm-branch-c

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

2024-03-14 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne milestoned https://github.com/llvm/llvm-project/pull/85247 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

2024-03-14 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/85247 LIT was never really meant to generate tests during discovery, and we probably shouldn't be doing this. This hack is even worse than the initial attempt because it buries the "UNSUPPORTED" at the bottom of the

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

2024-03-14 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/85247 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

2024-03-14 Thread Louis Dionne via llvm-branch-commits
ldionne wrote: @mordante So should I close this PR? https://github.com/llvm/llvm-project/pull/85247 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

2024-03-14 Thread Louis Dionne via llvm-branch-commits
ldionne wrote: Is the fix only to switch to 18.1 in the cmake? I can do that if that's it, I just don't fully understand the situation w/ clang tidy ODR violations since you were the one to make these changes https://github.com/llvm/llvm-project/pull/85247 _

[llvm-branch-commits] [libcxx] [libc++] Use clang-tidy version that matches the compiler we use in the CI (PR #85305)

2024-03-14 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne milestoned https://github.com/llvm/llvm-project/pull/85305 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Use clang-tidy version that matches the compiler we use in the CI (PR #85305)

2024-03-14 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/85305 This works around ODR violations in the clang-tidy plugin we use to perform the modules tests. Fixes #85242 >From 810c55db5c92f5786a4c2b1b1336dd8b62f28f86 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu,

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

2024-03-14 Thread Louis Dionne via llvm-branch-commits
ldionne wrote: No worries! I just created https://github.com/llvm/llvm-project/pull/85305, hopefully that should do the trick. https://github.com/llvm/llvm-project/pull/85247 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org http

[llvm-branch-commits] [runtimes] Allow building against an installed LLVM tree (PR #86209)

2024-03-26 Thread Louis Dionne via llvm-branch-commits
@@ -218,6 +218,22 @@ foreach(entry ${runtimes}) endforeach() if(LLVM_INCLUDE_TESTS) + # Add lit if needed before adding any runtimes since their CMake tests + # configuration might depend on lit being present. + if (NOT HAVE_LLVM_LIT) +# If built by manually invoking cm

[llvm-branch-commits] [runtimes] Allow building against an installed LLVM tree (PR #86209)

2024-03-26 Thread Louis Dionne via llvm-branch-commits
@@ -218,6 +218,22 @@ foreach(entry ${runtimes}) endforeach() if(LLVM_INCLUDE_TESTS) + # Add lit if needed before adding any runtimes since their CMake tests + # configuration might depend on lit being present. + if (NOT HAVE_LLVM_LIT) +# If built by manually invoking cm

[llvm-branch-commits] [libcxx] [libc++][chrono] Adds the sys_info class. (PR #85619)

2024-03-26 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/85619 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][chrono] Adds the sys_info class. (PR #85619)

2024-03-26 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,127 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm-branch-commits] [libcxx] [libc++][chrono] Adds the sys_info class. (PR #85619)

2024-03-26 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne commented: We can dive into the implementation during the next round of review! https://github.com/llvm/llvm-project/pull/85619 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cg

[llvm-branch-commits] [libcxx] [libc++][chrono] Adds the sys_info class. (PR #85619)

2024-03-26 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,53 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-

[llvm-branch-commits] [libcxx] [libc++][chrono] Adds the sys_info class. (PR #85619)

2024-03-26 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,1374 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm-branch-commits] [libcxx] release/18.x: [libc++] Simplify the implementation of (#86843) (PR #87374)

2024-04-11 Thread Louis Dionne via llvm-branch-commits
ldionne wrote: > As mentioned on #86843, this breaks using `-pedantic` in code that includes > libc++ headers. Since this got cherry-picked, we also must cherry-pick #88214. I just started that process here: https://github.com/llvm/llvm-project/pull/88214#issuecomment-2050203419 https://githu

[llvm-branch-commits] [libcxx] release/18.x: [libc++] Fix -Wgnu-include-next in stddef.h (#88214) (PR #88419)

2024-04-11 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/88419 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Improves time zone format specifiers. (PR #85797)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. LGTM with minor comments. Thanks! https://github.com/llvm/llvm-project/pull/85797 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[llvm-branch-commits] [libcxx] [libc++][TZDB] Improves time zone format specifiers. (PR #85797)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
@@ -170,10 +171,45 @@ _LIBCPP_HIDE_FROM_ABI void __format_century(basic_stringstream<_CharT>& __sstr, __sstr << std::format(_LIBCPP_STATICALLY_WIDEN(_CharT, "{:02}"), __century); } +// Implements the %z format specifier according to [tab:time.format.spec], where +// '__mod

[llvm-branch-commits] [libcxx] [libc++][TZDB] Improves time zone format specifiers. (PR #85797)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
@@ -170,10 +171,45 @@ _LIBCPP_HIDE_FROM_ABI void __format_century(basic_stringstream<_CharT>& __sstr, __sstr << std::format(_LIBCPP_STATICALLY_WIDEN(_CharT, "{:02}"), __century); } +// Implements the %z format specifier according to [tab:time.format.spec], where +// '__mod

[llvm-branch-commits] [libcxx] [libc++][TZDB] Improves time zone format specifiers. (PR #85797)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/85797 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Improves time zone format specifiers. (PR #85797)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
@@ -170,10 +171,45 @@ _LIBCPP_HIDE_FROM_ABI void __format_century(basic_stringstream<_CharT>& __sstr, __sstr << std::format(_LIBCPP_STATICALLY_WIDEN(_CharT, "{:02}"), __century); } +// Implements the %z format specifier according to [tab:time.format.spec], where +// '__mod

[llvm-branch-commits] [libcxx] [libc++][TZDB] Improves time zone format specifiers. (PR #85797)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/85797 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][chrono] Improves date formatting. (PR #86127)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/86127 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][chrono] Improves date formatting. (PR #86127)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
@@ -322,15 +322,13 @@ _LIBCPP_HIDE_FROM_ABI void __format_chrono_using_chrono_specs( __formatter::__format_year(__sstr, __t.tm_year + 1900); break; - case _CharT('F'): { -int __year = __t.tm_year + 1900; -if (__year < 1000) { - __

[llvm-branch-commits] [libcxx] [libc++][chrono] Improves date formatting. (PR #86127)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/86127 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][chrono] Improves date formatting. (PR #86127)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/86127 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds sys_info formatter. (PR #85896)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/85896 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds local_info formatter. (PR #86256)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/86256 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds local_info formatter. (PR #86256)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. LGTM with small comments. https://github.com/llvm/llvm-project/pull/86256 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llv

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds local_info formatter. (PR #86256)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,50 @@ +// -*- C++ -*- ldionne wrote: Maybe update the commit message since this patch actually introduces `local_info`, not only the formatter for it. https://github.com/llvm/llvm-project/pull/86256 ___ llv

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds local_info formatter. (PR #86256)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,50 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds local_info formatter. (PR #86256)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,114 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm-branch-commits] [libcxx] release/18.x: [libc++] Fix -Wgnu-include-next in stddef.h (#88214) (PR #88419)

2024-04-17 Thread Louis Dionne via llvm-branch-commits
ldionne wrote: I don't think a release note is necessary here because we introduced the "bug" and fixed it in the same point-release. So from the user's perspective there was no issue introduced. https://github.com/llvm/llvm-project/pull/88419 ___ ll

[llvm-branch-commits] [libc] [libcxx] [libcxxabi] [libunwind] [llvm] [pstl] Revise IDE folder structure (PR #89755)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/89755 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Fixes reverse time lookups. (PR #89502)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/89502 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Fixes reverse time lookups. (PR #89502)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/89502 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Makes saturation functions privately available. (PR #89503)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/89503 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone get_info(local_time). (PR #89537)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/89537 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone get_info(local_time). (PR #89537)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/89537 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone get_info(local_time). (PR #89537)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -903,6 +904,180 @@ time_zone::__get_info(sys_seconds __time) const { std::__throw_runtime_error("tzdb: corrupt db"); } +enum class __position { + __beginning, + __middle, + __end, +}; + +// Determines the position of "__time" inside "__info". +// +// The code picks an

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone get_info(local_time). (PR #89537)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne requested changes to this pull request. https://github.com/llvm/llvm-project/pull/89537 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone get_info(local_time). (PR #89537)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -903,6 +904,180 @@ time_zone::__get_info(sys_seconds __time) const { std::__throw_runtime_error("tzdb: corrupt db"); } +enum class __position { + __beginning, + __middle, + __end, +}; + +// Determines the position of "__time" inside "__info". +// +// The code picks an

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone get_info(local_time). (PR #89537)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -903,6 +904,180 @@ time_zone::__get_info(sys_seconds __time) const { std::__throw_runtime_error("tzdb: corrupt db"); } +enum class __position { + __beginning, + __middle, + __end, +}; + +// Determines the position of "__time" inside "__info". +// +// The code picks an

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone get_info(local_time). (PR #89537)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -903,6 +904,180 @@ time_zone::__get_info(sys_seconds __time) const { std::__throw_runtime_error("tzdb: corrupt db"); } +enum class __position { + __beginning, + __middle, + __end, +}; + +// Determines the position of "__time" inside "__info". +// +// The code picks an

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone get_info(local_time). (PR #89537)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -903,6 +904,180 @@ time_zone::__get_info(sys_seconds __time) const { std::__throw_runtime_error("tzdb: corrupt db"); } +enum class __position { + __beginning, + __middle, + __end, +}; + +// Determines the position of "__time" inside "__info". +// +// The code picks an

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone get_info(local_time). (PR #89537)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -903,6 +904,180 @@ time_zone::__get_info(sys_seconds __time) const { std::__throw_runtime_error("tzdb: corrupt db"); } +enum class __position { + __beginning, + __middle, + __end, +}; + +// Determines the position of "__time" inside "__info". +// +// The code picks an

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping. (PR #88283)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/88283 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping. (PR #88283)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/88283 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping. (PR #88283)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/88283 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping. (PR #88283)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/88283 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping. (PR #88283)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -328,8 +313,13 @@ def generate_data_tables() -> str: # # When this region becomes substantially smaller we need to investigate # this design. +# +# Due to P2713R1 Escaping improvements in std::format the range +# E0100..E01EF ; Grapheme_Extend # Mn

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping. (PR #88283)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/88283 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping performance. (PR #88533)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/88533 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping performance. (PR #88533)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. LGTM with a few comments! https://github.com/llvm/llvm-project/pull/88533 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llv

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping performance. (PR #88533)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -305,23 +316,28 @@ def generate_data_tables() -> str: data = compactPropertyRanges(sorted(properties, key=lambda x: x.lower)) -# The last entry is large. In Unicode 14 it contains the entries -# 3134B..0 912564 elements -# This are 446 entries of 1325 e

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping performance. (PR #88533)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/88533 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping performance. (PR #88533)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -305,23 +316,28 @@ def generate_data_tables() -> str: data = compactPropertyRanges(sorted(properties, key=lambda x: x.lower)) -# The last entry is large. In Unicode 14 it contains the entries -# 3134B..0 912564 elements -# This are 446 entries of 1325 e

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping performance. (PR #88533)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -305,23 +316,28 @@ def generate_data_tables() -> str: data = compactPropertyRanges(sorted(properties, key=lambda x: x.lower)) -# The last entry is large. In Unicode 14 it contains the entries -# 3134B..0 912564 elements -# This are 446 entries of 1325 e

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping performance. (PR #88533)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -106,1110 +105,748 @@ namespace __escaped_output_table { /// table lacks a property, thus having more bits available for the size. /// /// The data has 2 values: -/// - bits [0, 10] The size of the range, allowing 2048 elements. -/// - bits [11, 31] The lower bound code poin

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping performance. (PR #88533)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,100 @@ +//===--===// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping performance. (PR #88533)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -106,1110 +105,748 @@ namespace __escaped_output_table { /// table lacks a property, thus having more bits available for the size. /// /// The data has 2 values: -/// - bits [0, 10] The size of the range, allowing 2048 elements. -/// - bits [11, 31] The lower bound code poin

[llvm-branch-commits] [libcxx] release/18.x: [libcxx] [modules] Add _LIBCPP_USING_IF_EXISTS on aligned_alloc (#89827) (PR #89894)

2024-04-25 Thread Louis Dionne via llvm-branch-commits
ldionne wrote: > Can we ignore the libcxx test failure? Yes. It turns out to be extremely difficult to keep the release branch CI working *and* the `main` branch CI working at the same time. I mean it mostly works, except for annoyances like this. https://github.com/llvm/llvm-project/pull/898

[llvm-branch-commits] [libc] [libcxx] [libcxxabi] [libunwind] [llvm] [pstl] Revise IDE folder structure (PR #89755)

2024-05-21 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. LGTM. After checking, I think this only impacts `add_lit_testsuites` since we don't use many other things from `AddLLVM.cmake` in the runtimes. https://github.com/llvm/llvm-project/pull/89755 ___

<    1   2   3   4   5   6   >