[llvm-branch-commits] [flang] [flang][OpenMP] Map simple `do concurrent` loops to OpenMP host constructs (PR #127633)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/127633 >From 06bf9bcf103167ad1ca2f45f4700bf563fb4a07c Mon Sep 17 00:00:00 2001 From: ergawy Date: Tue, 18 Feb 2025 02:50:46 -0600 Subject: [PATCH] [flang][OpenMP] Map simple `do concurrent` loops to OpenMP host constru

[llvm-branch-commits] [flang] [flang][OpenMP] Extend `do concurrent` mapping to multi-range loops (PR #127634)

https://github.com/ergawy edited https://github.com/llvm/llvm-project/pull/127634 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP] Map simple `do concurrent` loops to OpenMP host constructs (PR #127633)

https://github.com/ergawy edited https://github.com/llvm/llvm-project/pull/127633 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP] Map simple `do concurrent` loops to OpenMP host const… (PR #127633)

https://github.com/ergawy created https://github.com/llvm/llvm-project/pull/127633 …ructs Upstreams one more part of the ROCm `do concurrent` to OpenMP mapping pass. This PR add support for converting simple loops to the equivalent OpenMP constructs on the host: `omp parallel do`. Towards tha

[llvm-branch-commits] [flang] [flang][OpenMP] Map simple `do concurrent` loops to OpenMP host constructs (PR #127633)

https://github.com/ergawy edited https://github.com/llvm/llvm-project/pull/127633 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP] Handle "loop-local values" in `do concurrent` nests (PR #127635)

https://github.com/ergawy created https://github.com/llvm/llvm-project/pull/127635 Extends `do concurrent` mapping to handle "loop-local values". A loop-local value is one that is used exclusively inside the loop but allocated outside of it. This usually corresponds to temporary values that ar

[llvm-branch-commits] [flang] [flang][OpenMP] Extend `do concurrent` mapping to multi-range loops (PR #127634)

https://github.com/ergawy created https://github.com/llvm/llvm-project/pull/127634 Adds support for converting mulit-range loops to OpenMP (on the host only for now). The changes here "prepare" a loop nest for collapsing by sinking iteration variables to the innermost `fir.do_loop` op in the n

[llvm-branch-commits] [flang] [flang][OpenMP] Handle "loop-local values" in `do concurrent` nests (PR #127635)

https://github.com/ergawy edited https://github.com/llvm/llvm-project/pull/127635 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP] Map simple `do concurrent` loops to OpenMP host constructs (PR #127633)

https://github.com/ergawy edited https://github.com/llvm/llvm-project/pull/127633 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP] Map simple `do concurrent` loops to OpenMP host constructs (PR #127633)

ergawy wrote: Ping! Please have a look when you have time. https://github.com/llvm/llvm-project/pull/127633 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP] Map simple `do concurrent` loops to OpenMP host constructs (PR #127633)

@@ -0,0 +1,45 @@ +! Tests that if `do concurrent` is not perfectly nested in its parent loop, that +! we skip converting the not-perfectly nested `do concurrent` loop. + +! RUN: %flang_fc1 -emit-hlfir -fopenmp -fdo-concurrent-to-openmp=host %s -o - \ +! RUN: | FileCheck %s + +p

[llvm-branch-commits] [flang] [flang][OpenMP] Map simple `do concurrent` loops to OpenMP host constructs (PR #127633)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/127633 >From 2e6bf4c394db115bd4a369473742b7411a03334c Mon Sep 17 00:00:00 2001 From: ergawy Date: Tue, 18 Feb 2025 02:50:46 -0600 Subject: [PATCH 1/3] [flang][OpenMP] Map simple `do concurrent` loops to OpenMP host con

[llvm-branch-commits] [flang] [flang][OpenMP] Extend `do concurrent` mapping to multi-range loops (PR #127634)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/127634 >From 090ea42681a2e0bfbb73853eb75f8e31d3adf120 Mon Sep 17 00:00:00 2001 From: ergawy Date: Tue, 18 Feb 2025 06:17:17 -0600 Subject: [PATCH] [flang][OpenMP] Extend `do concurrent` mapping to multi-range loops Ad

[llvm-branch-commits] [flang] [flang][OpenMP] Map simple `do concurrent` loops to OpenMP host constructs (PR #127633)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/127633 >From 2e6bf4c394db115bd4a369473742b7411a03334c Mon Sep 17 00:00:00 2001 From: ergawy Date: Tue, 18 Feb 2025 02:50:46 -0600 Subject: [PATCH 1/2] [flang][OpenMP] Map simple `do concurrent` loops to OpenMP host con

[llvm-branch-commits] [flang] [flang][OpenMP] Handle "loop-local values" in `do concurrent` nests (PR #127635)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/127635 >From 1adeaa2b3ef110ad7770539d6573c2bde2ae5897 Mon Sep 17 00:00:00 2001 From: ergawy Date: Tue, 18 Feb 2025 06:40:19 -0600 Subject: [PATCH] [flang][OpenMP] Handle "loop-local values" in `do concurrent` nests Ex

[llvm-branch-commits] [mlir] [flang][OpenMP] Translate OpenMP scopes when compiling for target device (PR #130078)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/130078 >From 2b6b9c1fae4ea33cb4d3056dc016cdcac2cfc304 Mon Sep 17 00:00:00 2001 From: ergawy Date: Thu, 6 Mar 2025 03:16:59 -0600 Subject: [PATCH 1/3] [flang][OpenMP] Translate OpenMP scopes when compiling for target de

[llvm-branch-commits] [mlir] [flang][OpenMP] Translate OpenMP scopes when compiling for target device (PR #130078)

@@ -5315,6 +5320,46 @@ convertTargetOpsInNest(Operation *op, llvm::IRBuilderBase &builder, return WalkResult::interrupt(); return WalkResult::skip(); } + + // Non-target ops might nest target-related ops, therefore, we + //

[llvm-branch-commits] [mlir] [flang][OpenMP] Translate OpenMP scopes when compiling for target device (PR #130078)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/130078 >From 9de8c664bad3a851e3b9644711b24c6449db9e49 Mon Sep 17 00:00:00 2001 From: ergawy Date: Thu, 6 Mar 2025 03:16:59 -0600 Subject: [PATCH 1/4] [flang][OpenMP] Translate OpenMP scopes when compiling for target de

[llvm-branch-commits] [mlir] [flang][OpenMP] Translate OpenMP scopes when compiling for target device (PR #130078)

@@ -5255,6 +5283,51 @@ convertTargetOpsInNest(Operation *op, llvm::IRBuilderBase &builder, return WalkResult::interrupt(); return WalkResult::skip(); } + + // Non-target ops might nest target-related ops, therefore, we + //

[llvm-branch-commits] [mlir] [flang][OpenMP] Translate OpenMP scopes when compiling for target device (PR #130078)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/130078 >From 9de8c664bad3a851e3b9644711b24c6449db9e49 Mon Sep 17 00:00:00 2001 From: ergawy Date: Thu, 6 Mar 2025 03:16:59 -0600 Subject: [PATCH 1/4] [flang][OpenMP] Translate OpenMP scopes when compiling for target de

[llvm-branch-commits] [flang] [flang][OpenMP] Map simple `do concurrent` loops to OpenMP host constructs (PR #127633)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/127633 >From a615d777295ac1cf5fc1c8bd2eca9f5d6283b409 Mon Sep 17 00:00:00 2001 From: ergawy Date: Tue, 18 Feb 2025 02:50:46 -0600 Subject: [PATCH] [flang][OpenMP] Map simple `do concurrent` loops to OpenMP host constru

[llvm-branch-commits] [flang] [flang][OpenMP] Map simple `do concurrent` loops to OpenMP host constructs (PR #127633)

@@ -93,11 +169,14 @@ bool isPerfectlyNested(fir::DoLoopOp outerLoop, fir::DoLoopOp innerLoop) { /// recognize a certain nested loop as part of the nest it just returns the /// parent loops it discovered before. mlir::LogicalResult collectLoopNest(fir::DoLoopOp currentLoop, -

[llvm-branch-commits] [flang] [flang][OpenMP] Extend `do concurrent` mapping to multi-range loops (PR #127634)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/127634 >From 40d14156ff5d48ce94de96d8d23119a35b728dab Mon Sep 17 00:00:00 2001 From: ergawy Date: Tue, 18 Feb 2025 06:17:17 -0600 Subject: [PATCH] [flang][OpenMP] Extend `do concurrent` mapping to multi-range loops Ad

[llvm-branch-commits] [flang] [flang][OpenMP] Handle "loop-local values" in `do concurrent` nests (PR #127635)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/127635 >From 2d9fb8f381a413c4451f812efc15636d5ab15825 Mon Sep 17 00:00:00 2001 From: ergawy Date: Tue, 18 Feb 2025 06:40:19 -0600 Subject: [PATCH] [flang][OpenMP] Handle "loop-local values" in `do concurrent` nests Ex

[llvm-branch-commits] [flang] [mlir] [mlir][OpenMP] Pack task private variables into a heap-allocated context struct (PR #125307)

https://github.com/ergawy approved this pull request. LGTM! Thanks! https://github.com/llvm/llvm-project/pull/125307 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-com

[llvm-branch-commits] [flang] [flang][fir] Basic lowering `fir.do_concurrent` locality specs to `fir.do_loop ... unordered` (PR #138512)

@@ -162,7 +173,52 @@ class DoConcurrentConversion assert(loop.getRegion().hasOneBlock()); mlir::Block &loopBlock = loop.getRegion().getBlocks().front(); -// Collect iteration variable(s) allocations do that we can move them +// Handle localization +if (!loo

[llvm-branch-commits] [flang] [flang][fir] Basic PFT to MLIR lowering for do concurrent locality specifiers (PR #138534)

@@ -2029,9 +2031,33 @@ class FirConverter : public Fortran::lower::AbstractConverter { void handleLocalitySpecs(const IncrementLoopInfo &info) { Fortran::semantics::SemanticsContext &semanticsContext = bridge.getSemanticsContext(); -for (const Fortran::semant

[llvm-branch-commits] [flang] [flang][fir] Basic PFT to MLIR lowering for do concurrent locality specifiers (PR #138534)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/138534 >From b6893b6bd8444508867a91b9d28e5cc725fab191 Mon Sep 17 00:00:00 2001 From: ergawy Date: Mon, 5 May 2025 07:15:52 -0500 Subject: [PATCH 1/2] [flang][fir] Basic PFT to MLIR lowering for do concurrent locality s

[llvm-branch-commits] [flang] [flang][fir] Basic PFT to MLIR lowering for do concurrent locality specifiers (PR #138534)

@@ -2029,9 +2031,33 @@ class FirConverter : public Fortran::lower::AbstractConverter { void handleLocalitySpecs(const IncrementLoopInfo &info) { Fortran::semantics::SemanticsContext &semanticsContext = bridge.getSemanticsContext(); -for (const Fortran::semant

[llvm-branch-commits] [flang] [flang][fir] Basic PFT to MLIR lowering for do concurrent locality specifiers (PR #138534)

@@ -2029,9 +2031,30 @@ class FirConverter : public Fortran::lower::AbstractConverter { void handleLocalitySpecs(const IncrementLoopInfo &info) { Fortran::semantics::SemanticsContext &semanticsContext = bridge.getSemanticsContext(); -for (const Fortran::semant

[llvm-branch-commits] [flang] [flang][fir] Basic PFT to MLIR lowering for do concurrent locality specifiers (PR #138534)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/138534 >From 0d309682fa886e3481f95ed0b0ba9a6ca9a5c9f1 Mon Sep 17 00:00:00 2001 From: ergawy Date: Mon, 5 May 2025 07:15:52 -0500 Subject: [PATCH 1/2] [flang][fir] Basic PFT to MLIR lowering for do concurrent locality s

[llvm-branch-commits] [flang] [flang][fir] Basic lowering `fir.do_concurrent` locality specs to `fir.do_loop ... unordered` (PR #138512)

@@ -162,7 +173,52 @@ class DoConcurrentConversion assert(loop.getRegion().hasOneBlock()); mlir::Block &loopBlock = loop.getRegion().getBlocks().front(); -// Collect iteration variable(s) allocations do that we can move them +// Handle localization +if (!loo

[llvm-branch-commits] [flang] [flang][fir] Basic PFT to MLIR lowering for do concurrent locality specifiers (PR #138534)

https://github.com/ergawy edited https://github.com/llvm/llvm-project/pull/138534 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang] Generlize names of delayed privatization CLI flags (PR #138816)

https://github.com/ergawy created https://github.com/llvm/llvm-project/pull/138816 Remove the `openmp` prefix from delayed privatization/localization flags since they are now used for `do concurrent` as well. Rate limit · GitHub body { background

[llvm-branch-commits] [flang] [flang][fir] Basic lowering `fir.do_concurrent` locality specs to `fir.do_loop ... unordered` (PR #138512)

https://github.com/ergawy edited https://github.com/llvm/llvm-project/pull/138512 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][fir] Add `fir.local` op for locality specifiers (PR #138505)

https://github.com/ergawy edited https://github.com/llvm/llvm-project/pull/138505 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][fir] Add locality specifiers modeling to `fir.do_concurrent.loop` (PR #138506)

https://github.com/ergawy edited https://github.com/llvm/llvm-project/pull/138506 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang] Generlize names of delayed privatization CLI flags (PR #138816)

https://github.com/ergawy edited https://github.com/llvm/llvm-project/pull/138816 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP] Update `do concurrent` mapping pass to use `fir.do_concurrent` op (PR #138489)

https://github.com/ergawy edited https://github.com/llvm/llvm-project/pull/138489 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][fir] Add `fir.local` op for locality specifiers (PR #138505)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/138505 >From 09f3a12a25be35d119c02164ef6a4d21a024a940 Mon Sep 17 00:00:00 2001 From: ergawy Date: Mon, 5 May 2025 04:20:40 -0500 Subject: [PATCH 1/3] [flang][fir] Add `fir.local` op for locality specifiers Adds a new `

[llvm-branch-commits] [flang] [flang][fir] Add `fir.local` op for locality specifiers (PR #138505)

ergawy wrote: > Please could you add a test for the verifier failures. Done. https://github.com/llvm/llvm-project/pull/138505 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-

[llvm-branch-commits] [flang] [flang][fir] Add `fir.local` op for locality specifiers (PR #138505)

@@ -3485,6 +3485,137 @@ def fir_BoxTotalElementsOp let hasCanonicalizer = 1; } +def YieldOp : fir_Op<"yield", +[Pure, ReturnLike, Terminator, + ParentOneOf<["LocalitySpecifierOp"]>]> { + let summary = "loop yield and termination operation"; + let description = [{ +

[llvm-branch-commits] [flang] [flang][fir] Add `fir.local` op for locality specifiers (PR #138505)

@@ -3485,6 +3485,137 @@ def fir_BoxTotalElementsOp let hasCanonicalizer = 1; } +def YieldOp : fir_Op<"yield", +[Pure, ReturnLike, Terminator, + ParentOneOf<["LocalitySpecifierOp"]>]> { + let summary = "loop yield and termination operation"; + let description = [{ +

[llvm-branch-commits] [flang] [flang][fir] Basic lowering `fir.do_concurrent` locality specs to `fir.do_loop ... unordered` (PR #138512)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/138512 >From a4acb56894a9e5ec95f857a671e672b126e979c5 Mon Sep 17 00:00:00 2001 From: ergawy Date: Mon, 5 May 2025 06:50:49 -0500 Subject: [PATCH 1/2] [flang][fir] Basci lowering `fir.do_concurrent` locality specs to `f

[llvm-branch-commits] [flang] [flang][fir] Basic lowering `fir.do_concurrent` locality specs to `fir.do_loop ... unordered` (PR #138512)

ergawy wrote: > This needs a TODO message for locality specifiers which are not yet supported > (as I understand it this means ones with init or dealloc regions) Done. I think we might end up not supporting `init` and `dealloc` regions for `fir.local` ops since this is the case for early local

[llvm-branch-commits] [flang] [flang][fir] Basic PFT to MLIR lowering for do concurrent locality specifiers (PR #138534)

@@ -2029,9 +2031,30 @@ class FirConverter : public Fortran::lower::AbstractConverter { void handleLocalitySpecs(const IncrementLoopInfo &info) { Fortran::semantics::SemanticsContext &semanticsContext = bridge.getSemanticsContext(); -for (const Fortran::semant

[llvm-branch-commits] [flang] [flang] Generlize names of delayed privatization CLI flags (PR #138816)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/138816 >From e0eb1611a67579562edefe1c66263c2cc562c5d7 Mon Sep 17 00:00:00 2001 From: ergawy Date: Wed, 7 May 2025 02:41:14 -0500 Subject: [PATCH] [flang] Generlize names of delayed privatization CLI flags Remove the `o

[llvm-branch-commits] [flang] [flang] Enable delayed localization by default for `do concurrent` (PR #142567)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/142567 >From 5647d02ea8ff66ac7be0a8752abd40c60f719f2c Mon Sep 17 00:00:00 2001 From: ergawy Date: Tue, 3 Jun 2025 04:22:20 -0500 Subject: [PATCH] [flang] Enable delayed localization by default for `do concurrent` ---

[llvm-branch-commits] [flang] [flang] Enable delayed localization by default for `do concurrent` (PR #142567)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/142567 >From 345406e6f8eaf63ed312011e60d0d0200a1d72de Mon Sep 17 00:00:00 2001 From: ergawy Date: Tue, 3 Jun 2025 04:22:20 -0500 Subject: [PATCH] [flang] Enable delayed localization by default for `do concurrent` ---

[llvm-branch-commits] [flang] [mlir] [flang][OpenMP][NFC] remove globals with mlir::StateStack (PR #144898)

https://github.com/ergawy approved this pull request. LGTM! Thanks https://github.com/llvm/llvm-project/pull/144898 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-comm

[llvm-branch-commits] [flang] [flang][OpenMP][NFC] Refactor to avoid global variable (PR #144087)

ergawy wrote: I have no idea how I closed this! Sorry @tblah, can you please reopen it? https://github.com/llvm/llvm-project/pull/144087 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[llvm-branch-commits] [flang] [mlir] [MLIR][OpenMP] Simplify OpenMP device codegen (PR #137201)

https://github.com/ergawy edited https://github.com/llvm/llvm-project/pull/137201 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [mlir] [MLIR][OpenMP] Simplify OpenMP device codegen (PR #137201)

@@ -5488,40 +5483,172 @@ convertDeclareTargetAttr(Operation *op, mlir::omp::DeclareTargetAttr attribute, return success(); } -// Returns true if the operation is inside a TargetOp or -// is part of a declare target function. -static bool isTargetDeviceOp(Operation *op) { +n

[llvm-branch-commits] [flang] [mlir] [MLIR][OpenMP] Simplify OpenMP device codegen (PR #137201)

@@ -3173,19 +3173,14 @@ convertOmpThreadprivate(Operation &opInst, llvm::IRBuilderBase &builder, LLVM::GlobalOp global = addressOfOp.getGlobal(moduleTranslation.symbolTable()); llvm::GlobalValue *globalValue = moduleTranslation.lookupGlobal(global); - - if (!ompBuil

[llvm-branch-commits] [flang] [flang][OpenMP][NFC] Refactor to avoid global variable (PR #144087)

https://github.com/ergawy closed https://github.com/llvm/llvm-project/pull/144087 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP][NFC] Refactor to avoid global variable (PR #144087)

ergawy wrote: Reopening since I closed it by mistake somehow. https://github.com/llvm/llvm-project/pull/144087 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [mlir] [MLIR][OpenMP] Simplify OpenMP device codegen (PR #137201)

https://github.com/ergawy approved this pull request. LGTM! Thanks Sergio and sorry for the very late review. Just 2 questions. https://github.com/llvm/llvm-project/pull/137201 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org htt

[llvm-branch-commits] [flang] [flang][OpenMP] Add symbol table scopes for `teams` and `parallel` (PR #144015)

https://github.com/ergawy created https://github.com/llvm/llvm-project/pull/144015 Adds symbol map scopes for standalone `teams` and `parallel` constructs. This is required to properly bind the privatized symbols in both constructs so that nested constructs can find them. Resolves https://git

[llvm-branch-commits] [flang] [flang][fir] Small clean-up in `fir_DoConcurrentLoopOp`'s defintion (PR #146028)

https://github.com/ergawy created https://github.com/llvm/llvm-project/pull/146028 Re-organizes the op definition a little bit and removes a method that does not add much value to the API. >From d9ca670ba85ea25660c2ba7a79961c73ee1de3a6 Mon Sep 17 00:00:00 2001 From: ergawy Date: Fri, 27 Jun 2

[llvm-branch-commits] [flang] [NFC][flang] Move `ReductionProcessor` to `Lower/Support`. (PR #146025)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/146025 >From 5073e7d31238dc441cf1a7e8f35f75d9c8b29f12 Mon Sep 17 00:00:00 2001 From: ergawy Date: Thu, 26 Jun 2025 23:30:04 -0500 Subject: [PATCH] [NFC][flang] Move `ReductionProcessor` to `Lower/Support`. With #145837

[llvm-branch-commits] [flang] [flang][OpenMP] Basic mapping of `do concurrent ... reduce` to OpenMP (PR #146033)

https://github.com/ergawy created https://github.com/llvm/llvm-project/pull/146033 Now that we have changes introduced by #145837, mapping reductions from `do concurrent` to OpenMP is almost trivial. This PR adds such mapping. TODO: Add tests >From b99122bb337d80d0d7958b6763e1337b3e5d9405 Mon

[llvm-branch-commits] [flang] [NFC][flang] Move `ReductionProcessor` to `Lower/Support`. (PR #146025)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/146025 >From 9021dbcf419e189f96e2d88f6db97c9d472dc2b9 Mon Sep 17 00:00:00 2001 From: ergawy Date: Thu, 26 Jun 2025 23:30:04 -0500 Subject: [PATCH] [NFC][flang] Move `ReductionProcessor` to `Lower/Support`. With #145837

[llvm-branch-commits] [flang] [flang][fir] Small clean-up in `fir_DoConcurrentLoopOp`'s defintion (PR #146028)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/146028 >From 5f665c949781fda9406e67c74c31217dba170a4c Mon Sep 17 00:00:00 2001 From: ergawy Date: Fri, 27 Jun 2025 00:05:42 -0500 Subject: [PATCH] [flang][fir] Small clean-up in `fir_DoConcurrentLoopOp`'s defintion Re

[llvm-branch-commits] [flang] [flang][OpenMP] Basic mapping of `do concurrent ... reduce` to OpenMP (PR #146033)

https://github.com/ergawy converted_to_draft https://github.com/llvm/llvm-project/pull/146033 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang] Enable delayed localization by default for `do concurrent` (PR #142567)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/142567 >From fd943c277c419105055caf92180f641550b747f3 Mon Sep 17 00:00:00 2001 From: ergawy Date: Tue, 3 Jun 2025 04:22:20 -0500 Subject: [PATCH] [flang] Enable delayed localization by default for `do concurrent` ---

[llvm-branch-commits] [flang] [flang][OpenMP] Map basic `local` specifiers to `private` clauses (PR #142735)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/142735 >From 62596cdddcbda71b2a1b306cedd8de238510b105 Mon Sep 17 00:00:00 2001 From: ergawy Date: Wed, 4 Jun 2025 00:54:37 -0500 Subject: [PATCH] [flang][OpenMP] Map basic `local` specifiers to `private` clauses Start

[llvm-branch-commits] [flang] [flang][OpenMP] Extend locality spec to OMP claues (`init` and `dealloc` regions) (PR #142795)

https://github.com/ergawy created https://github.com/llvm/llvm-project/pull/142795 Extends support for locality specifier to OpenMP translation by adding supprot for transling localizers that have `init` and `dealloc` regions. >From 7b331963134cafc47290a45a321e7a62ef8cfce7 Mon Sep 17 00:00:00

[llvm-branch-commits] [flang] [flang] Enable delayed localization by default for `do concurrent` (PR #142567)

https://github.com/ergawy created https://github.com/llvm/llvm-project/pull/142567 None >From 47ad6ccdc66e22552650bfa965caa16acbdf2bc4 Mon Sep 17 00:00:00 2001 From: ergawy Date: Tue, 3 Jun 2025 04:22:20 -0500 Subject: [PATCH] [flang] Enable delayed localization by default for `do concurrent`

[llvm-branch-commits] [flang] [flang] Enable delayed localization by default for `do concurrent` (PR #142567)

https://github.com/ergawy edited https://github.com/llvm/llvm-project/pull/142567 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][fir][OpenMP] Refactor privtization code into shared location (PR #141767)

https://github.com/ergawy created https://github.com/llvm/llvm-project/pull/141767 Refactors the utils needed to create privtization/locatization ops for both the fir and OpenMP dialects into a shared location isolating OpenMP stuff out of it as much as possible. >From 2524b27d5f8ab6c6df2c3a8

[llvm-branch-commits] [flang] [flang][fir][OpenMP] Refactor privtization code into shared location (PR #141767)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/141767 >From cfee9fea07cefc99c5b6b978eeb1755ad8cbfeed Mon Sep 17 00:00:00 2001 From: ergawy Date: Wed, 28 May 2025 06:18:33 -0500 Subject: [PATCH] [flang][fir][OpenMP] Refactor privtization code into shared location R

[llvm-branch-commits] [flang] [llvm] [flang][OpenMP] Map basic `local` specifiers to `private` clauses (PR #142735)

ergawy wrote: I don't know why these 9 commits were added! Weird. https://github.com/llvm/llvm-project/pull/142735 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi

[llvm-branch-commits] [flang] [flang][fir] Small clean-up in `fir_DoConcurrentLoopOp`'s defintion (PR #146028)

https://github.com/ergawy edited https://github.com/llvm/llvm-project/pull/146028 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [NFC][flang] Move `ReductionProcessor` to `Lower/Support`. (PR #146025)

https://github.com/ergawy edited https://github.com/llvm/llvm-project/pull/146025 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP] Basic mapping of `do concurrent ... reduce` to OpenMP (PR #146033)

https://github.com/ergawy edited https://github.com/llvm/llvm-project/pull/146033 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP] Basic mapping of `do concurrent ... reduce` to OpenMP (PR #146033)

https://github.com/ergawy ready_for_review https://github.com/llvm/llvm-project/pull/146033 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP] Basic mapping of `do concurrent ... reduce` to OpenMP (PR #146033)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/146033 >From c99a5025813a43c6984ad267d38d4d4b6b508ac7 Mon Sep 17 00:00:00 2001 From: ergawy Date: Fri, 27 Jun 2025 00:58:08 -0500 Subject: [PATCH] [flang][OpenMP] Basic mapping of `do concurrent ... reduce` to OpenMP

[llvm-branch-commits] [flang] [NFC][flang] Move `ReductionProcessor` to `Lower/Support`. (PR #146025)

https://github.com/ergawy edited https://github.com/llvm/llvm-project/pull/146025 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP] Move extractOmpDirective to Utils.cpp, NFC (PR #148653)

https://github.com/ergawy approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/148653 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP] Basic mapping of `do concurrent ... reduce` to OpenMP (PR #146033)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/146033 >From 40b783f0a3c558201fcefdc9f1f0e60013901a75 Mon Sep 17 00:00:00 2001 From: ergawy Date: Fri, 27 Jun 2025 00:58:08 -0500 Subject: [PATCH 1/2] [flang][OpenMP] Basic mapping of `do concurrent ... reduce` to Open

[llvm-branch-commits] [flang] [flang][fir] Small clean-up in `fir_DoConcurrentLoopOp`'s defintion (PR #146028)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/146028 >From 53f9c0dc052075d5fedc0d22893e816ca00785c8 Mon Sep 17 00:00:00 2001 From: ergawy Date: Fri, 27 Jun 2025 00:05:42 -0500 Subject: [PATCH] [flang][fir] Small clean-up in `fir_DoConcurrentLoopOp`'s defintion Re

[llvm-branch-commits] [flang] [NFC][flang] Move `ReductionProcessor` to `Lower/Support`. (PR #146025)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/146025 >From 062fab576aa99cae0d393dbea70bcce5d4ef8587 Mon Sep 17 00:00:00 2001 From: ergawy Date: Thu, 26 Jun 2025 23:30:04 -0500 Subject: [PATCH 1/2] [NFC][flang] Move `ReductionProcessor` to `Lower/Support`. With #1

[llvm-branch-commits] [flang] [flang][do concurrent] Extned `getAllocaBlock()` and emit yields correctly (PR #146853)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/146853 >From 9bdbb0ca514f5d13b893532c12a4480391bfbcfd Mon Sep 17 00:00:00 2001 From: ergawy Date: Thu, 3 Jul 2025 05:45:40 -0500 Subject: [PATCH] [flang][do concurrent] Extned `getAllocaBlock()` and emit yields correct

[llvm-branch-commits] [flang] [flang][fir] Small clean-up in `fir_DoConcurrentLoopOp`'s defintion (PR #146028)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/146028 >From 8e67de7800c02e7d93fadabc92a91618dda0d715 Mon Sep 17 00:00:00 2001 From: ergawy Date: Fri, 27 Jun 2025 00:05:42 -0500 Subject: [PATCH] [flang][fir] Small clean-up in `fir_DoConcurrentLoopOp`'s defintion Re

[llvm-branch-commits] [flang] [flang][do concurrent] Extned `getAllocaBlock()` and emit yields correctly (PR #146853)

https://github.com/ergawy created https://github.com/llvm/llvm-project/pull/146853 Handles some loose ends in `do concurrent` reduction declarations. This PR extends `getAllocaBlock` to handle declare ops, and also emit `fir.yield` in all regions. >From caabbde941c1c870a850d4ed85d1b81d5e5d075

[llvm-branch-commits] [flang] [flang][fir] Small clean-up in `fir_DoConcurrentLoopOp`'s defintion (PR #146028)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/146028 >From 15ed831ad72cf5d109278f01a693a8fd4a7e2793 Mon Sep 17 00:00:00 2001 From: ergawy Date: Fri, 27 Jun 2025 00:05:42 -0500 Subject: [PATCH] [flang][fir] Small clean-up in `fir_DoConcurrentLoopOp`'s defintion Re

[llvm-branch-commits] [flang] [flang][OpenMP] Basic mapping of `do concurrent ... reduce` to OpenMP (PR #146033)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/146033 >From ba0d0c89692622968db915fb89d70443d032cdf3 Mon Sep 17 00:00:00 2001 From: ergawy Date: Fri, 27 Jun 2025 00:58:08 -0500 Subject: [PATCH 1/2] [flang][OpenMP] Basic mapping of `do concurrent ... reduce` to Open

[llvm-branch-commits] [flang] [NFC][flang] Move `ReductionProcessor` to `Lower/Support`. (PR #146025)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/146025 >From db537f5fbb7d1f7c6c965262beef9682ccdcabf3 Mon Sep 17 00:00:00 2001 From: ergawy Date: Thu, 26 Jun 2025 23:30:04 -0500 Subject: [PATCH 1/2] [NFC][flang] Move `ReductionProcessor` to `Lower/Support`. With #1

[llvm-branch-commits] [flang] [flang][OpenMP] Basic mapping of `do concurrent ... reduce` to OpenMP (PR #146033)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/146033 >From f7837d52f95340e627852ebaa34407ac318156c5 Mon Sep 17 00:00:00 2001 From: ergawy Date: Fri, 27 Jun 2025 00:58:08 -0500 Subject: [PATCH 1/2] [flang][OpenMP] Basic mapping of `do concurrent ... reduce` to Open

[llvm-branch-commits] [flang] [flang][OpenMP] Basic mapping of `do concurrent ... reduce` to OpenMP (PR #146033)

ergawy wrote: > LGTM but please could you add a test that covers every region. Thanks for the review. Done. https://github.com/llvm/llvm-project/pull/146033 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org

[llvm-branch-commits] [flang] [flang][OpenMP] Basic mapping of `do concurrent ... reduce` to OpenMP (PR #146033)

https://github.com/ergawy edited https://github.com/llvm/llvm-project/pull/146033 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][fir] Small clean-up in `fir_DoConcurrentLoopOp`'s defintion (PR #146028)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/146028 >From 105ac7ade82ccfdfd0b33d30dc46c84a94df884b Mon Sep 17 00:00:00 2001 From: ergawy Date: Fri, 27 Jun 2025 00:05:42 -0500 Subject: [PATCH] [flang][fir] Small clean-up in `fir_DoConcurrentLoopOp`'s defintion Re

[llvm-branch-commits] [flang] [NFC][flang] Move `ReductionProcessor` to `Lower/Support`. (PR #146025)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/146025 >From 6a7c71ecaebccf4d8dddc7373384b4df918973c2 Mon Sep 17 00:00:00 2001 From: ergawy Date: Thu, 26 Jun 2025 23:30:04 -0500 Subject: [PATCH] [NFC][flang] Move `ReductionProcessor` to `Lower/Support`. With #145837

[llvm-branch-commits] [flang] [flang][OpenMP] Basic mapping of `do concurrent ... reduce` to OpenMP (PR #146033)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/146033 >From 34a5df1725f185ba91d9a41ab6286635537502dc Mon Sep 17 00:00:00 2001 From: ergawy Date: Fri, 27 Jun 2025 00:58:08 -0500 Subject: [PATCH] [flang][OpenMP] Basic mapping of `do concurrent ... reduce` to OpenMP

[llvm-branch-commits] [flang] [flang][fir] Small clean-up in `fir_DoConcurrentLoopOp`'s defintion (PR #146028)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/146028 >From 3e2bdf5a8d346f6817f86e98f098e3f6cc47e0b0 Mon Sep 17 00:00:00 2001 From: ergawy Date: Fri, 27 Jun 2025 00:05:42 -0500 Subject: [PATCH] [flang][fir] Small clean-up in `fir_DoConcurrentLoopOp`'s defintion Re

[llvm-branch-commits] [flang] [NFC][flang] Move `ReductionProcessor` to `Lower/Support`. (PR #146025)

https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/146025 >From 6a7c71ecaebccf4d8dddc7373384b4df918973c2 Mon Sep 17 00:00:00 2001 From: ergawy Date: Thu, 26 Jun 2025 23:30:04 -0500 Subject: [PATCH 1/2] [NFC][flang] Move `ReductionProcessor` to `Lower/Support`. With #1

[llvm-branch-commits] [flang] release/21.x: [flang][OpenMP] Restore reduction processor behavior broken by #145837 (#150178) (PR #150196)

ergawy wrote: I did not know about the backporting process, abandoning this pr to follow the process. https://github.com/llvm/llvm-project/pull/150196 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[llvm-branch-commits] [flang] release/21.x: [flang][OpenMP] Restore reduction processor behavior broken by #145837 (#150178) (PR #150196)

https://github.com/ergawy closed https://github.com/llvm/llvm-project/pull/150196 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] release/21.x: [flang][OpenMP] Restore reduction processor behavior broken by #145837 (#150178) (PR #150196)

https://github.com/ergawy created https://github.com/llvm/llvm-project/pull/150196 Backport 36c37b019b5daae79785e8558d693e6ec42b0ebd Requested by @tblah Fixes #149089 and #149700. Before #145837, when processing a reduction symbol not yet supported by OpenMP lowering, the reduction processor

[llvm-branch-commits] [flang] [flang] Skip processing reductions for unstructured `do concurrent` loops (PR #150188)

https://github.com/ergawy created https://github.com/llvm/llvm-project/pull/150188 Fixes #149563 When emitting unstructured `do concurrent` loops, reduction processing should be skipped since we are not emitting `fir.do_concurrent` loop in the first place. >From 72e6be536d6d71d63a4db35aec859

<    1   2   3   4   >