Prabhuk wrote:
This patch is squashed into #87574 PR. Closing this patch.
https://github.com/llvm/llvm-project/pull/87572
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branc
https://github.com/Prabhuk closed
https://github.com/llvm/llvm-project/pull/87572
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
ilovepi wrote:
Yeah, squashing those patches together is probably better. That way, the whole
thing goes in and comes out atomically.
https://github.com/llvm/llvm-project/pull/87572
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.
https://github.com/Prabhuk updated
https://github.com/llvm/llvm-project/pull/87572
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Prabhuk updated
https://github.com/llvm/llvm-project/pull/87572
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
Prabhuk wrote:
> I think this is mostly fine, but the patch currently only adds the LLVM flag
> without doing anything. Perhaps this should be higher up in the stack(or I’m
> looking at them in the wrong order?)?
>
> You may want to consider adding a test here to check that the option works.
https://github.com/Prabhuk updated
https://github.com/llvm/llvm-project/pull/87572
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Prabhuk updated
https://github.com/llvm/llvm-project/pull/87572
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
ilovepi wrote:
I think this is mostly fine, but the patch currently only adds the LLVM flag
without doing anything. Perhaps this should be higher up in the stack(or I’m
looking at them in the wrong order?)?
You may want to consider adding a test here to check that the option works. You
could
https://github.com/Prabhuk updated
https://github.com/llvm/llvm-project/pull/87572
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Prabhuk updated
https://github.com/llvm/llvm-project/pull/87572
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Prabhuk edited
https://github.com/llvm/llvm-project/pull/87572
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
12 matches
Mail list logo