[llvm-branch-commits] [llvm] AMDGPU: Delete spills of undef values (PR #119684)

arsenm wrote: ### Merge activity * **Dec 17, 12:51 AM EST**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/119684). https://github.com/llvm/llvm-project/pull/119684

[llvm-branch-commits] [llvm] AMDGPU: Delete spills of undef values (PR #119684)

@@ -54,3 +54,45 @@ body: | SI_SPILL_S64_SAVE renamable $sgpr4_sgpr5, %stack.0, implicit $exec, implicit $sgpr96_sgpr97_sgpr98_sgpr99, implicit $sgpr32 :: (store (s64) into %stack.0, align 4, addrspace 5) ... + +--- +name: sgpr_spill_s32_undef +tracksRegLiven

[llvm-branch-commits] [llvm] AMDGPU: Delete spills of undef values (PR #119684)

https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/119684 >From 69aa81bb9763c092605e9445f61657314f8c390d Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Mon, 28 Mar 2022 11:24:48 -0400 Subject: [PATCH 1/2] AMDGPU: Delete spills of undef values It would be a bit mor

[llvm-branch-commits] [llvm] AMDGPU: Delete spills of undef values (PR #119684)

@@ -54,3 +54,45 @@ body: | SI_SPILL_S64_SAVE renamable $sgpr4_sgpr5, %stack.0, implicit $exec, implicit $sgpr96_sgpr97_sgpr98_sgpr99, implicit $sgpr32 :: (store (s64) into %stack.0, align 4, addrspace 5) ... + +--- +name: sgpr_spill_s32_undef +tracksRegLiven

[llvm-branch-commits] [llvm] AMDGPU: Delete spills of undef values (PR #119684)

https://github.com/cdevadas approved this pull request. https://github.com/llvm/llvm-project/pull/119684 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] AMDGPU: Delete spills of undef values (PR #119684)

https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/119684 >From c56e320b410a50791b006dd75c48ff74c89a735d Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Mon, 28 Mar 2022 11:24:48 -0400 Subject: [PATCH 1/2] AMDGPU: Delete spills of undef values It would be a bit mor

[llvm-branch-commits] [llvm] AMDGPU: Delete spills of undef values (PR #119684)

arsenm wrote: > Currently, regalloc won't do subreg spilling. But it will be fixed in the > foreseeable future. What will happen if you write a test that spills the > `undef` subreg of a tuple? Do you want to cover it anyway? There's no change in interpretation of an undef use with subregister

[llvm-branch-commits] [llvm] AMDGPU: Delete spills of undef values (PR #119684)

cdevadas wrote: Currently, regalloc won't do subreg spilling. But it will be fixed in the foreseeable future. What will happen if you write a test that spills the `undef` subreg of a tuple? Do you want to cover it anyway? https://github.com/llvm/llvm-project/pull/119684 ___

[llvm-branch-commits] [llvm] AMDGPU: Delete spills of undef values (PR #119684)

https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/119684 >From 3db8f1e5c89a19bf289d6745bca910f220c51dd4 Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Mon, 28 Mar 2022 11:24:48 -0400 Subject: [PATCH 1/2] AMDGPU: Delete spills of undef values It would be a bit mor

[llvm-branch-commits] [llvm] AMDGPU: Delete spills of undef values (PR #119684)

https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/119684 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] AMDGPU: Delete spills of undef values (PR #119684)

https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/119684 >From 03cca4cf3b65cb6988db7a983f3c3349fa0b390a Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Mon, 28 Mar 2022 14:11:28 -0400 Subject: [PATCH 1/3] [Statepoint] Treat undef operands less specially This rever

[llvm-branch-commits] [llvm] AMDGPU: Delete spills of undef values (PR #119684)

github-actions[bot] wrote: :warning: undef deprecator found issues in your code. :warning: You can test this locally with the following command: ``bash git diff -U0 --pickaxe-regex -S '([^a-zA-Z0-9#_-]undef[^a-zA-Z0-9_-]|UndefValue::get)' 21a94e80ec529fac5a23febcdf738f01c56d0100

[llvm-branch-commits] [llvm] AMDGPU: Delete spills of undef values (PR #119684)

llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Matt Arsenault (arsenm) Changes AMDGPU: Delete spills of undef values It would be a bit more logical to preserve the undef and do the normal expansion, but this is less work. This avoids verifier errors in a future patch which sta

[llvm-branch-commits] [llvm] AMDGPU: Delete spills of undef values (PR #119684)

arsenm wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/119684?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [llvm] AMDGPU: Delete spills of undef values (PR #119684)

https://github.com/arsenm ready_for_review https://github.com/llvm/llvm-project/pull/119684 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] AMDGPU: Delete spills of undef values (PR #119684)

https://github.com/arsenm created https://github.com/llvm/llvm-project/pull/119684 AMDGPU: Delete spills of undef values It would be a bit more logical to preserve the undef and do the normal expansion, but this is less work. This avoids verifier errors in a future patch which starts deleting l