[llvm-branch-commits] [llvm] [NFC] Use unique_ptr in SparseSet (PR #116617)

optimisan wrote: ### Merge activity * **Nov 22, 6:17 AM EST**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/116617). https://github.com/llvm/llvm-project/pull/116617 __

[llvm-branch-commits] [llvm] [NFC] Use unique_ptr in SparseSet (PR #116617)

https://github.com/optimisan updated https://github.com/llvm/llvm-project/pull/116617 >From 69c604aacd3a71b3559dbc96721eef2ef06200f7 Mon Sep 17 00:00:00 2001 From: Akshat Oke Date: Mon, 18 Nov 2024 10:15:19 + Subject: [PATCH 1/2] [NFC] Use unique_ptr in SparseSet This allows implementing t

[llvm-branch-commits] [llvm] [NFC] Use unique_ptr in SparseSet (PR #116617)

https://github.com/optimisan updated https://github.com/llvm/llvm-project/pull/116617 >From 6ef46d12e2238a470140a0bfba100174415fbc9d Mon Sep 17 00:00:00 2001 From: Akshat Oke Date: Mon, 18 Nov 2024 10:15:19 + Subject: [PATCH 1/2] [NFC] Use unique_ptr in SparseSet This allows implementing t

[llvm-branch-commits] [llvm] [NFC] Use unique_ptr in SparseSet (PR #116617)

https://github.com/dwblaikie approved this pull request. LGTM - thanks! https://github.com/llvm/llvm-project/pull/116617 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch

[llvm-branch-commits] [llvm] [NFC] Use unique_ptr in SparseSet (PR #116617)

dwblaikie wrote: Oh, and please add unit test coverage for the new move functionality. https://github.com/llvm/llvm-project/pull/116617 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[llvm-branch-commits] [llvm] [NFC] Use unique_ptr in SparseSet (PR #116617)

@@ -205,7 +209,7 @@ class SparseSet { assert(Idx < Universe && "Key out of range"); assert(Sparse != nullptr && "Invalid sparse type"); const unsigned Stride = std::numeric_limits::max() + 1u; -for (unsigned i = Sparse[Idx], e = size(); i < e; i += Stride) { +

[llvm-branch-commits] [llvm] [NFC] Use unique_ptr in SparseSet (PR #116617)

https://github.com/optimisan created https://github.com/llvm/llvm-project/pull/116617 This allows implementing the move constructor. >From 8a5db30a3841b88ccac2c781d933eeb45560fdfa Mon Sep 17 00:00:00 2001 From: Akshat Oke Date: Mon, 18 Nov 2024 10:15:19 + Subject: [PATCH] [NFC] Use unique_

[llvm-branch-commits] [llvm] [NFC] Use unique_ptr in SparseSet (PR #116617)

llvmbot wrote: @llvm/pr-subscribers-llvm-adt Author: Akshat Oke (optimisan) Changes This allows implementing the move constructor. --- Full diff: https://github.com/llvm/llvm-project/pull/116617.diff 1 Files Affected: - (modified) llvm/include/llvm/ADT/SparseSet.h (+11-7) ``

[llvm-branch-commits] [llvm] [NFC] Use unique_ptr in SparseSet (PR #116617)

https://github.com/optimisan ready_for_review https://github.com/llvm/llvm-project/pull/116617 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [NFC] Use unique_ptr in SparseSet (PR #116617)

optimisan wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/116617?utm_source=stack-comment-downstack-mergeability-warning