[llvm-branch-commits] [clang] [KeyInstr] Complex assignment atoms (PR #134638)

2025-05-22 Thread Orlando Cazalet-Hyams via llvm-branch-commits
@@ -1356,6 +1361,7 @@ LValue ComplexExprEmitter::EmitBinAssignLValue(const BinaryOperator *E, } ComplexPairTy ComplexExprEmitter::VisitBinAssign(const BinaryOperator *E) { + ApplyAtomGroup Grp(CGF.getDebugInfo()); ComplexPairTy Val; LValue LV = EmitBinAssignLValue(E, V

[llvm-branch-commits] [clang] [KeyInstr] Complex assignment atoms (PR #134638)

2025-05-22 Thread Orlando Cazalet-Hyams via llvm-branch-commits
@@ -1209,6 +1213,7 @@ LValue ComplexExprEmitter:: EmitCompoundAssignLValue(const CompoundAssignOperator *E, ComplexPairTy (ComplexExprEmitter::*Func)(const BinOpInfo&), RValue &Val) { + ApplyAtomGroup Grp(CGF.getDebugInfo());

[llvm-branch-commits] [clang] [KeyInstr] Complex assignment atoms (PR #134638)

2025-05-21 Thread Jeremy Morse via llvm-branch-commits
https://github.com/jmorse commented: Looks good overall but I have some minor comments about symmetry with other patches https://github.com/llvm/llvm-project/pull/134638 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://l

[llvm-branch-commits] [clang] [KeyInstr] Complex assignment atoms (PR #134638)

2025-05-21 Thread Jeremy Morse via llvm-branch-commits
https://github.com/jmorse edited https://github.com/llvm/llvm-project/pull/134638 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [KeyInstr] Complex assignment atoms (PR #134638)

2025-05-21 Thread Jeremy Morse via llvm-branch-commits
@@ -1356,6 +1361,7 @@ LValue ComplexExprEmitter::EmitBinAssignLValue(const BinaryOperator *E, } ComplexPairTy ComplexExprEmitter::VisitBinAssign(const BinaryOperator *E) { + ApplyAtomGroup Grp(CGF.getDebugInfo()); ComplexPairTy Val; LValue LV = EmitBinAssignLValue(E, V

[llvm-branch-commits] [clang] [KeyInstr] Complex assignment atoms (PR #134638)

2025-05-21 Thread Jeremy Morse via llvm-branch-commits
@@ -1209,6 +1213,7 @@ LValue ComplexExprEmitter:: EmitCompoundAssignLValue(const CompoundAssignOperator *E, ComplexPairTy (ComplexExprEmitter::*Func)(const BinOpInfo&), RValue &Val) { + ApplyAtomGroup Grp(CGF.getDebugInfo());

[llvm-branch-commits] [clang] [KeyInstr] Complex assignment atoms (PR #134638)

2025-05-21 Thread Orlando Cazalet-Hyams via llvm-branch-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134638 >From fd282a63fd709cdcdcdc2dacef58144dbf9b15c1 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 13:36:59 +0100 Subject: [PATCH 1/3] [KeyInstr] Complex assignment atoms This patch is pa

[llvm-branch-commits] [clang] [KeyInstr] Complex assignment atoms (PR #134638)

2025-05-21 Thread Orlando Cazalet-Hyams via llvm-branch-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134638 >From fd282a63fd709cdcdcdc2dacef58144dbf9b15c1 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 13:36:59 +0100 Subject: [PATCH 1/2] [KeyInstr] Complex assignment atoms This patch is pa

[llvm-branch-commits] [clang] [KeyInstr] Complex assignment atoms (PR #134638)

2025-05-21 Thread Orlando Cazalet-Hyams via llvm-branch-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134638 >From fd282a63fd709cdcdcdc2dacef58144dbf9b15c1 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 13:36:59 +0100 Subject: [PATCH] [KeyInstr] Complex assignment atoms This patch is part o

[llvm-branch-commits] [clang] [KeyInstr] Complex assignment atoms (PR #134638)

2025-04-07 Thread Orlando Cazalet-Hyams via llvm-branch-commits
OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134638?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr] Complex assignment atoms (PR #134638)

2025-04-07 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Orlando Cazalet-Hyams (OCHyams) Changes This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" section at the to

[llvm-branch-commits] [clang] [KeyInstr] Complex assignment atoms (PR #134638)

2025-04-07 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Orlando Cazalet-Hyams (OCHyams) Changes This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" section at the top which

[llvm-branch-commits] [clang] [KeyInstr] Complex assignment atoms (PR #134638)

2025-04-07 Thread Orlando Cazalet-Hyams via llvm-branch-commits
https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134638 This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" section at the top which adds context