[llvm-branch-commits] [clang] [KeyInstr][Clang] While stmt atom (PR #134645)

2025-05-22 Thread Jeremy Morse via llvm-branch-commits
https://github.com/jmorse approved this pull request. LGTM with nits https://github.com/llvm/llvm-project/pull/134645 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-co

[llvm-branch-commits] [clang] [KeyInstr][Clang] While stmt atom (PR #134645)

2025-05-22 Thread Jeremy Morse via llvm-branch-commits
https://github.com/jmorse edited https://github.com/llvm/llvm-project/pull/134645 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [KeyInstr][Clang] While stmt atom (PR #134645)

2025-05-22 Thread Jeremy Morse via llvm-branch-commits
@@ -0,0 +1,34 @@ +// RUN: %clang_cc1 -gkey-instructions -x c++ -std=c++17 %s -debug-info-kind=line-tables-only -emit-llvm -o - \ +// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not atomRank + +// RUN: %clang_cc1 -gkey-instructions -x c %s -debug-info-kin

[llvm-branch-commits] [clang] [KeyInstr][Clang] While stmt atom (PR #134645)

2025-05-22 Thread Jeremy Morse via llvm-branch-commits
@@ -0,0 +1,34 @@ +// RUN: %clang_cc1 -gkey-instructions -x c++ -std=c++17 %s -debug-info-kind=line-tables-only -emit-llvm -o - \ +// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not atomRank + +// RUN: %clang_cc1 -gkey-instructions -x c %s -debug-info-kin

[llvm-branch-commits] [clang] [KeyInstr][Clang] While stmt atom (PR #134645)

2025-05-22 Thread Jeremy Morse via llvm-branch-commits
@@ -1130,7 +1130,14 @@ void CodeGenFunction::EmitWhileStmt(const WhileStmt &S, if (!Weights && CGM.getCodeGenOpts().OptimizationLevel) BoolCondVal = emitCondLikelihoodViaExpectIntrinsic( BoolCondVal, Stmt::getLikelihood(S.getBody())); -Builder.CreateCond

[llvm-branch-commits] [clang] [KeyInstr][Clang] While stmt atom (PR #134645)

2025-05-21 Thread Orlando Cazalet-Hyams via llvm-branch-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134645 >From e3c271ebbf4792bf684acef2af8fbc9df9a9b596 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 18:49:32 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] While stmt atom See test comment f

[llvm-branch-commits] [clang] [KeyInstr][Clang] While stmt atom (PR #134645)

2025-04-10 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Orlando Cazalet-Hyams (OCHyams) Changes See test comment for possible future improvement. This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, in

[llvm-branch-commits] [clang] [KeyInstr][Clang] While stmt atom (PR #134645)

2025-04-10 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Orlando Cazalet-Hyams (OCHyams) Changes See test comment for possible future improvement. This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introd

[llvm-branch-commits] [clang] [KeyInstr][Clang] While stmt atom (PR #134645)

2025-04-07 Thread Orlando Cazalet-Hyams via llvm-branch-commits
https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134645 See test comment for possible future improvement. This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "q

[llvm-branch-commits] [clang] [KeyInstr][Clang] While stmt atom (PR #134645)

2025-04-07 Thread Orlando Cazalet-Hyams via llvm-branch-commits
OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134645?utm_source=stack-comment-downstack-mergeability-warning";