[llvm-branch-commits] [clang] [KeyInstr][Clang] Scalar init atom (PR #134633)

2025-05-21 Thread Jeremy Morse via llvm-branch-commits
https://github.com/jmorse approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/134633 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [KeyInstr][Clang] Scalar init atom (PR #134633)

2025-05-21 Thread Orlando Cazalet-Hyams via llvm-branch-commits
OCHyams wrote: > Looks good with a test tweak and question. My understanding of what's going > on here is that: > > * Assignment-expressions that store a scalar to memory are added to the > "current" source atom, > * For source constructs that haven't been instrumented yet, that's > potential

[llvm-branch-commits] [clang] [KeyInstr][Clang] Scalar init atom (PR #134633)

2025-05-21 Thread Orlando Cazalet-Hyams via llvm-branch-commits
@@ -0,0 +1,19 @@ +// RUN: %clang -gkey-instructions -x c++ %s -gmlt -gcolumn-info -S -emit-llvm -o - \ +// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not atomRank + +// RUN: %clang -gkey-instructions -x c %s -gmlt -gcolumn-info -S -emit-llvm -o - \ +//

[llvm-branch-commits] [clang] [KeyInstr][Clang] Scalar init atom (PR #134633)

2025-05-21 Thread Orlando Cazalet-Hyams via llvm-branch-commits
@@ -0,0 +1,19 @@ +// RUN: %clang -gkey-instructions -x c++ %s -gmlt -gcolumn-info -S -emit-llvm -o - \ +// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not atomRank + +// RUN: %clang -gkey-instructions -x c %s -gmlt -gcolumn-info -S -emit-llvm -o - \ +//

[llvm-branch-commits] [clang] [KeyInstr][Clang] Scalar init atom (PR #134633)

2025-05-21 Thread Orlando Cazalet-Hyams via llvm-branch-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134633 >From 8534d6e34772867640665bfa3ad3547babd1a12d Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Tue, 1 Apr 2025 14:50:41 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] Scalar init atom This patch is par

[llvm-branch-commits] [clang] [KeyInstr][Clang] Scalar init atom (PR #134633)

2025-04-07 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Orlando Cazalet-Hyams (OCHyams) Changes This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" section at the top which

[llvm-branch-commits] [clang] [KeyInstr][Clang] Scalar init atom (PR #134633)

2025-04-07 Thread Orlando Cazalet-Hyams via llvm-branch-commits
OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134633?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr][Clang] Scalar init atom (PR #134633)

2025-04-07 Thread Orlando Cazalet-Hyams via llvm-branch-commits
https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134633 This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" section at the top which adds context