https://github.com/shawbyoung edited
https://github.com/llvm/llvm-project/pull/97502
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -73,13 +73,26 @@ class YAMLProfileReader : public ProfileReaderBase {
bool parseFunctionProfile(BinaryFunction &Function,
const yaml::bolt::BinaryFunctionProfile &YamlBF);
+ /// Returns block cnt equality if IgnoreHash is true, otherwise, hash
dcci wrote:
> I have a couple of general comments about this. Can you also please add a
> description explaining what this patch does?
i.e. why we're refactoring these functions.
https://github.com/llvm/llvm-project/pull/97502
___
llvm-branch-commits
https://github.com/dcci edited https://github.com/llvm/llvm-project/pull/97502
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/dcci commented:
I have a couple of general comments about this.
Can you also please add a description explaining what this patch does?
https://github.com/llvm/llvm-project/pull/97502
___
llvm-branch-commits mailing list
llvm-branch-c
@@ -73,13 +73,26 @@ class YAMLProfileReader : public ProfileReaderBase {
bool parseFunctionProfile(BinaryFunction &Function,
const yaml::bolt::BinaryFunctionProfile &YamlBF);
+ /// Returns block cnt equality if IgnoreHash is true, otherwise, hash
@@ -73,13 +73,26 @@ class YAMLProfileReader : public ProfileReaderBase {
bool parseFunctionProfile(BinaryFunction &Function,
const yaml::bolt::BinaryFunctionProfile &YamlBF);
+ /// Returns block cnt equality if IgnoreHash is true, otherwise, hash
llvmbot wrote:
@llvm/pr-subscribers-bolt
Author: Shaw Young (shawbyoung)
Changes
Moved function matching techniques into separate helper functions.
---
Full diff: https://github.com/llvm/llvm-project/pull/97502.diff
2 Files Affected:
- (modified) bolt/include/bolt/Profile/YAMLProfileRe
https://github.com/shawbyoung ready_for_review
https://github.com/llvm/llvm-project/pull/97502
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/shawbyoung edited
https://github.com/llvm/llvm-project/pull/97502
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/shawbyoung created
https://github.com/llvm/llvm-project/pull/97502
Moved function matching techniques into separate helper functions.
Test Plan: n/a
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://
11 matches
Mail list logo
