https://github.com/nocchijiang approved this pull request.
https://github.com/llvm/llvm-project/pull/115750
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
nocchijiang wrote:
> I suspect that the no-LTO case might still encounter some slowdown, as each
> CU needs to read the entire CGData regardless.
I can confirm that the performance have been improved significantly from my
testing on no-LTO projects that the slowdown is acceptable now. Before a
nocchijiang wrote:
Hit an assertion in `ignoreOp` when testing the refactored code.
```
Assertion failed: (OpIdx < I->getNumOperands() && "Invalid operand index"),
function ignoreOp, file GlobalMergeFunctions.cpp, line 129.
Stop reason: hit program assert
expr I->dump()
%6 = tail call ptr @ob
@@ -420,101 +412,79 @@ static ParamLocsVecTy computeParamInfo(
bool GlobalMergeFunc::merge(Module &M, const StableFunctionMap *FunctionMap) {
bool Changed = false;
- // Build a map from stable function name to function.
- StringMap StableNameToFuncMap;
- for (auto &F : M)
https://github.com/nocchijiang edited
https://github.com/llvm/llvm-project/pull/115750
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -420,101 +412,79 @@ static ParamLocsVecTy computeParamInfo(
bool GlobalMergeFunc::merge(Module &M, const StableFunctionMap *FunctionMap) {
bool Changed = false;
- // Build a map from stable function name to function.
- StringMap StableNameToFuncMap;
- for (auto &F : M)
https://github.com/nocchijiang commented:
This refactoring makes much more sense to me than the previous implementation.
https://github.com/llvm/llvm-project/pull/115750
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://li
@@ -420,101 +412,79 @@ static ParamLocsVecTy computeParamInfo(
bool GlobalMergeFunc::merge(Module &M, const StableFunctionMap *FunctionMap) {
bool Changed = false;
- // Build a map from stable function name to function.
- StringMap StableNameToFuncMap;
- for (auto &F : M)
@@ -420,101 +412,79 @@ static ParamLocsVecTy computeParamInfo(
bool GlobalMergeFunc::merge(Module &M, const StableFunctionMap *FunctionMap) {
bool Changed = false;
- // Build a map from stable function name to function.
- StringMap StableNameToFuncMap;
- for (auto &F : M)
