OCHyams wrote:
> The original commit seems to have failed a bunch of runners. Can we check if
> that needs to be fixed before a backport?
Just had a look through the 11 fails - as far as I can tell none of them are
related to this change. There's still two pending builds
(`libc-riscv64-debian
OCHyams wrote:
Landed in 8e50e882a847a8fd51ee8ec22fea5df192b14c06
https://github.com/llvm/llvm-project/pull/141618
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-comm
OCHyams wrote:
Nope that didn't seem to work. I'll land it manually...
> will destructors that run when "break"ing out of a loop get the key-ness of
> the "break" statement? (This might not be a bad thing at all).
Similar answer to elsewhere - calls aren't annotated by the front end, instead
OCHyams wrote:
I didn't close this, GitHub did (because I merged the base branch? for others
that resulted in rebasing dependant branches on main... I don't understand why
this one was different). I don't seem to be able to reopen it or convert it to
a draft since the base branch no longer exi
https://github.com/OCHyams closed
https://github.com/llvm/llvm-project/pull/141618
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/141618
>From c0c96232ad8a1a3342728590f975e0310362f1cf Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Tue, 27 May 2025 15:54:34 +0100
Subject: [PATCH 1/2] continue
---
clang/lib/CodeGen/CGCleanup.cpp
https://github.com/OCHyams converted_to_draft
https://github.com/llvm/llvm-project/pull/134653
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/OCHyams created
https://github.com/llvm/llvm-project/pull/141618
Based on top of https://github.com/llvm/llvm-project/pull/134646
This patch is part of a stack that teaches Clang to generate Key Instructions
metadata for C and C++.
RFC:
https://discourse.llvm.org/t/rfc-impro
https://github.com/OCHyams ready_for_review
https://github.com/llvm/llvm-project/pull/134650
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
OCHyams wrote:
Keeping in draft till the patches below this in the stack are merged, as this
touches all their tests. Unfortunately the diff is going to be messed up till
then too due to various branch retargeting and rebasing.
https://github.com/llvm/llvm-project/pull/134652
_
https://github.com/OCHyams converted_to_draft
https://github.com/llvm/llvm-project/pull/134652
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/OCHyams converted_to_draft
https://github.com/llvm/llvm-project/pull/134651
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134650
>From 0e2df471a1a9d1009086167b3dfe14af9a7a43af Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 22:05:32 +0100
Subject: [PATCH 1/2] [KeyInstr][Clang] Assign matrix element atom
This pa
https://github.com/OCHyams converted_to_draft
https://github.com/llvm/llvm-project/pull/134650
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/OCHyams converted_to_draft
https://github.com/llvm/llvm-project/pull/134649
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134649
>From ee7ef1b588e08991f141dcef31f2c3133311f654 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 21:56:37 +0100
Subject: [PATCH] [KeyInstr][Clang] Assign vector element atom
This patch
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134648
>From 76d8a4306760fba28fc22c936b46d98263c37971 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 19:57:39 +0100
Subject: [PATCH 1/2] [KeyInstr][Clang] Bitfield atom
This patch is part o
https://github.com/OCHyams converted_to_draft
https://github.com/llvm/llvm-project/pull/134648
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134647
>From d99a29e180b29f9bce7d6e3172d4241e3f0cba56 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 19:46:01 +0100
Subject: [PATCH 1/2] [KeyInstr][Clang] For range stmt atoms
This patch is
https://github.com/OCHyams converted_to_draft
https://github.com/llvm/llvm-project/pull/134647
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
OCHyams wrote:
Excellent, I mistakenly merged this into users/OCHyams/ki-clang-catch-init
rather than main. **Merged in 123bf5f46c31a016768b7ecd9b164bde5ef881d9**
https://github.com/llvm/llvm-project/pull/134642
___
llvm-branch-commits mailing list
l
https://github.com/OCHyams converted_to_draft
https://github.com/llvm/llvm-project/pull/134644
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/OCHyams converted_to_draft
https://github.com/llvm/llvm-project/pull/134643
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/OCHyams edited
https://github.com/llvm/llvm-project/pull/134643
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/OCHyams closed
https://github.com/llvm/llvm-project/pull/134642
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -0,0 +1,51 @@
+// RUN: %clang_cc1 -gkey-instructions -x c++ -std=c++17 %s
-debug-info-kind=line-tables-only -emit-llvm -o - \
+// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not
atomRank --check-prefixes=CHECK,CHECK-CXX
+
+// RUN: %clang_cc1 -gkey-inst
@@ -0,0 +1,51 @@
+// RUN: %clang_cc1 -gkey-instructions -x c++ -std=c++17 %s
-debug-info-kind=line-tables-only -emit-llvm -o - \
+// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not
atomRank --check-prefixes=CHECK,CHECK-CXX
+
+// RUN: %clang_cc1 -gkey-inst
@@ -1356,6 +1361,7 @@ LValue ComplexExprEmitter::EmitBinAssignLValue(const
BinaryOperator *E,
}
ComplexPairTy ComplexExprEmitter::VisitBinAssign(const BinaryOperator *E) {
+ ApplyAtomGroup Grp(CGF.getDebugInfo());
ComplexPairTy Val;
LValue LV = EmitBinAssignLValue(E, V
@@ -1209,6 +1213,7 @@ LValue ComplexExprEmitter::
EmitCompoundAssignLValue(const CompoundAssignOperator *E,
ComplexPairTy (ComplexExprEmitter::*Func)(const BinOpInfo&),
RValue &Val) {
+ ApplyAtomGroup Grp(CGF.getDebugInfo());
OCHyams wrote:
Thanks @jmorse, that should be all nits/questions addressed now.
https://github.com/llvm/llvm-project/pull/134637
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llv
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134637
>From 3b4ca1b09a659e575e022109fd8c607c9df3864f Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Wed, 2 Apr 2025 18:01:48 +0100
Subject: [PATCH 01/12] [KeyInstr][Clang] Assignment atom group
This patch
@@ -5849,6 +5852,7 @@ LValue CodeGenFunction::EmitObjCIsaExpr(const ObjCIsaExpr
*E) {
LValue CodeGenFunction::EmitCompoundAssignmentLValue(
const CompoundAssignOperator *E) {
+ ApplyAtomGroup Grp(getDebugInfo());
O
@@ -0,0 +1,41 @@
+
+// RUN: %clang -gkey-instructions -x c++ %s -gmlt -gno-column-info -S
-emit-llvm -o - -ftrivial-auto-var-init=pattern \
+// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not
atomRank
+
+// RUN: %clang -gkey-instructions -x c %s -gmlt -gn
@@ -5985,6 +5985,15 @@ LValue CodeGenFunction::EmitBinaryOperatorLValue(const
BinaryOperator *E) {
OCHyams wrote:
Yeah that's right - added to the test for better coverage.
https://github.com/llvm/llvm-project/pull/134637
_
@@ -0,0 +1,34 @@
+// RUN: %clang_cc1 -gkey-instructions -x c++ %s
-debug-info-kind=line-tables-only -emit-llvm -o - \
+// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not
atomRank
+
+// RUN: %clang_cc1 -gkey-instructions -x c %s
-debug-info-kind=line-tabl
@@ -0,0 +1,41 @@
+
+// RUN: %clang -gkey-instructions -x c++ %s -gmlt -gno-column-info -S
-emit-llvm -o - -ftrivial-auto-var-init=pattern \
+// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not
atomRank
+
+// RUN: %clang -gkey-instructions -x c %s -gmlt -gn
@@ -0,0 +1,48 @@
+// RUN: %clang_cc1 -gkey-instructions -x c++ %s
-debug-info-kind=line-tables-only -emit-llvm -o - \
+// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not
atomRank
OCHyams wrote:
Done
https://github.com/llvm/llvm-project/
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134637
>From 3b4ca1b09a659e575e022109fd8c607c9df3864f Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Wed, 2 Apr 2025 18:01:48 +0100
Subject: [PATCH 01/11] [KeyInstr][Clang] Assignment atom group
This patch
@@ -5985,6 +5985,15 @@ LValue CodeGenFunction::EmitBinaryOperatorLValue(const
BinaryOperator *E) {
assert(E->getOpcode() == BO_Assign && "unexpected binary l-value");
+ // This covers both LHS and RHS expressions, though nested RHS
+ // expressions may get subsequently s
@@ -5985,6 +5985,15 @@ LValue CodeGenFunction::EmitBinaryOperatorLValue(const
BinaryOperator *E) {
assert(E->getOpcode() == BO_Assign && "unexpected binary l-value");
+ // This covers both LHS and RHS expressions, though nested RHS
+ // expressions may get subsequently s
https://github.com/OCHyams edited
https://github.com/llvm/llvm-project/pull/134635
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134654
>From 36537a2ede8874fd806d408b186ea33a7d4e1423 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Mon, 7 Apr 2025 12:18:48 +0100
Subject: [PATCH 1/2] [NFC][KeyInstr][Clang] Add some additional tests
Thi
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134653
>From 5725d90b6828e1aa9822f3a8af4e45a613480f74 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Mon, 7 Apr 2025 08:59:09 +0100
Subject: [PATCH 1/6] [KeyInstr][Clang] Coerced store atoms
This patch is
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134652
>From 9bfc7f9adab19ce5b8353f0b569a852b1e48c68a Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Fri, 4 Apr 2025 16:28:39 +0100
Subject: [PATCH 1/4] [KeyInstr][Clang] Ret atom
This patch is part of a s
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134649
>From 7c2a67e1b6be8f8431a87f72446d150a81e23ffd Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 21:56:37 +0100
Subject: [PATCH] [KeyInstr][Clang] Assign vector element atom
This patch
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134651
>From f3ee6148da5339e55d12250484cf9fb5dd8a6487 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Fri, 4 Apr 2025 14:36:43 +0100
Subject: [PATCH 1/2] [KeyInstr][Clang] Store-like builtin atoms
---
clan
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134650
>From 1838e5455d7d1d83cfa00c16b00e11aa3f6128de Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 22:05:32 +0100
Subject: [PATCH 1/2] [KeyInstr][Clang] Assign matrix element atom
This pa
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134648
>From ac74a71ca01d949c3f45a3661f1db68139a54a80 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 19:57:39 +0100
Subject: [PATCH 1/2] [KeyInstr][Clang] Bitfield atom
This patch is part o
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134648
>From ac74a71ca01d949c3f45a3661f1db68139a54a80 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 19:57:39 +0100
Subject: [PATCH] [KeyInstr][Clang] Bitfield atom
This patch is part of a
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134647
>From 240476a6bcc82d37825aeea626fccf58590495a8 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 19:46:01 +0100
Subject: [PATCH 1/2] [KeyInstr][Clang] For range stmt atoms
This patch is
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134646
>From c4b2db1f76d59927fd54bf7901d6cdadf99ec77a Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 19:12:47 +0100
Subject: [PATCH 1/2] [KeyInstr][Clang] For stmt atom
This patch is part o
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134646
>From c4b2db1f76d59927fd54bf7901d6cdadf99ec77a Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 19:12:47 +0100
Subject: [PATCH] [KeyInstr][Clang] For stmt atom
This patch is part of a
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134645
>From e3c271ebbf4792bf684acef2af8fbc9df9a9b596 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 18:49:32 +0100
Subject: [PATCH 1/2] [KeyInstr][Clang] While stmt atom
See test comment f
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134640
>From 2fc4653e3e2bd825114b8081df06696c0f2b6b43 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 17:00:09 +0100
Subject: [PATCH 1/2] [KeyInstr][Clang] Member initalization atom
This pat
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134639
>From 46ccd7a165bde6ad72f785551bf57cc7fb590378 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 15:15:39 +0100
Subject: [PATCH 1/4] [KeyInstr][Clang] Aggregate init + copy
This patch i
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134638
>From fd282a63fd709cdcdcdc2dacef58144dbf9b15c1 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 13:36:59 +0100
Subject: [PATCH 1/3] [KeyInstr] Complex assignment atoms
This patch is pa
https://github.com/OCHyams edited
https://github.com/llvm/llvm-project/pull/134637
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134638
>From fd282a63fd709cdcdcdc2dacef58144dbf9b15c1 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 13:36:59 +0100
Subject: [PATCH 1/2] [KeyInstr] Complex assignment atoms
This patch is pa
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134638
>From fd282a63fd709cdcdcdc2dacef58144dbf9b15c1 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Thu, 3 Apr 2025 13:36:59 +0100
Subject: [PATCH] [KeyInstr] Complex assignment atoms
This patch is part o
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134637
>From 3b4ca1b09a659e575e022109fd8c607c9df3864f Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Wed, 2 Apr 2025 18:01:48 +0100
Subject: [PATCH 1/6] [KeyInstr][Clang] Assignment atom group
This patch i
OCHyams wrote:
> Looks good with a test tweak and question. My understanding of what's going
> on here is that:
>
> * Assignment-expressions that store a scalar to memory are added to the
> "current" source atom,
> * For source constructs that haven't been instrumented yet, that's
> potential
@@ -0,0 +1,19 @@
+// RUN: %clang -gkey-instructions -x c++ %s -gmlt -gcolumn-info -S -emit-llvm
-o - \
+// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not
atomRank
+
+// RUN: %clang -gkey-instructions -x c %s -gmlt -gcolumn-info -S -emit-llvm -o
- \
+//
@@ -0,0 +1,19 @@
+// RUN: %clang -gkey-instructions -x c++ %s -gmlt -gcolumn-info -S -emit-llvm
-o - \
+// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not
atomRank
+
+// RUN: %clang -gkey-instructions -x c %s -gmlt -gcolumn-info -S -emit-llvm -o
- \
+//
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134633
>From 8534d6e34772867640665bfa3ad3547babd1a12d Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Tue, 1 Apr 2025 14:50:41 +0100
Subject: [PATCH 1/2] [KeyInstr][Clang] Scalar init atom
This patch is par
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/134632
>From 0544aed12dd76bd64c42ce186c586702d3e01589 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Tue, 1 Apr 2025 11:59:24 +0100
Subject: [PATCH] [KeyInstr][Clang] Add ApplyAtomGroup
This is a scoped he
OCHyams wrote:
> This all seems fine -- I guess the plumbing here has to get in without a
> test, before then later real changes come in and can be tested.
>
> The "Override" vs new-source-atom distinction seems a little clunky, although
> I haven't read how it's used to get the full context.
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/133494
error: too big or took too long to generate
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm
OCHyams wrote:
> LGTM (although the hand-written (check-lines that is) tests are more fun and
> easier to read)
Agreed. I think I must've lost steam around this part of the stack. Fixed.
https://github.com/llvm/llvm-project/pull/133490
___
llvm-branc
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/133490
>From a612a99e2b5540c7fca93dd4dd3fcc07cc1cc9fd Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Wed, 26 Mar 2025 16:03:41 +
Subject: [PATCH 1/3] [KeyInstr][LoopRotate] Remap atoms of duplicated
in
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/133488
>From 47404a2700661b959024677d73c7a14b18c81d83 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Tue, 25 Mar 2025 15:24:05 +
Subject: [PATCH 1/2] [KeyInstr][JumpThreading] Remap atoms duping bb with
@@ -0,0 +1,81 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
UTC_ARGS: --version 5
+; RUN: opt %s -S -passes=simplifycfg -bonus-inst-threshold=2 | FileCheck %s
+
+;; Block d gets folded into preds b and c. Check the cloned instructions get
-
@@ -1129,13 +1130,17 @@ static void
cloneInstructionsIntoPredecessorBlockAndUpdateSSAUses(
Instruction *NewBonusInst = BonusInst.clone();
-if (!isa(BonusInst) &&
-PTI->getDebugLoc() != NewBonusInst->getDebugLoc()) {
- // Unless the instruction has the sa
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/133482
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-s
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/133482
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-s
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/133482
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-s
OCHyams wrote:
> Github has helpfully chucked away my comments; was the unit-test-error that I
> fixed corrected? If so, LGTM.
Yep, fixed that
https://github.com/llvm/llvm-project/pull/133480
___
llvm-branch-commits mailing list
llvm-branch-commits@l
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/133481
>From fde8c9e4834a2dad33c1349ef94fc90544a09b65 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Fri, 21 Mar 2025 16:49:14 +
Subject: [PATCH 1/2] [KeyInstr] Inline atom info
Source atom groups are
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/133482
>From 958c0d775bc696df74b847b106ccd2531d5e12e2 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Mon, 24 Mar 2025 13:48:07 +
Subject: [PATCH] [KeyInstr][SimplifyCFG] Remap atoms when folding br to c
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/133481
>From fde8c9e4834a2dad33c1349ef94fc90544a09b65 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Fri, 21 Mar 2025 16:49:14 +
Subject: [PATCH] [KeyInstr] Inline atom info
Source atom groups are iden
OCHyams wrote:
@SLTozer are you happy with my responses to your inline comments? And a few
weeks ago offline we discussed that the slightly not-nfc change to preserve
isImplicitCode is probably ok. Are you still happy with that?
@jmorse I used some early-exits in the lambda - does that look ok
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/133480
>From 2c538d7ba71f82c49800331d996316a96696aee2 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Fri, 21 Mar 2025 11:52:30 +
Subject: [PATCH 1/4] [KeyInstr] Merge atoms in DILocation::getMergedLocat
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/133480
>From 2c538d7ba71f82c49800331d996316a96696aee2 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Fri, 21 Mar 2025 11:52:30 +
Subject: [PATCH 1/3] [KeyInstr] Merge atoms in DILocation::getMergedLocat
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/133480
>From 2c538d7ba71f82c49800331d996316a96696aee2 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Fri, 21 Mar 2025 11:52:30 +
Subject: [PATCH] [KeyInstr] Merge atoms in DILocation::getMergedLocation
https://github.com/OCHyams updated
https://github.com/llvm/llvm-project/pull/133478
>From 511ee0a22ab388a8794dd4f487a23615eb4ad800 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Tue, 18 Mar 2025 16:50:17 +
Subject: [PATCH 1/5] [KeyInstr] Add Atom Group waterline to LLVMContext
OCHyams wrote:
> Seems fine; although why's it needed for key instructions, I have a vague
> recollection that LLVM doesn't actually care about the source locations
> attached to PHIs?
The motivation came from reviewing code duplication sites to update for Key
Instructions, finding this, tryi
@@ -1129,13 +1130,17 @@ static void
cloneInstructionsIntoPredecessorBlockAndUpdateSSAUses(
Instruction *NewBonusInst = BonusInst.clone();
-if (!isa(BonusInst) &&
-PTI->getDebugLoc() != NewBonusInst->getDebugLoc()) {
- // Unless the instruction has the sa
https://github.com/OCHyams edited
https://github.com/llvm/llvm-project/pull/133482
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
OCHyams wrote:
> Possibly part of the design here is to simply not care, if it's only about
> internal consistency within a Function (does that hold after inlining too).
> Apologies if this is all explained in a later patch.
It is indeed the goal not to care; an instruction is only considered
@@ -226,8 +230,44 @@ DILocation *DILocation::getMergedLocation(DILocation
*LocA, DILocation *LocB) {
bool SameCol = L1->getColumn() == L2->getColumn();
unsigned Line = SameLine ? L1->getLine() : 0;
unsigned Col = SameLine && SameCol ? L1->getColumn() : 0;
-
-re
@@ -67,6 +67,9 @@ DILocation::DILocation(LLVMContext &C, StorageType Storage,
unsigned Line,
#ifdef EXPERIMENTAL_KEY_INSTRUCTIONS
assert(AtomRank <= 7 && "AtomRank number should fit in 3 bits");
#endif
+ if (AtomRank)
OCHyams wrote:
note to self: should be
https://github.com/OCHyams closed
https://github.com/llvm/llvm-project/pull/134634
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
OCHyams wrote:
Thanks for the review. Landed in
https://github.com/llvm/llvm-project/commit/308654608cb8bc5bbd5d4b3779cb7d92920dd6b7
(sorry for the additional noise, I'm still getting to grips with Graphite,
plus this patch isn't actually dependant on its parent in the stack).
https://github.
https://github.com/OCHyams created
https://github.com/llvm/llvm-project/pull/134647
This patch is part of a stack that teaches Clang to generate Key Instructions
metadata for C and C++.
The Key Instructions project is introduced, including a "quick summary" section
at the top which adds context
https://github.com/OCHyams created
https://github.com/llvm/llvm-project/pull/134651
[KeyIntsr][Clang] Builtins alloca auto-init atom
This patch is part of a stack that teaches Clang to generate Key Instructions
metadata for C and C++.
The Key Instructions project is introduced, including a "qu
OCHyams wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134632?utm_source=stack-comment-downstack-mergeability-warning";
https://github.com/OCHyams created
https://github.com/llvm/llvm-project/pull/134645
See test comment for possible future improvement.
This patch is part of a stack that teaches Clang to generate Key Instructions
metadata for C and C++.
The Key Instructions project is introduced, including a "q
OCHyams wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134647?utm_source=stack-comment-downstack-mergeability-warning";
OCHyams wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134636?utm_source=stack-comment-downstack-mergeability-warning";
OCHyams wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134645?utm_source=stack-comment-downstack-mergeability-warning";
OCHyams wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134638?utm_source=stack-comment-downstack-mergeability-warning";
1 - 100 of 217 matches
Mail list logo
