[llvm-branch-commits] [llvm] release/20.x: [LV] Fix crash when building partial reductions using types that aren't known scale factors (#136680) (PR #136863)

2025-04-28 Thread Nicholas Guy via llvm-branch-commits
NickGuy-Arm wrote: I can verify that updating the test files doesn't impact the test itself. Looks to be some instruction reordering but no change to the functionality being tested, and this test passes on main without any further changes. How do we go about updating the test on this branch, a

[llvm-branch-commits] [llvm] [LV] Reduce register usage for scaled reductions (PR #133090)

2025-03-26 Thread Nicholas Guy via llvm-branch-commits
https://github.com/NickGuy-Arm edited https://github.com/llvm/llvm-project/pull/133090 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [LV] Reduce register usage for scaled reductions (PR #133090)

2025-03-26 Thread Nicholas Guy via llvm-branch-commits
NickGuy-Arm wrote: Could you pre-commit this test, so we can see how the output changes before and after the changes in LoopVectorize.cpp https://github.com/llvm/llvm-project/pull/133090 ___ llvm-branch-commits maili

[llvm-branch-commits] [llvm] [LV] Reduce register usage for scaled reductions (PR #133090)

2025-03-26 Thread Nicholas Guy via llvm-branch-commits
@@ -5026,10 +5026,23 @@ calculateRegisterUsage(VPlan &Plan, ArrayRef VFs, // even in the scalar case. RegUsage[ClassID] += 1; } else { +// The output from scaled phis and scaled reductions actually have +// fewer lanes

[llvm-branch-commits] [llvm] [LV] Reduce register usage for scaled reductions (PR #133090)

2025-03-26 Thread Nicholas Guy via llvm-branch-commits
https://github.com/NickGuy-Arm commented: Looks generally good to me so far, with a few nitpicks. https://github.com/llvm/llvm-project/pull/133090 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[llvm-branch-commits] [llvm] [LV] Reduce register usage for scaled reductions (PR #133090)

2025-03-26 Thread Nicholas Guy via llvm-branch-commits
@@ -5026,10 +5026,23 @@ calculateRegisterUsage(VPlan &Plan, ArrayRef VFs, // even in the scalar case. RegUsage[ClassID] += 1; } else { +// The output from scaled phis and scaled reductions actually have +// fewer lanes

[llvm-branch-commits] [llvm] [LV] Reduce register usage for scaled reductions (PR #133090)

2025-03-26 Thread Nicholas Guy via llvm-branch-commits
@@ -2031,17 +2033,19 @@ class VPReductionPHIRecipe : public VPHeaderPHIRecipe, /// scalar value. class VPPartialReductionRecipe : public VPSingleDefRecipe { unsigned Opcode; + unsigned ScaleFactor; NickGuy-Arm wrote: Nit: Could this be `VFScaleFactor` to ma

[llvm-branch-commits] [llvm] 16bf02c - Reland "[AArch64] Attempt to sink mul operands""

2021-01-18 Thread Nicholas Guy via llvm-branch-commits
Author: Nicholas Guy Date: 2021-01-18T16:00:22Z New Revision: 16bf02c3a19d4e1f4a19cb243de612e17f54f5a9 URL: https://github.com/llvm/llvm-project/commit/16bf02c3a19d4e1f4a19cb243de612e17f54f5a9 DIFF: https://github.com/llvm/llvm-project/commit/16bf02c3a19d4e1f4a19cb243de612e17f54f5a9.diff LOG:

[llvm-branch-commits] [llvm] f5fcbe4 - [AArch64] Further restricts when a dup(*ext) can be rearranged

2021-01-18 Thread Nicholas Guy via llvm-branch-commits
Author: Nicholas Guy Date: 2021-01-18T16:00:21Z New Revision: f5fcbe4e3c68584ef4858590a079f17593feabbd URL: https://github.com/llvm/llvm-project/commit/f5fcbe4e3c68584ef4858590a079f17593feabbd DIFF: https://github.com/llvm/llvm-project/commit/f5fcbe4e3c68584ef4858590a079f17593feabbd.diff LOG:

[llvm-branch-commits] [llvm] dda6003 - [AArch64] Attempt to sink mul operands

2021-01-13 Thread Nicholas Guy via llvm-branch-commits
Author: Nicholas Guy Date: 2021-01-13T15:23:36Z New Revision: dda60035e9f0769c8907cdf6561489e0435c2275 URL: https://github.com/llvm/llvm-project/commit/dda60035e9f0769c8907cdf6561489e0435c2275 DIFF: https://github.com/llvm/llvm-project/commit/dda60035e9f0769c8907cdf6561489e0435c2275.diff LOG:

[llvm-branch-commits] [llvm] ed23229 - [AArch64] Fix crash caused by invalid vector element type

2021-01-08 Thread Nicholas Guy via llvm-branch-commits
Author: Nicholas Guy Date: 2021-01-08T12:02:54Z New Revision: ed23229a64aed5b9d6120d57138d475291ca3667 URL: https://github.com/llvm/llvm-project/commit/ed23229a64aed5b9d6120d57138d475291ca3667 DIFF: https://github.com/llvm/llvm-project/commit/ed23229a64aed5b9d6120d57138d475291ca3667.diff LOG:

[llvm-branch-commits] [llvm] 350247a - [AArch64] Rearrange mul(dup(sext/zext)) to mul(sext/zext(dup))

2021-01-06 Thread Nicholas Guy via llvm-branch-commits
Author: Nicholas Guy Date: 2021-01-06T16:02:16Z New Revision: 350247a93c07906300b79955ff882004a92ae368 URL: https://github.com/llvm/llvm-project/commit/350247a93c07906300b79955ff882004a92ae368 DIFF: https://github.com/llvm/llvm-project/commit/350247a93c07906300b79955ff882004a92ae368.diff LOG: