[llvm-branch-commits] [clang] clang/AMDGPU: Stop looking for oclc_daz_opt_* control libraries (PR #134805)

2025-04-08 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 approved this pull request. Nice to see fewer of these used. We should be able to get rid of the wavefrontsize ones if we use the builtin, and if Alex's WIP lands we can replace the ISA checks with that. https://github.com/llvm/llvm-project/pull/134805 __

[llvm-branch-commits] [llvm] release/20.x: [OpenMP] Fix misspelled symbol name (#126120) (PR #126121)

2025-02-25 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: It is very important that this gets backported. https://github.com/llvm/llvm-project/pull/126121 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [libc] release/20.x: [Clang] Add handlers for 'match_any' and 'match_all' to `gpuintrin.h` (#127504) (PR #127704)

2025-02-20 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: > @jhuber6 Why do you want to back port this and what's the impact if we don't? Sorry, https://github.com/llvm/llvm-project/pull/127703 is the actually important one and I forget to cherry pick it, fixes a test and incorrect behavior. Figured if I was backporting that I could me

[llvm-branch-commits] [libcxx] release/20.x: [libc++] Guard include of with __has_include (#127691) (PR #127842)

2025-02-19 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/127842 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [libc] release/20.x: [Clang] Add handlers for 'match_any' and 'match_all' to `gpuintrin.h` (#127504) (PR #127704)

2025-02-18 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 approved this pull request. Approving my own patch feels like a conflict of interest. https://github.com/llvm/llvm-project/pull/127704 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm

[llvm-branch-commits] [llvm] release/20.x: AMDGPU: Stop emitting an error on illegal addrspacecasts (#127487) (PR #127496)

2025-02-17 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/127496 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libc] release/20.x: libc/cmake: don't fail if LLVM_VERSION_SUFFIX isn't defined (#126359) (PR #127099)

2025-02-13 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/127099 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=flang-rt (PR #110217)

2025-02-13 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/110217 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [AMDGPU][clang] Replace gfx940 and gfx941 with gfx942 in clang (PR #126762)

2025-02-11 Thread Joseph Huber via llvm-branch-commits
@@ -106,8 +106,6 @@ enum class OffloadArch { GFX90a, GFX90c, GFX9_4_GENERIC, - GFX940, - GFX941, jhuber6 wrote: So `--offload-arch=gfx940` will be a hard error after working at least since clang 16? That sounds very silly. https://github.com/llvm/llv

[llvm-branch-commits] [clang] [AMDGPU][clang] Replace gfx940 and gfx941 with gfx942 in clang (PR #126762)

2025-02-11 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 approved this pull request. Okay, so I guess we can delete these because the cards that corresponded to these were never fully released as I understand it. https://github.com/llvm/llvm-project/pull/126762 ___ llvm-branch-com

[llvm-branch-commits] [clang] [AMDGPU][clang] Replace gfx940 and gfx941 with gfx942 in clang (PR #126762)

2025-02-11 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/126762 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [AMDGPU][clang] Replace gfx940 and gfx941 with gfx942 in clang (PR #126762)

2025-02-11 Thread Joseph Huber via llvm-branch-commits
@@ -106,8 +106,6 @@ enum class OffloadArch { GFX90a, GFX90c, GFX9_4_GENERIC, - GFX940, - GFX941, jhuber6 wrote: Seems bizarre to just fully remove support when we still accept things like `gfx600` to this day. As far as I understand, these are basical

[llvm-branch-commits] [clang] [libc] release/20.x: [Clang] Fix test after new argument was added (PR #125912)

2025-02-11 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: > @jhuber6 Can you take a look at these test failures. Looks green now. https://github.com/llvm/llvm-project/pull/125912 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[llvm-branch-commits] [clang] [libc] release/20.x: [Clang] Fix test after new argument was added (PR #125912)

2025-02-08 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: Should just be the two commits, it just unfortunately took the name of the latest one. I would've squashed them if I knew how. https://github.com/llvm/llvm-project/pull/125912 ___ llvm-branch-commits mailing list llvm-branch-commits@lis

[llvm-branch-commits] [libc] fix: removes invalid token from LLVM_VERSION_SUFFIX in LIBC namespace (PR #126193)

2025-02-07 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/126193 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libc] fix: removes invalid token from LLVM_VERSION_SUFFIX in LIBC namespace (PR #126193)

2025-02-07 Thread Joseph Huber via llvm-branch-commits
@@ -51,7 +51,8 @@ set(LIBC_KERNEL_HEADERS "/usr/include" CACHE STRING "Path to Linux kernel header # Defining a global namespace to enclose all libc functions. set(default_namespace "__llvm_libc") if(LLVM_VERSION_MAJOR) - set(default_namespace "__llvm_libc_${LLVM_VERSION_MAJ

[llvm-branch-commits] [libc] fix: removes invalid token from LLVM_VERSION_SUFFIX in LIBC namespace (PR #126193)

2025-02-07 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 commented: Is this a backport? I don't see one for the `main` branch. Normally you land it on main and follow https://llvm.org/docs/GitHub.html#backporting-fixes-to-the-release-branches for the backport. https://github.com/llvm/llvm-project/pull/126193 _

[llvm-branch-commits] [llvm] release/20.x: [offload] [test] Use test compiler ID rather than host (#124408) (PR #125498)

2025-02-03 Thread Joseph Huber via llvm-branch-commits
=?utf-8?q?Micha=C5=82_G=C3=B3rny?= Message-ID: In-Reply-To: https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/125498 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists

[llvm-branch-commits] [flang] [Flang] Promote FortranEvaluateTesting library (PR #124417)

2025-01-27 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/124417 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] Rename libFortranRuntime.a to libflang_rt.a (PR #122341)

2025-01-20 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 approved this pull request. Straightforward renaming and more consistent with the clang runtimes. https://github.com/llvm/llvm-project/pull/122341 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https:

[llvm-branch-commits] [flang] [Flang] Promote FortranEvaluateTesting library (PR #122334)

2025-01-17 Thread Joseph Huber via llvm-branch-commits
@@ -1,47 +1,34 @@ set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}) -add_library(FortranEvaluateTesting jhuber6 wrote: Does anyone use the omp offload build? I'm hoping to make that unnecessary once we have the flang-rt build working. https://git

[llvm-branch-commits] [clang] [llvm] [OffloadBundler] Rework the ctor of `OffloadTargetInfo` to support AMDGPU's generic target (PR #122629)

2025-01-14 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: Somewhere for the linker wrapper I just checked if the triple was recognized, you could probably just take strings after the `-` until it stops working. https://github.com/llvm/llvm-project/pull/122629 ___ llvm-branch-commits mailing li

[llvm-branch-commits] [flang] [Flang] Introduce FortranSupport (PR #122069)

2025-01-10 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 approved this pull request. Seems reasonable to me https://github.com/llvm/llvm-project/pull/122069 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=flang-rt (PR #110217)

2025-01-08 Thread Joseph Huber via llvm-branch-commits
@@ -0,0 +1,232 @@ +#===-- CMakeLists.txt --===# +# +# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-

[llvm-branch-commits] [mlir] [mlir][rocdl] Add AMDGPU-specific `cf.assert` lowering (PR #121067)

2025-01-03 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: > 1. Approved > > 2. Wrt OpenCL ... I hope legalization didn't get broken, but in the > OpenCL flow, pryntf should lower to ... `printf()`, which the compiler will > handle. Or at least that's my recollection of how that goes from staring at > the AMDGPU backend ~a year ago

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=flang-rt (PR #110217)

2024-12-11 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: > > Also, I noticed that both linux and windows builds fail to generate some > > subcommands apparently (but this doesn't seem to cause an explicit error): > > ``` > > [70/72] Generating $PREFIX/compile_commands.json > > Failed to parse {json_file}: {e} > > ``` > > > > > >

[llvm-branch-commits] [llvm] [19.x] Backport standalone build fixes for offload (PR #118643)

2024-12-04 Thread Joseph Huber via llvm-branch-commits
=?utf-8?q?Micha=C5=82_G=C3=B3rny?= , =?utf-8?q?Micha=C5=82_G=C3=B3rny?= , =?utf-8?q?Micha=C5=82_G=C3=B3rny?= , =?utf-8?q?Micha=C5=82_G=C3=B3rny?= , =?utf-8?q?Micha=C5=82_G=C3=B3rny?= Message-ID: In-Reply-To: https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-p

[llvm-branch-commits] [llvm] AMDGPU: Move default wavesize hack for disassembler (PR #117422)

2024-11-23 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/117422 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] AMDGPU: Use isWave[32|64] instead of comparing size value (PR #117411)

2024-11-22 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 approved this pull request. LG https://github.com/llvm/llvm-project/pull/117411 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=flang-rt (PR #110217)

2024-11-19 Thread Joseph Huber via llvm-branch-commits
@@ -150,12 +150,18 @@ if ("flang" IN_LIST LLVM_ENABLE_PROJECTS) endif() endif() +if ("flang-rt" IN_LIST LLVM_ENABLE_RUNTIMES) + if (NOT "flang" IN_LIST LLVM_ENABLE_PROJECTS) +message(FATAL_ERROR "Flang is not enabled, but is required for the Flang-RT runtime") + endif

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=flang-rt (PR #110217)

2024-11-12 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: > > This patch doesn't apply cleanly for me > > That's because it's a series of patches (see OP), so you have to apply them > all in order (or simply check out the branch that represents this PR) I thought that's what happens by default when you use https://patch-diff.githubuse

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=flang-rt (PR #110217)

2024-11-12 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: This patch doesn't apply cleanly for me https://github.com/llvm/llvm-project/pull/110217 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=flang-rt (PR #110217)

2024-11-11 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 commented: Does anyone know why this patch keeps failing the libc++ tests? Seems related to something in `libc` for some reason. If we could get the CI green I'd be happy to say it's good enough for now. https://github.com/llvm/llvm-project/pull/110217 __

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=flang-rt (PR #110217)

2024-11-10 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: > > Overall I think the patch is fine pending some naming nits, my one concern > > is the `-U__GLIBCXX` stuff, because undefining internal vars seems really > > sketchy. Do we use `-nostdlib++` to make sure we don't link the C++ library? > > There is a > [test](https://github.c

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=flang-rt (PR #110217)

2024-11-07 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: Overall I think the patch is fine pending some naming nits, my one concern is the `-U__GLIBCXX` stuff, because undefining internal vars seems really sketchy. Do we use `-nostdlib++` to make sure we don't link the C++ library? https://github.com/llvm/llvm-project/pull/110217

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=flang-rt (PR #110217)

2024-11-07 Thread Joseph Huber via llvm-branch-commits
@@ -0,0 +1,165 @@ +#===-- CMakeLists.txt --===# +# +# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=flang-rt (PR #110217)

2024-11-06 Thread Joseph Huber via llvm-branch-commits
@@ -171,145 +76,88 @@ set(sources unit-map.cpp unit.cpp utf.cpp - ${FORTRAN_MODULE_OBJECTS} ) -include(AddFlangOffloadRuntime) - -# List of files that are buildable for all devices. -set(supported_files - ISO_Fortran_binding.cpp - allocatable.cpp - allocator-regist

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=flang-rt (PR #110217)

2024-11-06 Thread Joseph Huber via llvm-branch-commits
@@ -171,145 +76,88 @@ set(sources unit-map.cpp unit.cpp utf.cpp - ${FORTRAN_MODULE_OBJECTS} ) -include(AddFlangOffloadRuntime) - -# List of files that are buildable for all devices. -set(supported_files - ISO_Fortran_binding.cpp - allocatable.cpp - allocator-regist

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=flang-rt (PR #110217)

2024-11-06 Thread Joseph Huber via llvm-branch-commits
@@ -171,145 +76,88 @@ set(sources unit-map.cpp unit.cpp utf.cpp - ${FORTRAN_MODULE_OBJECTS} ) -include(AddFlangOffloadRuntime) - -# List of files that are buildable for all devices. -set(supported_files - ISO_Fortran_binding.cpp - allocatable.cpp - allocator-regist

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=FortranRuntime (PR #110217)

2024-11-06 Thread Joseph Huber via llvm-branch-commits
@@ -0,0 +1,165 @@ +#===-- CMakeLists.txt --===# +# +# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=flang-rt (PR #110217)

2024-11-06 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/110217 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=FortranRuntime (PR #110217)

2024-11-06 Thread Joseph Huber via llvm-branch-commits
@@ -270,13 +271,15 @@ function(runtime_default_target) -DLLVM_BUILD_TOOLS=${LLVM_BUILD_TOOLS} -DCMAKE_C_COMPILER_WORKS=ON -DCMAKE_CXX_COMPILER_WORKS=ON +

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=FortranRuntime (PR #110217)

2024-11-06 Thread Joseph Huber via llvm-branch-commits
@@ -0,0 +1,165 @@ +#===-- CMakeLists.txt --===# +# +# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=FortranRuntime (PR #110217)

2024-11-06 Thread Joseph Huber via llvm-branch-commits
@@ -221,6 +230,9 @@ function(llvm_ExternalProject_Add name source_dir) -DCMAKE_ASM_COMPILER=${LLVM_RUNTIME_OUTPUT_INTDIR}/clang${CMAKE_EXECUTABLE_SUFFIX}) endif() endif() +if(FLANG_IN_TOOLCHAIN) + list(APPEND compiler_args -DCMAKE_

[llvm-branch-commits] [llvm] AMDGPU: Fix producing invalid IR on vector typed getelementptr (PR #114113)

2024-10-29 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 approved this pull request. Makes sense, thanks again. https://github.com/llvm/llvm-project/pull/114113 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[llvm-branch-commits] [clang] clang/AMDGPU: Emit grid size builtins with range metadata (PR #113038)

2024-10-19 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/113038 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] AMDGPU: Add instruction flags when lowering ctor/dtor (PR #111652)

2024-10-09 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/111652 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] Revert "[LinkerWrapper] Extend with usual pass options (#96704)" (#102226) (PR #106439)

2024-08-28 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 approved this pull request. Thanks https://github.com/llvm/llvm-project/pull/106439 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/19.x: [Clang] Correctly forward `--cuda-path` to the nvlink wrapper (#100170) (PR #100216)

2024-08-13 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/100216 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/19.x: Revert "[LLVM] Silence compiler-rt warning in runtimes build (#99525)" (PR #102475)

2024-08-08 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: So, in the "bad" case, it's finding the LLVMConfig.cmake I would expect. The "good" case is picking up the wrong one, but it somehow works? In both cases it reports that LLVM was found, but the one in-tree doesn't work for some reason. Sorry for all the questions, I'm not able t

[llvm-branch-commits] [llvm] release/19.x: Revert "[LLVM] Silence compiler-rt warning in runtimes build (#99525)" (PR #102475)

2024-08-08 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: > For reasons I don't understand, cmake (version 3.22.1, default on Ubuntu > 22.04.4) is not producing debug output for the find_package call for LLVM if > I use `cmake --debug-find`. It does produce output for other packages. > > Resorting to strace -efile: > > Good: > > ```

[llvm-branch-commits] [llvm] release/19.x: Revert "[LLVM] Silence compiler-rt warning in runtimes build (#99525)" (PR #102475)

2024-08-08 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: > > It appears that in the bad case, `LLVM_CMAKE_DIR` during the `find_package` > is set to `/home/ubuntu/llvm-project/llvm/cmake/modules`. In the good case, > it's set to `/home/ubuntu/bld`. The latter is what it's supposed to do, I would think? When doing a runtimes build it

[llvm-branch-commits] [llvm] release/19.x: Revert "[LLVM] Silence compiler-rt warning in runtimes build (#99525)" (PR #102475)

2024-08-08 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: Do you any clue why this is broken? `LLVM_CMAKE_DIR` should be innocuous enough, so if it's causing failures then there's probably a separate issue. https://github.com/llvm/llvm-project/pull/102475 ___ llvm-branch-commits mailing list l

[llvm-branch-commits] [llvm] release/19.x: InferAddressSpaces: Fix mishandling stores of pointers to themselves (#101877) (PR #101887)

2024-08-04 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/101887 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libc] release/19.x: [libc] Fix leftover debug commandline argument (PR #100291)

2024-07-29 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/100291 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libc] release/19.x: [libc] Fix leftover debug commandline argument (PR #100291)

2024-07-24 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/100291 >From c3dfd23fd6bb167eb6be49a24aef14a0f5621d8d Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 23 Jul 2024 21:35:09 -0500 Subject: [PATCH 1/2] [libc] Fix leftover debug commandline argument Summary: Fixe

[llvm-branch-commits] [libc] release/19.x: [libc] Fix leftover debug commandline argument (PR #100291)

2024-07-23 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/100291 >From c3dfd23fd6bb167eb6be49a24aef14a0f5621d8d Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 23 Jul 2024 21:35:09 -0500 Subject: [PATCH 1/2] [libc] Fix leftover debug commandline argument Summary: Fixe

[llvm-branch-commits] [libc] release/19.x: [libc] Fix leftover debug commandline argument (PR #100291)

2024-07-23 Thread Joseph Huber via llvm-branch-commits
@@ -29,7 +29,7 @@ to learn about the defaults for your platform and target. - ``LIBC_CONF_ENABLE_STRONG_STACK_PROTECTOR``: Enable -fstack-protector-strong to defend against stack smashing attack. - ``LIBC_CONF_KEEP_FRAME_POINTER``: Keep frame pointer in functions for b

[llvm-branch-commits] [clang] release/19.x: [Clang] Correctly forward `--cuda-path` to the nvlink wrapper (#100170) (PR #100216)

2024-07-23 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/100216 >From d7f99606094fc1feb41b50de0b0eb6d07460 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 23 Jul 2024 14:41:57 -0500 Subject: [PATCH 1/5] [Clang] Correctly forward `--cuda-path` to the nvlink wrappe

[llvm-branch-commits] [clang] release/19.x: [Clang] Correctly forward `--cuda-path` to the nvlink wrapper (#100170) (PR #100216)

2024-07-23 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/100216 >From d7f99606094fc1feb41b50de0b0eb6d07460 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 23 Jul 2024 14:41:57 -0500 Subject: [PATCH 1/4] [Clang] Correctly forward `--cuda-path` to the nvlink wrappe

[llvm-branch-commits] [clang] release/19.x: [Clang] Correctly forward `--cuda-path` to the nvlink wrapper (#100170) (PR #100216)

2024-07-23 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/100216 >From d7f99606094fc1feb41b50de0b0eb6d07460 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 23 Jul 2024 14:41:57 -0500 Subject: [PATCH 1/3] [Clang] Correctly forward `--cuda-path` to the nvlink wrappe

[llvm-branch-commits] [clang] release/19.x: [Clang] Correctly forward `--cuda-path` to the nvlink wrapper (#100170) (PR #100216)

2024-07-23 Thread Joseph Huber via llvm-branch-commits
@@ -23,14 +22,14 @@ // RUN: %t/host-x86_64-unknown-linux-gnu.s // Check plugin, -passes, and no remarks. -// RUN: clang-linker-wrapper -o a.out --embed-bitcode \ +// RUN: clang-linker-wrapper -o a.out --embed-bitcode --dry-run \ // RUN: --linker-path=/usr/bin/true %t/

[llvm-branch-commits] [clang] release/19.x: [Clang] Correctly forward `--cuda-path` to the nvlink wrapper (#100170) (PR #100216)

2024-07-23 Thread Joseph Huber via llvm-branch-commits
@@ -23,14 +22,14 @@ // RUN: %t/host-x86_64-unknown-linux-gnu.s // Check plugin, -passes, and no remarks. -// RUN: clang-linker-wrapper -o a.out --embed-bitcode \ +// RUN: clang-linker-wrapper -o a.out --embed-bitcode --dry-run \ jhuber6 wrote: ```suggesti

[llvm-branch-commits] [clang] release/19.x: [Clang] Correctly forward `--cuda-path` to the nvlink wrapper (#100170) (PR #100216)

2024-07-23 Thread Joseph Huber via llvm-branch-commits
@@ -43,7 +42,7 @@ // RUN: -check-prefixes=YML %s // Check handling of bad plugin. -// RUN: not clang-linker-wrapper \ +// RUN: not clang-linker-wrapper --dry-run \ jhuber6 wrote: ```suggestion // RUN: not clang-linker-wrapper \ ``` https://github.com/llv

[llvm-branch-commits] [clang] release/19.x: [Clang] Correctly forward `--cuda-path` to the nvlink wrapper (#100170) (PR #100216)

2024-07-23 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/100216 >From d7f99606094fc1feb41b50de0b0eb6d07460 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 23 Jul 2024 14:41:57 -0500 Subject: [PATCH 1/2] [Clang] Correctly forward `--cuda-path` to the nvlink wrappe

[llvm-branch-commits] [clang] release/19.x: [Clang] Correctly forward `--cuda-path` to the nvlink wrapper (#100170) (PR #100216)

2024-07-23 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/100216 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/19.x: [Clang] Correctly forward `--cuda-path` to the nvlink wrapper (#100170) (PR #100216)

2024-07-23 Thread Joseph Huber via llvm-branch-commits
@@ -1,9 +1,5 @@ // Check various clang-linker-wrapper pass options after -offload-opt. jhuber6 wrote: ```suggestion // REQUIRES: llvm-plugins, llvm-examples // REQUIRES: x86-registered-target // REQUIRES: amdgpu-registered-target ``` https://github.com/llvm/l

[llvm-branch-commits] [libc] [llvm] release/19.x: [NVPTX] Fix internal indirect call prototypes not obeying the ABI (#100131) (PR #100174)

2024-07-23 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: This should be merged https://github.com/llvm/llvm-project/pull/100174 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [openmp] release/18.x: [OpenMP][OMPT] Fix hsa include when building amdgpu/src/rtl.cpp (PR #95484)

2024-06-17 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/95484 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [openmp] release/18.x: [OpenMP][OMPT] Fix hsa include when building amdgpu/src/rtl.cpp (PR #95484)

2024-06-17 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: I merged my patch, I think the window to backport to 18.x is passed so you'll need to use the main branch for now. Thanks for bringing this to my attention. https://github.com/llvm/llvm-project/pull/95484 ___ llvm-branch-commits mailing

[llvm-branch-commits] [openmp] release/18.x: [OpenMP][OMPT] Fix hsa include when building amdgpu/src/rtl.cpp (PR #95484)

2024-06-17 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: Made https://github.com/llvm/llvm-project/pull/95769, don't know if the window for the 18.x window is still open for a back port. https://github.com/llvm/llvm-project/pull/95484 ___ llvm-branch-commits mailing list llvm-branch-commits@l

[llvm-branch-commits] [openmp] release/18.x: [OpenMP][OMPT] Fix hsa include when building amdgpu/src/rtl.cpp (PR #95484)

2024-06-16 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: > This doesn't make sense, the ROCm packages may be just badly made by AMD. > > When I temporarily remove `/usr/include/hsa` without uninstalling > `libhsa-runtime-dev` **AND** while using > `-DLIBOMPTARGET_FORCE_DLOPEN_LIBHSA=ON`, I can build LLVM18 without patch. > > With `-D

[llvm-branch-commits] [openmp] release/18.x: [OpenMP][OMPT] Fix hsa include when building amdgpu/src/rtl.cpp (PR #95484)

2024-06-14 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: > The `openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp` file requires > the `HSA_AMD_AGENT_INFO_TIMESTAMP_FREQUENCY` symbol. > > This symbol is expected to be provided by > `openmp/libomptarget/plugins-nextgen/amdgpu/dynamic_hsa/hsa_ext_amd.h`, not > by third-party exter

[llvm-branch-commits] [openmp] release/18.x: [OpenMP][OMPT] Fix hsa include when building amdgpu/src/rtl.cpp (PR #95484)

2024-06-13 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/95484 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [openmp] release/18.x: [OpenMP][OMPT] Fix hsa include when building amdgpu/src/rtl.cpp (PR #95484)

2024-06-13 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 commented: We made a change recently that made the dynamic_hsa version the default. The error you're seeing is from an old HSA, so if you're overriding the default to use an old library that's probably not worth working around. https://github.com/llvm/llvm-project/pu

[llvm-branch-commits] [libc] [libcxx] [libcxxabi] [libunwind] [llvm] [pstl] Revise IDE folder structure (PR #89755)

2024-05-21 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/89755 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libc] [libcxx] [libcxxabi] [libunwind] [llvm] [pstl] Revise IDE folder structure (PR #89755)

2024-05-21 Thread Joseph Huber via llvm-branch-commits
@@ -9,6 +9,7 @@ include(${LLVM_COMMON_CMAKE_UTILS}/Modules/CMakePolicy.cmake include(${LLVM_COMMON_CMAKE_UTILS}/Modules/LLVMVersion.cmake) project(Runtimes C CXX ASM) +set(LLVM_SUBPROJECT_TITLE "Runtimes") jhuber6 wrote: Is this needed? My understanding is th

[llvm-branch-commits] [openmp] release/18.x: [OpenMP] Fix child processes to use affinity_none (#91391) (PR #91479)

2024-05-10 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: > @jhuber6 What do you think about merging this PR to the release branch? This PR should be merged. > @jhuber6 , Sorry, I'm not used to backporting. Are you the right person for > this? AFAIK the bot asking is automated and then a human pushes the button. https://github.com/ll

[llvm-branch-commits] [llvm] [RISCV] Support llvm.readsteadycounter intrinsic (PR #82322)

2024-02-20 Thread Joseph Huber via llvm-branch-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/82322 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [openmp] release/18.x: [OpenMP] [cmake] Don't use -fno-semantic-interposition on Windows (#81113) (PR #81332)

2024-02-15 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: Sure, LG https://github.com/llvm/llvm-project/pull/81332 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [openmp] PR for llvm/llvm-project#80117 (PR #80291)

2024-02-01 Thread Joseph Huber via llvm-branch-commits
jhuber6 wrote: Merge https://github.com/llvm/llvm-project/pull/80291 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [openmp] a957634 - [OpenMP] Add documentation for error messages and release notes

2021-01-13 Thread Joseph Huber via llvm-branch-commits
Author: Joseph Huber Date: 2021-01-13T11:00:41-05:00 New Revision: a957634942a48c963a8ed99b1bb90f7b985a3602 URL: https://github.com/llvm/llvm-project/commit/a957634942a48c963a8ed99b1bb90f7b985a3602 DIFF: https://github.com/llvm/llvm-project/commit/a957634942a48c963a8ed99b1bb90f7b985a3602.diff

[llvm-branch-commits] [openmp] abb174b - [OpenMP] Add example in Libomptarget Information docs

2021-01-07 Thread Joseph Huber via llvm-branch-commits
Author: Joseph Huber Date: 2021-01-07T15:00:51-05:00 New Revision: abb174bbc100437556fd386d920a9939723e0647 URL: https://github.com/llvm/llvm-project/commit/abb174bbc100437556fd386d920a9939723e0647 DIFF: https://github.com/llvm/llvm-project/commit/abb174bbc100437556fd386d920a9939723e0647.diff

[llvm-branch-commits] [openmp] 631501b - [OpenMP] Fixing typo on memory size in Documenation

2020-12-23 Thread Joseph Huber via llvm-branch-commits
Author: Joseph Huber Date: 2020-12-23T11:46:26-05:00 New Revision: 631501b1f90e8a90faeadbd535a557633a5af71b URL: https://github.com/llvm/llvm-project/commit/631501b1f90e8a90faeadbd535a557633a5af71b DIFF: https://github.com/llvm/llvm-project/commit/631501b1f90e8a90faeadbd535a557633a5af71b.diff

[llvm-branch-commits] [openmp] 6e60346 - [OpenMP] Fixing Typo in Documentation

2020-12-23 Thread Joseph Huber via llvm-branch-commits
Author: Joseph Huber Date: 2020-12-23T09:17:51-05:00 New Revision: 6e603464959d43e0e430d0f8ac5522b073d68ba1 URL: https://github.com/llvm/llvm-project/commit/6e603464959d43e0e430d0f8ac5522b073d68ba1 DIFF: https://github.com/llvm/llvm-project/commit/6e603464959d43e0e430d0f8ac5522b073d68ba1.diff

[llvm-branch-commits] [openmp] 1c19804 - [OpenMP] Add OpenMP Documentation for Libomptarget environment variables

2020-12-22 Thread Joseph Huber via llvm-branch-commits
Author: Joseph Huber Date: 2020-12-22T17:41:27-05:00 New Revision: 1c19804ebf4c97666a5c7de86ca7432c6b020205 URL: https://github.com/llvm/llvm-project/commit/1c19804ebf4c97666a5c7de86ca7432c6b020205 DIFF: https://github.com/llvm/llvm-project/commit/1c19804ebf4c97666a5c7de86ca7432c6b020205.diff