[llvm-branch-commits] [llvm] [llvm-objdump] Support --symbolize-operand on AArch64 (PR #145009)

https://github.com/jh7370 approved this pull request. LGTM, thanks. Probably want to wait for @MaskRay for final sign-off, but if he's too busy, land it in a couple of days anyway. https://github.com/llvm/llvm-project/pull/145009 ___ llvm-branch-commi

[llvm-branch-commits] [llvm] [llvm-objdump] Support --symbolize-operand on AArch64 (PR #145009)

@@ -0,0 +1,77 @@ +# RUN: llvm-mc --triple=aarch64-elf --filetype=obj < %s | llvm-objdump -d -r --symbolize-operands --no-show-raw-insn --no-leading-addr - | FileCheck %s --match-full-lines jh7370 wrote: Nit: let's split this line over multiple lines for readabi

[llvm-branch-commits] [llvm] [llvm-objdump] Support --symbolize-operand on AArch64 (PR #145009)

@@ -0,0 +1,77 @@ +# RUN: llvm-mc --triple=aarch64-elf --filetype=obj < %s | llvm-objdump -d -r --symbolize-operands --no-show-raw-insn --no-leading-addr - | FileCheck %s --match-full-lines + +# CHECK: : +# CHECK-NEXT: b +# CHECK-NEXT: tbz x0, #0x2c, +# CHECK-NEXT: : +

[llvm-branch-commits] [llvm] [llvm-objdump] Support --symbolize-operand on AArch64 (PR #145009)

@@ -1784,6 +1784,10 @@ void AArch64InstPrinter::printAlignedLabel(const MCInst *MI, uint64_t Address, unsigned OpNum, const MCSubtargetInfo &STI, ra

[llvm-branch-commits] [llvm] [llvm-objdump] Support --symbolize-operand on AArch64 (PR #145009)

@@ -0,0 +1,77 @@ +# RUN: llvm-mc --triple=aarch64-elf --filetype=obj < %s | llvm-objdump -d -r --symbolize-operands --no-show-raw-insn --no-leading-addr - | FileCheck %s --match-full-lines + +# CHECK: : +# CHECK-NEXT: b +# CHECK-NEXT: tbz x0, #0x2c, +# CHECK-NEXT: : +

[llvm-branch-commits] [llvm] [llvm-objdump] Support --symbolize-operand on AArch64 (PR #145009)

https://github.com/jh7370 edited https://github.com/llvm/llvm-project/pull/145009 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [llvm-objdump] Support --symbolize-operand on AArch64 (PR #145009)

@@ -1813,6 +1817,12 @@ void AArch64InstPrinter::printAdrAdrpLabel(const MCInst *MI, uint64_t Address, unsigned OpNum, const MCSubtargetInfo &STI, ra

[llvm-branch-commits] [llvm] [llvm-objdump] Support --symbolize-operand on AArch64 (PR #145009)

@@ -0,0 +1,77 @@ +# RUN: llvm-mc --triple=aarch64-elf --filetype=obj < %s | llvm-objdump -d -r --symbolize-operands --no-show-raw-insn --no-leading-addr - | FileCheck %s --match-full-lines + +# CHECK: : +# CHECK-NEXT: b +# CHECK-NEXT: tbz x0, #0x2c, +# CHECK-NEXT: : +

[llvm-branch-commits] [llvm] [llvm-objdump] Support --symbolize-operand on AArch64 (PR #145009)

https://github.com/jh7370 commented: Basically looks good. Just some typos and other nits. Also, the documentation for the option says it works only for PPC and X86. Please could you update this and double-check whether the command-line help has the same note. https://github.com/llvm/llvm-proj

[llvm-branch-commits] [llvm-objdump] Support --symbolize-operand on AArch64 (PR #145009)

@@ -0,0 +1,42 @@ +# RUN: yaml2obj %s -o %t +# RUN: llvm-objdump %t -d --symbolize-operands --no-show-raw-insn --no-leading-addr | \ +# RUN: FileCheck %s --match-full-lines +# RUN: llvm-objdump %t -d --symbolize-operands --no-show-raw-insn --no-leading-addr --adjust-vma=0x2000

[llvm-branch-commits] [llvm-objdump] Support --symbolize-operand on AArch64 (PR #145009)

@@ -0,0 +1,42 @@ +# RUN: yaml2obj %s -o %t +# RUN: llvm-objdump %t -d --symbolize-operands --no-show-raw-insn --no-leading-addr | \ +# RUN: FileCheck %s --match-full-lines +# RUN: llvm-objdump %t -d --symbolize-operands --no-show-raw-insn --no-leading-addr --adjust-vma=0x2000

[llvm-branch-commits] [llvm-objdump] Support --symbolize-operand on AArch64 (PR #145009)

@@ -0,0 +1,42 @@ +# RUN: yaml2obj %s -o %t jh7370 wrote: Nit: there's a typo in the filename. https://github.com/llvm/llvm-project/pull/145009 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org htt

[llvm-branch-commits] [clang] [llvm] release/20.x: [Hexagon] Set the default compilation target to V68 (#125239) (PR #128597)

jh7370 wrote: I don't know why I've been included on this PR - I have no knowledge of this area, nor was I involved with the original PR. https://github.com/llvm/llvm-project/pull/128597 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.l

[llvm-branch-commits] [llvm] [SHT_LLVM_FUNC_MAP][llvm-readobj]Introduce function address map section and emit dynamic instruction count(readobj part) (PR #124333)

@@ -940,6 +940,92 @@ ELFFile::decodeBBAddrMap(const Elf_Shdr &Sec, const Elf_Shdr *RelaSec, return std::move(AddrMapsOrErr); } +template +Expected> +ELFFile::decodeFuncMap(const Elf_Shdr &Sec, + const Elf_Shdr *RelaSec) const { + bool IsRelocat

[llvm-branch-commits] [llvm] [SHT_LLVM_FUNC_MAP][llvm-readobj]Introduce function address map section and emit dynamic instruction count(readobj part) (PR #124333)

@@ -940,6 +940,92 @@ ELFFile::decodeBBAddrMap(const Elf_Shdr &Sec, const Elf_Shdr *RelaSec, return std::move(AddrMapsOrErr); } +template +Expected> +ELFFile::decodeFuncMap(const Elf_Shdr &Sec, + const Elf_Shdr *RelaSec) const { + bool IsRelocat

[llvm-branch-commits] [llvm] [SHT_LLVM_FUNC_MAP][llvm-readobj]Introduce function address map section and emit dynamic instruction count(readobj part) (PR #124333)

@@ -7922,6 +7928,59 @@ void LLVMELFDumper::printBBAddrMaps(bool PrettyPGOAnalysis) { } } +template void LLVMELFDumper::printFuncMaps() { + bool IsRelocatable = this->Obj.getHeader().e_type == ELF::ET_REL; + using Elf_Shdr = typename ELFT::Shdr; + auto IsMatch = [](const

[llvm-branch-commits] [llvm] [SHT_LLVM_FUNC_MAP][llvm-readobj]Introduce function address map section and emit dynamic instruction count(readobj part) (PR #124333)

@@ -7922,6 +7928,59 @@ void LLVMELFDumper::printBBAddrMaps(bool PrettyPGOAnalysis) { } } +template void LLVMELFDumper::printFuncMaps() { + bool IsRelocatable = this->Obj.getHeader().e_type == ELF::ET_REL; + using Elf_Shdr = typename ELFT::Shdr; + auto IsMatch = [](const

[llvm-branch-commits] [llvm] [SHT_LLVM_FUNC_MAP][llvm-readobj]Introduce function address map section and emit dynamic instruction count(readobj part) (PR #124333)

@@ -940,6 +940,92 @@ ELFFile::decodeBBAddrMap(const Elf_Shdr &Sec, const Elf_Shdr *RelaSec, return std::move(AddrMapsOrErr); } +template +Expected> +ELFFile::decodeFuncMap(const Elf_Shdr &Sec, + const Elf_Shdr *RelaSec) const { + bool IsRelocat

[llvm-branch-commits] [llvm] release/20.x: [llvm-objcopy][ReleaseNotes] Fix prints wrong path when dump-section output path doesn't exist #125345 (PR #126607)

https://github.com/jh7370 approved this pull request. LGTM, with @MaskRay's suggestion. https://github.com/llvm/llvm-project/pull/126607 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[llvm-branch-commits] [llvm] release/20.x: [llvm-objcopy] Fix prints wrong path when dump-section output path doesn't exist (#125345) (PR #126367)

https://github.com/jh7370 approved this pull request. LGTM. Regarding the release note, you'll need one on the release branch. IIUC, you won't then need one on `main`, because the release branch is still in RC mode, so not a final release yet. https://github.com/llvm/llvm-project/pull/126367

[llvm-branch-commits] [YAML] Don't validate `Fill::Size` after error (PR #123280)

@@ -1750,7 +1750,9 @@ void MappingTraits>::mapping( std::string MappingTraits>::validate( IO &io, std::unique_ptr &C) { if (const auto *F = dyn_cast(C.get())) { -if (F->Pattern && F->Pattern->binary_size() != 0 && !F->Size) +// Can't check the `Size`, as it's req

[llvm-branch-commits] [llvm-objdump] -r: support CREL (PR #97382)

https://github.com/jh7370 approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/97382 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [llvm-objcopy] Support CREL (PR #97521)

https://github.com/jh7370 approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/97521 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [llvm-objcopy] Support CREL (PR #97521)

@@ -0,0 +1,140 @@ +# RUN: yaml2obj %s -o %t +# RUN: llvm-objcopy --remove-section=.foo --strip-symbol=unused %t %t.out +# RUN: llvm-readelf -Sr %t.out | FileCheck %s + +# CHECK: [Nr] Name TypeAddress Off Size ES Flg Lk Inf Al +# CHECK-N

[llvm-branch-commits] [llvm] [llvm-objcopy] Support CREL (PR #97521)

https://github.com/jh7370 commented: Is it worth a test to show a user attempting to strip a symbol referenced by a crel section? Similarly, a crel section that is associated with a section that gets stripped? Perhaps not needed, but just a thought. https://github.com/llvm/llvm-project/pull/97

[llvm-branch-commits] [llvm] [llvm-objcopy] Support CREL (PR #97521)

https://github.com/jh7370 edited https://github.com/llvm/llvm-project/pull/97521 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [llvm-objcopy] Support CREL (PR #97521)

@@ -0,0 +1,63 @@ +//===- MCELFExtras.h - Extra functions for ELF --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm-branch-commits] [llvm-objdump] -r: support CREL (PR #97382)

@@ -1117,9 +1155,11 @@ void ELFObjectFile::getRelocationTypeName( template Expected ELFObjectFile::getRelocationAddend(DataRefImpl Rel) const { - if (getRelSection(Rel)->sh_type != ELF::SHT_RELA) -return createError("Section is not SHT_RELA"); - return (int64_t)getRela(R

[llvm-branch-commits] [llvm-objcopy] Support CREL (PR #97521)

https://github.com/jh7370 commented: I've skimmed briefly and the changes look reasonable - will look more in depth on a separate occasion when I have more time. Not for this PR, but I wonder if there would be some benefit in a `--decode-crel` and/or `--encode-crel` option that would convert a

[llvm-branch-commits] [llvm-objdump] -r: support CREL (PR #97382)

@@ -1022,6 +1033,47 @@ ELFObjectFile::section_rel_begin(DataRefImpl Sec) const { uintptr_t SHT = reinterpret_cast((*SectionsOrErr).begin()); RelData.d.a = (Sec.p - SHT) / EF.getHeader().e_shentsize; RelData.d.b = 0; + if (reinterpret_cast(Sec.p)->sh_type == ELF::SHT_CRE

[llvm-branch-commits] [llvm-objcopy] Simplify --[de]compress-debug-sections and don't compress SHF_ALLOC sections (PR #84885)

@@ -12,8 +12,10 @@ # CHECK: Name TypeAddress Off Size ES Flg Lk Inf Al # COMPRESSED:.debug_fooPROGBITS 40 {{.*}} 00 C 0 0 8 # COMPRESSED-NEXT: .notdebug_foo PROGBITS

[llvm-branch-commits] [llvm-objcopy] Simplify --[de]compress-debug-sections and don't compress SHF_ALLOC sections (PR #84885)

https://github.com/jh7370 commented: Looks basically fine to me. https://github.com/llvm/llvm-project/pull/84885 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm-objcopy] Simplify --[de]compress-debug-sections and don't compress SHF_ALLOC sections (PR #84885)

https://github.com/jh7370 edited https://github.com/llvm/llvm-project/pull/84885 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm-objcopy] Simplify --[de]compress-debug-sections and don't compress SHF_ALLOC sections (PR #84885)

@@ -214,33 +214,34 @@ static Error dumpSectionToFile(StringRef SecName, StringRef Filename, SecName.str().c_str()); } -static bool isCompressable(const SectionBase &Sec) { - return !(Sec.Flags & ELF::SHF_COMPRESSED) && - StringRef(Sec.Name)

[llvm-branch-commits] [llvm] ReleaseNotes for LLVM binary utilities (PR #83751)

https://github.com/jh7370 edited https://github.com/llvm/llvm-project/pull/83751 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] ReleaseNotes for LLVM binary utilities (PR #83751)

@@ -344,21 +344,26 @@ Changes to the LLVM tools * Fixed big-endian support in llvm-symbolizer's DWARF location parser. * llvm-readelf now supports ``--extra-sym-info`` (``-X``) to display extra information (section name) when showing symbols. - -* ``llvm-nm`` now supports the

[llvm-branch-commits] [llvm] ReleaseNotes for LLVM binary utilities (PR #83751)

https://github.com/jh7370 approved this pull request. LGTM (I haven't attempted to review the list of changes to make sure you haven't missed any). https://github.com/llvm/llvm-project/pull/83751 ___ llvm-branch-commits mailing list llvm-branch-commit

[llvm-branch-commits] [llvm] release/18.x: [docs][llvm-objcopy] Add missing formats (#81981) (PR #82470)

https://github.com/jh7370 approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/82470 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/18.x: [llvm-objcopy] Add SystemZ support (#81841) (PR #82324)

jh7370 wrote: Functionally, I'm confident this is safe, but I don't know whether it's too late in the cycle to be picking additional non-bug fix commits. @tstellar? Also, as noted in the original PR, the corresponding doc change needs picking too. https://github.com/llvm/llvm-project/pull/823

[llvm-branch-commits] [ARM, MC] Support FDPIC relocations (PR #82187)

https://github.com/jh7370 edited https://github.com/llvm/llvm-project/pull/82187 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [ARM, MC] Support FDPIC relocations (PR #82187)

@@ -143,3 +143,10 @@ ELF_RELOC(R_ARM_THM_BF16, 0x88) ELF_RELOC(R_ARM_THM_BF12, 0x89) ELF_RELOC(R_ARM_THM_BF18, 0x8a) ELF_RELOC(R_ARM_IRELATIVE, 0xa0) +ELF_RELOC(R_ARM_GOTFUNCDESC,0xa1) +ELF_RELOC(R_ARM_GOTOFFFUN

[llvm-branch-commits] [ARM, MC] Support FDPIC relocations (PR #82187)

https://github.com/jh7370 commented: BinaryFormat/llvm-readobj aspects looks fine to me, but the assembler side of things goes a bit over my head, so you'll need someone else to review that area. https://github.com/llvm/llvm-project/pull/82187 ___ llv

[llvm-branch-commits] [llvm] [libc] [flang] [clang-tools-extra] [compiler-rt] [clang] [OptTable] Make new lines in help text respect indentation (PR #74880)

https://github.com/jh7370 edited https://github.com/llvm/llvm-project/pull/74880 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [clang-tools-extra] [libc] [llvm] [flang] [clang] [OptTable] Make new lines in help text respect indentation (PR #74880)

@@ -1,16 +1,16 @@ ; RUN: llvm-cvtres /h > %t -; RUN: FileCheck -input-file=%t %s -check-prefix=HELP_TEST +; RUN: FileCheck -input-file=%t %s --strict-whitespace -check-prefix=HELP_TEST -; HELP_TEST: OVERVIEW: Resource Converter -; HELP_TEST-DAG: USAGE: llvm-cvtres [options

[llvm-branch-commits] [flang] [llvm] [clang-tools-extra] [clang] [compiler-rt] [libc] [OptTable] Make new lines in help text respect indentation (PR #74880)

https://github.com/jh7370 commented: > > Is the main functionality of this test actually tested in the current > > patch? It doesn't seem to be to me. > I don't fully understand your comment, I am working on getting some of the > test to be whitespace strict to specifically test the functionali

[llvm-branch-commits] [libc] [compiler-rt] [clang] [clang-tools-extra] [llvm] [flang] [OptTable] Make new lines in help text respect indentation (PR #74880)

https://github.com/jh7370 commented: Is the main functionality of this test actually tested in the current patch? It doesn't seem to be to me. https://github.com/llvm/llvm-project/pull/74880 ___ llvm-branch-commits mailing list llvm-branch-commits@lis

[llvm-branch-commits] [llvm] 5b95eb0 - [debuginfo-test][cross-project-tests] Release note for new project name

Author: James Henderson Date: 2021-09-21T09:48:35+01:00 New Revision: 5b95eb0b442e8eaa6b90ff765a3ad4c271c2d9eb URL: https://github.com/llvm/llvm-project/commit/5b95eb0b442e8eaa6b90ff765a3ad4c271c2d9eb DIFF: https://github.com/llvm/llvm-project/commit/5b95eb0b442e8eaa6b90ff765a3ad4c271c2d9eb.dif

[llvm-branch-commits] [lld] b37a349 - [lld][ELF][test] Add testing for IE/LD TLS weak undef references

Author: James Henderson Date: 2021-01-25T09:58:56Z New Revision: b37a349ff2442e73ceafeee982afb430359e08b1 URL: https://github.com/llvm/llvm-project/commit/b37a349ff2442e73ceafeee982afb430359e08b1 DIFF: https://github.com/llvm/llvm-project/commit/b37a349ff2442e73ceafeee982afb430359e08b1.diff LO

[llvm-branch-commits] [llvm] f07403e - [llvm-symbolizer][doc] Reorder --relativenames in options list

Author: James Henderson Date: 2021-01-20T11:50:00Z New Revision: f07403eb1a5f781b1bcc2b0c18ef7f632e1a0fdc URL: https://github.com/llvm/llvm-project/commit/f07403eb1a5f781b1bcc2b0c18ef7f632e1a0fdc DIFF: https://github.com/llvm/llvm-project/commit/f07403eb1a5f781b1bcc2b0c18ef7f632e1a0fdc.diff LO