christopherbate wrote:
> Yes but then you're proposing we should add to the monolithic scripts an
> invocation of install-distributions? That seems fine too.
I'm not familiar enough with the infra to know where tests for `install` or
`install-distribution` should go. @joker-eph do you have a r
@@ -65,6 +65,12 @@ if (MLIR_INCLUDE_INTEGRATION_TESTS)
endif()
+option(MLIR_RUN_STANDALONE_INSTALL_TESTS "Run Standalone example install
tests." ON)
+if(MLIR_RUN_STANDALONE_INSTALL_TESTS AND "${CMAKE_INSTALL_PREFIX}" STREQUAL "")
+ message(WARNING "Standalone example instal
christopherbate wrote:
> The existing Standalone test already performs a nested build command
That test is using configure/build in a different build directory. Yes, it is
nested in the existing one, but it is a new, temporary build directory.
Existing test does something like this:
- Parent
christopherbate wrote:
I don't fully understand the rationale for adding this test. I followed the
links, and it seems to stem from [this
comment](https://github.com/llvm/llvm-project/pull/157583#issuecomment-3274164357).
But the relationship between that failure and this test is not clear to
https://github.com/christopherbate approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/155856
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-com
