llvmbot wrote:
@llvm/pr-subscribers-llvm-transforms
Author: None (llvmbot)
Changes
Backport c136d3237a3c6230cfe1ab3f0f6790f903c54a27
Requested by: @davemgreen
---
Full diff: https://github.com/llvm/llvm-project/pull/111796.diff
2 Files Affected:
- (modified) llvm/lib/Transforms/Vector
https://github.com/llvmbot milestoned
https://github.com/llvm/llvm-project/pull/111796
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@RKSimon What do you think about merging this PR to the release branch?
https://github.com/llvm/llvm-project/pull/111796
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/llvmbot created
https://github.com/llvm/llvm-project/pull/111796
Backport c136d3237a3c6230cfe1ab3f0f6790f903c54a27
Requested by: @davemgreen
>From b64f2902d1b01234f57888fcf78282bc7cddb293 Mon Sep 17 00:00:00 2001
From: David Green
Date: Wed, 9 Oct 2024 16:20:03 +0100
Subjec
@@ -1110,6 +1110,7 @@ void CombinerHelper::applySextInRegOfLoad(
Builder.buildLoadInstr(TargetOpcode::G_SEXTLOAD, MI.getOperand(0).getReg(),
LoadDef->getPointerReg(), *NewMMO);
MI.eraseFromParent();
+ LoadDef->eraseFromParent();
ts
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/111457
>From 0df57333178d360c441956cc2509f5eca4434c0e Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Sat, 5 Oct 2024 21:56:51 -0300
Subject: [PATCH] [clang] Implement TTP 'reversed' pack matching for deduced
fu
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/111457
>From 1975bae70df78c437d10a361a15aca27f218460e Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Sat, 5 Oct 2024 21:56:51 -0300
Subject: [PATCH] [clang] Implement TTP 'reversed' pack matching for deduced
fu
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/107350
>From aa016046df11993dff967eff970530c73ecf849e Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Thu, 5 Sep 2024 00:25:40 -0300
Subject: [PATCH] [clang] CWG2398: improve overload resolution backwards compat
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/111457
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/111457
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -1365,8 +1365,9 @@ Error BinaryFunction::disassemble() {
if (containsAddress(TargetAddress)) {
TargetSymbol = getOrCreateLocalLabel(TargetAddress);
} else {
-if (TargetAddress == getAddress() + getSize() &&
-TargetA
https://github.com/aaupov updated
https://github.com/llvm/llvm-project/pull/111771
>From 67faa5f82d5b754f9a0c1f7ded516b5e25ce3f24 Mon Sep 17 00:00:00 2001
From: Amir Ayupov
Date: Wed, 9 Oct 2024 16:56:07 -0700
Subject: [PATCH] fix indentation
Created using spr 1.3.4
---
bolt/test/X86/builtin_
llvmbot wrote:
@llvm/pr-subscribers-bolt
Author: Amir Ayupov (aaupov)
Changes
Lift the restriction that builtin_unreachable has to be strictly within
`MaxSize` of a function.
Test Plan: added builtin_unreachable.s
---
Full diff: https://github.com/llvm/llvm-project/pull/111771.diff
2
https://github.com/aaupov created
https://github.com/llvm/llvm-project/pull/111771
Lift the restriction that builtin_unreachable has to be strictly within
`MaxSize` of a function.
Test Plan: added builtin_unreachable.s
___
llvm-branch-commits maili
klausler wrote:
> While it would be possible to only have a `FortranRuntime/CMakeLists.txt` and
> leave all the other files in `flang/`, I strongly believe this is a bad idea.
> It is the norm for LLVM runtimes to have separate sources.
A Fortran compiler and its runtime are tightly coupled; t
efriedma-quic wrote:
Did you address
https://github.com/llvm/llvm-project/pull/109409#pullrequestreview-2332197449 ?
https://github.com/llvm/llvm-project/pull/109409
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists
https://github.com/efriedma-quic approved this pull request.
LGTM
This should be safe to merge: it only affects usage of the new counted_by
attribute, and this fixes a significant bug blocking usage of that feature.
https://github.com/llvm/llvm-project/pull/111445
_
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/107350
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
arsenm wrote:
> The duplicating is only due to atomicity of the load?
The duplicating is the apparent effect because the non-atomic load can be
deleted. There's no plus to keeping it around
> if (atomic)
> EraseFromParent();
> ```
This just adds extra work for later code to delete. The zex
tschuett wrote:
The duplicating is only due to atomicity of the load?
https://github.com/llvm/llvm-project/blob/4605ba0437728ecf8233ba6dbb52ffba30a22743/llvm/test/CodeGen/AArch64/GlobalISel/prelegalizercombiner-sextload-from-sextinreg.mir#L17
Then I vote for:
```
if (atomic)
EraseFromParent(
tschuett wrote:
I meant: if atomic ...
https://github.com/llvm/llvm-project/pull/111730
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
arsenm wrote:
> Standard question: Could you add/extend a mir file for showing the different
> cases and should the erase be conditional on the type?
The type doesn't matter. The original load always has to be removed. This is
only done for hasOneUse anyway
https://github.com/llvm/llvm-proje
arsenm wrote:
> But patch adds several MUBUF_Pseudo_Load_Pats which are not covered by tests?
The only cases that might have missing coverage is extend to 16-bit register
cases. In the DAG we didn't have legal 16-bit types on gfx6/7, but we could
handle the loads here
https://github.com/ll
arsenm wrote:
> The original test files look unaffected? https://reviews.llvm.org/D85966
I don't think AArch64 will pass the legality check for the atomic sextload
https://github.com/llvm/llvm-project/pull/111730
___
llvm-branch-commits mailing list
l
tschuett wrote:
The original test files look unaffected? https://reviews.llvm.org/D85966
https://github.com/llvm/llvm-project/pull/111730
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/arsenm ready_for_review
https://github.com/llvm/llvm-project/pull/111730
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-llvm-globalisel
Author: Matt Arsenault (arsenm)
Changes
The sext_inreg (load) combine was not deleting the old load instruction,
and it would never be deleted if volatile or atomic.
---
Full diff: https://github.com/llvm/llvm-project/pull/111730.diff
arsenm wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/111730?utm_source=stack-comment-downstack-mergeability-warning";
https://github.com/arsenm created
https://github.com/llvm/llvm-project/pull/111730
The sext_inreg (load) combine was not deleting the old load instruction,
and it would never be deleted if volatile or atomic.
>From 5a23c2797ae59eb493fb9804ec32a1b8dc7755b2 Mon Sep 17 00:00:00 2001
From: Matt Ars
https://github.com/arsenm updated
https://github.com/llvm/llvm-project/pull/111721
>From 81dad077b21128cfc827ffb18b12631407a2bde4 Mon Sep 17 00:00:00 2001
From: Matt Arsenault
Date: Wed, 9 Oct 2024 19:35:29 +0400
Subject: [PATCH] AMDGPU/GlobalISel: Handle atomic sextload and zextload
Atomic lo
topperc wrote:
> Ping.
>
> And some updates on vector support: currently, `ExpandMemCmp` will only
> generate integer types (`i128`, `i256` and so on). So, if we simply add
> `128`, `256`, `vlen` to `LoadSizes`, the LLVM IR will use `i128`/`i256`/...
> and then they are expanded to legal scal
rampitec wrote:
> > Missing test for buffer loads?
>
> Those are the gfx7 global cases. There aren't any atomic buffer load
> intrinsics
But patch adds several MUBUF_Pseudo_Load_Pats which are not covered by tests?
https://github.com/llvm/llvm-project/pull/111721
_
@@ -1144,42 +2872,116 @@ entry:
define i32 @memcmp_size_4(ptr %s1, ptr %s2) nounwind {
; CHECK-ALIGNED-RV32-LABEL: memcmp_size_4:
; CHECK-ALIGNED-RV32: # %bb.0: # %entry
-; CHECK-ALIGNED-RV32-NEXT:addi sp, sp, -16
-; CHECK-ALIGNED-RV32-NEXT:sw ra, 12(sp) # 4-byte
@@ -0,0 +1,331 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
UTC_ARGS: --version 5
+; RUN: llc -global-isel -mtriple=amdgcn-amd-amdhsa -mcpu=kaveri < %s |
FileCheck -check-prefixes=GCN,GFX7 %s
+; RUN: llc -global-isel -mtriple=amdgcn-amd-amdhs
arsenm wrote:
> Missing test for buffer loads?
Those are the gfx7 global cases. There aren't any atomic buffer load intrinsics
https://github.com/llvm/llvm-project/pull/111721
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
ht
Author: Jorge Gorbe Moya
Date: 2024-10-09T10:44:19-07:00
New Revision: cee0873fc83beb441a27b1f0555da54e56aa0910
URL:
https://github.com/llvm/llvm-project/commit/cee0873fc83beb441a27b1f0555da54e56aa0910
DIFF:
https://github.com/llvm/llvm-project/commit/cee0873fc83beb441a27b1f0555da54e56aa0910.di
llvmbot wrote:
@llvm/pr-subscribers-compiler-rt-sanitizer
Author: David CARLIER (devnexen)
Changes
…BSD. (#110246)
For backport #111724
To Fix #110215
Interceptors introduced with 18a7ebda99044473fdbce6376993714ff54e6690
---
Patch is 28.40 KiB, truncated to 20.00 KiB below, full versi
https://github.com/devnexen created
https://github.com/llvm/llvm-project/pull/111725
…BSD. (#110246)
For backport #111724
To Fix #110215
Interceptors introduced with 18a7ebda99044473fdbce6376993714ff54e6690
>From cb632327b87e78506d6d91d1d7244e5a5f5c87e6 Mon Sep 17 00:00:00 2001
From: David C
https://github.com/arsenm edited
https://github.com/llvm/llvm-project/pull/111721
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
@llvm/pr-subscribers-llvm-globalisel
Author: Matt Arsenault (arsenm)
Changes
Atomic loads are handled differently from the DAG, and have separate opcodes
and explicit control over the extensions, like ordinary loads. Add
new patterns for t
https://github.com/arsenm ready_for_review
https://github.com/llvm/llvm-project/pull/111721
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
arsenm wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/111721?utm_source=stack-comment-downstack-mergeability-warning";
https://github.com/arsenm created
https://github.com/llvm/llvm-project/pull/111721
Atomic loads are handled differently from the DAG, and have separate opcodes
and explicit control over the extensions, like ordinary loads. Add
new patterns for these.
There's room for cleanup and improvement. d1
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/107350
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
clementval wrote:
> > How recent is your latest rebase? They are missing files in this PR.
>
> I did not do a rebase since I started working on this PR, maybe 3 weeks ago.
> With new files added/removed upstream and at the same time reviewers probably
> asking to change the move location, keep
arsenm wrote:
ping
https://github.com/llvm/llvm-project/pull/109409
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/jhuber6 approved this pull request.
https://github.com/llvm/llvm-project/pull/111652
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -58,21 +67,62 @@ class MapInfoFinalizationPass
/*corresponding local alloca=*/fir::AllocaOp>
localBoxAllocas;
- void genDescriptorMemberMaps(mlir::omp::MapInfoOp op,
- fir::FirOpBuilder &builder,
-
@@ -82,104 +132,188 @@ class MapInfoFinalizationPass
// perform an alloca and then store to it and retrieve the data from the
new
// alloca.
if (mlir::isa(descriptor.getType())) {
- // If we have already created a local allocation for this BoxType,
- // w
@@ -58,21 +67,62 @@ class MapInfoFinalizationPass
/*corresponding local alloca=*/fir::AllocaOp>
localBoxAllocas;
- void genDescriptorMemberMaps(mlir::omp::MapInfoOp op,
- fir::FirOpBuilder &builder,
-
@@ -107,6 +107,19 @@ unsigned AArch64InstrInfo::getInstSizeInBytes(const
MachineInstr &MI) const {
unsigned NumBytes = 0;
const MCInstrDesc &Desc = MI.getDesc();
+ if (!MI.isBundle() && isTailCallReturnInst(MI)) {
+NumBytes = Desc.getSize() ? Desc.getSize() : 4;
+
+
https://github.com/kovdan01 edited
https://github.com/llvm/llvm-project/pull/110705
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/kovdan01 commented:
@atrosinenko Could you please add a test for the case you've fixed in your
latest commit edaae6a75879a38ffe8cd4e064aa9aca77126ef3? I might be missing
smth, but the fix looks untested.
https://github.com/llvm/llvm-project/pull/110705
__
cor3ntin wrote:
Cherry pick as discussed in #111477
https://github.com/llvm/llvm-project/pull/111660
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/cor3ntin milestoned
https://github.com/llvm/llvm-project/pull/111660
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: cor3ntin (cor3ntin)
Changes
`__has_builtin` was relying on reversible identifiers and string matching to
recognize builtin-type traits, leading to some newer type traits not being
recognized.
Fixes #111477
---
Full diff: https://github.
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/111660
`__has_builtin` was relying on reversible identifiers and string matching to
recognize builtin-type traits, leading to some newer type traits not being
recognized.
Fixes #111477
>From e3ef65bd21443588acb142d
https://github.com/wangpc-pp updated
https://github.com/llvm/llvm-project/pull/107548
>From f21cfcfc90330ee3856746b6315a81a00313b0e0 Mon Sep 17 00:00:00 2001
From: Wang Pengcheng
Date: Fri, 6 Sep 2024 17:20:51 +0800
Subject: [PATCH 1/5] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=
https://github.com/wangpc-pp updated
https://github.com/llvm/llvm-project/pull/107548
>From f21cfcfc90330ee3856746b6315a81a00313b0e0 Mon Sep 17 00:00:00 2001
From: Wang Pengcheng
Date: Fri, 6 Sep 2024 17:20:51 +0800
Subject: [PATCH 1/5] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=
Meinersbur wrote:
> How recent is your latest rebase? They are missing files in this PR.
I did not do a rebase since I started working on this PR, maybe 3 weeks ago.
With new files added/removed upstream and at the same time reviewers probably
asking to change the move location, keeping the PR
Meinersbur wrote:
> This is a gigantic change and I don't understand why it's being made. Why is
> so much code moving out of flang/ ?
As explained in the summary, this is in preparation of #110217.
#110217 changes the libFortranRuntime build to use the `LLVM_ENABLE_RUNTIMES`
build system, l
arsenm wrote:
### Merge activity
* **Oct 9, 5:42 AM EDT**: @arsenm started a stack merge that includes this pull
request via
[Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/110815).
https://github.com/llvm/llvm-project/pull/110815
_
wangpc-pp wrote:
Ping.
And some updates on vector support: currently, `ExpandMemCmp` will only
generate integer types (`i128`, `i256`) and so on. So, if we simply add `128`,
`256`, `vlen` to `LoadSizes`, the LLVM IR will use i128/i256/... and then they
are expanded to legal scalar types as we
@@ -171,145 +76,88 @@ set(sources
unit-map.cpp
unit.cpp
utf.cpp
- ${FORTRAN_MODULE_OBJECTS}
)
-include(AddFlangOffloadRuntime)
-
-# List of files that are buildable for all devices.
-set(supported_files
- ISO_Fortran_binding.cpp
- allocatable.cpp
- allocator-regist
https://github.com/nikic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/110815
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/arsenm ready_for_review
https://github.com/llvm/llvm-project/pull/111652
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
Ayush9054 wrote:
Observation:
It has come to our attention that the changes made in
llvm/lib/CodeGen/MIRParser/MIRParser.cpp are not related to the current pull
request (PR). As these modifications do not pertain directly to the
functionality addressed in this PR, they should be extracted and
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Matt Arsenault (arsenm)
Changes
These should be well behaved address computations.
---
Full diff: https://github.com/llvm/llvm-project/pull/111652.diff
4 Files Affected:
- (modified) llvm/lib/Target/AMDGPU/AMDGPUCtorDtorLowerin
arsenm wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/111652?utm_source=stack-comment-downstack-mergeability-warning";
https://github.com/arsenm created
https://github.com/llvm/llvm-project/pull/111652
These should be well behaved address computations.
>From 61f32fccd4cb7f8ef167ea5e6a7fb8e820a459b2 Mon Sep 17 00:00:00 2001
From: Matt Arsenault
Date: Wed, 9 Oct 2024 13:11:16 +0400
Subject: [PATCH] AMDGPU: Add i
https://github.com/arsenm closed
https://github.com/llvm/llvm-project/pull/103939
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
Author: David Spickett
Date: 2024-10-09T09:54:53+01:00
New Revision: 358ad5760066ef415012732c03fb28ec823f3205
URL:
https://github.com/llvm/llvm-project/commit/358ad5760066ef415012732c03fb28ec823f3205
DIFF:
https://github.com/llvm/llvm-project/commit/358ad5760066ef415012732c03fb28ec823f3205.diff
https://github.com/arsenm updated
https://github.com/llvm/llvm-project/pull/103939
>From b655b4c3d3be5f8347ff4bc8fa37c1553f1fd980 Mon Sep 17 00:00:00 2001
From: Matt Arsenault
Date: Wed, 14 Aug 2024 16:51:08 +0400
Subject: [PATCH 1/2] Local: Handle noalias.addrspace in copyMetadataForLoad
---
https://github.com/arsenm edited
https://github.com/llvm/llvm-project/pull/103939
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -177,7 +177,7 @@ define i32 @test_load_cast_combine_noalias_addrspace(ptr
%ptr) {
; Ensure (cast (load (...))) -> (load (cast (...))) preserves TBAA.
arsenm wrote:
```suggestion
; Ensure (cast (load (...))) -> (load (cast (...))) preserves no
alias.addrspac
https://github.com/frasercrmck approved this pull request.
LGTM other than nit
https://github.com/llvm/llvm-project/pull/103939
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm
@@ -177,7 +177,7 @@ define i32 @test_load_cast_combine_noalias_addrspace(ptr
%ptr) {
; Ensure (cast (load (...))) -> (load (cast (...))) preserves TBAA.
frasercrmck wrote:
Should this comment reference `noalias.addrspace` rather than TBAA?
https://github.com/
https://github.com/cdevadas approved this pull request.
https://github.com/llvm/llvm-project/pull/110229
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
78 matches
Mail list logo