Re: [lldb-dev] [cfe-dev] [RFC] Deprecate pre-commit email code reviews in favor of Phabricator

2021-05-18 Thread Krzysztof Parzyszek via lldb-dev
Post-commit reviews are conducted, in order of preference, on Phabricator, This still seems like a change in practice that I'm not in favor of, personally - due to the current divergence between email and phab review feedback. Yes, this would be one way to unify it - but I'm not sure it's necessa

Re: [lldb-dev] [cfe-dev] [RFC] Deprecate pre-commit email code reviews in favor of Phabricator

2021-05-18 Thread David Blaikie via lldb-dev
On Tue, May 18, 2021 at 6:50 AM Krzysztof Parzyszek wrote: > Post-commit reviews are conducted, in order of preference, on Phabricator, > > This still seems like a change in practice that I'm not in favor of, > personally - due to the current divergence between email and phab review > feedback. Y