Re: [lldb-dev] https://reviews.llvm.org/D69273

2019-11-04 Thread Pavel Labath via lldb-dev
On 04/11/2019 18:19, Jim Ingham wrote: Sorry, my brain is not working this morning, I answered your question in the review comments… Jim NP, maybe let's continue the discussion there? I find it useful to have the actual code change around.. ___ l

Re: [lldb-dev] https://reviews.llvm.org/D69273

2019-11-04 Thread Jim Ingham via lldb-dev
Sorry, my brain is not working this morning, I answered your question in the review comments… Jim > On Nov 4, 2019, at 7:28 AM, Pavel Labath wrote: > > On 31/10/2019 20:51, Jim Ingham via lldb-dev wrote: >> It looks like this change is causing problems with swift. I was talking a >> little

Re: [lldb-dev] https://reviews.llvm.org/D69273

2019-11-04 Thread Pavel Labath via lldb-dev
On 31/10/2019 20:51, Jim Ingham via lldb-dev wrote: It looks like this change is causing problems with swift. I was talking a little bit with Davide about this and it seems like it wasn't obvious how this was designed to work. So here's what this was intended to do (apologies if this is at t

Re: [lldb-dev] https://reviews.llvm.org/D69273

2019-10-31 Thread Davide Italiano via lldb-dev
On Thu, Oct 31, 2019 at 1:06 PM Pavel Labath via lldb-dev wrote: > > (Just writing to say that tomorrow is a public holiday in most of > Europe, so I wont be able to meaningfully reply to this until > monday/tuesday. But if, in the mean time, you want to revert this, or > just limit the scope of t

Re: [lldb-dev] https://reviews.llvm.org/D69273

2019-10-31 Thread Pavel Labath via lldb-dev
(Just writing to say that tomorrow is a public holiday in most of Europe, so I wont be able to meaningfully reply to this until monday/tuesday. But if, in the mean time, you want to revert this, or just limit the scope of that patch somehow, then that's fine with me.) On 31/10/2019 20:51, Jim

Re: [lldb-dev] https://reviews.llvm.org/D69273

2019-10-31 Thread Davide Italiano via lldb-dev
Thanks for the explanation. + Pavel & Adrian. On Thu, Oct 31, 2019 at 12:51 PM Jim Ingham via lldb-dev wrote: > > It looks like this change is causing problems with swift. I was talking a > little bit with Davide about this and it seems like it wasn't obvious how > this was designed to work.