On Tue, Oct 27, 2015 at 8:12 PM, Zachary Turner wrote:
> Todd, I have one question. If I understand correctly, we currently run
> dotest.py as a script, which imports dosep and calls some method in dosep,
> and dosep then again exec's dotest.
>
> Can you think of a pythonic way to make this work
It looks like `lldbsuite.lldb_root` is not getting set correctly for you.
Line 1070 of lldbsuite/test/dotest.py looks like this:
lldbRootDirectory = lldbsuite.lldb_root
`lldbsuite.lldb_root` is set in `packages/Python/lldbsuite/__init__.py`
whenever someone writes `import lldbsuite`. The imp
Can you give me a stack trace?
On Wed, Oct 28, 2015 at 10:37 PM Zachary Turner wrote:
> Shoot, I'm at the LLVM Developers Conference tomorrow and Friday as well.
> Let me eyeball the code and see if I can figure out what might be wrong.
>
>
> On Wed, Oct 28, 2015 at 4:25 PM Greg Clayton wrote:
Shoot, I'm at the LLVM Developers Conference tomorrow and Friday as well.
Let me eyeball the code and see if I can figure out what might be wrong.
On Wed, Oct 28, 2015 at 4:25 PM Greg Clayton wrote:
> Zach: this no longer works:
>
> % ./dotest.py -A x86_64 -C clang -v -t
> /.../packages/Python/
Zach: this no longer works:
% ./dotest.py -A x86_64 -C clang -v -t
/.../packages/Python/lldbsuite/test/functionalities/completion
fill "..." in with your path to your lldb root.
It is unable to find lldb because lldbtest_config.lldbExec isn't set
correctly...
> On Oct 28, 2015, at 12:21 PM,
The fix seems to work -
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/7900
.
Thank you.
On Wed, Oct 28, 2015 at 12:21 PM, Zachary Turner wrote:
> Committed r251544 to try to fix this.
>
> On Wed, Oct 28, 2015 at 12:18 PM Zachary Turner
> wrote:
>
>> It's saying "import
Committed r251544 to try to fix this.
On Wed, Oct 28, 2015 at 12:18 PM Zachary Turner wrote:
> It's saying "import: command not found". Do I need to put a
> `#!/usr/bin/env python` or something at the top? I thought by virtue of
> having a .py extension this would be handled, but maybe not.
>
It's saying "import: command not found". Do I need to put a
`#!/usr/bin/env python` or something at the top? I thought by virtue of
having a .py extension this would be handled, but maybe not.
On Wed, Oct 28, 2015 at 12:16 PM Zachary Turner wrote:
> We can set executable permissions
> on packa
We can set executable permissions
on packages/Python/lldbsuite/test/dotest.py for now. I suppose that's
actually necessary for now since it does tget executed indirectly by dosep.
I plan to remove the need for this, and at the same time make it fail if
you try to run that file directly. Will tha
Linux build bot is failing
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/7895
:
/lldb-buildbot/lldbSlave/buildWorkingDir/scripts/../llvm/tools/lldb/test/dotest.py
--executable
/lldb-buildbot/lldbSlave/buildWorkingDir/scripts/../build/bin/lldb -A i386
-C clang-3.5 -s logs-
This is in right now (without my proposed change from previous email,
although I can make that as a followup since it's just cleanup)
In any case, let me know if anything blows up. It took 35 minutes just to
commit, so hopefully any problems that arise can be fixed with localized
patches instead
Todd, I have one question. If I understand correctly, we currently run
dotest.py as a script, which imports dosep and calls some method in dosep,
and dosep then again exec's dotest.
Can you think of a pythonic way to make this work under the new layout? To
be clear, I have it working, just not i
Ok, I'll do it tomorrow. Since it's a big code move I was a little worried
it would break someone's bot or the Xcode build, but I guess we can deal
with issues that pop up afterwards.
On Tue, Oct 27, 2015 at 5:14 PM Jim Ingham wrote:
> It seems like everybody is okay with the idea of this, so I
It seems like everybody is okay with the idea of this, so I don't see the need
for a review of the details of this stage. If you think there's anything
tricky call it out in words, otherwise I say just commit it.
Jim
> On Oct 27, 2015, at 4:30 PM, Zachary Turner via lldb-dev
> wrote:
>
> I
I have the first part of the patch in, and the second part of the patch
(which is essentially just a whole-folder rename with a couple of fixups)
ready to go. What's the best way to have this reviewed? Uploading a 7MB
patch to Phabricator probably isn't going to work out very well.
On Tue, Oct 2
I think I have a way to split this into two smaller CLs. I'm testing this
at the moment, if so it will allow the first CL to be most of the
preparation for the rename without the rename, and then the second CL
should literally just be a straight move with only 1-2 line code change.
So I'll try to
16 matches
Mail list logo
