Re: [lldb-dev] Problem with watchpoints

2016-09-15 Thread Ted Woodward via lldb-dev
b-dev-boun...@lists.llvm.org] On Behalf Of Jim Ingham via lldb-dev Sent: Monday, September 12, 2016 2:01 PM To: Daniel Noland Cc: lldb-dev@lists.llvm.org Subject: Re: [lldb-dev] Problem with watchpoints > On Sep 12, 2016, at 11:53 AM, Daniel Noland wrote: > > > > On 09/12/2016 1

Re: [lldb-dev] Problem with watchpoints

2016-09-12 Thread Jim Ingham via lldb-dev
> On Sep 12, 2016, at 11:53 AM, Daniel Noland wrote: > > > > On 09/12/2016 11:30 AM, Jim Ingham wrote: >> >>> On Sep 9, 2016, at 7:33 PM, Daniel Noland wrote: >>> >>> Yes, that was pretty much my assessment when I read through the code. >>> >>> My existing patch (which I will post when I g

Re: [lldb-dev] Problem with watchpoints

2016-09-12 Thread Daniel Noland via lldb-dev
On 09/12/2016 11:30 AM, Jim Ingham wrote: > >> On Sep 9, 2016, at 7:33 PM, Daniel Noland wrote: >> >> Yes, that was pretty much my assessment when I read through the code. >> >> My existing patch (which I will post when I get home) takes a very >> conservative approach and only modifies what i

Re: [lldb-dev] Problem with watchpoints

2016-09-12 Thread Jim Ingham via lldb-dev
> On Sep 9, 2016, at 7:33 PM, Daniel Noland wrote: > > Yes, that was pretty much my assessment when I read through the code. > > My existing patch (which I will post when I get home) takes a very > conservative approach and only modifies what is strictly necessary to make > the callback featu

Re: [lldb-dev] Problem with watchpoints

2016-09-09 Thread Daniel Noland via lldb-dev
Yes, that was pretty much my assessment when I read through the code. My existing patch (which I will post when I get home) takes a very conservative approach and only modifies what is strictly necessary to make the callback feature work. That said, I found myself copy / paste / slight changing a

Re: [lldb-dev] Problem with watchpoints

2016-09-09 Thread Jim Ingham via lldb-dev
The main problem with the watchpoint code is that it doesn't share nearly as much of the implementation of options and callback handling with the breakpoints as it should. For instance, there's very little need for WatchpointOptions and BreakpointOptions to be separate classes, they do pretty

Re: [lldb-dev] Problem with watchpoints

2016-09-09 Thread Daniel Noland via lldb-dev
I have also noticed a few problems similar to Ted's and I plan to address them assuming nobody else is already on it. That said, I am new around here so please bear with me :) In fact, I have been hacking on a few watchpoint methods for a while now. I have implemented some features I personally

Re: [lldb-dev] Problem with watchpoints

2016-09-09 Thread Greg Clayton via lldb-dev
> On Sep 8, 2016, at 4:47 PM, Ted Woodward via lldb-dev > wrote: > > I recently discovered a problem with watchpoints talking to the Hexagon > simulator: > > (lldb) w s e 0x1000 > error: Watchpoint creation failed (addr=0x1000, size=4). > error: Target supports (0) hardware watchpoint slots.