Re: [lldb-dev] Problem with dotest_channels.py

2015-12-15 Thread Todd Fiala via lldb-dev
Yeah I'll have a look at what it's doing. I wouldn't expect a return to crash there, just not receive the data. I'm guessing other parts of asyncore code might be doing invalid things with the socket at that point. We do need to be able to handle this case, though, on timeouts that kill the send

Re: [lldb-dev] Problem with dotest_channels.py

2015-12-15 Thread Zachary Turner via lldb-dev
I wonder if you need a flush somewhere before you invoke the cleanup func? Would that do it? It looks like the sending side of the connection is closing before the receiving side has received all its data. On Tue, Dec 15, 2015 at 3:49 PM Adrian McCarthy wrote: > With Todd's change, I was gettin

Re: [lldb-dev] Problem with dotest_channels.py

2015-12-15 Thread Adrian McCarthy via lldb-dev
With Todd's change, I was getting a Ninja crash. Zach and I replaced the returns Todd added with raises, in order to propagate the exception up the stack, and that avoids the Ninja crash, so I'll check that in in a moment. In the mean time, here's the error message we got out of it. 155 out of 4

Re: [lldb-dev] Problem with dotest_channels.py

2015-12-14 Thread Todd Fiala via lldb-dev
Hey Zachary, I just put in: r255581 which should hopefully: (1) catch the exception you see there, (2) handle it gracefully in the common and to-be-expected case of the test inferior going down hard, and (3) print out an error if anything else unexpected is happening here. Let me know if you get

Re: [lldb-dev] Problem with dotest_channels.py

2015-12-14 Thread Todd Fiala via lldb-dev
Yeah that's a messed up exception scenario that is hard to read. I'll figure something out when I repro it. One side is closing before the other is expecting it, but likely in a way we need to expect. I think it is ugly-ified because it is coming from some kind of worker thread within async-core

Re: [lldb-dev] Problem with dotest_channels.py

2015-12-14 Thread Zachary Turner via lldb-dev
If nothing else, maybe we can print out a more useful exception backtrace. What kind of exception, what line, and what was the message? That might help give us a better idea of what's causing it. On Mon, Dec 14, 2015 at 2:03 PM Todd Fiala wrote: > Hi Zachary! > > > > > > On Mon, Dec 14, 2015 at

Re: [lldb-dev] Problem with dotest_channels.py

2015-12-14 Thread Todd Fiala via lldb-dev
Hi Zachary! On Mon, Dec 14, 2015 at 1:28 PM, Zachary Turner via lldb-dev < lldb-dev@lists.llvm.org> wrote: > Hi Todd, lately I've been seeing this sporadically when running the test > suite. > > [TestNamespaceLookup.py FAILED] > Command invoked: C:\Python27_LLDB\x86\python_d.exe > D:\src\llvm