Re: [lldb-dev] Prebuilt binary for Windows

I don't know an easy way to accomplish that. While app-local deployment is now supported, the set of deployed dlls depends on the host OS version (according to this ). I've opened a bug

Re: [lldb-dev] Prebuilt binary for Windows

On Thu, Jan 12, 2017 at 10:18 AM, Vadim Chugunov via lldb-dev < lldb-dev@lists.llvm.org> wrote: > I was referring to this: https://support.microsoft.com/en-us/help/ > 2999226/update-for-universal-c-runtime-in-windows. Granted, it was > probably marked as non-critical, so some users may have skip

Re: [lldb-dev] Prebuilt binary for Windows

On Thu, Jan 12, 2017 at 1:18 PM, Vadim Chugunov via lldb-dev < lldb-dev@lists.llvm.org> wrote: > I was referring to this: https://support.microsoft.com/en-us/help/ > 2999226/update-for-universal-c-runtime-in-windows. Granted, it was > probably marked as non-critical, so some users may have skipp

Re: [lldb-dev] Prebuilt binary for Windows

I was referring to this: https://support.microsoft.com/en-us/help/2999226/update-for-universal-c-runtime-in-windows. Granted, it was probably marked as non-critical, so some users may have skipped it. > One of the redist options is to include an MSU in your installer that tells Windows Update t

Re: [lldb-dev] Prebuilt binary for Windows

> [UCRT] had been pushed to Vista, 7 and 8 via Windows Update I didn't think that was true in general. One of the redist options is to include an MSU in your installer that tells Windows Update to add UCRT to the list of components it updates. So some Vista, 7, and 8 users may have received it

Re: [lldb-dev] Prebuilt binary for Windows

Turner Cc: LLDB Subject: Re: [lldb-dev] Prebuilt binary for Windows On Wed, Jan 11, 2017 at 3:54 PM, Zachary Turner mailto:ztur...@google.com> > wrote: Ahh, that would make sense as well, since LLDB links against liblldb as a dll. Don't see a good solution to this short

Re: [lldb-dev] Prebuilt binary for Windows

On Wed, Jan 11, 2017 at 3:54 PM, Zachary Turner wrote: > Ahh, that would make sense as well, since LLDB links against liblldb as a > dll. Don't see a good solution to this short of forcing dynamic linking. > liblldb has to be a dll because it needs to be visible to python as an > extension modu

Re: [lldb-dev] Prebuilt binary for Windows

Ahh, that would make sense as well, since LLDB links against liblldb as a dll. Don't see a good solution to this short of forcing dynamic linking. liblldb has to be a dll because it needs to be visible to python as an extension module. And if it's a dll and uses static linking, then we would hav

Re: [lldb-dev] Prebuilt binary for Windows

Okay, as far as I can see, the issue is not with Python, but that lldb.exe and liblldb.dll have their own private copies of the CRT. When startup script is given on the command line, lldb.exe creates a pipe, writes the script into the write end, wraps a stdio file around the read end, and gives th

Re: [lldb-dev] Prebuilt binary for Windows

On Wed, Jan 11, 2017 at 1:47 PM Vadim Chugunov wrote: > > Definitely seems CRT / Python related. The call to fgets indicates that > it's doing something involving a FILE*. It's probably a FILE* that refers > to a file created from within Python's copy of the CRT. > > Any idea where in the code

Re: [lldb-dev] Prebuilt binary for Windows

Definitely seems CRT / Python related. The call to fgets indicates that it's doing something involving a FILE*. It's probably a FILE* that refers to a file created from within Python's copy of the CRT. Another problem that dynamic linking would solve. Can you confirm that the problem does not o

Re: [lldb-dev] Prebuilt binary for Windows

BTW, here's the call stack at the point of failure. I don't see anything Python-related in it, so maybe it's some other CRT interaction. liblldb!_invoke_watson(wchar_t * expression = 0x "", wchar_t * function_name = 0x "", wchar_t * file_name = 0x "", unsigned int line_nu

Re: [lldb-dev] Prebuilt binary for Windows

I agree that linking to them dynamically is safer, but then you get into the deployment problem. You do have to redistribute the DLLs for users using anything less than Windows 10. There are several options for doing that: VCRedist, MSMs, MSUs, and app-local deployment. They each have drawbacks

Re: [lldb-dev] Prebuilt binary for Windows

If we do that though, we still get 2 copies of the CRT. One for python and one for LLDB. While I *think* there is a strong enough API boundary in how the application and Python access each others' data structures that it doesn't matter, I'm not 100% sure without further research. It seems safer

Re: [lldb-dev] Prebuilt binary for Windows

I was just reading up on this the other day. Statically linking to the Universal CRT (and related libraries) *is* supported though it's not Microsoft's top recommendation. Initially, they said they weren't going to support app-local deployment, but they backed off on that, and it, too, is now sup

Re: [lldb-dev] Prebuilt binary for Windows

The purpose of linking the CRT statically was to ensure that clang can run on systems that don't have the CRT already installed from some other app or by VS itself. As long as that is preserved, feel free to do whatever you need. I think we still want to link vcruntime140 statically and the C++ ru

Re: [lldb-dev] Prebuilt binary for Windows

Is static CRT even still supported / recommended when using the new Universal CRT? My understanding is the new UCRT is considered a core windows component, so we don't ahve to distribute redistributables anymore. Maybe I'm wrong about this. That said, I think we want dynamic regardless, otherwis

Re: [lldb-dev] Prebuilt binary for Windows

Sorry, just found another problem: the installed lldb crashes when given a script via the command line. For example, `lldb -O "p 42"` dies with exception 0xC409. It didn't happen with the one I've build locally, so I started digging... The difference seems to be that build_llvm_build_package.

Re: [lldb-dev] Prebuilt binary for Windows

Great! Thanks for pushing this. On Tue, Jan 10, 2017 at 7:00 PM, Vadim Chugunov wrote: > Yes, the new build works! > > On Tue, Jan 10, 2017 at 6:20 PM, Hans Wennborg wrote: >> >> I've downgraded my swig to 3.0.8 and built a new snapshot (r291454). >> Please let me know if that works. >> >> On Tu

Re: [lldb-dev] Prebuilt binary for Windows

Yes, the new build works! On Tue, Jan 10, 2017 at 6:20 PM, Hans Wennborg wrote: > I've downgraded my swig to 3.0.8 and built a new snapshot (r291454). > Please let me know if that works. > > On Tue, Jan 10, 2017 at 10:14 AM, Zachary Turner > wrote: > > It sounds like the solution to the problem

Re: [lldb-dev] Prebuilt binary for Windows

I've downgraded my swig to 3.0.8 and built a new snapshot (r291454). Please let me know if that works. On Tue, Jan 10, 2017 at 10:14 AM, Zachary Turner wrote: > It sounds like the solution to the problem is to downgrade SWIG on the build > machine. If it's using version 3.0.9 or higher, just use

Re: [lldb-dev] Prebuilt binary for Windows

It sounds like the solution to the problem is to downgrade SWIG on the build machine. If it's using version 3.0.9 or higher, just use whatever the last version before that is. 3.0.8, for example. At least there's a good workaround in the interim (i.e. setting PYTHONPATH) On Tue, Jan 10, 2017 at

Re: [lldb-dev] Prebuilt binary for Windows

I'll do another snapshot maybe next week or the week after. You can also ping me if you want it sooner or later. We're kicking off the release process for 4.0.0 on Thursday. I don't fully understand the problem here, but if there's some way to work around it and get lldb into good shape for the 4.

Re: [lldb-dev] Prebuilt binary for Windows

This appears to be a SWIG bug: https://github.com/swig/swig/issues/769 On Mon, Jan 9, 2017 at 9:14 PM, Vadim Chugunov wrote: > It worked! > > ...but not before I set PYTHONPATH=C:\Program Files > (x86)\LLVM\lib\site-packages\lldb > Without that, it couldn't find the _lldb module, so we are not q

Re: [lldb-dev] Prebuilt binary for Windows

It worked! ...but not before I set PYTHONPATH=C:\Program Files (x86)\LLVM\lib\site-packages\lldb Without that, it couldn't find the _lldb module, so we are not quite out of the woods yet. When are you planning to make the next snapshot build? Thanks! On Mon, Jan 9, 2017 at 3:48 PM, Hans Wennbor

Re: [lldb-dev] Prebuilt binary for Windows

Vadim, it looks like your change was committed in r291291, and I've built a new snapshot today which includes it. Can you give it a try and see if everything works? Cheers, Hans On Thu, Jan 5, 2017 at 10:46 AM, Zachary Turner wrote: > I will commit it, in the meantime can you request commit acce

Re: [lldb-dev] Prebuilt binary for Windows

I will commit it, in the meantime can you request commit access so that any future patches you can commit? On Wed, Jan 4, 2017 at 1:54 PM Vadim Chugunov wrote: > Thanks! > > Would anyone be so kind to commit that? > > On Wed, Jan 4, 2017 at 11:47 AM, Zachary Turner > wrote: > > Sorry, a combina

Re: [lldb-dev] Prebuilt binary for Windows

Thanks! Would anyone be so kind to commit that? On Wed, Jan 4, 2017 at 11:47 AM, Zachary Turner wrote: > Sorry, a combination of national holidays and extended vacations happened > and this fell off my radar. lgtm > > On Wed, Jan 4, 2017 at 11:46 AM Vadim Chugunov wrote: > >> Zachary, >> Can

Re: [lldb-dev] Prebuilt binary for Windows

Sorry, a combination of national holidays and extended vacations happened and this fell off my radar. lgtm On Wed, Jan 4, 2017 at 11:46 AM Vadim Chugunov wrote: > Zachary, > Can you please take a look at that change? ( > https://reviews.llvm.org/D27476) > > It'll be sad if another snapshot buil