Re: [lldb-dev] LLDB Demangling

2018-07-26 Thread Pavel Labath via lldb-dev
On Wed, 25 Jul 2018 at 19:15, Stefan Gränitz wrote: > > right now the Symtab class builds a table containing all > > demangled names. This is mostly unnecessary, and > What exact table are you referring to here? The m_name_to_index map does > store both, demangled and mangled strings. Not sure to

Re: [lldb-dev] LLDB Demangling

2018-07-26 Thread Stefan Gränitz via lldb-dev
One more short question, as you seem to be much more familiar with the code than me. Maybe you have an idea? In the unit test I prepared, I didn't manage to cover this line in Symtab::InitNameIndexes(): https://github.com/llvm-mirror/lldb/blob/master/source/Symbol/Symtab.cpp#L348 With both demang

Re: [lldb-dev] LLDB Demangling

2018-07-25 Thread Stefan Gränitz via lldb-dev
Hi Pavel, thanks for your feedback! > I would propose to create a new class (RichMangingInfo?), which would > wrap both ItaniumPartialDemangler and the existing string-chopping > implementation, and provide a unified interface on top of them. Right, good point. Adding an abstraction like this cert

Re: [lldb-dev] LLDB Demangling

2018-07-25 Thread Pavel Labath via lldb-dev
Hello Stefan, thank you for working on this. I believe this work will bring a huge improvement to LLDB. Adding something like DemangleWithRichNameIndexInfo to the Mangled class makes sense to me. However, I don't think that function should be taking an ItaniumPartialDemangler as an argument. The