Re: [lldb-dev] LLDB: Unwinding based on Assembly Instruction Profiling

2015-10-30 Thread Jason Molenda via lldb-dev
Hi Abhishek, > On Oct 30, 2015, at 6:56 AM, Abhishek Aggarwal wrote: > > When eh_frame has epilogue description as well, the Assembly profiler > doesn't need to augment it. In this case, is eh_frame augmented unwind > plan used as Non Call Site Unwind Plan or Assembly based Unwind Plan > is use

Re: [lldb-dev] LLDB: Unwinding based on Assembly Instruction Profiling

2015-10-19 Thread Jason Molenda via lldb-dev
> On Oct 19, 2015, at 2:54 PM, Jason Molenda via lldb-dev > wrote: > Greg's original statement isn't correct -- about a year ago Tong Shen changed > lldb to using eh_frame for the currently-executing frame. While it is true > that eh_frame is not guaranteed to describe the prologue/epilogue,

Re: [lldb-dev] LLDB: Unwinding based on Assembly Instruction Profiling

2015-10-19 Thread Jason Molenda via lldb-dev
Hi all, sorry I missed this discussion last week, I was a little busy. Greg's original statement isn't correct -- about a year ago Tong Shen changed lldb to using eh_frame for the currently-executing frame. While it is true that eh_frame is not guaranteed to describe the prologue/epilogue, in p

Re: [lldb-dev] LLDB: Unwinding based on Assembly Instruction Profiling

2015-10-15 Thread Tamas Berghammer via lldb-dev
If we are trying to unwind from a non call site (frame 0 or signal handler) then the current implementation first try to use the non call site unwind plan (usually assembly emulation) and if that one fails then it will fall back to the call site unwind plan (eh_frame, compact unwind info, etc.) ins

Re: [lldb-dev] LLDB: Unwinding based on Assembly Instruction Profiling

2015-10-14 Thread Greg Clayton via lldb-dev
> On Oct 14, 2015, at 1:02 PM, Joerg Sonnenberger via lldb-dev > wrote: > > On Wed, Oct 14, 2015 at 11:42:06AM -0700, Greg Clayton via lldb-dev wrote: >> EH frame can't be used to unwind when we are in the first frame because >> it is only valid at call sites. It also can't be used in frames th

Re: [lldb-dev] LLDB: Unwinding based on Assembly Instruction Profiling

2015-10-14 Thread Joerg Sonnenberger via lldb-dev
On Wed, Oct 14, 2015 at 11:42:06AM -0700, Greg Clayton via lldb-dev wrote: > EH frame can't be used to unwind when we are in the first frame because > it is only valid at call sites. It also can't be used in frames that > are asynchronously interrupted like signal handler frames. This is not neces

Re: [lldb-dev] LLDB: Unwinding based on Assembly Instruction Profiling

2015-10-14 Thread Greg Clayton via lldb-dev
EH frame can't be used to unwind when we are in the first frame because it is only valid at call sites. It also can't be used in frames that are asynchronously interrupted like signal handler frames. So at frame zero, we typically just fall back to the default unwind plan for the current archit