Re: [lldb-dev] something just toasted the test suite on OS X

Okay. I'm stuck fixing the OS X build, but if you have something else to check, feel free to send it over my way and I can run it on another machine. On Tue, Jan 26, 2016 at 7:52 PM, Zachary Turner wrote: > Humm.. it's a unicode literal, not sure why it's complaining. I guess > I'll have to c

Re: [lldb-dev] something just toasted the test suite on OS X

Humm.. it's a unicode literal, not sure why it's complaining. I guess I'll have to crack open my linux machine and see what's going on tomorrow. On Tue, Jan 26, 2016 at 6:12 PM Todd Fiala wrote: > I'm still getting a lot of these: > > > Traceback (most recent call last): > File "test/dotest.

Re: [lldb-dev] something just toasted the test suite on OS X

I'm still getting a lot of these: Traceback (most recent call last): File "test/dotest.py", line 7, in lldbsuite.test.run_suite() File "/Users/tfiala/src/lldb-tot/lldb/packages/Python/lldbsuite/test/dotest.py", line 1089, in run_suite resultclass=test_result.LLDBTestResult).run(confi

Re: [lldb-dev] something just toasted the test suite on OS X

Oh missed this. I'll give it a shot, hang on. On Tue, Jan 26, 2016 at 5:14 PM, Zachary Turner wrote: > Bump. Can I re-submit this? > > On Tue, Jan 26, 2016 at 10:54 AM Zachary Turner > wrote: > >> Can one of you guys try out this patch and see if it works? If so I'll >> commit it. >> >> I do

Re: [lldb-dev] something just toasted the test suite on OS X

Bump. Can I re-submit this? On Tue, Jan 26, 2016 at 10:54 AM Zachary Turner wrote: > Can one of you guys try out this patch and see if it works? If so I'll > commit it. > > I don't know of a way to make this "elegant". i.e. a single syntax / > paradigm that works in both versions without intr

Re: [lldb-dev] something just toasted the test suite on OS X

Can one of you guys try out this patch and see if it works? If so I'll commit it. I don't know of a way to make this "elegant". i.e. a single syntax / paradigm that works in both versions without introducing any helper functions. On Tue, Jan 26, 2016 at 12:26 AM Zachary Turner wrote: > No wo

Re: [lldb-dev] something just toasted the test suite on OS X

No worries, worst case scenario a sledgehammer solution is to change all the places where we write to the session file to convert to unicode first (which would be a trivial conversion, since everything is going to be ascii, which is already valid utf 8). The reason a problem arose at all is becaus

Re: [lldb-dev] something just toasted the test suite on OS X

Okay we're back to green here: http://lab.llvm.org:8080/green/job/lldb_build_test/16173/ Thanks, Enrico! Zachary, I may let this rest until the morning. If you want to try something else, shoot me a patch and I'll gladly try it. -Todd On Mon, Jan 25, 2016 at 9:16 PM, Todd Fiala wrote: > It's

Re: [lldb-dev] something just toasted the test suite on OS X

It's in item 3 from Effective Python, by Brett Slatkin, which goes over having methods that always go to unicode or to byte streams taking either unicode or byte style strings, for both Python 2 and Python 3. Essentially you figure out what you want it to be in, and you write a couple helper route

Re: [lldb-dev] something just toasted the test suite on OS X

I'm also not sure why Linux isn't failing. Looking at the documentation for io.write https://docs.python.org/2/library/io.html#text-i-o> object, i see this: write(*s*) Write the unicode

Re: [lldb-dev] something just toasted the test suite on OS X

Hah the comedy of late night emails. We all go away for hours, then all get back here within minutes :-) (Zachary - I will still have a look at it tonight since I am curious why we weren't seeing it on all the (what I think are) Python 2.7-based systems). On Mon, Jan 25, 2016 at 9:02 PM, Enrico

Re: [lldb-dev] something just toasted the test suite on OS X

Should be reverted in 258791. Sent from my iPhone > On Jan 25, 2016, at 8:54 PM, Zachary Turner wrote: > > sorry, yea I stuck around for a while after that patch waiting for emails, > but nothing came through. Please revert in the meantime, I'll work on a fix > tomorrow. > >> On Mon, Jan 25

Re: [lldb-dev] something just toasted the test suite on OS X

Oh no worries, I borked the builder email on our currently cumbersome multi-step process. They're failing with a permutation of this: Traceback (most recent call last): File "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2224, in dsym_test_

Re: [lldb-dev] something just toasted the test suite on OS X

sorry, yea I stuck around for a while after that patch waiting for emails, but nothing came through. Please revert in the meantime, I'll work on a fix tomorrow. On Mon, Jan 25, 2016 at 8:52 PM Todd Fiala via lldb-dev < lldb-dev@lists.llvm.org> wrote: > I think I see what happened w/r/t why no em

Re: [lldb-dev] something just toasted the test suite on OS X

I think I see what happened w/r/t why no emails when out when the build went heavy red. (Well they went out internally, but not externally). When I made the change on Friday to improve the workflow for the Green Dragon OS X builder and test output, I switched email over to the builder step, which

Re: [lldb-dev] something just toasted the test suite on OS X

Well our whole test suite just stopped running, so yes. On Mon, Jan 25, 2016 at 6:58 PM, Enrico Granata wrote: > > On Jan 25, 2016, at 6:48 PM, Todd Fiala via lldb-dev < > lldb-dev@lists.llvm.org> wrote: > > Not sure exactly what it is, but all the tests are failing due to some bad > assumptions

Re: [lldb-dev] something just toasted the test suite on OS X

> On Jan 25, 2016, at 6:48 PM, Todd Fiala via lldb-dev > wrote: > > Not sure exactly what it is, but all the tests are failing due to some bad > assumptions of unicode vs. str on Python 2 vs. 3 if I had to guess. > Author: zturner Date: Mon Jan 25 18:59:42 2016 New Revision: 258759 URL: htt

[lldb-dev] something just toasted the test suite on OS X

Not sure exactly what it is, but all the tests are failing due to some bad assumptions of unicode vs. str on Python 2 vs. 3 if I had to guess. I am not going to be able to look at details on that, but here's a link to the log on the OS X builder: http://lab.llvm.org:8080/green/job/lldb_build_test