Re: [lldb-dev] lldb fails to hit breakpoint when line maps to multiple addresses

2015-10-08 Thread Jim Ingham via lldb-dev
> On Oct 7, 2015, at 5:07 PM, Jim Ingham wrote: > > Another way to do this - which I thought about originally but rejected as too > much delicate machinery for the desired effect - is to add the notion of > "clusters" of locations to the breakpoint. Instead of eliding all the > segments with

Re: [lldb-dev] lldb fails to hit breakpoint when line maps to multiple addresses

2015-10-07 Thread Jim Ingham via lldb-dev
> On Oct 7, 2015, at 4:39 PM, d...@burble.org wrote: > > On Mon, Oct 05, 2015 at 03:01:28PM -0700, Jim Ingham wrote: >> >> Given that, the best lldb can do is use heuristics, and the best heuristic I >> had was Block == basic block??? > > Can you at least check for branches then? (Yes, that

Re: [lldb-dev] lldb fails to hit breakpoint when line maps to multiple addresses

2015-10-07 Thread via lldb-dev
On Mon, Oct 05, 2015 at 03:01:28PM -0700, Jim Ingham wrote: > > Given that, the best lldb can do is use heuristics, and the best heuristic I > had was Block == basic block??? Can you at least check for branches then? (Yes, that would require dissassebly). > The motivation is that compilers

Re: [lldb-dev] lldb fails to hit breakpoint when line maps to multiple addresses

2015-10-05 Thread Jim Ingham via lldb-dev
> On Sep 23, 2015, at 6:39 PM, d...@burble.org wrote: > > On Wed, Sep 23, 2015 at 11:44:41AM -0700, Greg Clayton wrote: >> We currently coalesce breakpoints to avoid the user stopping multiple times >> on the same source line. This might have been done to avoid stepping issues >> we might have

Re: [lldb-dev] lldb fails to hit breakpoint when line maps to multiple addresses

2015-09-24 Thread via lldb-dev
On Thu, Sep 24, 2015 at 02:34:39PM -0700, Greg Clayton wrote: > > I only want to add options if we have a split community on what the right > thing to do is. I believe we should be able to come up with a solution that > makes sense that everyone will like. You might check the SVN history on the

Re: [lldb-dev] lldb fails to hit breakpoint when line maps to multiple addresses

2015-09-24 Thread Greg Clayton via lldb-dev
> On Sep 23, 2015, at 6:39 PM, d...@burble.org wrote: > > On Wed, Sep 23, 2015 at 11:44:41AM -0700, Greg Clayton wrote: >> We currently coalesce breakpoints to avoid the user stopping multiple times >> on the same source line. This might have been done to avoid stepping issues >> we might have

Re: [lldb-dev] lldb fails to hit breakpoint when line maps to multiple addresses

2015-09-23 Thread via lldb-dev
On Wed, Sep 23, 2015 at 11:44:41AM -0700, Greg Clayton wrote: > We currently coalesce breakpoints to avoid the user stopping multiple times > on the same source line. This might have been done to avoid stepping issues > we might have had in the past, but we have made many modifications to > step

Re: [lldb-dev] lldb fails to hit breakpoint when line maps to multiple addresses

2015-09-23 Thread Greg Clayton via lldb-dev
We currently coalesce breakpoints to avoid the user stopping multiple times on the same source line. This might have been done to avoid stepping issues we might have had in the past, but we have made many modifications to stepping such that the step thread plans now know how to step through two

[lldb-dev] lldb fails to hit breakpoint when line maps to multiple addresses

2015-09-22 Thread via lldb-dev
We have a case where a source breakpoint isn't hit because the source line maps to 2 addresses in the debug info and lldb only sets 1 BP on the first address which is in a basic block that is rarely executed. The codegen looks something like this (in pseudo code): some_code br lbl