Re: [lldb-dev] Possible bug in DataExtractor::GetMaxU64Bitfield

2019-12-05 Thread Shafik Yaghmour via lldb-dev
Ted, This was a good catch! I landed a patch for this a little while ago: https://reviews.llvm.org/D70992 Thank you > On Nov 25, 2019, at 9:49 AM, Ted Woodward via lldb-dev > wrote: > > Here’s an interesting bug, in source/Utility/DataExtractor.cpp, > DataE

[lldb-dev] Possible bug in DataExtractor::GetMaxU64Bitfield

2019-11-25 Thread Ted Woodward via lldb-dev
Here's an interesting bug, in source/Utility/DataExtractor.cpp, DataExtractor::GetMaxU64Bitfield: uint64_t bitfield_mask = ((1ul << bitfield_bit_size) - 1); In Visual Studio 2017, ul is a 32 bit type. When I run it with a size of 36 (from large_packed in test/API/lang/c/bitfields/main.c), I