Implemented a fix in: https://reviews.llvm.org/D44015
Could you please review it?
Em 28/02/2018 16:07, Pavel Labath escreveu:
> I think this is the interesting part: std::__uniq_ptr_impl std::default_delete >
>
> There is no such type in the example I posted. It looks like the
> implementation of
I think this is the interesting part: std::__uniq_ptr_impl >
There is no such type in the example I posted. It looks like the
implementation of std::unique_ptr changed, and they added an extra
member object. This tells me the fix should be in the data formatter
for std::unique_ptr and not std::tup
All the test cases in TestDataFormatterStdUniquePtr were failing.
My std::unique_ptr layout is:
(std::unique_ptr >) iup = {
(std::__uniq_ptr_impl >) _M_t = {
(std::tuple >) _M_t = {
(std::_Tuple_impl<0, int *, std::default_delete >)
std::_Tuple_impl<0, int *, std::defa
Then the question becomes how can we identify the STL that is being used
correctly so we can do the right thing. I worry that if std::unique_ptr isn't
working that many many other STL things won't work as well. We are tuned for a
specific STL
> On Feb 27, 2018, at 2:12 PM, Pavel Labath via lldb
This probably isn't arch-dependent. More likely you just have a
different version of libstdc++. Can you share how the std::unique_ptr
layout looks like for you. This is how my std::unique_ptr looks like
(from libstdc++.so.6.0.22):
(lldb) fr var X -R -T
(std::unique_ptr >) X = {
(std::unique_ptr
It depends on the version of the C++ standard library you are using. Is this
the only thing that isn't working in the STL data formatters? I would expect
the STL library to be the same on PowerPC as it is on other platforms so I
wouldn't guess this would be an issue that is arch dependent.
Greg
Hi,
LLDB is printing a empty value for unique pointers in PowerPC.
And I am investigating a solution for this problem.
The problem occurs because the ptr_obj variable has a empty value in
Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp:73.
I could solve it, changing this line
Plugins/Lan