The classes appear to be all forward declared intentionally, so you'd need
to include a lot of missing files. Just moving the destructor to cpp file
should be pretty easy and still allow to keep the header footprint down,
which speeds up build times.
On Thu, Oct 22, 2015 at 11:22 AM Eugene Zelenk
On Thu, Oct 22, 2015 at 11:15 AM, Zachary Turner wrote:
> For the disassembler patch, the problem is you've defaulted the destructor
> but you've got a unique_ptr to a forward declared class. MSVC is actually
> correct in failing to compile this, and I'm not sure why other compilers are
> accepti
For the disassembler patch, the problem is you've defaulted the destructor
but you've got a unique_ptr to a forward declared class. MSVC is actually
correct in failing to compile this, and I'm not sure why other compilers
are accepting it. My guess is something to do with the order of includes
fr
Hi, Zachary!
On Thu, Oct 22, 2015 at 9:34 AM, Zachary Turner wrote:
> I'm taking a look now. In the future please revert changes that break a
> buildbot. If you think you might know what the fix is (i.e. you guess that
> including a header will fix it), then you can just check it in as a test.
>
It looks like you're generating these diffs from an SVN repo, so I'm seeing
lldb/trunk in the paths. Because of that, I can't apply it on my git repo
which doesn't have the "trunk" folder. Can you generate the diffs for the
2 aforementioned CLs by cding into the trunk directory and generating the
I'm taking a look now. In the future please revert changes that break a
buildbot. If you think you might know what the fix is (i.e. you guess that
including a header will fix it), then you can just check it in as a test.
If after a few attempts you still can't figure it out, then revert the
change
Hi!
I broke couple of times MSVC builds when committed minor code
cleanups. Looks like problem occurred because of changed order of
headers.
I could not investigated problems myself, because I don't have access to MSVC.
Changes in question:
r250872:
source/Plugins/Disassembler/llvm/Disassemble
