Re: [lldb-dev] File::Read does not read everything

2016-10-17 Thread Eugene Birukov via lldb-dev
Done. https://reviews.llvm.org/D25712 Sent from Outlook<http://aka.ms/weboutlook> From: Zachary Turner Sent: Monday, October 17, 2016 5:24 PM To: Eugene Birukov; Greg Clayton Cc: LLDB Subject: Re: [lldb-dev] File::Read does not read everything

Re: [lldb-dev] File::Read does not read everything

2016-10-17 Thread Zachary Turner via lldb-dev
Outlook <http://aka.ms/weboutlook> > > > -- > *From:* Zachary Turner > *Sent:* Monday, October 17, 2016 5:01 PM > *To:* Eugene Birukov; Greg Clayton > > *Cc:* LLDB > *Subject:* Re: [lldb-dev] File::Read does not read everything > Can

Re: [lldb-dev] File::Read does not read everything

2016-10-17 Thread Eugene Birukov via lldb-dev
ukov; Greg Clayton Cc: LLDB Subject: Re: [lldb-dev] File::Read does not read everything Can you upload a diff (with context) to phabricator and add lldb-commits as a subscriber and myself / Greg as reviewers? On Mon, Oct 17, 2016 at 4:59 PM Eugene Birukov via lldb-dev mailto:lldb-dev@lists.llvm.

Re: [lldb-dev] File::Read does not read everything

2016-10-17 Thread Zachary Turner via lldb-dev
lse > > > > Sent from Outlook <http://aka.ms/weboutlook> > > > -- > *From:* Greg Clayton > *Sent:* Monday, October 17, 2016 12:39 PM > *To:* Eugene Birukov > *Cc:* LLDB > *Subject:* Re: [lldb-dev] File::Read does not read everything

Re: [lldb-dev] File::Read does not read everything

2016-10-17 Thread Eugene Birukov via lldb-dev
eft -= bytes_read; +pos += bytes_read; +} } } else Sent from Outlook<http://aka.ms/weboutlook> From: Greg Clayton Sent: Monday, October 17, 2016 12:39 PM To: Eugene Birukov Cc: LLDB Subject: Re: [lldb-de

Re: [lldb-dev] File::Read does not read everything

2016-10-17 Thread Greg Clayton via lldb-dev
It is probably best to make the code loop as long as "bytes_reads > 0" and we haven't read "num_bytes" yet. The darwin kernel has a INT32_MAX read size which gets set to MAX_READ_SIZE, but we need to do that because if you try to read more than that it reads nothing. So MAX_READ_SIZE is more for

[lldb-dev] File::Read does not read everything

2016-10-17 Thread Eugene Birukov via lldb-dev
Hello, I am using LLDB 3.9 on Linux Ubuntu. I am loading a 5GiB core which is located on Windows file share mounted on Linux via mount.cifs. I see that we successfully allocated memory and are trying to fill it in one read. Unfortunately pread returns 2GiB and we never check for short read her