Re: [lldb-dev] [llvm-dev] [RFC] Runtime checks for ABI breaking build of LLVM

2016-11-19 Thread Chris Bieneman via lldb-dev
Mehdi, I think your second approach is the better option. Going with the first option means we would need to remove references to llvm-config.h in ADT, which I don't think is a simple task. -Chris > On Nov 18, 2016, at 4:23 PM, Mehdi Amini via llvm-dev > wrote: > > >> On Nov 18, 2016, at 3

Re: [lldb-dev] [llvm-dev] [RFC] Runtime checks for ABI breaking build of LLVM

2016-11-18 Thread Mehdi Amini via lldb-dev
> On Nov 18, 2016, at 3:45 PM, Mehdi Amini wrote: > > Hi, > > I had to revert it, because it breaks building LLDB on MacOS. > > It turns out it would break any client that is including llvm-config.h but > not linking to libLLVMSupport. > So either: > > - we shouldn’t allow to include llvm-co

Re: [lldb-dev] [llvm-dev] [RFC] Runtime checks for ABI breaking build of LLVM

2016-11-18 Thread Mehdi Amini via lldb-dev
Hi, I had to revert it, because it breaks building LLDB on MacOS. It turns out it would break any client that is including llvm-config.h but not linking to libLLVMSupport. So either: - we shouldn’t allow to include llvm-config.h without linking to LLVM, in which case I need to look a bit close