Re: [lldb-dev] [cfe-dev] [llvm-dev] RFC: Code Review Process

2021-10-07 Thread David Blaikie via lldb-dev
On Thu, Oct 7, 2021 at 3:44 PM Renato Golin wrote: > On Thu, 7 Oct 2021 at 23:16, David Blaikie wrote: > >> I don't think diversity necessarily relates to this aspect of managerial >> structure. Unless we're talking about the less benevolent dictatorships >> where the authority figures both prov

Re: [lldb-dev] [cfe-dev] [llvm-dev] RFC: Code Review Process

2021-10-07 Thread Renato Golin via lldb-dev
On Thu, 7 Oct 2021 at 23:16, David Blaikie wrote: > I don't think diversity necessarily relates to this aspect of managerial > structure. Unless we're talking about the less benevolent dictatorships > where the authority figures both provide structure, but also set some > fairly negative tones fo

Re: [lldb-dev] [cfe-dev] [llvm-dev] RFC: Code Review Process

2021-10-07 Thread David Blaikie via lldb-dev
On Thu, Oct 7, 2021 at 3:02 PM Renato Golin wrote: > On Thu, 7 Oct 2021 at 22:31, David Blaikie wrote: > >> This is how we've always done it so far and it has been working well. At >>> least most people I know think that this is better than most other >>> alternatives, including ad-hoc decision

Re: [lldb-dev] [cfe-dev] [llvm-dev] RFC: Code Review Process

2021-10-07 Thread Renato Golin via lldb-dev
On Thu, 7 Oct 2021 at 22:31, David Blaikie wrote: > This is how we've always done it so far and it has been working well. At >> least most people I know think that this is better than most other >> alternatives, including ad-hoc decision making plans. >> > > I'm not sure I'd say it's been working

Re: [lldb-dev] [cfe-dev] [llvm-dev] RFC: Code Review Process

2021-10-07 Thread David Blaikie via lldb-dev
On Thu, Oct 7, 2021 at 2:22 PM Renato Golin via cfe-dev < cfe-...@lists.llvm.org> wrote: > On Thu, 7 Oct 2021 at 21:48, Reid Kleckner wrote: > >> I want to take the other side here, and say that I appreciate that the >> board is trying to provide more structure for this decision making process. >

Re: [lldb-dev] [cfe-dev] [llvm-dev] RFC: Code Review Process

2021-10-07 Thread Renato Golin via lldb-dev
On Thu, 7 Oct 2021 at 21:48, Reid Kleckner wrote: > I want to take the other side here, and say that I appreciate that the > board is trying to provide more structure for this decision making process. > I don't think the board is trying to step in and take ownership of the > decision, they are tr

Re: [lldb-dev] [cfe-dev] [llvm-dev] RFC: Code Review Process

2021-10-07 Thread Reid Kleckner via lldb-dev
On Tue, Oct 5, 2021 at 9:48 AM Renato Golin via cfe-dev < cfe-...@lists.llvm.org> wrote: > On Tue, 5 Oct 2021 at 17:06, Tom Stellard via llvm-dev < > llvm-...@lists.llvm.org> wrote: > >> - Any other information that you think will help the Board of Directors >> make the best decision. > > - Founda

Re: [lldb-dev] [cfe-dev] [llvm-dev] RFC: Code Review Process

2021-10-07 Thread Raphael Isemann via lldb-dev
Just two comments on the process here: 1. I don't think we can really make a 'wrong' decision regarding what code review platform we use. While Github's review interface has its own problems, it's not so bad that it would actually prevent people from reviewing code. Having said that, the only way