[lldb-dev] Running Clang-format automatically in CMake

2016-09-06 Thread Eugene Zelenko via lldb-dev
Hi! Since LLDB code is freshly formatted, it may make sense to run Clang-format automatically via CMake. If not as part of regular build, but may be subtarget of install or check targets as it done in Polly. Eugene. ___ lldb-dev mailing list lldb-dev@li

[lldb-dev] Some thought on LLDB Evolution: Good Citizenship in the LLVM Community

2016-08-09 Thread Eugene Zelenko via lldb-dev
Hi! I'd like to propose couple of topics on "Good Citizenship in the LLVM Community": 1) LLDB developers should participate in release process. Process of LLDB release validation is unclear. At least there are no LLDB binaries in http://llvm.org/pre-releases/3.9.0/rc1/clang+llvm-3.9.0-rc1-x86_64

Re: [lldb-dev] Incorrect libclang dependency in standalone build

2016-06-10 Thread Eugene Zelenko via lldb-dev
On Fri, Jun 10, 2016 at 4:25 PM, Pavel Labath wrote: > This is a side-effect of the cmake version bump to 3.4. Cmake now > errors out on non-existing targets. You'll need to figure out a way to > avoid adding this target to the dependency list. Patches welcome. :) Comment in cmake/modules/AddLLDB

[lldb-dev] Incorrect libclang dependency in standalone build

2016-06-10 Thread Eugene Zelenko via lldb-dev
Hi! I got next message for each internal library when building standalone LLDB on RHEL 6: CMake Warning (dev) at cmake/modules/AddLLDB.cmake:90 (add_dependencies): Policy CMP0046 is not set: Error on non-existent dependency in add_dependencies. Run "cmake --help-policy CMP0046" for policy de

Re: [lldb-dev] Standalone build broken after r269332

2016-05-16 Thread Eugene Zelenko via lldb-dev
Hi, Pavel! On Mon, May 16, 2016 at 3:04 AM, Pavel Labath wrote: > Hi Eugene, > > my thoughts on this are inline. > > At which stage does the build now fail for you (after applying the > fixes above)? Build failed at very beginning: source/lldb.cpp:19:10: fatal error: 'clang/Basic/Version.h' fil

[lldb-dev] Standalone build broken after r269332

2016-05-13 Thread Eugene Zelenko via lldb-dev
Hi! I tried to build standalone LLDB after r269332 change in LLDBStandalone.cmake and encountered next problems: It implies that LLVM and Clang were built separately, but they could be built together, so next changes should be made as in previous version: - include("${LLVM_OBJ_ROOT}/lib${LLVM_

Re: [lldb-dev] Help with MSVC build issues

2015-10-22 Thread Eugene Zelenko via lldb-dev
On Thu, Oct 22, 2015 at 11:15 AM, Zachary Turner wrote: > For the disassembler patch, the problem is you've defaulted the destructor > but you've got a unique_ptr to a forward declared class. MSVC is actually > correct in failing to compile this, and I'm not sure why other compilers are > accepti

Re: [lldb-dev] Help with MSVC build issues

2015-10-22 Thread Eugene Zelenko via lldb-dev
Hi, Zachary! On Thu, Oct 22, 2015 at 9:34 AM, Zachary Turner wrote: > I'm taking a look now. In the future please revert changes that break a > buildbot. If you think you might know what the fix is (i.e. you guess that > including a header will fix it), then you can just check it in as a test. >

[lldb-dev] Help with MSVC build issues

2015-10-22 Thread Eugene Zelenko via lldb-dev
Hi! I broke couple of times MSVC builds when committed minor code cleanups. Looks like problem occurred because of changed order of headers. I could not investigated problems myself, because I don't have access to MSVC. Changes in question: r250872: source/Plugins/Disassembler/llvm/Disassemble