Re: [lldb-dev] [llvm-dev] [cfe-dev] RFC: Code Review Process

2021-10-06 Thread Philip Reames via lldb-dev
Since I think we're risking confusion on the point here, let me clarify that at least my response to this thread should not be read as opposition (or support) for a migration to github.  I am expressing no opinion on that matter.  I see the primary point being discussed in this thread being the

Re: [lldb-dev] Serial port support in LLDB

2021-10-06 Thread Michał Górny via lldb-dev
On Wed, 2021-10-06 at 14:32 +0200, Pavel Labath wrote: > Thanks for the nice summary Michał. I've found it very helpful. > > The thing I am missing from this proposal is how would those settings > translate into actual termios calls? Like, who would be responsible > reading those settings and ac

Re: [lldb-dev] Serial port support in LLDB

2021-10-06 Thread Pavel Labath via lldb-dev
Thanks for the nice summary Michał. I've found it very helpful. The thing I am missing from this proposal is how would those settings translate into actual termios calls? Like, who would be responsible reading those settings and acting on them? Currently we have some tty code in ConnectionFile

Re: [lldb-dev] [llvm-dev] RFC: Code Review Process

2021-10-06 Thread James Henderson via lldb-dev
Forgive me if I'm wrong, but if the community consensus is that we should continue to use Phabricator, and Phabricator is not being provided/maintained by the LLVM Foundation, isn't it moot what the LLVM Foundation/Infrastructure Working Group recommends/wants to happen? The current maintainers wou