Re: [lldb-dev] Problem with watchpoints

2016-09-09 Thread Daniel Noland via lldb-dev
Yes, that was pretty much my assessment when I read through the code. My existing patch (which I will post when I get home) takes a very conservative approach and only modifies what is strictly necessary to make the callback feature work. That said, I found myself copy / paste / slight changing a

Re: [lldb-dev] Problem with watchpoints

2016-09-09 Thread Jim Ingham via lldb-dev
The main problem with the watchpoint code is that it doesn't share nearly as much of the implementation of options and callback handling with the breakpoints as it should. For instance, there's very little need for WatchpointOptions and BreakpointOptions to be separate classes, they do pretty

Re: [lldb-dev] Problem with watchpoints

2016-09-09 Thread Daniel Noland via lldb-dev
I have also noticed a few problems similar to Ted's and I plan to address them assuming nobody else is already on it. That said, I am new around here so please bear with me :) In fact, I have been hacking on a few watchpoint methods for a while now. I have implemented some features I personally

Re: [lldb-dev] [OS X]: building lldb with cmake

2016-09-09 Thread Zachary Turner via lldb-dev
To be completely honest with you I don't even know why this class exists. All it needs to do is use llvm's regex class. The entire MIUtilParse.h / .cpp files can be deleted as far as I'm concerned. On Fri, Sep 9, 2016 at 12:45 PM Zachary Turner wrote: > Yes, this is a bug in LLDB. You're welco

Re: [lldb-dev] [OS X]: building lldb with cmake

2016-09-09 Thread Zachary Turner via lldb-dev
Yes, this is a bug in LLDB. You're welcome to try to fix it by changing it to include "llvm/Support/Regex.h" instead of this private header. Not sure if you will run into any issues, but in theory I see no reason why it shouldn't work. On Fri, Sep 9, 2016 at 12:37 PM René J.V. Bertin via lldb-de

Re: [lldb-dev] [OS X]: building lldb with cmake

2016-09-09 Thread René J . V . Bertin via lldb-dev
Hi, I wanted to see how far I could get with a standalone build, so I copied the missing CheckAtomic.cmake file into the installed cmake/llvm directory, and tried to build lldb. It aborted at 93% because it tried to include a headerfile from the llvm source: {{{ In file included from /opt/loc

Re: [lldb-dev] [OS X]: building lldb with cmake

2016-09-09 Thread René J . V . Bertin via lldb-dev
On Friday September 09 2016 10:34:37 Greg Clayton wrote: Hi, >The biggest issue with trying to use cmake on macOS is that there is no >support for building frameworks, please correct me if I am wrong. The xcode >build will build a "LLDB.framework" that contains all headers and the shared >libr

Re: [lldb-dev] [OS X]: building lldb with cmake

2016-09-09 Thread Zachary Turner via lldb-dev
It's possible they weren't supported in the past, but creating Frameworks is definitely supported now. https://cmake.org/cmake/help/v3.6/manual/cmake-buildsystem.7.html#apple-frameworks https://cmake.org/cmake/help/v3.6/prop_tgt/FRAMEWORK.html#prop_tgt:FRAMEWORK Here's a more detailed example. h

Re: [lldb-dev] [OS X]: building lldb with cmake

2016-09-09 Thread Greg Clayton via lldb-dev
The biggest issue with trying to use cmake on macOS is that there is no support for building frameworks, please correct me if I am wrong. The xcode build will build a "LLDB.framework" that contains all headers and the shared library, and the "lldb" command line tool that links against that. We r

Re: [lldb-dev] Problem with watchpoints

2016-09-09 Thread Greg Clayton via lldb-dev
> On Sep 8, 2016, at 4:47 PM, Ted Woodward via lldb-dev > wrote: > > I recently discovered a problem with watchpoints talking to the Hexagon > simulator: > > (lldb) w s e 0x1000 > error: Watchpoint creation failed (addr=0x1000, size=4). > error: Target supports (0) hardware watchpoint slots.

Re: [lldb-dev] [OS X]: building lldb with cmake

2016-09-09 Thread René J . V . Bertin via lldb-dev
On Friday September 09 2016 10:42:34 Pavel Labath wrote: Hi Pavel Thanks for pointing me to > Hi Rene, > lldb/cmake/modules/LLDBStandalone.cmake for how to set it up. As far > as I know, the main trick is pointing your build to the llvm-config > binary installed by the llvm package So, adding

Re: [lldb-dev] [OS X]: building lldb with cmake

2016-09-09 Thread Pavel Labath via lldb-dev
Hi Rene, building lldb on osx with cmake should work fine when you're doing it as a part of llvm (our buildbot is doing it ). What you are asking for is called a "standalone" build of LLDB. I don't think anyone has tried it on a mac, but

[lldb-dev] [OS X]: building lldb with cmake

2016-09-09 Thread René J . V . Bertin via lldb-dev
Hi, I've been working on a MacPorts port for lldb (MacPorts already provides ports for llvm and clang; cf. https://trac.macports.org/ticket/45251). Using the Xcode project isn't really an option here, so I've based my approach on the instructions for building using CMake on *n*x. In short: -