Re: [lldb-dev] LLDB Evolution: Next Phase

2016-08-23 Thread Zachary Turner via lldb-dev
Pretty much, yea. On Tue, Aug 23, 2016 at 12:24 PM Ed Maste wrote: > On 23 August 2016 at 11:55, Zachary Turner wrote: > > > > Should we consider adding git hyper-blame to llvm and recommending its > usage? > > Nifty, I hadn't encountered git hyper-blame before. Thanks Zach. > > If I understand

Re: [lldb-dev] LLDB Evolution: Next Phase

2016-08-23 Thread Ed Maste via lldb-dev
On 23 August 2016 at 11:55, Zachary Turner wrote: > > Should we consider adding git hyper-blame to llvm and recommending its usage? Nifty, I hadn't encountered git hyper-blame before. Thanks Zach. If I understand correctly all we need to do is add a `.git-blame-ignore-revs` file to the lldb root

Re: [lldb-dev] LLDB Evolution: Next Phase

2016-08-23 Thread Zachary Turner via lldb-dev
Should we consider adding git hyper-blame to llvm and recommending its usage? https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/git-hyper-blame.html On Tue, Aug 23, 2016 at 6:44 AM Ed Maste via lldb-dev < lldb-dev@lists.llvm.org> wrote: > On 19 August 2016 at 1

Re: [lldb-dev] Linux ELF header e_ident[EI_OSABI] value

2016-08-23 Thread Howard Hellyer via lldb-dev
"Ted Woodward" wrote on 22/08/2016 21:03:02: > We don't want to make ELFOSABI_NONE mean Linux. ELFOSABI_NONE is > historically ELFOSABI_SYSV, and used by a lot of things. So not all > core files identified as ELFOSABI_NONE are Linux. I agree that other OS's may use it or have used it in the p

Re: [lldb-dev] Linux ELF header e_ident[EI_OSABI] value

2016-08-23 Thread Howard Hellyer via lldb-dev
> I would change it so that the "os" doesn't get set to anything when > it detects this in the core file. When an OS is not specified, the > llvm::Triple will return OSUnknown as the enumeration value for the > OS _and_ the llvm::StringRef value will return an empty string. This > is known in LL

Re: [lldb-dev] LLDB Evolution: Next Phase

2016-08-23 Thread Ed Maste via lldb-dev
On 19 August 2016 at 17:10, Kate Stone via lldb-dev wrote: > > Sept 5th Trunk closes for commits while reformatting takes place and is > validated before re-opening trunk. This is fine with me. As for validation, from my perspective I want to make sure the FreeBSD build-only buildbot is green: h

Re: [lldb-dev] Linux ELF header e_ident[EI_OSABI] value

2016-08-23 Thread Ed Maste via lldb-dev
On 22 August 2016 at 16:03, Ted Woodward via lldb-dev wrote: > > We don't want to make ELFOSABI_NONE mean Linux. ELFOSABI_NONE is historically > ELFOSABI_SYSV, and used by a lot of things. So not all core files identified > as ELFOSABI_NONE are Linux. Indeed, and that's true for binaries and li