Okay, will do.
On Thu, Oct 22, 2015 at 12:56 PM, Zachary Turner wrote:
> This is going in right now. As it is a fairly large change, it wouldn't
> surprise me if someone encounters an issue. I tested this everywhere I can
> and it seems fine, so please let me know if anyone encounters anything
This is going in right now. As it is a fairly large change, it wouldn't
surprise me if someone encounters an issue. I tested this everywhere I can
and it seems fine, so please let me know if anyone encounters anything.
On Thu, Oct 22, 2015 at 11:39 AM Todd Fiala wrote:
> Yeah I think the bigge
Yeah I think the biggest thing I wanted to check there was that there
wasn't any unittest2 behavior present in that cut of unittest2 that didn't
make it into the revamped version brought into the python distributions
when they upgraded unittest. Then it's just a big rename exercise on
replacing un
(And side note: if you're pushing a "lambda: self.foo()" with no arguments,
the lambda is unneeded and you can just push "self.foo" --- that cleanup
hook pushed on most tests at the end of the file is a perfect example of an
unneeded level of lambda indirection).
On Wed, Oct 21, 2015 at 12:04 PM,
Cool! I probably won't delete it from the repo entirely, because that
entails mucking with the command line options of dotest to remove any
related options, and any initialization code in dotest.py or TestBase
subclasses related to unittest2. For now I'll just delete the imports from
each individ
(I was eventually going to do this at some point after I verified it was
indeed true). It should just be called unittest in a stock distribution.
On Thu, Oct 22, 2015 at 11:29 AM, Todd Fiala wrote:
> We could also then remove unittest2 from inclusion in the lldb repo.
>
>
> On Thu, Oct 22, 2015
We could also then remove unittest2 from inclusion in the lldb repo.
On Thu, Oct 22, 2015 at 11:28 AM, Todd Fiala wrote:
> I'd be okay with that.
>
> The unittest2 stuff looks like it was a vestige of being incorporated
> before unittest2 was stock (unitest) on Python 2.[6,7]?. Everyone should
I'd be okay with that.
The unittest2 stuff looks like it was a vestige of being incorporated
before unittest2 was stock (unitest) on Python 2.[6,7]?. Everyone should
have a unitest included that is effectively what we use as unittest2.
-Todd
On Thu, Oct 22, 2015 at 10:05 AM, Zachary Turner via
The classes appear to be all forward declared intentionally, so you'd need
to include a lot of missing files. Just moving the destructor to cpp file
should be pretty easy and still allow to keep the header footprint down,
which speeds up build times.
On Thu, Oct 22, 2015 at 11:22 AM Eugene Zelenk
On Thu, Oct 22, 2015 at 11:15 AM, Zachary Turner wrote:
> For the disassembler patch, the problem is you've defaulted the destructor
> but you've got a unique_ptr to a forward declared class. MSVC is actually
> correct in failing to compile this, and I'm not sure why other compilers are
> accepti
For the disassembler patch, the problem is you've defaulted the destructor
but you've got a unique_ptr to a forward declared class. MSVC is actually
correct in failing to compile this, and I'm not sure why other compilers
are accepting it. My guess is something to do with the order of includes
fr
Hi, Zachary!
On Thu, Oct 22, 2015 at 9:34 AM, Zachary Turner wrote:
> I'm taking a look now. In the future please revert changes that break a
> buildbot. If you think you might know what the fix is (i.e. you guess that
> including a header will fix it), then you can just check it in as a test.
>
It looks like you're generating these diffs from an SVN repo, so I'm seeing
lldb/trunk in the paths. Because of that, I can't apply it on my git repo
which doesn't have the "trunk" folder. Can you generate the diffs for the
2 aforementioned CLs by cding into the trunk directory and generating the
I plan to put this in today. Greg, should I just go ahead and delete all
the unittest2 stuff entirely? TBH I'm all for anything that reduces the
complexity of the test suite. It's got a couple hundred options that
nobody uses, seems like we should start whittling away at stuff that
doesn't get a
You can get pretty much the same effect though by just running dotest and
passing it the folder that the .py file is in. Then it only runs tests in
that folder. You can specify the filename too if you want to limit it to
one name. Sure, it's a few keystrokes less to just type
TestMultithreaded.
I believe it would import lldb correctly. I don't tend to run the tests
individually, but if it did work, I would use it more.
> On Oct 22, 2015, at 9:26 AM, Zachary Turner via lldb-dev
> wrote:
>
> Todd, Greg, can you guys confirm this is true? The import lldb would
> succeed if someone ha
I'm taking a look now. In the future please revert changes that break a
buildbot. If you think you might know what the fix is (i.e. you guess that
including a header will fix it), then you can just check it in as a test.
If after a few attempts you still can't figure it out, then revert the
change
Hi!
I broke couple of times MSVC builds when committed minor code
cleanups. Looks like problem occurred because of changed order of
headers.
I could not investigated problems myself, because I don't have access to MSVC.
Changes in question:
r250872:
source/Plugins/Disassembler/llvm/Disassemble
+todd and greg
On Thu, Oct 22, 2015 at 9:26 AM Zachary Turner wrote:
> Todd, Greg, can you guys confirm this is true? The import lldb would
> succeed if someone had their PYTHONPATH set up just right, but if really
> none of us care about it, I'm with Tamas in that I'd rather remove it.
>
> On
Todd, Greg, can you guys confirm this is true? The import lldb would
succeed if someone had their PYTHONPATH set up just right, but if really
none of us care about it, I'm with Tamas in that I'd rather remove it.
On Thu, Oct 22, 2015 at 2:55 AM Tamas Berghammer
wrote:
> Hi Zach,
>
> I think no
Hi Zach,
I think nobody is using the "if __name__ == '__main__'" block as executing
a test file directly isn't working at the moment (the "import lldb" command
fails). If you plan to change all test file then I would prefer to remove
the reference to unittest2 from them for simplicity if nobody ha
21 matches
Mail list logo
