[Lldb-commits] [PATCH] D156817: _wsopen_s does not accept bits other than `_S_IREAD | _S_IWRITE`

2023-08-01 Thread yshui via Phabricator via lldb-commits
yshui created this revision. Herald added a project: All. yshui requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When sending file from a Linux host to a Windows remote, Linux host will try to copy the source file's permission bits, which w

[Lldb-commits] [PATCH] D156817: [lldb][windows] _wsopen_s does not accept bits other than `_S_IREAD | _S_IWRITE`

2023-08-03 Thread yshui via Phabricator via lldb-commits
yshui added a comment. In D156817#4553045 , @DavidSpickett wrote: > What exactly are the other bits in the mode here, are we losing something > important potentially? I guess it can't be that important if Windows rejects > them. I don't think so, grou

[Lldb-commits] [PATCH] D156817: [lldb][windows] _wsopen_s does not accept bits other than `_S_IREAD | _S_IWRITE`

2023-08-28 Thread yshui via Phabricator via lldb-commits
yshui added a comment. In D156817#4620998 , @mstorsjo wrote: > I noticed this review is accepted but not committed. If you don't have commit > access, what's your preferred git identity, i.e. `Real Name `? "Yuxuan Shui " Thanks. Repository: rG LLVM