walter-erquinigo wrote:
@jimingham , thanks! I reverted the changes to that method and left a tiny
comment mentioning that it's used by swift.
https://github.com/llvm/llvm-project/pull/68927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
@@ -212,6 +212,38 @@ This loads the coredump file `/cores/123.core` associated
with the program
}
```
+### Connect to a Debug Server on the Current Machine
+
+This connects to a debug server (e.g. `lldb-server`, `gdbserver`) on
+the current machine, that is debugging the prog
walter-erquinigo wrote:
Thanks, @JDevlieghere !
https://github.com/llvm/llvm-project/pull/68927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
A problem that I'm seeing now is that if we move all the plugins to
`lldb_private::plugin`, the `liblldb-private.exports` file will by default emit
all the lldb symbols (the ones in plugins + the regular lldb_private symbols).
This can potentially be too many symbols, a
walter-erquinigo wrote:
> That expectations, combined with the fact that LLDB has plugins, makes it
> really sound like lldb_plugin is the interface we expose for writing
> (dynamically loadable) plugins.
I don't think people would have the expectation that you need to use
`lldb_plugin` for
walter-erquinigo wrote:
> I think I'm missing something. The API's you are calling the lldb_plugin
> API's aren't really stand-alone, are they? The lldb_plugin::dwarf API's seem
> to have a bunch of methods that take lldb_private types. So you already have
> to have some kind of closure of
walter-erquinigo wrote:
@clayborg PTAL
https://github.com/llvm/llvm-project/pull/68927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@bulbazord , ReadCStringFromMemory returns the length of the string, which in
the case of empty strings is 0!
So, this code was wrong since the beginning. The only thing to check is
error.Success() and not the size.
https://github.com/llvm/llvm-project/pull/68924
_
walter-erquinigo wrote:
@bulbazord , thanks!! I'll try to improve the type system and other parts of
the LLDB as I add support for my language.
https://github.com/llvm/llvm-project/pull/68927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/68927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/68924
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
I've just updated this PR to use
```
namespace lldb_private::plugin {
namespace swift {
```
PTAL, @JDevlieghere , @clayborg
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm
walter-erquinigo wrote:
Thanks for unblocking me!!
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: walter erquinigo
Date: 2023-10-13T17:22:49-04:00
New Revision: a669a237c45a515bea0d258cbbecdbbb3170d57a
URL:
https://github.com/llvm/llvm-project/commit/a669a237c45a515bea0d258cbbecdbbb3170d57a
DIFF:
https://github.com/llvm/llvm-project/commit/a669a237c45a515bea0d258cbbecdbbb3170d57a.di
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/69238
We've been using the backtick as our escape character, however that leads to a
weird experience on VS Code, because on most hosts, as soon as you type the
backtick on VS Code, the IDE will introduce ano
https://github.com/walter-erquinigo ready_for_review
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/69238
>From 3d14b2938e0fd6073cdafcea4a54071f23158b42 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 16 Oct 2023 15:08:20 -0400
Subject: [PATCH] [lldb-vscode] Allow specifying a custom escape charac
walter-erquinigo wrote:
> (Not related to this PR but I put up an
> [RFC](https://discourse.llvm.org/t/rfc-rename-lldb-vscode-to-lldb-dap/74075/)
> on Friday to rename it to `lldb-dap`. Putting it up here for extra
> visibility.)
Nice! I'll approve your PR if you make that change!
https://gi
walter-erquinigo wrote:
@clayborg , good point, I'll move it to launch and attach settings.
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
walter-erquinigo wrote:
> Can you check real quick if any native plug-ins can have and or access global
> settings from the VS Code GUI? That would be the best way for all of these.
> Maybe there is a combination mode where we have some typescript in our
> extension, but still have a native DA
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/69238
>From 4595d0940738b42f19d4127f3743afbaa53f0691 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 16 Oct 2023 15:08:20 -0400
Subject: [PATCH] [lldb-vscode] Allow specifying a custom escape charac
walter-erquinigo wrote:
@clayborg , I've updated this patch using launch and attach settings, which
might be fine following what've been doing so far. Even though I agree that
it'd be nice to read the GUI global configs, I think that all settings should
be also configurable via launch and atta
walter-erquinigo wrote:
Sure, Greg, I'll update my patch with the empty prefix.
I'll probably write the very basic Typescript wrapper in two weeks. I would
like to see it a point of contribution between different companies
https://github.com/llvm/llvm-project/pull/69238
___
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/69238
>From 19295d5fe84c1f06f3e5d712d5af39f8ef48286c Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 16 Oct 2023 15:08:20 -0400
Subject: [PATCH] [lldb-vscode] Allow specifying a custom escape charac
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@JDevlieghere , PTAL
https://discourse.llvm.org/t/rfc-rename-lldb-vscode-to-lldb-dap/74075/16?u=wallace
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
fantastic!
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@clayborg , friendly ping
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: walter erquinigo
Date: 2023-10-17T18:15:29-04:00
New Revision: 59908504cd7a72cd2a614e5c6db5410101209365
URL:
https://github.com/llvm/llvm-project/commit/59908504cd7a72cd2a614e5c6db5410101209365
DIFF:
https://github.com/llvm/llvm-project/commit/59908504cd7a72cd2a614e5c6db5410101209365.di
Author: walter erquinigo
Date: 2023-10-17T18:50:18-04:00
New Revision: 7d1bf1c5cf284ce1a18fe0ce4a4cf91f3e514866
URL:
https://github.com/llvm/llvm-project/commit/7d1bf1c5cf284ce1a18fe0ce4a4cf91f3e514866
DIFF:
https://github.com/llvm/llvm-project/commit/7d1bf1c5cf284ce1a18fe0ce4a4cf91f3e514866.di
@@ -52,12 +52,17 @@ llvm::StringRef GetAsString(const llvm::json::Value &value);
/// \param[in] key
/// The key to use when extracting the value
///
+/// \param[in] defaultValue
+/// The default value to return if the key is not present
+///
/// \return
/// A llvm
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/69238
>From adcf4b7ad6ec67805293af99300643075a02b75b Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 16 Oct 2023 15:08:20 -0400
Subject: [PATCH] [lldb-vscode] Allow specifying a custom escape charac
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/69696
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@clayborg , friendly ping :)
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/69981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/69990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/69990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -321,6 +322,7 @@ class SymbolFileDWARF : public SymbolFileCommon {
m_file_index = file_index;
}
+protected:
walter-erquinigo wrote:
My bad for merging this, but I beg you not to reintroduce it. I originally
intended to have an isolated patch just fo
@@ -321,6 +322,7 @@ class SymbolFileDWARF : public SymbolFileCommon {
m_file_index = file_index;
}
+protected:
walter-erquinigo wrote:
The ivars thing make sense. Could you at least just move the ivars into a
protected or private section for now? If yo
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/69990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -321,6 +322,7 @@ class SymbolFileDWARF : public SymbolFileCommon {
m_file_index = file_index;
}
+protected:
walter-erquinigo wrote:
Sure, after you merge this patch, I'll send another one exposing only what's
needed. I'll also remove DWARFASTParserC
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/69238
>From 09cd46a63b1fb68e3c5c03273cbc90825b09d027 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 16 Oct 2023 15:08:20 -0400
Subject: [PATCH] [lldb-vscode] Allow specifying a custom escape charac
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/70157
This effectively moves a few functions from protected to public. In any case,
for the sake of having a cleaner SymbolFileDWARF API, it's better if it's not a
friend of a one of its consumers, DWARFASTPa
https://github.com/walter-erquinigo ready_for_review
https://github.com/llvm/llvm-project/pull/70157
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -325,15 +323,46 @@ class SymbolFileDWARF : public SymbolFileCommon {
m_file_index = file_index;
}
-protected:
typedef llvm::DenseMap DIEToTypePtr;
- typedef llvm::DenseMap
- DIEToVariableSP;
+
+ virtual DIEToTypePtr &GetDIEToType() { return m_die_to_type; }
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/70157
>From 98c80871a753c58a49e8ba0d535e03e99d633109 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Tue, 24 Oct 2023 22:32:38 -0400
Subject: [PATCH 1/2] [LLDB][NFC] Remove DWARFASTParserClang as friend
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/70157
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/70996
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -396,8 +398,22 @@ Symbols::LocateExecutableSymbolFile(const ModuleSpec
&module_spec,
}
}
}
-
- return LocateExecutableSymbolFileDsym(module_spec);
+ FileSpec dsym_bundle = LocateExecutableSymbolFileDsym(module_spec);
+ if (dsym_bundle)
+return dsym_bundle
@@ -396,8 +398,22 @@ Symbols::LocateExecutableSymbolFile(const ModuleSpec
&module_spec,
}
}
}
-
- return LocateExecutableSymbolFileDsym(module_spec);
+ FileSpec dsym_bundle = LocateExecutableSymbolFileDsym(module_spec);
+ if (dsym_bundle)
+return dsym_bundle
https://github.com/walter-erquinigo commented:
pretty nice feature!
https://github.com/llvm/llvm-project/pull/70996
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -196,13 +196,15 @@ elseif (LLDB_EXPORT_ALL_SYMBOLS)
MESSAGE("-- Symbols (liblldb): exporting all symbols from the lldb and
lldb_private namespaces")
# Pull out the various lldb libraries linked into liblldb, these will be used
- # when looking for symbols to extract.
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/71087
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/71087
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -196,13 +196,15 @@ elseif (LLDB_EXPORT_ALL_SYMBOLS)
MESSAGE("-- Symbols (liblldb): exporting all symbols from the lldb and
lldb_private namespaces")
# Pull out the various lldb libraries linked into liblldb, these will be used
- # when looking for symbols to extract.
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/71143
DummySyntheticFrontEnd is implementing correctly CalculateNumChildren but not
MightHaveChildren, where instead of delegating its action, it was returning
true.
This fixes that simple bug.
>From 57d19f
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/71143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/71455
- [LLDB][easy] Fix a bug in DummySyntheticFrontEnd
- [LLDB] Don't forcefully initialize the process trace plugin
>From 57d19fdd476b293a87f1c14b743ba636350af7a1 Mon Sep 17 00:00:00 2001
From: walter erqu
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/71455
>From d877ef80bbaa62afed2c7656c5ff6e84a8628786 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 6 Nov 2023 17:57:45 -0500
Subject: [PATCH] [LLDB] Don't forcefully initialize the process trace p
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/71455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/71455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/71455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/71455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/71828
lldb's AppleDWARFIndex is created with a few `llvm::AppleAcceleratorTable`
variables, but they only hold pointers to the underlying data, which doesn't
prevent the data owner (lldb's DataBufferHeap) fro
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/71843
When this option is enabled, display names of stack frames are generated using
the `${function.name-with-args}` formatter instead of simply calling
`SBFrame::GetDisplayFunctionName`. This makes lldb-dap
walter-erquinigo wrote:
The changes seem very trivial to me, so please let me know if there's something
else I should do or be aware of.
https://github.com/llvm/llvm-project/pull/71828
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
@@ -57,7 +57,9 @@ std::unique_ptr AppleDWARFIndex::Create(
return std::make_unique(
walter-erquinigo wrote:
These asserts might not always pass? I don't know if it's guaranteed that if
one of those sections is present, then the rest of them are as well.
ht
@@ -187,3 +188,19 @@ def test_stackTrace(self):
self.assertEquals(
0, len(stackFrames), "verify zero frames with startFrame out of
bounds"
)
+
+@skipIfWindows
walter-erquinigo wrote:
I think all vscode tests skip on windows...
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/71843
>From 980f1e0ceb43da5f4d504f7ed04c3abb591e406d Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 9 Nov 2023 13:15:55 -0500
Subject: [PATCH] [lldb-dap] Add an option to show function args in stac
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/71843
>From 7b9b5897e2e801d7bc97639ed302b885481659bd Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 9 Nov 2023 13:15:55 -0500
Subject: [PATCH] [lldb-dap] Add an option to show function args in stac
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/71843
>From 2f3841dc6d68f755b11f6677ed2d034a88a297c8 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 9 Nov 2023 13:15:55 -0500
Subject: [PATCH] [lldb-dap] Add an option to show function args in stac
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/71843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/71843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@clayborg , I did pretty much what you asked but with a few changes:
- I added the `customFrameFormat` option to the json config, and it'll be used
if provided and non-empty. I just find it simpler to control everything with
one single option.
- I added the SBFormat cla
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/71828
>From 48ba23b4c0ef9c698b26d06e5b8b337a774563b8 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 9 Nov 2023 11:40:23 -0500
Subject: [PATCH] [LLDB] Ensure the data of apple accelerator tables is
@@ -57,7 +57,9 @@ std::unique_ptr AppleDWARFIndex::Create(
return std::make_unique(
walter-erquinigo wrote:
@JDevlieghere , what do you suggest in this case? Plain assert or better not to
put anything? I'd rather follow the guidelines
https://github.com/ll
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/71828
>From b7fadbbe01d626fbffe2523c601b2e7ea727b591 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 9 Nov 2023 11:40:23 -0500
Subject: [PATCH] [LLDB] Ensure the data of apple accelerator tables is
@@ -57,7 +57,9 @@ std::unique_ptr AppleDWARFIndex::Create(
return std::make_unique(
walter-erquinigo wrote:
Sure, I've just changed it to assert
https://github.com/llvm/llvm-project/pull/71828
___
lldb-commits mai
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/71828
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/71843
>From 8ad22d82fb987c1f32446220d96760e71b9f5130 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 9 Nov 2023 13:15:55 -0500
Subject: [PATCH] [lldb-dap] Add an option to show function args in stac
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/71843
>From f7e9a2a9e206062f187ae4cc74038bd31ba32d26 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 9 Nov 2023 13:15:55 -0500
Subject: [PATCH] [lldb-dap] Add an option to show function args in stac
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/71843
>From 650690b3c8333b6ce54359508519c881f23cf4c4 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 9 Nov 2023 13:15:55 -0500
Subject: [PATCH] [lldb-dap] Add an option to show function args in stac
@@ -0,0 +1,47 @@
+//===-- SBFormat.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/71843
>From 96d3b9e61dde88bc5d7b6dbad7c35932054b8981 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 9 Nov 2023 13:15:55 -0500
Subject: [PATCH] [lldb-dap] Add an option to show function args in stac
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/71843
>From 9dab558339346e15149bb59da4dc2d58070dafa2 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 9 Nov 2023 13:15:55 -0500
Subject: [PATCH] [lldb-dap] Add an option to show function args in stac
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/71843
>From 9dab558339346e15149bb59da4dc2d58070dafa2 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 9 Nov 2023 13:15:55 -0500
Subject: [PATCH 1/2] [lldb-dap] Add an option to show function args in
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/71843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/72196
When this option gets enabled, descriptions of threads will be generated using
the format provided in the launch configuration instead of generating it
manually in the dap code. This allows lldb-dap to
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/72196
>From 00c258dd5c90cd920e5771ac89c0a8d2e97be937 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 13 Nov 2023 21:42:26 -0500
Subject: [PATCH] thread format
---
lldb/include/lldb/API/SBFormat.h
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/72196
>From bedae95f3c3f9d719b3677ef59c262283b813284 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 13 Nov 2023 21:42:26 -0500
Subject: [PATCH] thread format
---
lldb/include/lldb/API/SBFormat.h
@@ -839,4 +839,19 @@ void DAP::SetFrameFormat(llvm::StringRef format) {
}
}
+void DAP::SetThreadFormat(llvm::StringRef format) {
+ if (format.empty())
+return;
+ lldb::SBError error;
+ g_dap.thread_format = lldb::SBFormat(format.data(), error);
walter
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/72196
>From b6205d1befdaefc5ef17a9bc7b3eec960caecda6 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 13 Nov 2023 21:42:26 -0500
Subject: [PATCH] thread format
---
lldb/include/lldb/API/SBFormat.h
@@ -953,9 +953,9 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread
&thread,
} else {
body.try_emplace("reason", "breakpoint");
char desc_str[64];
- uint64_t bp_id = thread.GetStopReasonDataAtIndex(0);
- uint64_t bp_loc_id = thread.GetStopReasonD
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/72196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
Thank you!
https://github.com/llvm/llvm-project/pull/72631
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/72631
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Walter Erquinigo
Date: 2022-10-18T13:57:52-07:00
New Revision: 566146c03b054db2530f6b5997dfd0cd1a243657
URL:
https://github.com/llvm/llvm-project/commit/566146c03b054db2530f6b5997dfd0cd1a243657
DIFF:
https://github.com/llvm/llvm-project/commit/566146c03b054db2530f6b5997dfd0cd1a243657.di
601 - 700 of 973 matches
Mail list logo
